Re: edk2[16474] properly support GCC - pass 'I' (int) rather than 'L' (long) to struct.unpack.

2014-12-03 Thread Andrew Fish
> On Dec 3, 2014, at 10:01 PM, jy...@users.sourceforge.net wrote: > > Revision: 16474 > http://sourceforge.net/p/edk2/code/16474 > Author: jyao1 > Date: 2014-12-04 06:01:15 + (Thu, 04 Dec 2014) > Log Message: > --- > properly support GCC - pass 'I' (int) rather than 'L'

edk2[16475] Fix typo.

2014-12-03 Thread jyao1
Revision: 16475 http://sourceforge.net/p/edk2/code/16475 Author: jyao1 Date: 2014-12-04 06:03:58 + (Thu, 04 Dec 2014) Log Message: --- Fix typo. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao, Jiewen" Reviewed-by: "Rangarajan, Ravi P" Revi

edk2[16474] properly support GCC - pass 'I' (int) rather than 'L' (long) to struct.unpack.

2014-12-03 Thread jyao1
Revision: 16474 http://sourceforge.net/p/edk2/code/16474 Author: jyao1 Date: 2014-12-04 06:01:15 + (Thu, 04 Dec 2014) Log Message: --- properly support GCC - pass 'I' (int) rather than 'L' (long) to struct.unpack. Contributed-under: TianoCore Contribution Agreement 1.0

edk2[16473] ShellPkg: Connect all the consoles in "reconnect -r".

2014-12-03 Thread shenshushi
Revision: 16473 http://sourceforge.net/p/edk2/code/16473 Author: shenshushi Date: 2014-12-04 01:18:04 + (Thu, 04 Dec 2014) Log Message: --- ShellPkg: Connect all the consoles in "reconnect -r". Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu S

edk2[16472] NetworkPkg: Source fixes and cleanup for ARMGCC compiles

2014-12-03 Thread sfu5
Revision: 16472 http://sourceforge.net/p/edk2/code/16472 Author: sfu5 Date: 2014-12-04 00:55:50 + (Thu, 04 Dec 2014) Log Message: --- NetworkPkg: Source fixes and cleanup for ARMGCC compiles - Fix EFI_IPv4_ADDRESS usages to use a macro to copy the structure instead o

edk2[16471] MdeModulePkg: Source fixes and cleanup for ARMGCC compiles

2014-12-03 Thread erictian
Revision: 16471 http://sourceforge.net/p/edk2/code/16471 Author: erictian Date: 2014-12-04 00:32:24 + (Thu, 04 Dec 2014) Log Message: --- MdeModulePkg: Source fixes and cleanup for ARMGCC compiles - Fix EFI_IPv4_ADDRESS usages to use a macro to copy the structure inst

edk2[16470] MdeModulePkg: Unregister DXE FpdtStatusCodeHandler.

2014-12-03 Thread lgao4
Revision: 16470 http://sourceforge.net/p/edk2/code/16470 Author: lgao4 Date: 2014-12-03 15:34:08 + (Wed, 03 Dec 2014) Log Message: --- MdeModulePkg: Unregister DXE FpdtStatusCodeHandler. DXE FpdtStatusCodeHandler is required to be unregistered even if StatusCodeReport

RE: edk2[16468] Code clean-up to eliminate potential "dereferenced pointer" warning.

2014-12-03 Thread Long, Qin
I agree. Will change this to some conditional handling here for better applicability. Thanks. Best Regards & Thanks, LONG, Qin -Original Message- From: Andrew Fish [mailto:af...@apple.com] Sent: Wednesday, December 03, 2014 4:31 PM To: Long, Qin Cc: ql...@users.sourceforge.net; edk2-co

edk2[16469] Fix a regression bug to uni parser.

2014-12-03 Thread yingke
Revision: 16469 http://sourceforge.net/p/edk2/code/16469 Author: yingke Date: 2014-12-03 08:30:56 + (Wed, 03 Dec 2014) Log Message: --- Fix a regression bug to uni parser. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yingke Liu Reviewed-by: Li

Re: edk2[16468] Code clean-up to eliminate potential "dereferenced pointer" warning.

2014-12-03 Thread Andrew Fish
> On Dec 3, 2014, at 12:29 AM, Long, Qin wrote: > > Hi, Andrew, > > Thanks for your review. > > This new-added ASSERT() is for the internal function of this file, and > external invocation has guaranteed the pointer is valid. So here ASSERT() is > just to eliminate the possible warning info

RE: edk2[16468] Code clean-up to eliminate potential "dereferenced pointer" warning.

2014-12-03 Thread Long, Qin
Hi, Andrew, Thanks for your review. This new-added ASSERT() is for the internal function of this file, and external invocation has guaranteed the pointer is valid. So here ASSERT() is just to eliminate the possible warning information from some static-scanning tools. Best Regards & Thanks,