Reviewed-by: Qiu Shumin
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng
Sent: Friday, August 07, 2015 9:46 AM
To: edk2-devel@lists.01.org
Cc: David Woodhouse; Woodhouse, David
Subject: [edk2] [PATCH] MdeModulePkg DxeIpl: Fix IA32 build f
DHCP policy is applied as default at boot time on all NICs in the system, which
results
in all NIC ports attempting DHCP and trying to acquire IP addresses during boot.
Ip4 driver should only set dhcp as default policy, and not trigger DORA at
driver binding
start(). We should start DORA until on
Thanks Ting!
I have one "LanIntelE1000Dxe" code and using it, but this code is not yet
tested on UEFI.
And as my network (ping/ifconfig) is not working, I am clueless about what
exactly causing the issue.
Thanks and Regards,
Shaveta
-Original Message-
From: edk2-devel [mailto:edk2-deve
Hi Shaveta,
The upper layer drivers since SNP are available for several years and validated
in multiple UEFI enabled platforms.
Sorry I don't know whether you can get the UEFI Intel E1000 NIC card driver.
You may search the download center in Intel.com? Hope other guys in the mailing
list know.
Reviewed-by: Ruiyu Ni
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Qiu
Shumin
Sent: Wednesday, August 5, 2015 1:53 PM
To: edk2-devel@lists.01.org
Cc: Ronald Cron ; Qiu, Shumin
Subject: [edk2] [PATCH] ShellPkg: Add function comments and ref
Upper layer drivers like SNP/MNP are also taken from EDK2 and not been tested
on UEFI.
>From where can I get the complete code of Intel E1000 NIC card driver for UEFI?
Is such tested code available for use for UEFI?
Thanks and Regards,
Shaveta
-Original Message-
From: Ye, Ting [mailto
Reviewed-by: Jiaxin Wu
-Original Message-
From: Wang, Fan
Sent: Friday, August 7, 2015 9:33 AM
To: edk2-devel@lists.01.org
Cc: Ye, Ting; Wu, Jiaxin; Fu, Siyuan
Subject: [Patch] MdeModulePkg: Change the macro name to fit coding style
Change a macro name to fit EDK2 naming conventions: U
Reviewed-by: Jiaxin Wu
-Original Message-
From: Wang, Fan
Sent: Friday, August 7, 2015 9:32 AM
To: edk2-devel@lists.01.org
Cc: Ye, Ting; Wu, Jiaxin; Fu, Siyuan
Subject: [Patch] NetworkPkg: Change the macro name to fit coding style
Change several macro names to fit EDK2 naming convention
Reviewed-by: Jiaxin Wu
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu Siyuan
Sent: Monday, July 27, 2015 1:51 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch] MdeModulePkg: Use monotonic count to initialize the
NetLib random seed.
Net
Looks good to me.
Reviewed-by: Ye Ting
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu Siyuan
Sent: Monday, July 27, 2015 1:51 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch] MdeModulePkg: Use monotonic count to initialize the
NetLib
Hi Laszlo,
Have sent out the formal patch for review.
Thanks,
Star
[EOM]
> -Original Message-
> From: Zeng, Star
> Sent: Friday, August 7, 2015 9:36 AM
> To: Zeng, Star; Laszlo Ersek; Paolo Bonzini
> Cc: Justen, Jordan L; edk2-de...@ml01.01.org; Andrew Fish; Yao, Jiewen;
> Chen Fan; Fan,
Reviewed-by: Qiu Shumin
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wang Fan
Sent: Friday, August 07, 2015 9:32 AM
To: edk2-devel@lists.01.org
Cc: Ye, Ting; Fu, Siyuan; Wu, Jiaxin
Subject: [edk2] [Patch] NetworkPkg: Change the macro name to fi
when stack NX has been enabled for BSP.
DxeIpl may have enabled Execute Disable for BSP,
APs need to get the status and sync up the settings,
otherwise EFI_MP_SERVICES_PROTOCOL->StartupAllAPs
may not work.
Got positive comments and test result from Laszlo
for the early draft patch, thanks.
Cc: L
Hi David,
> -Original Message-
> From: David Woodhouse [mailto:dw...@infradead.org]
> Sent: Thursday, August 6, 2015 8:11 PM
> To: Zeng, Star; edk2-de...@ml01.01.org
> Cc: Yao, Jiewen
> Subject: Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Add stack NX support
>
> On Fri, 2015-07-31 at 20:22 +
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Got the build failure feedback below, this patch is to fix that.
This broke the IA32 Ovmf build for me, with GCC 5.1.1 (Fedora 22):
/home/dwmw2/git/edk2/MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c:377:7:
error: ‘PageTables’ may be used uninitialized in this function
[-Werror=maybe-uninitial
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Zeng, Star
> Sent: Friday, August 7, 2015 9:28 AM
> To: Laszlo Ersek; Paolo Bonzini
> Cc: Justen, Jordan L; edk2-de...@ml01.01.org; Andrew Fish; Yao, Jiewen;
> Chen Fan; Fan, Jeff
> Subject: Re:
Change a macro name to fit EDK2 naming conventions: Use all capital letters for
#define.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: fanwang2
---
MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.c | 2 +-
MdeModulePkg/Universal/Network/IScsiDxe/IScsiMisc.h | 2 +-
2
Change several macro names to fit EDK2 naming conventions: Use all capital
letters for #define.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: fanwang2
---
NetworkPkg/IScsiDxe/IScsiMisc.c | 8
NetworkPkg/IScsiDxe/IScsiMisc.h | 8
2 files changed, 8 inse
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, August 6, 2015 9:43 PM
> To: Zeng, Star; Paolo Bonzini
> Cc: Andrew Fish; Justen, Jordan L; edk2-de...@ml01.01.org; Yao, Jiewen;
> Chen Fan; Fan, Jeff
> Subject: Re: [edk2] [PATCH] MdeModulePkg DxeIpl: Ad
On 08/06/15 16:55, Paolo Bonzini wrote:
>
>
> On 06/08/2015 16:31, Laszlo Ersek wrote:
>>> kvm_cpuid:func 8001 rax 6e8 rbx 0 rcx 0 rdx 10
>>> kvm_enter_smm:vcpu 0: leaving SMM, smbase 0x7ffc
>>> kvm_entry:vcpu 0
>>> kvm_exit: reason TRIPLE_F
Agree. Current implementation treats the DHCP policy configuration a
synchronous process. Let's discuss this further in spec group.
Best Regards,
Ting
-Original Message-
From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hp.com]
Sent: Friday, August 07, 2015 12:07 AM
To: edk2-dev
Samer,
Yes, we will continue to use DHCP default policy but we will postpone the DORA
process until upper layer driver configures an IP instance with default
address. This can solve the performance impact issue.
We will fix this soon, thanks a lot.
Best Regards,
Ting
-Original Message-
Yes, we agree that this is an regression issue and will be fixed soon. Thanks
Samer for reporting this.
Best Regards,
Ting
-Original Message-
From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hp.com]
Sent: Friday, August 07, 2015 12:03 AM
To: edk2-devel@lists.01.org; Ye, Ting
Sub
On 08/07/15 00:38, Laszlo Ersek wrote:
> On 08/06/15 16:55, Paolo Bonzini wrote:
>>
>>
>> On 06/08/2015 16:31, Laszlo Ersek wrote:
kvm_cpuid:func 8001 rax 6e8 rbx 0 rcx 0 rdx 10
kvm_enter_smm:vcpu 0: leaving SMM, smbase 0x7ffc
kvm_entry:vcp
For this specific issue, we will bring this up in the UEFI Forum for further
discussion, as the spec is not clear on whether DHCP policy configuration
should be synchronous or asynchronous.
Thanks,
--Samer
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] O
Sorry, I replied to the wrong issue.
This one is actually considered an issue in EDK2 that I think should be fixed.
Ting,
Do you agree?
Thanks,
--Samer
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
El-Haj-Mahmoud, Samer
Sent: Thursday, Aug
Ting,
Any follow up on this? Is this an issue in the current EDK2 implementation that
needs to be fixed?
Thanks,
--Samer
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
El-Haj-Mahmoud, Samer
Sent: Friday, July 31, 2015 9:39 AM
To: edk2-devel@
Jut to follow up on this item.
We will bring this up in the UEFI Forum for further discussion, as the spec is
not clear on whether DHCP policy configuration should be synchronous or
asynchronous.
Thanks,
--Samer
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.0
On 06/08/2015 16:31, Laszlo Ersek wrote:
>> kvm_cpuid:func 8001 rax 6e8 rbx 0 rcx 0 rdx 10
>> kvm_enter_smm:vcpu 0: leaving SMM, smbase 0x7ffc
>> kvm_entry:vcpu 0
>> kvm_exit: reason TRIPLE_FAULT rip 0x7ffdb6b2 info 0 0
>> kvm_userspace_exit
Separate followup message with the symptoms I managed to gather about
the failure on KVM.
On 08/06/15 15:42, Laszlo Ersek wrote:
> Hi Star,
>
> On 08/06/15 11:44, Zeng, Star wrote:
>> Hi Laszlo,
>>
>> Could you help take a try with the attached patch on your VM before I
>> send it for formal revie
I am fine with PACKAGES_PATH. If $(PACKAGES_PATH) exists, Build directory will
be in $(WORKSPACE), Conf, BaseTools and Package directories will be searched
from $(PACKAGES_PATH). If $(PACKAGES_PATH) doesn't exist, all of them will be
in $(WORKSPACE) same to current usage model.
For the below c
Hi Star,
On 08/06/15 11:44, Zeng, Star wrote:
> Hi Laszlo,
>
> Could you help take a try with the attached patch on your VM before I send it
> for formal review?
I got your patch via your first (public) message as well -- not the one
reflected by the list software, but on the direct route. So,
Thanks Liming
At 2015-08-06 14:51:28, "Gao, Liming" wrote:
>This is a bug in BaseTools. We will root cause it and provide the patch.
>
>-Original Message-
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Andrew
>Fish
>Sent: Thursday, August 06, 2015 1:58 PM
On Fri, 2015-07-31 at 20:22 +0800, Star Zeng wrote:
> This feature is added for UEFI spec that says
> "Stack may be marked as non-executable in identity mapped page tables".
> A PCD PcdSetNxForStack is added to turn on/off this feature, and it is
> FALSE by default.
This broke the IA32 Ovmf build
On 07/31/15 20:40, Laszlo Ersek wrote:
> The SMBIOS 3.x entry point is structurally different from the 2.x
> variant, therefore the current code used by OvmfPkg and ArmVirtPkg
> doesn't recognize an SMBIOS 3.0 entry point structure even if QEMU
> exports one. This series rectifies that.
>
> The fi
On 08/05/15 18:32, Laszlo Ersek wrote:
> The LineNumber parameter of the DebugAssert() function has type UINTN.
> DebugAssert() passes it to AsciiSPrint() with the %d conversion specifier
> at the moment, but %d would require an INT32 argument.
>
> Fix this by casting LineNumber to UINT64, also em
Hi Laszlo,
Could you help take a try with the attached patch on your VM before I send it
for formal review?
Thanks,
Star
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Thursday, August 6, 2015 4:40 PM
To: Zeng, Star
Cc: Andrew Fish; Justen, Jordan L; edk2-de...@m
On 08/06/15 03:08, Zeng, Star wrote:
> I am working on that.
> One thing is strange that StartupAllAPs is working well with my qemu by OVMF
> and even real machine.
I didn't write test code specifically for this, I just rebased my SMM
series to master after I committed your patch to SVN. After en
On 08/05/15 23:46, Jordan Justen wrote:
> On 2015-08-05 13:21:37, Andrew Fish wrote:
>>> On Aug 5, 2015, at 12:16 PM, Jordan Justen
>>> wrote:
>>> On 2015-08-05 07:06:46, Gao, Liming wrote:
Tim gave another idea to define multiple source locations in
Platform DSC file. It doesn't confli
Reviewed-by: Qiu Shumin
-Original Message-
From: Zhang, Chao B
Sent: Thursday, August 06, 2015 4:04 PM
To: edk2-devel@lists.01.org
Cc: Qiu, Shumin; Zhang, Chao B
Subject: [PATCH] SecurityPkg: Update coding style
Update to EDK2 coding style
Contributed-under: TianoCore Contribution Agre
Update to EDK2 coding style
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chao Zhang
---
SecurityPkg/Library/AuthVariableLib/AuthService.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/SecurityPkg/Library/AuthVariableLib/AuthService.c
b/SecurityP
42 matches
Mail list logo