Re: [edk2] [patch] MdeModulePkg: HttpLib BodyParseComplete Event should indicate the end of message body

Got your opinion, I will modify it later, thanks -Original Message- From: Ye, Ting Sent: Tuesday, August 11, 2015 1:33 PM To: Zhang, Lubo; edk2-devel@lists.01.org Cc: Wu, Jiaxin Subject: RE: [patch] MdeModulePkg: HttpLib BodyParseComplete Event should indicate the end of message body I

Re: [edk2] [patch] MdeModulePkg: HttpLib BodyParseComplete Event should indicate the end of message body

I suggest to update the comments below "The last chunk has been parsed, then need to decide last message is Trailer or CRLF", in order to make it easier for user to understand the code logic. Other parts are good to me. Reviewed-by: Ye Ting -Original Message- From: Zhang, Lubo Sent:

Re: [edk2] Library refinement: OptionRomPkg/BltLib

Laszlo, The reason I wanted to use the four APIs instead of only one BltLibGopBlt is if user just wants to fill video, he can supply less parameters. I am glad you have no concern to the refine proposal. Jordan, Any thought? Thanks, Ray -Original Message- From: Laszlo Ersek [mailto:ler.

[edk2] How to Add RealTek ALC262 Codec Support connected to Intel HDA bus

Hi experts! We have an Intel Atom Baytrail SoC (E3845) based board which has a Realtek ALC262 audio codec connected to the Intel HAD bus. We used the 0.82 MinnowBoard MAX firmware as our starting "BIOS" and modified it to support SODIMM's etc. We are using yocto built linux and Ubuntu as test OS'

Re: [edk2] Status of porting acpidump to edk2 ?

> On Aug 10, 2015, at 7:33 PM, Shubha Ramani wrote: > > I know people were attempting to port acpidump from https://www.acpica.org/ > to EDK2. Any success ? I need it desperately. If you look at the mailing list history jonathan.d.sm...@intel.com posted

[edk2] [patch] MdeModulePkg:Use safe string functions in UiApp.

Replace the unsafe string functions with the safe one in UiApp. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Application/UiApp/BootMaint/BootOption.c | 30 ++ .../Application/UiApp/BootMaint/FormGuid.h | 2 +- .../Ap

Re: [edk2] [Patch] MdeModulePkg: Fix issue about Ip4Dxe implementation for DHCP DORA process

Looks good to me. Reviewed-by: Ye Ting -Original Message- From: Wu, Jiaxin Sent: Friday, August 07, 2015 2:28 PM To: edk2-devel@lists.01.org Cc: Fu, Siyuan; Ye, Ting Subject: [Patch] MdeModulePkg: Fix issue about Ip4Dxe implementation for DHCP DORA process DHCP policy is applied as d

[edk2] Status of porting acpidump to edk2 ?

I know people were attempting to port acpidump from https://www.acpica.org/    to EDK2. Any success ? I need it desperately.  Thanks, Shubha Shubha D. ramanishubharam...@gmail.com shubharam...@yahoo.com ___ edk2-devel mailing list edk2-devel@lists.01.org

Re: [edk2] How to update an App Lib dependency ?

Yes thank you Tian. I rea the EDK2 Module Writer's Guide and figured it out. Shubha Shubha D. ramanishubharam...@gmail.com shubharam...@yahoo.com On Tuesday, August 4, 2015 5:49 PM, "Tian, Feng" wrote: Why do you need to do the copy operation? EDKII Build system could ensure this d

Re: [edk2] TCG EV_SEPARATOR event and PCR[7]

Hi Bill That is good question. In first version of TrEE, we do measure it at same place. But later, we realize it might cause issue on Win8. I added comments in code. // // We need measure Separator(7) here, because this event must be between SecureBootPolicy (Configure) // and ImageVerifi

Re: [edk2] Question about memory reservation from PrePi to DXE

On Mon, 2015-08-10 at 16:18 -0700, Andrew Fish wrote: > > > Laszlo and I are not the maintainers for this code. > https://github.com/tianocore/edk2/blob/master/Maintainers.txt > > > But it does feel like the assumption in the DXE Core is not implied by > the PI Specifications. Thanks, I'm us

Re: [edk2] Question about memory reservation from PrePi to DXE

> On Aug 10, 2015, at 4:01 PM, Benjamin Herrenschmidt > wrote: > > On Tue, 2015-08-11 at 08:08 +1000, Benjamin Herrenschmidt wrote: > > .../... > >> That means that if I want to reserve memory elsewhere in the system, I >> need to either: >> >> - Make sure that chunk of memory is not covered

Re: [edk2] Question about memory reservation from PrePi to DXE

On Tue, 2015-08-11 at 08:08 +1000, Benjamin Herrenschmidt wrote: .../... > That means that if I want to reserve memory elsewhere in the system, I > need to either: > > - Make sure that chunk of memory is not covered by a memory resource > descriptor HOB, or at least one that isn't marked somew

Re: [edk2] Question about memory reservation from PrePi to DXE

On Mon, 2015-08-10 at 14:38 -0700, Andrew Fish wrote: > > > The CoreInitializeMemoryServices() > https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Core/Dxe/Gcd/Gcd.c, > is going to start allocating from the resource descriptor HOB that contains > the PHIT range. If you are actually ru

Re: [edk2] Question about memory reservation from PrePi to DXE

> On Aug 10, 2015, at 1:51 PM, Benjamin Herrenschmidt > wrote: > > On Mon, 2015-08-10 at 20:14 +0200, Laszlo Ersek wrote: >> On 08/10/15 18:46, Andrew Fish wrote: > Essentially, I am on a platform/architecture which feeds a flat device-tree to EDK and I need to honor the input reserv

Re: [edk2] Question about memory reservation from PrePi to DXE

On Mon, 2015-08-10 at 20:14 +0200, Laszlo Ersek wrote: > On 08/10/15 18:46, Andrew Fish wrote: > >> Essentially, I am on a platform/architecture which feeds a flat > >> device-tree to EDK and I need to honor the input reserved regions > >> as they cover bits of memory either already used by the HW

Re: [edk2] Question about memory reservation from PrePi to DXE

On Mon, 2015-08-10 at 09:46 -0700, Andrew Fish wrote: > > > You can’t pass in an allocation, so you can only control things from > the GCD point of view. See CoreInitializeMemoryServices() in > https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Core/Dxe/Gcd/Gcd.c > > And that is done via

Re: [edk2] Loading/testing non-application modules (PEIMs, etc) in emulator

> On Aug 10, 2015, at 1:13 PM, David Van Arnem wrote: > > Hello, > > I am new to EFI development and I am trying to implement measured boot and > attestation using EDK2. Right now, I'm just trying to understand how to run > non-application modules using the EDK2 Emulator. > > I've built and

[edk2] Loading/testing non-application modules (PEIMs, etc) in emulator

Hello, I am new to EFI development and I am trying to implement measured boot and attestation using EDK2. Right now, I'm just trying to understand how to run non-application modules using the EDK2 Emulator. I've built and run the Emulator successfully (Fedora 22 64-bit), and I've been able

Re: [edk2] Question about memory reservation from PrePi to DXE

On 08/10/15 18:46, Andrew Fish wrote: > >> On Aug 8, 2015, at 2:59 PM, Benjamin Herrenschmidt >> mailto:b...@kernel.crashing.org>> wrote: >> >> On Sat, 2015-08-08 at 08:56 -0700, Andrew Fish wrote: >>> If you really need to punch holes in the memory map, then you can use >>> resource descriptors.

Re: [edk2] AMD's UEFI strategy? - AMD Response

> On 07/31/2015 02:32 PM, Simpson, Gary wrote: >>> Is anyone from AMD on this list? If you know the right person, could you please forward? >> [Gary Simpson] Hi, Lee. My name is Gary Simpson (Firmware Architect at AMD). Your post was forwarded to me. >> (Thanks to both people who did so.) If de

Re: [edk2] Question about memory reservation from PrePi to DXE

> On Aug 8, 2015, at 2:59 PM, Benjamin Herrenschmidt > wrote: > > On Sat, 2015-08-08 at 08:56 -0700, Andrew Fish wrote: >> If you really need to punch holes in the memory map, then you can use >> resource descriptors. > > Yes, I do need to punch holes in there, Laszlo explanation (which I > h

[edk2] OVMF BoF @ KVM Forum 2015

Hi. Let's do an OVMF BoF at this year's KVM Forum too. Paolo will present Securing secure boot: system management mode in KVM and Tiano Core on Thursday, August 20, in the 5:00pm - 5:30pm time slot. Right after that, the BoF section starts at 5:30pm: http://events.linuxfoundation.org/even

[edk2] [PATCH 2/2] BeagleBoardPkg: remove outdated build scripts and instructions

Now that we can build the Beagleboard NOR image without the custom build scripts, let's remove them since they are outdated and out of sync with each other. Remove readme.txt as well: it is also outdated, and mostly covers QEMU and how to build Linaro SD images, which may not be relevant to most u

[edk2] [PATCH 1/2] BeagleBoardPkg: fold configuration header into FD build

Since the configuration header never changes unless the board parameters in ConfigurationHeader.dat are updated, we can take a snapshot of the binary and add it to the FDF definition. This way, it will get emitted by the EDK2 build system instead of having to use a separate post-processing tool to

Re: [edk2] Problem with CorebootPayloadPkg startup

Zeng, Star [mailto:star.z...@intel.com] wrote: ]Sent: Monday, August 10, 2015 04:08 AM ]To: Scott Duplichan ; edk2-devel@lists.01.org ]Cc: Ma, Maurice ; Agyeman, Prince ]Subject: Re: [edk2] Problem with CorebootPayloadPkg startup ] ]> -Original Message- ]> From: edk2-devel [mailto:edk2

Re: [edk2] [PATCH 1/5] StdLib: remove mention of ARMGCC

On 10 August 2015 at 16:43, Daryl McDaniel wrote: > Ard, > > Thank you for the patch. I'll get it applied today. > Hello Daryl, Thanks, but perhaps I could have your ack instead, and apply everything when the various maintainers have acked each patch? You are the first to respond, and I'd like

Re: [edk2] [PATCH 1/5] StdLib: remove mention of ARMGCC

Ard, Thank you for the patch. I'll get it applied today. Daryl -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Monday, August 10, 2015 6:08 AM To: edk2-devel@lists.01.org; leif.lindh...@linaro.org; yingke.d@intel.com Cc: jordan.l.jus...@intel.com;

[edk2] [PATCH 0/3] ArmVirtXen clang fixes

These are some minor code changes to allow ArmVirtXen to be built using CLANG. Since the commercial ARM compiler suite is based on clang, we try and keep the EDK2 code clang-clean, hence these patches. Ard Biesheuvel (3): ArmVirtPkg: avoid relocated immediates in AARCH64 asm ArmVirtPkg: use gl

[edk2] [PATCH 3/3] OvmfPkg/Xen: use lower case x in hex immediate value

CLANG chokes on the value 0XEA1 since it expects the 0x prefix to use a lower case x. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- OvmfPkg/Include/IndustryStandard/Xen/arch-arm/xen.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[edk2] [PATCH 1/3] ArmVirtPkg: avoid relocated immediates in AARCH64 asm

The relocated immediate notation supported by GNU as (e.g., #:lo12:foo) is not supported by clang. Since we are loading a constant value, they were not entirely appropriate here anyway, so simply replace them with assembler arithmetic expressions. Contributed-under: TianoCore Contribution Agreemen

[edk2] [PATCH 2/3] ArmVirtPkg: use global section alignment in custom linker script

The ArmVirtPrePiUniCoreRelocatable module comes with its own GNU linker script to create a PIE executable that can relocate itself at runtime. In order to be able to build this module using CLANG, we need to adhere to the section alignment passed via to the linker using -z commmon-page-size, so add

Re: [edk2] [PATCH 3/5] ArmPlatformPkg: remove mention of ARMGCC and ARMLINUXGCC

On 10 August 2015 at 15:45, Leif Lindholm wrote: > On Mon, Aug 10, 2015 at 03:07:41PM +0200, Ard Biesheuvel wrote: >> Remove the ARMGCC and ARMLINUXGCC from comments in the respective >> Makefiles of ArmPlatformPkg and ArmJunoPkg and from the [ancient] >> Versatile Express instructions. >> >> Cont

Re: [edk2] [PATCH 3/5] ArmPlatformPkg: remove mention of ARMGCC and ARMLINUXGCC

On Mon, Aug 10, 2015 at 03:07:41PM +0200, Ard Biesheuvel wrote: > Remove the ARMGCC and ARMLINUXGCC from comments in the respective > Makefiles of ArmPlatformPkg and ArmJunoPkg and from the [ancient] > Versatile Express instructions. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Si

[edk2] [PATCH 5/5] BaseTools: remove ARMGCC and ARMLINUXGCC toolchains

The ARMGCC and ARMLINUXGCC toolchains are specific to the ARM and AARCH64 architectures, and overlap with the toolchain configuration that is provided by the GCC44 - GCC49 toolchains, which are defined for all architectures. To reduce the maintenance burden, and make it easier to keep these differ

[edk2] [PATCH 3/5] ArmPlatformPkg: remove mention of ARMGCC and ARMLINUXGCC

Remove the ARMGCC and ARMLINUXGCC from comments in the respective Makefiles of ArmPlatformPkg and ArmJunoPkg and from the [ancient] Versatile Express instructions. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPlatformPkg/ArmJunoPkg/Makefile

[edk2] [PATCH 1/5] StdLib: remove mention of ARMGCC

The ARMGCC toolchain will be removed, and so will the build rule family by the same name. So remove the BuildOptions specific to ARMGCC. Cc: Daryl McDaniel Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- StdLib/StdLib.inc | 2 -- 1 fil

[edk2] [PATCH 2/5] EmbeddedPkg: remove mention of ARMGCC

We are going to remove the ARMGCC toolchains, so replace any references to it with its replacement GCC48. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- EmbeddedPkg/Library/GdbDebugAgent/GdbDebugAgent.c | 4 ++-- EmbeddedPkg/Library/GdbDebugAgent/gdbnot

[edk2] [PATCH 0/5] remove ARMGCC and ARMLINUXGCC toolchains

Add one, remove two ... After adding the CLANG35 toolchain today, I noticed there is quite an abundance of toolchains supported in EDK2, and in the ARM case, there is some overlap between ARMGCC/ARMLINUXGCC and the GCC4x toolchains that are defined for all architectures. Since the recent changes

[edk2] [PATCH 4/5] BeagleBoardPkg: remove mention of ARMGCC and ARMLINUXGCC

The ARM and ARMLINUXGCC toolchains will be removed, so replace any mention of them with their replacement GCC48. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- BeagleBoardPkg/ba.bat | 5 +++-- BeagleBoardPkg/build.sh | 7 --- BeagleBoardPkg/re

Re: [edk2] error when use ovmf

On 08/10/15 08:50, 闪耀 wrote: > when i used ovmf.fd in qemu manager, > then occurcs this tips: > Boot Failed. EFI DVD/CDROM > Boot Failed. EFI Floopy > > > i don't know what does this mean? Your QEMU boot order specification ("-boot ..." option, or "-device ...,bootindex=N" properties) are incomp

Re: [edk2] Library refinement: OptionRomPkg/BltLib

On 08/10/15 05:09, Ni, Ruiyu wrote: > Jordan and Laszlo, > > I reviewed the OptionRomPkg/BltLib again and would like to discuss with > you about the potential API refinement. > > I attached two versions of the refined BltLib.h. > > > The common part of the two versions is: > > 1. BltLibGe

[edk2] [PATCH 2/2] BaseTools AARCH64: use tiny code model by default

The AARCH64 tiny code model produces more efficient code, since it uses relative symbol references rather than absolute references, i.e., an emitted relative reference refers to the symbol directly rather than a literal containing its 64-bit absolute address. This saves space in the binary, and red

[edk2] [PATCH 0/2] AARCH64 tiny code model support

The AARCH64 GCC builds use the GCC large code model by default, simply because it is the code model that requires the least amount of hacking to produce code that supports the PE/COFF conversion applied by Tianocore. However, it is suboptimal in more than one way: - each symbol reference requires

[edk2] [PATCH 1/2] ArmVirtPkg: build our DEBUG Shell using the small code model

The DEBUG build of the Shell exceeds 1 MB in size, which means that it cannot be built using the tiny code model. So force the use of the code model in this case. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmVirtPkg/ArmVirt.dsc.inc | 9 + 1

[edk2] [PATCH] MdeModulePkg Variable: Handle variable Attributes mismatch case

between variable HOB and NV storage. Variable HOB may be built by a system that supports and loads variable default, the variables in the HOB will be flush to NV storage after variable write search ready. After that, if the variable's Attributes is changed by someone and system reboots and tries t

[edk2] [patch 2/2] MdeModulePkg: Refine the code in UiApp

Refine the code in UiApp to prevent the potential risk. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Application/UiApp/BootMaint/FileExplorer.c | 1 - MdeModulePkg/Application/UiApp/BootMaint/Variable.c | 12 ++-- 2 files changed,

[edk2] [patch 1/2] IntelFrameworkModulePkg:Refine the code in LegacyBootMaintUiLib

Refine the code in LegacyBootMaintUiLib to prevent the potential risk. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Library/LegacyBootMaintUiLib/LegacyBootMaintUi.c| 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git

Re: [edk2] Problem with CorebootPayloadPkg startup

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Scott Duplichan > Sent: Monday, August 10, 2015 3:00 AM > To: edk2-devel@lists.01.org > Cc: Ma, Maurice; Agyeman, Prince > Subject: [edk2] Problem with CorebootPayloadPkg startup > > Hello, > >

Re: [edk2] [PATCH v2] BaseTools/GenFds: Fix 'NoneType' object is not iterable error.

Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Qiu Shumin Sent: Monday, August 10, 2015 2:22 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin; winggundu...@163.com; Gao, Liming Subject: [edk2] [PATCH v2] BaseTools/GenFds: F

Re: [edk2] [RFC PATCH 0/4] unify GCC command line options

On 10 August 2015 at 10:00, Gao, Liming wrote: > Ard: > This patch introduces GCC4X_ for common GCC option. It may be common for > GCC5, GCC6... So, how about use GCC_ prefix for all GCC common option? > Yes, I agree that would be better. I will change it. Thanks, Ard. > -Original Messa

Re: [edk2] [RFC PATCH 0/4] unify GCC command line options

Ard: This patch introduces GCC4X_ for common GCC option. It may be common for GCC5, GCC6... So, how about use GCC_ prefix for all GCC common option? Thanks Liming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Friday, Augu

Re: [edk2] [PATCH v4 7/7] BaseTools: add CLANG35 toolchain with AARCH64 support

On 10 August 2015 at 09:49, Gao, Liming wrote: > Reviewed-by: Liming Gao > Thanks Series committed as SVN r18192 ... r18198. Regards, Ard. > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, August 10, 2015 3:41 PM > To: edk2-devel@lists.01.

Re: [edk2] [PATCH v4 7/7] BaseTools: add CLANG35 toolchain with AARCH64 support

Reviewed-by: Liming Gao -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Monday, August 10, 2015 3:41 PM To: edk2-devel@lists.01.org; Liu, Yingke D; leif.lindh...@linaro.org Cc: Justen, Jordan L; Gao, Liming; Ard Biesheuvel Subject: [PATCH v4 7/7] BaseTool

Re: [edk2] [RFC PATCH 2/4] BaseTools GCC: unify warning flags for all GCC versions

On 10 August 2015 at 08:11, Gao, Liming wrote: > Reviewed-by: Liming Gao > Thank you Liming. Does that apply to all patches? Or just this 2/4 ? -- Ard. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard > Biesheuvel > Sent: Friday, Augu

[edk2] [PATCH v4 7/7] BaseTools: add CLANG35 toolchain with AARCH64 support

This adds support for building the AARCH64 platforms using the Clang compiler and assembler combined with the GNU (cross-)linker. The chosen name CLANG35 is based on version 3.5 being the oldest supported version, but no issues are known that would prevent its use with any later version. Contribu

[edk2] [PATCH v4 3/7] ArmPlatformPkg/ArmJunoPkg: use a rodata symbol for ReferenceAcpiTable

The ACPI .aslc files contain a ReferenceAcpiTable() function whose sole purpose is to ensure that the table itself does not get optimized away. However, when using clang, these dummy functions result in a 4 KB section alignment requirement, which is silly since everything except the .data section i

[edk2] [PATCH v4 0/7] small model and clang support for AARCH64

This is v4 of the followup to the series 'small C model and LLVM/clang support for AARCH64' that I sent out on July 17th. Now that the FFS/FV optimization patches have been merged, this is what remains to allow the AARCH64 platforms to be built using clang, combined with the GNU binutils (cross-)to

[edk2] [PATCH v4 2/7] ArmPkg/GenericWatchdogDxe: add missing VOID* cast

Use an explicit VOID* cast when passing a static char array into a function taking a void pointer. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm Tested-by: Leif Lindholm --- ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.

[edk2] [PATCH v4 4/7] ArmPlatformPkg/ArmJunoPkg: use TE 'auto' alignment for SEC modules

No need to hardcode the TE alignment anymore, now that GenFw sets the PE/COFF alignment according to the alignment requirements of the ELF input sections. Also enable FIXED FFS placement so that we can reclaim some of the space wasted to padding when using clang with 4 KB section alignment. Contr

[edk2] [PATCH v4 1/7] ArmPkg/GicV3: use GICv3 generic sysreg names only for GNU as

The GNU assembler extends the generic notation for IMPLEMENTATION DEFINED system registers to support any system register, so that system registers defined by newer versions of the architecture can still be used by older versions of the toolchain. Clang before v3.6 supports the generic notation, b

[edk2] [PATCH v4 6/7] BaseTools/GenFw: allow AArch64 tiny and small code model relocations

The AArch64 small C model makes extensive use of ADRP/ADD and ADRP/{LDR,STR} pairs to emit PC-relative symbol references with a +/- 4 GB range. Since the relocation pair splits the relative offset into a relative page offset and an absolute offset into a 4 KB page, we need to take extra care to ens

[edk2] [PATCH v4 5/7] ArmPlatformPkg/FVP: use 'auto' alignment and FIXED placement for XIP modules

Now that GenFw correctly propagates the minimum alignment of the ELF input sections to the PE/COFF binary, we can simply select 'auto' alignment in the FDF Rule section instead of tweaking it by hand. Also add the FIXED FFS attribute to the module types that may execute in place. This enables a ne

[edk2] [PATCH] ShellPkg\Tftp.c: Refine parameter name and use implicit comparison for BOOLEAN variable.

1. Refine parameter name to consistent with function headers. 2. To avoid potential bug BOOLEAN values should not use explicit comparisons to TRUE or FALSE. Cc: Ruiyu Ni Cc: Ronald Cron Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- ShellPkg/Library/Uefi