Re: [edk2] [PATCH] ArmPkg/CpuDxe: Disable interrupt before restoring context

2015-08-23 Thread Heyi Guo
On 08/17/2015 05:52 PM, Ard Biesheuvel wrote: On 13 August 2015 at 05:10, Heyi Guo wrote: Interrupt must be disabled before we storing ELR and other system registers, or else ELR will be overridden by interrupt reentrance. This bug is critical as we may get occasional exception or dead loop

Re: [edk2] [PATCH] ArmPkg/CpuDxe: Disable interrupt before restoring context

2015-08-23 Thread Ard Biesheuvel
On 23 August 2015 at 15:39, Heyi Guo wrote: > > > On 08/17/2015 05:52 PM, Ard Biesheuvel wrote: >> >> On 13 August 2015 at 05:10, Heyi Guo wrote: >>> >>> Interrupt must be disabled before we storing ELR and other system >>> registers, or else ELR will be overridden by interrupt reentrance. >>> >>

Re: [edk2] [Patch 6/8] OptionRomPkg/OvmfPkg: Remove BltLib::BltConfigure API

2015-08-23 Thread Jordan Justen
On 2015-08-17 19:42:04, Ni, Ruiyu wrote: > Jordan, > Sorry I missed your previous questions. Let me try to answer all > your questions in this email. > > Q1: Why merging Ex and non-Ex APIs? Providing Non-Ex APIs was to > make simpler functions available for blt operations. > > Merging the Ex and

Re: [edk2] [PATCH v3 2/2] OvmfPkg: Add HttpBoot support

2015-08-23 Thread Gary Ching-Pang Lin
On Sat, Aug 22, 2015 at 08:20:35PM -0700, Jordan Justen wrote: > I committed this patch. Thanks! > > I did have a question. I see that we need the HTTP_BOOT_ENABLE flag, > or the release build will overflow the 1MB image size. Is that the > only reason to only optionally enable the feature? > It'

Re: [edk2] [Patch 6/8] OptionRomPkg/OvmfPkg: Remove BltLib::BltConfigure API

2015-08-23 Thread Ni, Ruiyu
Jordan, reply embedded in the mail. Mike, Jordan proposed to add a new parameter Configuration in BltConfigure, instead of removing this API, to eliminate the global variables in library implementation. I think it's also a good solution and can benefit the library performance. What's your thou

[edk2] Some pages on new TianoCore wiki not being indexed (no results on Google)?

2015-08-23 Thread Bruce Cran
It seems indexing of the new wiki at http://tianocore.org is rather poor: I was looking for some information about the BeagleBoard/BeagleBone, and have found that even https://www.google.com/search?q=Beagle+Board+Wiki#q=tianocore+%22Beagle+Board+Wiki%22 doesn't have any results on tianocore.org

Re: [edk2] [Patch 6/8] OptionRomPkg/OvmfPkg: Remove BltLib::BltConfigure API

2015-08-23 Thread Jordan Justen
On 2015-08-23 20:09:23, Ni, Ruiyu wrote: > Jordan, > reply embedded in the mail. > > Mike, > Jordan proposed to add a new parameter Configuration in BltConfigure, > instead of removing this API, to eliminate the global variables in > library implementation. I think it's also a good solution and

[edk2] [patch] MdeModulePkg:Refine the code in HiiDatabaseDxe

2015-08-23 Thread Dandan Bi
Check the local variable 'NameSpace' before use it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/HiiDatabaseDxe/ConfigKeywordHandler.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/MdeModulePkg/Universa

Re: [edk2] [patch] MdeModulePkg:Refine the code in HiiDatabaseDxe

2015-08-23 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: Bi, Dandan Sent: Monday, August 24, 2015 1:28 PM To: Dong, Eric; Qiu, Shumin; edk2-devel@lists.01.org Subject: [patch] MdeModulePkg:Refine the code in HiiDatabaseDxe Check the local variable 'NameSpace' before use it. Contributed-under:

Re: [edk2] [patch] MdeModulePkg:Refine the code in HiiDatabaseDxe

2015-08-23 Thread Qiu, Shumin
Reviewed-by: Qiu Shumin -Original Message- From: Bi, Dandan Sent: Monday, August 24, 2015 1:28 PM To: Dong, Eric; Qiu, Shumin; edk2-devel@lists.01.org Subject: [patch] MdeModulePkg:Refine the code in HiiDatabaseDxe Check the local variable 'NameSpace' before use it. Contributed-under:

[edk2] [Patch] MdeModulePkg: Fix BdsDxe VS2015 build failure

2015-08-23 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Feng Tian --- MdeModulePkg/Universal/BdsDxe/BdsEntry.c | 1 - 1 file changed, 1 deletion(-) diff --git a/MdeModulePkg/Universal/BdsDxe/BdsEntry.c b/MdeModulePkg/Universal/BdsDxe/BdsEntry.c index 020f18d..6ffb66

Re: [edk2] [Patch] MdeModulePkg: Fix BdsDxe VS2015 build failure

2015-08-23 Thread Tian, Feng
Reviewed-by: Feng Tian -Original Message- From: Ni, Ruiyu Sent: Monday, August 24, 2015 13:44 To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Tian, Feng Subject: [Patch] MdeModulePkg: Fix BdsDxe VS2015 build failure Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu

[edk2] [Patch] NetworkPkg: Update HttpDxe to consume EFI_HTTP_UTILITIES_PROTOCOL

2015-08-23 Thread Jiaxin Wu
Since we add EFI_HTTP_UTILITIES_PROTOCOL support, HttpDxe driver should be updated to remove internal http utilities functions and consume this protocol directly. Cc: Ye Ting Cc: Siyuan Fu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiaxin Wu --- NetworkPkg/HttpDxe/

Re: [edk2] [PATCH 3/3] MdePkg/Library/UefiFileHandleLib: Make FileHandleReadLine return the right buffer size.

2015-08-23 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Qiu, Shumin Sent: Friday, August 21, 2015 4:03 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin; Carsey, Jaben; Gao, Liming Subject: [PATCH 3/3] MdePkg/Library/UefiFileHandleLib: Make FileHandleReadLine return the right buffer size. 1. '\r

[edk2] [patch] MdeModulePkg/Xhci: Remove TDs from transfer ring when timeout happens

2015-08-23 Thread Tian Feng
The error handling for timeout case is enhanced to remove TDs from transfer ring. The original code only removed s/w URB, but the h/w transfer descriptor TDs didn't get removed. It would cause data lost for data stream peripheral, such as usb-to-serial device, from the s/w perspective. Contributed

[edk2] [Patch] SourceLevelDebugPkg: Update package version to 0.96 to reflect new changes

2015-08-23 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Fan Jeff --- ShellPkg/ShellPkg.dsc | 4 +++- SourceLevelDebugPkg/SourceLevelDebugPkg.dec | 2 +- SourceLevelDebugPkg/SourceLevelDebugPkg.dsc | 2 +- 3 files changed, 5 insertions(+), 3 delet

[edk2] [Patch] SourceLevelDebugPkg: Update package version to 0.96 to reflect new changes

2015-08-23 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Fan Jeff --- SourceLevelDebugPkg/SourceLevelDebugPkg.dec | 2 +- SourceLevelDebugPkg/SourceLevelDebugPkg.dsc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/SourceLevelDebugPkg/SourceLevelD

Re: [edk2] [Patch 6/8] OptionRomPkg/OvmfPkg: Remove BltLib::BltConfigure API

2015-08-23 Thread Ni, Ruiyu
Jordan, The mail is too long so let me summarize in below: (I changed all API name to remove "Lib") 1. Have four or six BLT APIs? four: BltVideoFill BltVideoToVideo BltVideoToBuffer BltBufferToVideo six: BltVideoFill BltVideoToVideo BltVideoToBuffer BltBufferToVideo BltVideoToBufferEx

Re: [edk2] [Patch] SourceLevelDebugPkg: Update package version to 0.96 to reflect new changes

2015-08-23 Thread Fan, Jeff
Reviewed-by: Jeff Fan -Original Message- From: Ni, Ruiyu Sent: Monday, August 24, 2015 2:06 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Fan, Jeff Subject: [Patch] SourceLevelDebugPkg: Update package version to 0.96 to reflect new changes Contributed-under: TianoCore Contribution Agre