Re: [edk2] [PATCH] BaseTools/GenFw: align RVA of debug

2015-09-10 Thread Ard Biesheuvel
On 9 September 2015 at 11:44, Ard Biesheuvel wrote: > SVN commit r18077 ("BaseTools/GenFw: move .debug contents to .data to > save space") removed the separate .debug section after moving its > contents into .text or .data. However, this change does not take into > account that some of these conte

[edk2] [patch] MdeModulePkg:Refine the code comments in RegularExpressionDxe.

2015-09-10 Thread Dandan Bi
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../RegularExpressionDxe/RegularExpressionDxe.c| 146 + .../RegularExpressionDxe/RegularExpressionDxe.h| 108 +++ .../RegularExpressionDxe/RegularExpressionDxe.inf | 10 +

Re: [edk2] [Qemu-devel] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-10 Thread Andrew Fish
> On Sep 10, 2015, at 8:44 PM, Kevin Davis wrote: > >> >> On 09/10/2015 08:14 PM, Kevin Davis wrote: >>> Ah. I wasn't in the room when they figured it out. And I've never seen >> their written opinion. Is it documented somewhere? >> >> which in turn leads to this FAQ: >> https://urlde

Re: [edk2] [Qemu-devel] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-10 Thread Kevin Davis
> > On 09/10/2015 08:14 PM, Kevin Davis wrote: > >> > > Ah. I wasn't in the room when they figured it out. And I've never seen > their written opinion. Is it documented somewhere? > > which in turn leads to this FAQ: > https://web.archive.org/web/20121116185559/http://lkml.org/lkml/2009/6/ > 2

[edk2] [PATCH] ShellPkg: Fix Shell does not support ASCII pipe(|a).

2015-09-10 Thread Qiu Shumin
Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- ShellPkg/Application/Shell/Shell.c | 36 +--- 1 file changed, 25 insertions(+), 11 deletions(-) diff --git a/ShellPkg/Application/Shell/Shell.c b/ShellPkg/Appl

Re: [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-10 Thread Kevin Davis
> > > On 10/09/2015 16:24, Kevin Davis wrote: > > Further leading me to guess that any actual use of those > > implementations could lead to you actually needing to hire a real > > attorney and not one that you find on YouTube. > > The good thing is that attorneys have already figured it out. I

Re: [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-10 Thread Andrew Fish
> On Sep 10, 2015, at 7:22 AM, Blibbet wrote: > > >> Sure, mixture of licenses makes life more difficult. Not an excuse for >> ignoring non-BSD innovations and embracing Linux OSV/OEM community with >> their preferred license. GPL'ed LibreOffice bugfixes can't go upstream >> to BSD-like, ASF2 l

Re: [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-10 Thread Paolo Bonzini
On 10/09/2015 16:24, Kevin Davis wrote: > Further leading me to guess that any actual use of those > implementations could lead to you actually needing to hire a real > attorney and not one that you find on YouTube. The good thing is that attorneys have already figured it out. IBM figured out a

Re: [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-10 Thread Kevin Davis
> > > On Sep 10, 2015, at 4:40 AM, Alexander Graf wrote: > > > > > > > > On 10.09.15 12:04, Laszlo Ersek wrote: > >> On 09/10/15 08:19, Alexander Graf wrote: > >>> > >>> > Am 10.09.2015 um 07:32 schrieb Jordan Justen > : > >> > Laszlo's email raised the GPL question, but I was not sure

Re: [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-10 Thread Blibbet
> Sure, mixture of licenses makes life more difficult. Not an excuse for > ignoring non-BSD innovations and embracing Linux OSV/OEM community with > their preferred license. GPL'ed LibreOffice bugfixes can't go upstream > to BSD-like, ASF2 license of Apache OpenOffice, but that's life. I spent th

Re: [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-10 Thread Andrew Fish
> On Sep 10, 2015, at 4:40 AM, Alexander Graf wrote: > > > > On 10.09.15 12:04, Laszlo Ersek wrote: >> On 09/10/15 08:19, Alexander Graf wrote: >>> >>> Am 10.09.2015 um 07:32 schrieb Jordan Justen : >> Laszlo's email raised the GPL question, but I was not sure what the EDK II

Re: [edk2] [PATCH v2 0/2] MdeModulePkg: ScsiDiskDxe: handle EFI_BAD_BUFFER_SIZE from SCSI host adapter

2015-09-10 Thread Laszlo Ersek
On 09/10/15 02:46, Tian, Feng wrote: > Series Reviewed-by: Feng Tian Thank you! Committed as SVN r18437 and r18438. Laszlo > > Thanks > Feng > > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, September 09, 2015 17:39 > To: edk2-de...@ml01.01.org

Re: [edk2] [PATCH v3 0/4] enable Properties Table mem protection for ARM

2015-09-10 Thread Ard Biesheuvel
On 10 September 2015 at 11:45, Gao, Liming wrote: > Thanks. I am fine to GenFw tool change. > Thanks Liming. Any comments on the DebugRVA patch I sent out yesterday? Regards, Ard. > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Thursday, September

Re: [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-10 Thread Laszlo Ersek
On 09/10/15 08:19, Alexander Graf wrote: > > >> Am 10.09.2015 um 07:32 schrieb Jordan Justen : >> Laszlo's email raised the GPL question, but I was not sure what the >> EDK II community would accept with regards to GPL. Thus ... I asked. I >> guess I'm getting a better idea with regards to Apple

Re: [edk2] [PATCH v3 0/4] enable Properties Table mem protection for ARM

2015-09-10 Thread Gao, Liming
Thanks. I am fine to GenFw tool change. Liming -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Thursday, September 10, 2015 5:44 PM To: Gao, Liming Cc: edk2-devel@lists.01.org; leif.lindh...@linaro.org; Liu, Yingke D; sigmaepsilo...@gmail.com; ler...@red

Re: [edk2] [PATCH v3 0/4] enable Properties Table mem protection for ARM

2015-09-10 Thread Ard Biesheuvel
On 10 September 2015 at 11:32, Gao, Liming wrote: > Ard: > Does GenFw tool patch impact X86 arch? > No, it does not. Patch #1 just removes some dead code from Elf64Convert.c (since EM_ARM is only used for 32 bit code) Patch #2 changes three things in Elf32Convert.c: a) it removes a special ca

Re: [edk2] [Xen-devel] OVMF/Xen, Debian wheezy can't boot with NX on stack (Was: Re: [PATCH] OvmfPkg: prevent code execution from DXE stack)

2015-09-10 Thread Laszlo Ersek
On 09/10/15 05:05, Zeng, Star wrote: > On 2015/9/9 18:48, Laszlo Ersek wrote: >> me neither :) >> >>> but if this (executable code on stack) is >>> happening in grub is there something which is explicitly forbidden to >>> UEFI >>> apps by the UEFI spec? >> >> Yes, there is. This small OvmfPkg patch

Re: [edk2] [PATCH v3 0/4] enable Properties Table mem protection for ARM

2015-09-10 Thread Gao, Liming
Ard: Does GenFw tool patch impact X86 arch? Thanks Liming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Thursday, September 10, 2015 4:55 PM To: edk2-devel@lists.01.org; leif.lindh...@linaro.org; Liu, Yingke D Cc: sigmaep

[edk2] [Patch 0/6] Add multiple workspaces feature

2015-09-10 Thread Liming Gao
WORKSPACE is still kept. New optional PACKAGES_PATH is introduced to specify the additional WORKSPACEs. In PACKAGES_PATH, ';' is separator in Windows, ':' is separator in Linux. Build directory is in WORKSPACE. Package, BaseTools and Conf directory will be found from WORKSPACE and PACKAGES_PATH.

[edk2] [Patch 3/6] BaseTools: Update ECC tool to support multiple workspaces

2015-09-10 Thread Liming Gao
Update ECC to refer MultipleWorkspace class to convert the file path from WORKSPACE and PACKAGES_PATH. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Li YangX Reviewed-by: Liming Gao --- BaseTools/Source/Python/Ecc/Check.py | 13 + BaseTools/Source/P

[edk2] [Patch 5/6] BaseTools: Update Edk2Setup.bat to support multiple workspaces

2015-09-10 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao Reviewed-by: Wu Hao A --- BaseTools/Scripts/SetVisualStudio.bat | 2 +- BaseTools/Scripts/ShowEnvironment.bat | 2 ++ Edk2Setup.bat | 64 +-- 3 files change

[edk2] [Patch 1/6] BaseTools: Update Build tool to support multiple workspaces

2015-09-10 Thread Liming Gao
WORKSPACE is still kept. New PACKAGES_PATH is introduced to specify the additional WORKSPACEs. In PACKAGES_PATH, ';' is separator in Windows, ':' is separator in Linux. Build directory is in WORKSPACE. Package, BaseTools and Conf directory will be found from WORKSPACE and PACKAGES_PATH. In implem

[edk2] [Patch 6/6] BaseTools: Update edksetup.sh to support multiple workspaces

2015-09-10 Thread Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao Reviewed-by: Wu Hao A --- BaseTools/BuildEnv | 66 -- edksetup.sh| 19 +--- 2 files changed, 65 insertions(+), 20 deletions(-) diff --git a/B

[edk2] [Patch 2/6] BaseTools: Update UPT tool to support multiple workspaces

2015-09-10 Thread Liming Gao
Update UPT to refer MultipleWorkspace class to convert the file path from WORKSPACE and PACKAGES_PATH. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hesheng Chen Reviewed-by: Liming Gao --- .../Python/UPT/Core/DistributionPackageClass.py| 26 +++--- Base

[edk2] [Patch 4/6] BaseTools: Update edksetup.bat to support multiple workspaces

2015-09-10 Thread Liming Gao
1. Update edksetup.bat and toolsetup.bat to handle PACKAGES_PATH. BaseTools directory may be in PACKAGES_PATH instead of WORKSAPCE. 2. Introduce EDK_TOOLS_BIN env points to the windows binary tools dir. Windows BaseTools Win32 may be a separate directory. Contributed-under: TianoCore Contrib

Re: [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-10 Thread Paolo Bonzini
On 10/09/2015 08:57, Sharma Bhupesh wrote: > So based on my limited understanding, can't the OVMF driver which > uses features from some GPL based code, carry a dual license (GPL + > x11 [MIT]), No, that would require agreement from the original copyright holder, which you are not going to get.

[edk2] [PATCH v3 1/4] BaseTools/GenFw: remove ARM and RVCT references from ELF64 code

2015-09-10 Thread Ard Biesheuvel
ARM and RVCT apply to 32-bit code only, so remove any references to them from the 64-bit version of ElfConvert.c Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- BaseTools/Source/C/GenFw/Elf64Convert.c | 23 +--- 1 file changed, 1 insertio

[edk2] [PATCH v3 0/4] enable Properties Table mem protection for ARM

2015-09-10 Thread Ard Biesheuvel
This series implements 4 KB section alignment for ARM, which is required for supporting the Properties Table memory protection feature on this architecture. Patch #1 is a simple cleanup from the copy/paste that created Elf64Convert.c Patch #2 changes the PE/COFF .data alignment to adhere to the g

[edk2] [PATCH v3 3/4] BaseTools/ARM: move to unified GCC linker script

2015-09-10 Thread Ard Biesheuvel
Instead of using the ARM builtin linker script for GNU ld, use the new unified one instead. This will allow us to increase the section alignment for DXE_RUNTIME_MODULEs, which is a prerequisite for enabling the UEFIv2.5 Properties Table memory protection feature. Also, remove the -mword-relocation

[edk2] [PATCH v3 4/4] ArmVirtPkg: use 4 KB section alignment for ARM DXE_RUNTIME modules

2015-09-10 Thread Ard Biesheuvel
In order to support the Properties Table memory protection feature on 32-bit ARM, build DXE_RUNTIME_MODULE type binaries with 4 KB section alignment by setting the common-page-size linker command line option. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel Ac

[edk2] [PATCH v3 2/4] BaseTools/GenFw: make ARM's .data adhere to PE/COFF section alignment

2015-09-10 Thread Ard Biesheuvel
There is a special case in the 32-bit ElfConvert code where ARM's .data is not aligned to section alignment. This is needed to deal with an ARM RVCT specific size optimization that results in sections being misaligned with respect to their own alignment. The contents of these sections are laid out

[edk2] [Patch] ShellPkg: Add a simple case to test shell parameter parsing logic

2015-09-10 Thread Ruiyu Ni
TestArgv.nsh is a very simple shell script to test how the interpreter parses the parameters. It uses Argv.efi to dump the parameters passed from the interpreter. TestArgv.log is the desired output created by "TestArgv.nsh > TestArgv.log". Contributed-under: TianoCore Contribution Agreement 1.0 S

[edk2] [Basetool][ECC][patch]Remove the checkpoint for STATIC modifer and fix a bug for CONST variable

2015-09-10 Thread Chen, Hesheng
Hello Yang and all, Could you help review this patch? Thank you [Description] 1. Fix a bug of removing the checkpoint for STATIC modifier 2. Fix a bug of parsing CONST variable Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hess Chen Best Regards, Chen, Hess Intel Chi