In Shell spec 2.1 the return name of EFI_SHELL_PROTOCOL.GetCurDir() is defined
as
'fs0:\current-dir' while in current implementation it's 'fs0:\current-dir\'. To
follow
spec the patch removed the redundant '\' char.
Since it has been broken for a long time, some codes may depend on the broken
b
Yes. I have confirmed this is a typo in IA32 SDM. Good catch.
The code could be kept as is, since this is no real impact.
Thank you
Yao Jiewen
-Original Message-
From: Fan, Jeff
Sent: Monday, October 19, 2015 10:05 PM
To: Paolo Bonzini; Yao, Jiewen; Laszlo Ersek; edk2-de...@ml01.01.org
checked the ROM, it is the same it was a year ago.
Software versions:
QEMU emulator version 2.3.1 (qemu-2.3.1-6.fc22), Copyright (c) 2003-2008
Fabrice Bellard
EDK2.git: 20151019.b1270.g368002a
libvirtd (libvirt) 1.2.13.1 (doesn't matter much in that case)
Linux crossfire 4.2.3-200.fc22.x86_64
Dimitri,
Yes. A virtual mapping to the physical pages with the RT attribute may be
provided by the OS if the OS calls SetVirtualAddressMap().
The UEFI Spec quote below shows that some of the structures passed from
firmware to OS contain physical pointers that are not fixed up when
SetVirtualA
On 19/10/15 18:20, Andrew Fish wrote:
I was porting some code the other day and I hit a compiler warning that
PXE_OPFLAGS_STATION_ADDRESS_READ and PXE_OPFLAGS_STATION_ADDRESS_WRITE had the
same value? Is this correct, I didn’t see the value in the UEFI spec?
https://github.com/tianocore/edk2/b
Laszlo,
Thanks for the all git hints and advice.
I have split out the DSC update to the UefiCpuPkg, so it comes after the
PiSmmCpuiDxeSmm module is buildable.
Thanks,
Mike
>-Original Message-
>From: Laszlo Ersek [mailto:ler...@redhat.com]
>Sent: Monday, October 19, 2015 7:51 AM
>To: K
Laszlo,
I have updated the commit message and I have updated source to use gBS->Stall()
to be consistent with the rest of this module.
I will come back to this module in the future and look into using the
performance counter functions in the TimerLib and CpuPause(), so this module
can minimize
Laszlo,
Thanks for the feedback.
1) I have updated the author using --author='Laszlo Ersek '
2) I changed the order of the commits so the MP race condition is fixed before
your patch to sync MTRRs to all APs.
Best regards,
Mike
>-Original Message-
>From: edk2-devel [mailto:edk2-deve
I was porting some code the other day and I hit a compiler warning that
PXE_OPFLAGS_STATION_ADDRESS_READ and PXE_OPFLAGS_STATION_ADDRESS_WRITE had the
same value? Is this correct, I didn’t see the value in the UEFI spec?
https://github.com/tianocore/edk2/blob/master/MdePkg/Include/Uefi/UefiPxe.h
On Mon, Oct 19, 2015 at 09:36:00AM -0500, Jeremy Linton wrote:
> These patches correct a number of problems with the JUNO ACPI tables.
>
> First, put CCA attributes on the devices which can do DMA. This is
> because the linux kernel now requires ARM64 devices specify a coherency
> model. Without C
On 10/19/15 16:20, Laszlo Ersek wrote:
> On 10/19/15 09:44, Michael Kinney wrote:
>> Add module that initializes a CPU for the SMM environment and
>> installs the first level SMI handler. This module along with the
>> SMM IPL and SMM Core provide the services required for
>> DXE_SMM_DRIVERS to reg
On 10/19/15 16:18, Laszlo Ersek wrote:
> On 10/19/15 09:44, Michael Kinney wrote:
>> Add SmmCpuPlatformHookLib library class declaration
>> Add SmmCpuFeaturesLib library class declaration
>> Add gEfiSmmCpuServiceProtocolGuid protocol declaration
>> Build SmmCpuPlatformHookLibNull library instance
>
V3
Added appropriate contribution tag
V2
Removed mali definition as its not been completely tested yet.
V1
This set of patches updates the ACPI tables for the JunoR1 in keeping with
recent changes to the linux kernel.
These changes allow both the RHEL and mainline kernels to boot with a functio
These patches correct a number of problems with the JUNO ACPI tables.
First, put CCA attributes on the devices which can do DMA. This is
because the linux kernel now requires ARM64 devices specify a coherency
model. Without CCA the devices are unable to perform DMA.
Update the EHCI window to a fu
Code looks good. The format of the diff/patch seems quite different and harder
to decode than the usual.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Daryl McDaniel
> Sent: Friday, October 16, 2015 4:19 PM
> T
On 10/19/15 09:44, Michael Kinney wrote:
> Add module that initializes a CPU for the SMM environment and
> installs the first level SMI handler. This module along with the
> SMM IPL and SMM Core provide the services required for
> DXE_SMM_DRIVERS to register hardware and software SMI handlers.
>
On 10/19/15 09:44, Michael Kinney wrote:
> Add SmmCpuPlatformHookLib library class declaration
> Add SmmCpuFeaturesLib library class declaration
> Add gEfiSmmCpuServiceProtocolGuid protocol declaration
> Build SmmCpuPlatformHookLibNull library instance
> Build SmmCpuFeaturesLib library instance
>
This serial of patches s good to me! Thanks!
Reviewed-by: Jeff Fan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael
Kinney
Sent: Monday, October 19, 2015 3:45 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH v4 00/19] UefiCpuPkg: Add
On 10/19/15 09:44, Michael Kinney wrote:
> Add AcpuCpuData.h that defines a data structure that is shared between
> modules and is required for ACPI S3 support.
> APState field removed between V1 and V2 patch.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Michael Kin
Paolo,
Thanks reporting this spec issue. We will forward it to SDM owner to address it.
Thanks!
Jeff
-Original Message-
From: Paolo Bonzini [mailto:pbonz...@redhat.com]
Sent: Friday, October 16, 2015 4:38 PM
To: Yao, Jiewen; Fan, Jeff; Laszlo Ersek; edk2-de...@ml01.01.org
Cc: Kinney, Mi
comments below
On 10/19/15 09:44, Michael Kinney wrote:
> Address a race condition in first call to StartupAllAPs() with
> SingleThread set to TRUE in the MP initialization. If the APs
> have not entered their idle loop before StartupAllAPs() is called,
> then some of the APs will be in an unexpe
On 10/19/15 09:44, Michael Kinney wrote:
> From: edk2-devel
With SVN it won't matter much ultimately, but considering git per se, I
think in your git tree my authorship was lost somehow. (The
Signed-off-by below is correct though.) This can be fixed by:
- rebasing the series
- selecting "edit" fo
On 10/19/15 09:44, Michael Kinney wrote:
> Use PcdCpuApInitTimeOutInMicroSeconds instead of hardcoded 100ms for
> the time to wait for all APs to respond to first INIT SIPI SIPI
> wake request.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Michael Kinney
> Cc: Jeff
On 10/17/15 13:39, Paolo Bonzini wrote:
>
>
> On 16/10/2015 18:39, Kinney, Michael D wrote:
>> Paolo,
>>
>> Thanks for the reference. We believe this is a document issue.
>>
>> We would prefer to drop this patch.
>
> Fair enough. Laszlo, please keep it in your branch for ease of testing
> but
On 10/17/15 18:15, Kinney, Michael D wrote:
> Laszlo,
>
> I agree with many of your points.
>
> If you prefer, I can consolidate the UefiCpuPkg updates including 6
> items you list below into my UefiCpuPkg series and get that checked
> in first so you can focus on OVMF SMM.
That's greatly apprec
On 18/10/2015 09:38, Jordan Justen wrote:
> > This adjusts the previously introduced state save map access functions, to
> > account for QEMU and KVM's 64-bit state save map following the AMD spec
> > rather than the Intel one.
>
> Shouldn't this layout match the processor being emulated? I think
Hi Andrew,
Thank so much for your detailed reply.
Best Regards,
Nilesh
-Original Message-
From: af...@apple.com [mailto:af...@apple.com]
Sent: Thursday, October 15, 2015 8:42 PM
To: Nilesh
Cc: edk2-devel@lists.01.org
Subject: Re: [edk2] [EDK II] implementing
EFI_SMART_CARD_EDGE_PROTOCO
>
> UEFI spec has clear description about the configuration table for SMBIOS.
>
> UEFI 2.5 page 103 and 104:
> "
> The following list shows the GUIDs for tables defined in some of the
> industry standards. These
> industry standards define tables accessed as UEFI Configuration Tables
> on UEFI-
Add PlatformSecLib class and PlatformSecLibNull instance
that is used by the SecCore. PlatformSecLibNull should
not be used in a platform build. Instead, it should be
used as a template for implementing a platform specific
instance of the PlatformSecLib library class.
Contributed-under: TianoCor
Add CpuHotPlugData.h that defines a data structure that is shared between
modules and is required for to support hot plug CPUs.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Kinney
---
UefiCpuPkg/Include/CpuHotPlugData.h | 33 +
1
Add declaration of PlatformSecLib library class to DEC file
Add declaration of PcdPeiTemporaryRamStackSize PCD to DEC/UNI file
Add build of PlatformSecLibNull to DSC file
Add build of SecCore to DSC file
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Kinney
---
Ue
Add AcpuCpuData.h that defines a data structure that is shared between
modules and is required for ACPI S3 support.
APState field removed between V1 and V2 patch.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Kinney
Cc: Laszlo Ersek
---
UefiCpuPkg/Include/AcpiCp
Add SmmCpuPlatformHookLib that provides platform specific functions
that are used to initialize SMM and process SMIs. A Null instance
of this library is provided that should work for most platforms.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Kinney
---
UefiCp
Add modules that produce the SMM Communications PPI and
install a SW SMI handler for SMM Communication requests
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Kinney
---
.../PiSmmCommunication/PiSmmCommunicationPei.c | 425 +
.../PiSmmCommu
Add module that initializes a CPU for the SMM environment and
installs the first level SMI handler. This module along with the
SMM IPL and SMM Core provide the services required for
DXE_SMM_DRIVERS to register hardware and software SMI handlers.
CPU specific features are abstracted through the Sm
Add SmramSaveStateMap.h file that defines the 32-bit and 64-bit CPU
SMRAM Save State Map.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Kinney
---
UefiCpuPkg/Include/Register/SmramSaveStateMap.h | 190
1 file changed, 190 insertions(+)
c
Add module that initializes a CPU for the SMM environment and
installs the first level SMI handler. This module along with the
SMM IPL and SMM Core provide the services required for
DXE_SMM_DRIVERS to register hardware and software SMI handlers.
CPU specific features are abstracted through the Sm
Address a race condition in first call to StartupAllAPs() with
SingleThread set to TRUE in the MP initialization. If the APs
have not entered their idle loop before StartupAllAPs() is called,
then some of the APs will be in an unexpected state, and
StartupAllAPs() will hang. This is the hang cond
Use PcdCpuApInitTimeOutInMicroSeconds instead of hardcoded 100ms for
the time to wait for all APs to respond to first INIT SIPI SIPI
wake request.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Kinney
Cc: Jeff Fan
Cc: Laszlo Ersek
---
UefiCpuPkg/CpuDxe/ApStartup
Add SmmCpuFeaturesLib that provides CPU specific functions that are
used to initialize SMM and process SMIs. A functional implementation
of this library class is provided that is based on the
Intel(R) 64 and IA-32 Architectures Software Developer's Manual
[jeff@intel.com: Fix code style issue
From: edk2-devel
The Quark_EDKII_v1.1.0/IA32FamilyCpuBasePkg/CpuArchDxe
driver applies any MTRR changes to APs, if the
EFI_MP_SERVICES_PROTOCOL is available. We should do the same.
Additionally, the broadcast should occur at MP startup as well,
not only when MTRR settings are changed. The inspir
Only perform AP detection if PcdCpuMaxLogicalProcessorNumber > 1
Only free AP related structures of they were allocated
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Kinney
---
UefiCpuPkg/CpuDxe/CpuMp.c | 49 --
UefiCp
Add definition of the SMM CPU Service Protocol that is produced by
the PiSmmCpuDxeSmm module.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Kinney
---
UefiCpuPkg/Include/Protocol/SmmCpuService.h | 209
1 file changed, 209 insertions(+
Add SmmCpuPlatformHookLib library class declaration
Add SmmCpuFeaturesLib library class declaration
Add gEfiSmmCpuServiceProtocolGuid protocol declaration
Build SmmCpuPlatformHookLibNull library instance
Build SmmCpuFeaturesLib library instance
Changes between [PATCH v1] and [PATCH v2]:
1) Use mod
Add SecCore module that uses the PlatformSecLib class for platform
specific actions. The SecCore module also uses a new PCD to
configure the size of the stack used in the SEC phase. If the
stack size PCD is set to 0, the stack is configured to use half
of the available temporary RAM.
Contributed
Laszlo,
I have addressed the MP race conditions and have timeouts
configurable using a PCD in the CpuDxe module in this revised patch
series. I picked up the patch from your series to sync MTRRs. I
have also removed trailing spaces from all new files in UefiCpuPkg
and any files that were modi
Move CPUID related defines from LocalApic.h to Cpuid.h
Update LocalApicLib instances to include Cpuid.h
Update CpuMpPei module to include Cpuid.h
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Michael Kinney
---
UefiCpuPkg/CpuMpPei/CpuMpPei.h | 1 +
U
Hi Ray,
Could you help to review the updated patch?
Regards,
Sunny Wang
-Original Message-
From: Wang, Sunny (HPS SW)
Sent: Tuesday, October 13, 2015 6:10 PM
To: edk2-devel@lists.01.org
Cc: El-Haj-Mahmoud, Samer; Wang, Sunny (HPS SW)
Subject: [PATCH v2] MdeModulePkg: Make the B
48 matches
Mail list logo
