I am the author. Shumin did some final verification and fixed a bug and then
sent out for review.
> -Original Message-
> From: Justen, Jordan L
> Sent: Friday, December 04, 2015 4:11 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben ; Qiu, Shumin
>
> Subject: [PATCH] ShellPkg: Make '
I know this question has been answered before. Do I need to convert my
application to a UEFI StdLib applicationto do double or floating point math ?
Can't do it in a regular Shell App ?
Please illuminate.
Thanks,
Shubha Shubha D. ramanishubharam...@gmail.com
shubharam...@yahoo.com
___
From: Qiu Shumin
When using 'dh' to dump all protocols installed on a handle, some of
them are shown as 'UnknownDevice'.
Device patch make 'dh' support all spec defined protocols.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey
Reviewed-by: Qiu Shumin
Revie
Agreed. that works fine too...
> -Original Message-
> From: Justen, Jordan L
> Sent: Friday, December 04, 2015 2:14 PM
> To: Carsey, Jaben ; edk2-devel@lists.01.org
> Cc: Qiu, Shumin ; Carsey, Jaben
>
> Subject: RE: [PATCH v2 17/20] ShellPkg: Convert all .uni files to utf-8
> Importance:
On 2015-12-04 13:16:34, Carsey, Jaben wrote:
> There is a large change outstanding that was reviewed, but not yet
> committed for updating DH to display additional protocols. Can you
> commit that before this change?
How about we do the opposite? Commit this one first, and then rebase
that patch.
There is a large change outstanding that was reviewed, but not yet committed
for updating DH to display additional protocols. Can you commit that before
this change?
If yes,
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Justen, Jordan L
> Sent: Friday, December 04, 2015 12:1
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Justen, Jordan L
> Sent: Friday, December 04, 2015 12:14 PM
> To: edk2-devel@lists.01.org
> Cc: Justen, Jordan L ; Daryl McDaniel li...@mc2research.org>; Carsey, Jaben
> Subject: [PATCH v2 15/20] PerformancePkg: Convert all .uni fil
Hi,
I'm wondering under what conditions the SecureBoot EFI variable (with
GUID 8be4df61-93ca-11d2-aa0d-00e098032b8c) created. In particular, is it
necessarily present on computers that support Secure Boot but on which
that feature is disabled? I realize that it will normally exist in this
case (I'
Updated patch to use CopyMem instead of AsciiSPrint based on code review
feedback.
---
.../PeiDxeDebugLibReportStatusCode/DebugLib.c | 51 +++---
1 file changed, 36 insertions(+), 15 deletions(-)
diff --git
a/IntelFrameworkModulePkg/Library/PeiDxeDebugLibReportStatusCode/D
Thanks. I will send updated code change for the same library in
IntelFrameworkModulePkg.
> -Original Message-
> From: Gao, Liming [mailto:liming@intel.com]
> Sent: Friday, December 04, 2015 3:32 AM
> To: Anbazhagan, Baraneedharan; Kinney, Michael D; edk2-devel@lists.01.org
> Subject:
To convert these files I ran:
$ python3 BaseTools/Scripts/ConvertUni.py SourceLevelDebugPkg
Cc: Jeff Fan
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen
---
SourceLevelDebugPkg/DebugAgentDxe/DebugAgentDxe.uni | Bin 1888 -> 943 bytes
.../DebugAgentDxe/Debu
To convert these files I ran:
$ python3 BaseTools/Scripts/ConvertUni.py PerformancePkg
Cc: Daryl McDaniel
Cc: Jaben Carsey
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen
---
PerformancePkg/Dp_App/DpStrings.uni | Bin 38432 -> 19222 bytes
1 file changed, 0
To convert these files I ran:
$ python3 BaseTools/Scripts/ConvertUni.py ShellPkg
Cc: Jaben Carsey
Cc: Shumin Qiu
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen
---
ShellPkg/Application/Shell/Shell.uni | Bin 4840 -> 2419 bytes
ShellPkg/Libra
To convert these files I ran:
$ python3 BaseTools/Scripts/ConvertUni.py Vlv2TbltDevicePkg
Cc: David Wei
Cc: Tim He
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen
---
.../FirmwareUpdate/FirmwareUpdateStrings.uni | Bin 7472 -> 3750 bytes
.../Library/
To convert these files I ran:
$ python3 BaseTools/Scripts/ConvertUni.py PcAtChipsetPkg
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen
---
PcAtChipsetPkg/8254TimerDxe/Timer.uni | Bin 1784 -> 891 bytes
PcAtChipsetPkg/8254TimerDxe/
To convert these files I ran:
$ python3 BaseTools/Scripts/ConvertUni.py UefiCpuPkg
Cc: Jeff Fan
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen
---
UefiCpuPkg/CpuDxe/CpuDxe.uni| Bin 1756 -> 877 bytes
UefiCpuPkg/CpuDxe/CpuDxeExtra.un
web: https://github.com/jljusten/edk2/tree/uni-to-utf8-v2
git: https://github.com/jljusten/edk2.git uni-to-utf8-v2
Jordan Justen (20):
BaseTools/Scripts: Add ConvertUni.py script
ArmPkg: Convert all .uni files to utf-8
ArmPlatformPkg: Convert all .uni files to utf-8
CryptoPkg: Convert all
To convert these files I ran:
$ python3 BaseTools/Scripts/ConvertUni.py EmbeddedPkg
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen
---
EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatformDxe.uni | Bin 9422 -> 4710 bytes
1 f
To convert these files I ran:
$ python3 BaseTools/Scripts/ConvertUni.py IntelFrameworkModulePkg
Cc: Jeff Fan
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen
---
.../Bus/Isa/IsaBusDxe/IsaBusDxe.uni | Bin 2658 -> 1328 bytes
.../Bus/Isa/IsaBus
To convert these files I ran:
$ python3 BaseTools/Scripts/ConvertUni.py MdeModulePkg
Cc: Feng Tian
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen
---
.../BootManagerMenuApp/BootManagerMenuApp.uni | Bin 2110 -> 1054 bytes
.../BootManagerMenuApp/BootMa
To convert these files I ran:
$ python3 BaseTools/Scripts/ConvertUni.py SecurityPkg
Cc: Chao Zhang
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen
---
SecurityPkg/Application/RngTest/RngTest.uni | Bin 2254 -> 1126 bytes
SecurityPkg/Application/RngT
To convert these files I ran:
$ python3 BaseTools/Scripts/ConvertUni.py NetworkPkg
Cc: Siyuan Fu
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen
---
NetworkPkg/Application/IfConfig6/IfConfig6.uni | Bin 1884 -> 941 bytes
NetworkPkg/Application/IfConfig
To convert these files I ran:
$ python3 BaseTools/Scripts/ConvertUni.py DuetPkg
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen
---
DuetPkg/SmbiosGenDxe/SmbiosGenStrings.uni | Bin 2006 -> 1002 bytes
1 file changed, 0 insertions(+), 0 deletions
To convert these files I ran:
$ python3 BaseTools/Scripts/ConvertUni.py Nt32Pkg
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen
---
Nt32Pkg/CpuRuntimeDxe/Strings.uni| Bin 2172 -> 1088 bytes
Nt32Pkg/Library/PlatformBootManag
To convert these files I ran:
$ python3 BaseTools/Scripts/ConvertUni.py ArmPlatformPkg
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen
---
.../Library/ArmShellCmdRunAxf/ArmShellCmdRunAxf.uni | Bin 6472 -> 3235 bytes
To convert these files I ran:
$ python3 BaseTools/Scripts/ConvertUni.py EmulatorPkg
Cc: Andrew Fish
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen
---
.../MiscBaseBoardManufacturer.uni | Bin 2214 -> 1106 bytes
.../MiscSubClassPlatformD
To convert these files I ran:
$ python3 BaseTools/Scripts/ConvertUni.py CryptoPkg
Cc: Qin Long
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen
---
CryptoPkg/Application/Cryptest/Cryptest.uni | Bin 1924 -> 961 bytes
CryptoPkg/Application/Cryptest/
This script uses python codecs to convert .uni string files between
the utf-16 and utf-8 formats.
The advantages of utf-8 data:
* Generally smaller files
* More commonly supported by editors
* Not treated as binary data in patch files
The script was tested on MdePkg with both python 2.7 and py
To convert these files I ran:
$ python3 BaseTools/Scripts/ConvertUni.py IntelFrameworkPkg
Cc: Michael D Kinney
Cc: Jeff Fan
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen
---
IntelFrameworkPkg/IntelFrameworkPkg.uni | Bin 1930 -> 964 bytes
I
To convert these files I ran:
$ python3 BaseTools/Scripts/ConvertUni.py MdePkg
Cc: Michael D Kinney
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen
---
.../BaseCacheMaintenanceLib.uni | Bin 2434 -> 1216 bytes
MdePkg/Libr
To convert these files I ran:
$ python3 BaseTools/Scripts/ConvertUni.py ArmPkg
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen
---
ArmPkg/Application/LinuxLoader/LinuxLoader.uni | Bin 8166 -> 4082 bytes
1 file changed,
On 4 December 2015 at 20:20, Daryl McDaniel wrote:
[...]
>> On 12/03/15 13:54, Ard Biesheuvel wrote:
>>> The default behavior of the GCC compiler is to emit uninitialized
>>> globals into a COMMON section, where duplicate definitions are merged.
>>> This may result in unexpected behavior, since gl
On Friday, December 04, 2015, Laszlo Ersek wrote:
> Now, after reading the -fno-common documentation in the gcc manual, I'm
> actually *convinced* this is a gcc bug. The manual says on my RHEL-7.2
> system (excerpt):
>
>-fno-common
>In C code, controls the placement of uninitia
On 4 December 2015 at 20:13, Jordan Justen wrote:
> On 2015-12-04 08:43:29, Ard Biesheuvel wrote:
>> On 4 December 2015 at 17:27, Laszlo Ersek wrote:
>> > On 12/04/15 17:23, Paolo Bonzini wrote:
>> >>
>> >>
>> >> On 04/12/2015 11:39, Laszlo Ersek wrote:
>> >>> (4) Linking those two files into a c
On 2015-12-04 08:43:29, Ard Biesheuvel wrote:
> On 4 December 2015 at 17:27, Laszlo Ersek wrote:
> > On 12/04/15 17:23, Paolo Bonzini wrote:
> >>
> >>
> >> On 04/12/2015 11:39, Laszlo Ersek wrote:
> >>> (4) Linking those two files into a complete program is a violation of
> >>> "6.7 External defin
Sorry, I missed this patch. Yes, this looks good.
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Saturday, December 5, 2015 12:45 AM
> To: edk2-devel@lists.01.org; Long, Qin
> Cc: Ard Bieshe
Looks good to me. I think we should wait for Leekha for up to a few days to
confirm that this fixes the problem at their location.
Reviewed-by: Jaben Carsey
-Jaben
> -Original Message-
> From: Wu, Jiaxin
> Sent: Thursday, December 03, 2015 5:27 PM
> To: edk2-devel@lists.01.org
> Cc: L
On 3 December 2015 at 10:32, Ard Biesheuvel wrote:
> The header file OpenSslSupport.h not only defines a type 'struct timeval'
> but also defines a global variable 'timeval' of that type. The RVCT
> compiler does not merge this definition into a common symbol, resulting
> in duplicate definition e
On 4 December 2015 at 17:27, Laszlo Ersek wrote:
> On 12/04/15 17:23, Paolo Bonzini wrote:
>>
>>
>> On 04/12/2015 11:39, Laszlo Ersek wrote:
>>> (4) Linking those two files into a complete program is a violation of
>>> "6.7 External definitions":
>>>
>>> [...] If an identifier declared with ex
On 12/04/15 17:23, Paolo Bonzini wrote:
>
>
> On 04/12/2015 11:39, Laszlo Ersek wrote:
>> (4) Linking those two files into a complete program is a violation of
>> "6.7 External definitions":
>>
>> [...] If an identifier declared with external linkage is used in an
>> expression (other tha
On 12/04/15 16:26, Ard Biesheuvel wrote:
> On 4 December 2015 at 12:53, Laszlo Ersek wrote:
>> Nice in general; I have three comments:
>>
>> On 12/04/15 11:13, Shannon Zhao wrote:
>>> From: Shannon Zhao
>>>
>>> Here we add the memory space for the high memory nodes except the lowest
>>> one in FD
On 04/12/2015 11:39, Laszlo Ersek wrote:
> (4) Linking those two files into a complete program is a violation of
> "6.7 External definitions":
>
> [...] If an identifier declared with external linkage is used in an
> expression (other than as part of the operand of a *sizeof*
> opera
On 4 December 2015 at 15:50, Long, Qin wrote:
> Another open is:
> I know some companies / orgs will use the script to download / unpack / patch
> the openssl tar package for daily / automatic build testing.
> In before, OpenSSl put all releases (old and the latest) in one same folder,
> so no i
For the series, reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Thursday, December 3, 2015 6:51 PM
> To: edk2-devel@lists.01.org; eug...@hp.com; Long, Qin; dw...@infradead.org
> Cc: Ard Biesheu
On 4 December 2015 at 12:53, Laszlo Ersek wrote:
> Nice in general; I have three comments:
>
> On 12/04/15 11:13, Shannon Zhao wrote:
>> From: Shannon Zhao
>>
>> Here we add the memory space for the high memory nodes except the lowest
>> one in FDT. So these spaces will show up in the UEFI memory
Another open is:
I know some companies / orgs will use the script to download / unpack / patch
the openssl tar package for daily / automatic build testing.
In before, OpenSSl put all releases (old and the latest) in one same folder, so
no impacts to this process. In this year, OpenSSL only keep
Ard,
Thanks for your quick response against this OpenSSL upgrade. Your patch was
ready when I am still evaluating the security impacts and source changes. :-)
The severity evaluation should be moderate / high for EDKII-CryptoPkg, since
there were potential vulnerabilities on big number calculat
This should just return an error and not assert. We hit this when testing with
a client that was trying to access the old IP4_CONFIG on firmware implementing
IP4_CONFIG2.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eugene Cohen
---
MdeModulePkg/Universal/HiiDatabase
On 12/04/15 11:13, Shannon Zhao wrote:
> From: Shannon Zhao
>
> If there are more than one memory nodes in FDT, currently UEFI will
> assert. These two patches firstly let UEFI find the memory node with
> lowest base address and check if the address is what we expected and set
> PcdSystemMemorySi
Nice in general; I have three comments:
On 12/04/15 11:13, Shannon Zhao wrote:
> From: Shannon Zhao
>
> Here we add the memory space for the high memory nodes except the lowest
> one in FDT. So these spaces will show up in the UEFI memory map.
>
> Contributed-under: TianoCore Contribution Agree
> You're probably right. I'm very used to catching problems with PEI at
> that ASSERT() so I hate to see it go. But it could move to some well-
> defined place in DxeIpl.
I agree - I have hit that friendly ASSERT many times over the years as well.
This addition in my patchset in DxeIpl on the no
On 12/03/15 13:54, Ard Biesheuvel wrote:
> The default behavior of the GCC compiler is to emit uninitialized
> globals into a COMMON section, where duplicate definitions are merged.
> This may result in unexpected behavior, since global variables appearing
> by the same name in different C files ty
From: Shannon Zhao
Here we add the memory space for the high memory nodes except the lowest
one in FDT. So these spaces will show up in the UEFI memory map.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Shannon Zhao
---
ArmVirtPkg/ArmVirtQemu.dsc | 1 +
Arm
From: Shannon Zhao
While QEMU NUMA support on ARM will introduce more than one /memory node
in the device tree, it needs to find the lowest one and set
PcdSystemMemorySize with the actual size of this memory node.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Shannon Zha
From: Shannon Zhao
If there are more than one memory nodes in FDT, currently UEFI will
assert. These two patches firstly let UEFI find the memory node with
lowest base address and check if the address is what we expected and set
PcdSystemMemorySize as the size of this node. Then add other memory
Ard:
I check VS build. Two copies of mVirtualAddressChangeEvent are mapped to the
same memory location. For RuntimeDxe case, it doesn't cause any issue, because
their notification function doesn't use Event.
I agree this is a potential issue. But, VS and GCC compiler doesn't report
warning
Reviewed-by: Liming Gao
I would like to help commit your serial patches if no other comments.
Thanks
Liming
-Original Message-
From: Anbazhagan, Baraneedharan [mailto:anbazha...@hp.com]
Sent: Friday, December 04, 2015 1:13 AM
To: Kinney, Michael D; Gao, Liming; edk2-devel@lists.01.org
On 4 December 2015 at 10:17, Gao, Liming wrote:
> Good fix. How do you find this issue?
>
I got build failures with RVCT when using the UEFI Secure Boot
versions of VariableRuntimeDxe.
Could you check how VS deals with this? I.e., if the two copies of
mVirtualAddressChangeEvent are mapped onto th
Good fix. How do you find this issue?
Reviewed-by: Liming Gao
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Thursday, December 03, 2015 8:54 PM
To: edk2-devel@lists.01.org; Justen, Jordan L; Gao, Liming; Zhu, Yonghong
Cc: Ard Biesheuvel
Subject: [PATC
Upstream OpenSSL has released version 1.0.2e with security fixes, and has pulled
the previous version from the download servers. So upgrade our OpensslLib glue
from 1.0.2d to 1.0.2e.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
CryptoPkg/Library/Opens
60 matches
Mail list logo
