Re: [edk2] [Patch] ShellPkg: Fix ifconfig hang issue with incomplete parameters

Hi, Thanks for the fix, I will test it and revert in a day or two. Regards, Shaveta -Original Message- From: Carsey, Jaben [mailto:jaben.car...@intel.com] Sent: Friday, December 04, 2015 11:38 PM To: Wu, Jiaxin ; edk2-devel@lists.01.org Cc: Leekha Shaveta-B20052

Re: [edk2] [PATCH] ArmPkg/PrePeiCore: adhere to architectural stack alignment requirement

On 7 December 2015 at 18:12, Leif Lindholm wrote: > On Mon, Dec 07, 2015 at 04:59:49PM +0100, Ard Biesheuvel wrote: >> Instead of using fuzzy arithmetic with a hardcoded stack alignment value >> of 0x4, use the symbolic constant CPU_STACK_ALIGNMENT (which is at least >>

Re: [edk2] [patch] MdeModulePkg: Use PcdSet##S to replace PcdSet##

Reviewed-by: Qiu Shumin -Original Message- From: Bi, Dandan Sent: Monday, November 30, 2015 12:47 PM To: edk2-devel@lists.01.org Cc: Dong, Eric; Zeng, Star; Qiu, Shumin Subject: [patch] MdeModulePkg: Use PcdSet##S to replace PcdSet## Cc: Eric Dong

Re: [edk2] [PATCH 0/4] CryptoPkg: fix ARM and RVCT issues

On 7 December 2015 at 14:32, Cohen, Eugene wrote: > Ard, > >> As far as patch #4 is concerned, let's wait for confirmation from Eugene, >> also >> regarding the issue of reporting defect against RVCT (if there is a point in >> doing so) > > You're referring to "[PATCH 4/4]

Re: [edk2] [PATCH v3 0/4] Add BlockIO2 support for UFS

Sorry for typo, 'a.' should be "ScsiDiskDxe" instead of "ScsiBusDxe" > -Original Message- > From: Wu, Hao A > Sent: Tuesday, December 08, 2015 2:54 PM > To: edk2-devel@lists.01.org; Tian, Feng > Cc: Wu, Hao A > Subject: [PATCH v3 0/4] Add BlockIO2 support for UFS > > Compared with v2,

[edk2] [PATCH v3 2/4] MdeModulePkg ScsiDiskDxe: Add BlockIO2 Support

Together with EFI_BLOCK_IO_PROTOCOL, EFI_BLOCK_IO2_PROTOCOL is installed as well in ScsiDiskDxe. Block I/O 2 functions are implemented: Reset ReadBlocksEx WriteBlocksEx FlushBlocksEx Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu ---

[edk2] [PATCH v3 0/4] Add BlockIO2 support for UFS

Compared with v2, the following modifications have been made: a. ScsiBusDxe 1. For functions ScsiDiskReadBlocksEx() and ScsiDiskWriteBlocksEx(), signal 'Token->Event' when 'BufferSize' is zero. 2. For functions ScsiDiskReadBlocksEx() and ScsiDiskWriteBlocksEx(), add support for

[edk2] [PATCH v3 3/4] MdeModulePkg UfsPassThruDxe: Add Non-blocking I/O Support

Previously, UfsPassThruPassThru function does not handle the 'Event' parameter and blocking read/write operations are always executed. This commit enables non-blocking read/write feature for UFS devices. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu

[edk2] [PATCH v3 4/4] MdeModulePkg ScsiBusDxe: Fix caller event may nerver be signaled

For function ScsiExecuteSCSICommand(), when the 'Event' parameter is not NULL but the target SCSI device does not support non-blocking I/O, it will execute a blocking I/O operation instead. However, after the SCSI operation is done, the 'Event' is not signaled to inform the caller.

Re: [edk2] [PATCH v2] BaseTools GCC: avoid the use of COMMON symbols

On 7 December 2015 at 16:23, Laszlo Ersek wrote: > On 12/07/15 10:52, Ard Biesheuvel wrote: >> The default behavior of the GCC compiler is to emit uninitialized globals >> into a COMMON section, where duplicate definitions are merged. This may >> result in unexpected behavior,

Re: [edk2] [PATCH v2] BaseTools GCC: avoid the use of COMMON symbols

On 12/07/15 10:52, Ard Biesheuvel wrote: > The default behavior of the GCC compiler is to emit uninitialized globals > into a COMMON section, where duplicate definitions are merged. This may > result in unexpected behavior, since global variables defined under the > same name in different C files

[edk2] [PATCH] BaseTools: GCC: drop "asm" suffixes from BUILDRULEORDER

After SVN r17510 ("BaseTools: Add default BuildRuleOrder in tools_def.template") and SVN r17544 ("BaseTools/Conf: Don't support upper case nasm extensions"), the following suffix priorities were in place: - For XCODE32, XCLANG, XCODE5: S s nasm - Other toolchains: nasm asm Asm ASM S s When

Re: [edk2] [PATCH 0/4] CryptoPkg: fix ARM and RVCT issues

Ard, > As far as patch #4 is concerned, let's wait for confirmation from Eugene, also > regarding the issue of reporting defect against RVCT (if there is a point in > doing so) You're referring to "[PATCH 4/4] CryptoPkg/OpensslLib: ignore more false positive warnings for RVCT" and the idea of

Re: [edk2] HII ConfigRouting Assert - Why?

Eric, I stepped through this last week so I'll try to remember the path... There are two ways to find the DriverHandle in ExtractConfig: 1. searching the database of registered device paths, or the fallback of 2. calling LocateDevicePath for any handle matching the device path passed in. In

Re: [edk2] [Patch] BaseTools: process the files by the priority in BUILDRULEORDER

On 12/02/15 09:45, Yonghong Zhu wrote: > By the BUILDRULEORDER feature to process files listed in INF [Sources] > sections in priority order, if a filename is listed with multiple > extensions, the tools will use only the file that matches the first > extension in the space separated list. > >

Re: [edk2] [PATCH] ArmPkg/BdsLib: Send RemainingDevicePath to PXE Load File protocol

Hi Heyi, Thanks for this - committed as SVN r19148. Regards, Leif On Mon, Nov 23, 2015 at 04:25:25PM +0800, Heyi Guo wrote: > Load File protocol requires remaining device path rather than whole > device path. For PXE, it actually requires end node device path only, > or else invalid parameter

Re: [edk2] [PATCH] ArmPkg/PrePeiCore: adhere to architectural stack alignment requirement

On Mon, Dec 07, 2015 at 04:59:49PM +0100, Ard Biesheuvel wrote: > Instead of using fuzzy arithmetic with a hardcoded stack alignment value > of 0x4, use the symbolic constant CPU_STACK_ALIGNMENT (which is at least > 8 bytes, btw) to round the temporary stack base and size. > > Note that the stack

[edk2] [PATCH] ArmPkg/PrePeiCore: adhere to architectural stack alignment requirement

Instead of using fuzzy arithmetic with a hardcoded stack alignment value of 0x4, use the symbolic constant CPU_STACK_ALIGNMENT (which is at least 8 bytes, btw) to round the temporary stack base and size. Note that the stack itself is not initialized to an incorrectly aligned value, it is the

Re: [edk2] [PATCH] BaseTools: GCC: drop "asm" suffixes from BUILDRULEORDER

On 12/07/15 17:39, Jordan Justen wrote: > On 2015-12-07 07:03:47, Laszlo Ersek wrote: >> After SVN r17510 ("BaseTools: Add default BuildRuleOrder in >> tools_def.template") and SVN r17544 ("BaseTools/Conf: Don't support upper >> case nasm extensions"), the following suffix priorities were in

Re: [edk2] [PATCH] BaseTools: GCC: drop "asm" suffixes from BUILDRULEORDER

On 2015-12-07 07:03:47, Laszlo Ersek wrote: > After SVN r17510 ("BaseTools: Add default BuildRuleOrder in > tools_def.template") and SVN r17544 ("BaseTools/Conf: Don't support upper > case nasm extensions"), the following suffix priorities were in place: > > - For XCODE32, XCLANG, XCODE5: S s

Re: [edk2] [Patch] BaseTools: process the files by the priority in BUILDRULEORDER

On 2015-12-07 05:52:42, Laszlo Ersek wrote: > On 12/02/15 09:45, Yonghong Zhu wrote: > > By the BUILDRULEORDER feature to process files listed in INF [Sources] > > sections in priority order, if a filename is listed with multiple > > extensions, the tools will use only the file that matches the

Re: [edk2] [Patch] BaseTools: process the files by the priority in BUILDRULEORDER

On 12/07/15 18:14, Jordan Justen wrote: > On 2015-12-07 05:52:42, Laszlo Ersek wrote: >> On 12/02/15 09:45, Yonghong Zhu wrote: >>> By the BUILDRULEORDER feature to process files listed in INF [Sources] >>> sections in priority order, if a filename is listed with multiple >>> extensions, the tools

Re: [edk2] [PATCH v2 04/20] CryptoPkg: Convert all .uni files to utf-8

Reviewed-by: Qin Long Best Regards & Thanks, LONG, Qin > -Original Message- > From: Justen, Jordan L > Sent: Saturday, December 5, 2015 4:13 AM > To: edk2-devel@lists.01.org > Cc: Justen, Jordan L; Long, Qin > Subject: [PATCH v2 04/20] CryptoPkg: Convert all .uni

Re: [edk2] [PATCH 2/3] SecurityPkg: AuthVariableLib: Customized SecureBoot Mode transition. Implement Customized SecureBoot Mode transition logic according to Mantis 1263, including AuditMode/Deployed

On 7 December 2015 at 03:04, Zhang, Chao B wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Zhang, Chao > Reviewed-by: Zeng Star > Reviewed-by: Long Qin > --- This patch

[edk2] [PATCH v2] BaseTools GCC: avoid the use of COMMON symbols

The default behavior of the GCC compiler is to emit uninitialized globals into a COMMON section, where duplicate definitions are merged. This may result in unexpected behavior, since global variables defined under the same name in different C files may not refer to the same logical data item. For

Re: [edk2] [PATCH 0/4] CryptoPkg: fix ARM and RVCT issues

On 4 December 2015 at 16:45, Long, Qin wrote: > For the series, reviewed-by: Qin Long > Thank you Qin. I have committed the first three patches as SVN r19145 ... r19147, since they are not RVCT specific, and there were no objections raised. As far as

Re: [edk2] [PATCH 2/3] SecurityPkg: AuthVariableLib: Customized SecureBoot Mode transition. Implement Customized SecureBoot Mode transition logic according to Mantis 1263, including AuditMode/Deployed

Ard: Sorry for the inconvenience, your fix is good. Thanks & Best regards Chao Zhang -Original Message- From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] Sent: Monday, December 07, 2015 4:35 PM To: Zhang, Chao B Cc: edk2-devel@lists.01.org; qin.l...@inte.com; Zeng, Star

Re: [edk2] [PATCH 2/3] SecurityPkg: AuthVariableLib: Customized SecureBoot Mode transition. Implement Customized SecureBoot Mode transition logic according to Mantis 1263, including AuditMode/Deployed

On 7 December 2015 at 09:57, Zhang, Chao B wrote: > Ard: > Sorry for the inconvenience, your fix is good. > Thank you Chao > > > > > Thanks & Best regards > Chao Zhang > > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent:

[edk2] [PATCH] SecurityPkg: AuthVariableLib: Fix GCC compile error

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang, Chao --- SecurityPkg/Library/AuthVariableLib/AuthService.c | 34 +++ 1 file changed, 17 insertions(+), 17 deletions(-) diff --git

Re: [edk2] [PATCH v3 2/3] BaseTools/GenFw RVCT: fix relocation processing of PT_DYNAMIC sections

On 2 December 2015 at 17:06, Ard Biesheuvel wrote: > Unlike GNU ld, which can be instructed to emit symbol based static > relocations into fully linked binaries using the --emit-relocs command > line switch, the RVCT armlink tool can only emit dynamic relocations > into

[edk2] clang + ld build with .data section link error in X64 binary

Hello, I'm working on enabling the standard clang3.7 build for MinnowMax open source firmware. I meet an warning when use GNU ld linker to generate X64 image: "ld: warning: section `.data' type changed to PROGBITS" as below. This warning only appears on X64 binaries linking, and not on the i32

Re: [edk2] [PATCH] BaseTools GCC: avoid the use of COMMON symbols

On 12/04/15 20:20, Daryl McDaniel wrote: > On Friday, December 04, 2015, Laszlo Ersek wrote: >> Now, after reading the -fno-common documentation in the gcc manual, I'm >> actually *convinced* this is a gcc bug. The manual says on my RHEL-7.2 >> system (excerpt): >> >>-fno-common >>

Re: [edk2] InsertImageRecord and Section Alignment

Jiewen, I agree that is a good place to put the error message. Mike > -Original Message- > From: Yao, Jiewen > Sent: Sunday, December 6, 2015 7:06 PM > To: Kinney, Michael D ; Laszlo Ersek > ; Kinney, Michael D >

[edk2] [BaseTool][UPT][ECC]Fix a bug to ignore the lib ins defined in [components] section but also listed in SkipDir

Hello Yonghong and all, Could you help review this patch? Thank you [Description] 1. Fix a bug to ignore the lib ins defined in [components] section but also listed in SkipDir Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hess Chen Best

Re: [edk2] [PATCH] BaseTools: GCC: drop "asm" suffixes from BUILDRULEORDER

On 2015-12-07 18:15:55, Zhu, Yonghong wrote: > Hi Laszlo, > > Thanks. I will add the test on GCC and update the implementation to > ignore .asm for toolchain families that don't have a build rule. How long will this take to fix? If it going to take more than a few hours, then we should revert

Re: [edk2] clang + ld build with .data section link error in X64 binary

> On Dec 7, 2015, at 3:45 AM, Shi, Steven wrote: > > Hello, > I'm working on enabling the standard clang3.7 build for MinnowMax open source > firmware. I meet an warning when use GNU ld linker to generate X64 image: > "ld: warning: section `.data' type changed to

[edk2] [PATCH 0/4] BaseTools: Shell wrapper rewrite

From: Charles Duffy The attached set of patches make edk2 buildable on operating systems where "python" refers to Python 3.x and "python2" refers to Python 2.x; Arch Linux is an example of such. Moreover, they generally rewrite the set of scripts in question to conform with

[edk2] [PATCH 4/4] BaseTools: Improve LzmaF86Compress wrapper

From: Charles Duffy - Remove test usage declared obsolescent by POSIX - Pass argv array through as literal rather than forming into a string, then string-splitting and glob-expanding same. Signed-off-by: Charles Duffy Contributed-under: TianoCore

[edk2] [PATCH 2/4] BaseTools: Improve shell wrapper for C build commands

From: Charles Duffy - Avoid obsolescent forms of test builtin (`-a` and `-o`; see APPLICATION USAGE section of http://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html). - Quote all expansions to prevent string-splitting and globbing. - Avoid unspecified "exit

[edk2] [PATCH 1/4] BaseTools: Improve shell wrappers for Python build commands

From: Charles Duffy - Use `python2` executable if it exists, to avoid breakage on systems (such as Arch Linux) where `python` is Python 3. - Quote all references to `$0`, for safety when located in a directory containing spaces in its name. - Use the `exec` shell command

[edk2] [PATCH 3/4] BaseTools: Use python2 if available in Tests/GNUmakefile

From: Charles Duffy Signed-off-by: Charles Duffy Contributed-under: TianoCore Contribution Agreement 1.0 --- BaseTools/Tests/GNUmakefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Tests/GNUmakefile

Re: [edk2] [Patch 2/2] ShellPkg/mm: Fix mm to support multiple root bridge platform

Mike, Could you please check the updated patch which tries to use PciRootBridgeIo firstly, then CpuIo, then IO library for MMIO and IO access? Regards, Ray -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Wednesday, December 2,

[edk2] [PATCH] MdePkg: Restore SetupMode macro definition

Restore SetupMode macro definition to keep backward compatibility. No current module is referencing them now. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chao Zhang --- MdePkg/Include/Guid/ImageAuthentication.h | 3 +++ 1 file changed, 3

Re: [edk2] [PATCH] MdePkg: Restore SetupMode macro definition

On 2015/12/8 13:06, Zhang, Chao B wrote: Restore SetupMode macro definition to keep backward compatibility. No current module is referencing them now. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chao Zhang ---

Re: [edk2] [Patch V3] ShellPkg/mm: Fix mm to support multiple root bridge platform

The V3 version moved the HasRootBridgeIo variable definition to the beginning of function. And I sent it through GIT command in case the attachment in V2 mail is blocked by the lists.01.org. Regards, Ray -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On