Re: [edk2] [Patch] MdePkg: Add BasePciSegmentLibPciExpress library.

2015-12-11 Thread Ni, Ruiyu
OK I agree it will have more flexibility. Thanks for the comments. Thanks, Ray > 在 2015年12月12日，12:58，Kinney, Michael D 写道： > > Ray, > > I think this library instance should consume the PciLib class, not the > PciExpressLib class. That way, the specific PCI access method can be > selected fr

Re: [edk2] [Patch] MdePkg: Add BasePciSegmentLibPciExpress library.

2015-12-11 Thread Kinney, Michael D
Ray, I think this library instance should consume the PciLib class, not the PciExpressLib class. That way, the specific PCI access method can be selected from the PciLib instance that this library is linked against. The name should also be changed to BasePciSegmentLibPci Thanks, Mike >

Re: [edk2] [PATCH] ShellPkg/Shell - Fix ASSERT() when FvSimpleFileSystemDxe is used

2015-12-11 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: Kinney, Michael D > Sent: Friday, December 11, 2015 1:24 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: [PATCH] ShellPkg/Shell - Fix ASSERT() when FvSimpleFileSystemDxe is > used > Importance: High > > When the FvSi

[edk2] [PATCH] ShellPkg/Shell - Fix ASSERT() when FvSimpleFileSystemDxe is used

2015-12-11 Thread Michael Kinney
When the FvSimpleFileSystemDxe module is included in a platform, Simple File System Protocols are produced for firmware volumes(FV) that do not have the same style device paths as file systems with file names. The ShellPkg has an assumption that the device path contains device path nodes of type M

Re: [edk2] UEFI enable NETWORK STACK problem

2015-12-11 Thread Laszlo Ersek
On 12/11/15 15:40, Stephen Polkowski wrote: > Hello, > > I was hoping someone could help clarify what the "Enable Network > Stack" on a modern UEFI 2.3.1 system should do. When I enable the > network stack on some motherboards they will install the UNDI driver for > the on board NIC. Other m

[edk2] UEFI enable NETWORK STACK problem

2015-12-11 Thread Stephen Polkowski
Hello, I was hoping someone could help clarify what the "Enable Network Stack" on a modern UEFI 2.3.1 system should do. When I enable the network stack on some motherboards they will install the UNDI driver for the on board NIC. Other motherboards won't install the UNDI driver. What is co

[edk2] [Patch] MdePkg: backout Ipmi2.0 definitions header file.

2015-12-11 Thread Daocheng Bu
The file name is too long and with "Definitions" word that is duplicated meanings for the header file. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daocheng Bu CC: Liming Gao --- MdePkg/Include/IndustryStandard/Ipmi.h | 29 - .../IndustryStandard/IpmiNetFn