On 17 December 2015 at 10:04, Gao, Liming wrote:
> Ard:
> Do GCC_VFRPP_FLAGS and GCC_ASLPP_FLAGS require this change?
>
Probably, let me change that.
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Wednesday, December 16,
Siyuan,
Some minor comments to this patch:
1) Copyright year in Get_status.c is not updated to latest.
2) Parameter in PxeGetStatus() is updated though you did not update the
corresponding function description.
Reviewed-by: Ye Ting
Thanks,
Ting
-Original Message-
Reviewed-by: Liming Gao
-Original Message-
From: Dong, Eric
Sent: Thursday, December 17, 2015 3:55 PM
To: edk2-devel@lists.01.org; Gao, Liming
Subject: [Patch] DxeTpmMeasureBootLib: Change global variable name to avoid
name conflict.
Contributed-under: TianoCore
Reviewed-by: Ye Ting
-Original Message-
From: Zhang, Lubo
Sent: Tuesday, December 15, 2015 11:36 AM
To: edk2-devel@lists.01.org
Cc: Ye, Ting; Fu, Siyuan; Wu, Jiaxin
Subject: [patch] NetworkPkg:Fix the issue Http boot hang when network failed.
For both IPv4 and IPv6,
Update the os.path.join to mws.join for FILE/INF/CAPSULE/FV region type.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Yonghong Zhu
---
BaseTools/Source/Python/GenFds/Region.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff
Reviewed by jiewen@intel.com
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Thursday, December 17, 2015 2:51 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [PATCH v2 3/3] EdkCompatibilityPkg: Fix GCC error to avoid the
Reviewed-by: Liming Gao
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong
Zhu
Sent: Thursday, December 17, 2015 5:05 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch] BaseTools: Fix one bug in FD region for
Currently BootManager is an independent library,used by UiApp.It only load boot
option when enter UiApp.So when add boot option through boot maintenance
manager,
it will not display in boot manager. In order to fix this issue,now we update
the
boot manager form every time we enter it.
Cc:
Andrew:
Conf/.cache is shared between the different targets. If you configure the
targets with the different Conf directory and --no-cache, the multiple targets
may run parallel. Have you tried this way?
Thanks
Liming
-Original Message-
From: af...@apple.com [mailto:af...@apple.com]
On 17 December 2015 at 10:29, Gao, Liming wrote:
> Ard:
> Have you found other similar cases in EDKII project? Or, it this the only
> one?
>
I found this one as well:
.../PcAtChipsetPkg/Library/SerialIoLib/SerialPortLib.c:488:32: error:
shifting a negative signed value
Ard:
Have you found other similar cases in EDKII project? Or, it this the only one?
Thanks
Liming
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Wednesday, December 16, 2015 6:49 PM
To: edk2-devel@lists.01.org; Gao, Liming
Cc: dw...@infradead.org; Ard
Hi windy,
We use debug version for developer to do source level debug, there is no known
issue for release version. But we need to discuss more about whether we need to
change it to release version.
Best Regards,
Zhu Yonghong
-Original Message-
From: edk2-devel
Clang does not allow straight assignment of va_list types, so use the
correct VA_COPY() instead.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 4 ++--
1 file changed, 2
C99 does not define left-shifting negative values, so make all
[positive] preprocessor constants unsigned explicitly, so they
do not become negative values after bitwise negation.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
Since we are combining Clang with the GNU linker, make that explicit in
the target triplet. This affects certain builtin defines and other compiler
behavior that may be unspecified otherwise.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
This adds preliminary support for building for the IA32 and X64
architectures using the CLANG35 toolchain.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
BaseTools/Conf/tools_def.template | 53
This adds support for building for the IA32 and X64 architectures to the
CLANG35 toolchain.
NOTE: this is build tested only, using OvmfPkg/OvmfIa32.dsc and
OvmfPkg/OvmfX64.dsc. Especially X64 needs more testing, presumably, due to
the va_list and ms_abi issues that exist for GCC/X64 as well.
The
The runtime test whether the compiler supports arithmetic shift of
negative signed numbers currently relies on undefined behavior in C,
which means that all bets are off regarding whether the condition
that follows passes or fails, regardless of whether the compiler in
fact supports arithmetic
Hello everyone,
I have a problem regarding the output to the console using the EDK. When the
EFI Systems loads my application I can't see any output. I tryed to change the
output mode to texmode but it didn't work out. Can anyone help me? Following
the code:
#include
On 2015/12/17 18:00, Ard Biesheuvel wrote:
LcrParity and LcrStop may end up being referenced without being
initialized, so make sure they always have a value.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
On 2015/12/17 18:01, Ard Biesheuvel wrote:
C99 does not define left-shifting negative values, so make all
[positive] preprocessor constants unsigned explicitly, so they
do not become negative values after bitwise negation.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by:
Get AP loop mode to prepare for the monitor buffer required for ApInMwaitLoop
and ApInRunLoop.
Contributed-under: TianoCore Contribution Agreement 1.0
Cc: Feng Tian
Cc: Michael Kinney
Cc: Jordan Justen
v2:
(1) Per Michael Kinney's suggestion, update GetApLoopMode() not to check CPUID
on MONITOR/MWAIT support if PcdCpuApLoopMode is not set to ApMwaitLoop.
(2) Add PcdCpuApTargetCstate to specify the C-state for APs instead of the max
C-state.
v1:
Support 3 AP loop modes:
A: Place AP in
On 2015/12/17 18:00, Ard Biesheuvel wrote:
Clang does not allow straight assignment of va_list types, so use the
correct VA_COPY() instead.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
web.de> writes:
PS: What I forgot to mention, I tested it with a VM Ware Virtual Machine and
it worked (I could se the output)!
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Mike,
I sent the patch to fix x64 version issue. Please help to review it.
Thanks!
Jeff
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fan, Jeff
Sent: Thursday, December 17, 2015 8:19 AM
To: Kinney, Michael D; edk2-devel@lists.01.org
Cc:
This new PCD is used to specify the AP loop mode during POST phase.
The value 1 means we will place AP in the Hlt-Loop state by HLT instruction.
BSP need to send INIT-SIPI-SIPI to wake up APs.
The value 2 means we will place AP in the deepest C-state by MWAIT instruction.
BSP need to modify the
If ApLoopMode is ApInHltLoop, BSP will send INIT-SIPI-SIPI to wake up APs.
If ApLoopMode is ApInMwaitLoop or ApInRunLoop, BSP will write one semaphore to
wake up APs.
Contributed-under: TianoCore Contribution Agreement 1.0
Cc: Feng Tian
Cc: Michael Kinney
After AP function is executed, we will place AP in proper loop mode. Because AP
maybe waken up by SMI or other reasons. We need to read signature in monitor
buffer to check if APs is waken up by BSP. If it is not waken up by BSP, we will
continue to place them into proper loop mode.
Add GetApLoopMode() that will get PCD PcdCpuApLoopMode firstly. If it is
ApInMwaitLoop, we will check if MONITOR/MWAIT feature supported by CPUID. If
MONITOR/MWAIT feature is not supported, force AP loop mode to ApInHltLoop.
GetApLoopMode() also return the largest line size required.
This new PCD is used to specify the AP C-state value by MWAIT instruction.
More deeper C-state means more longer latency time when APs exiting from MWAIT
state. Platforms need to balance the performance and power saving to find the
proper C-state for APs.
Also, some processor may not ready for
Contributed-under: TianoCore Contribution Agreement 1.0
Cc: Feng Tian
Cc: Michael Kinney
Cc: Jordan Justen
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan
Tested-by:
On 17 December 2015 at 14:59, Zeng, Star wrote:
> On 2015/12/17 18:00, Ard Biesheuvel wrote:
>>
>> LcrParity and LcrStop may end up being referenced without being
>> initialized, so make sure they always have a value.
>>
>> Contributed-under: TianoCore Contribution Agreement
On 8 December 2015 at 09:54, Ard Biesheuvel wrote:
> The RVCT compiler chokes on a couple of issues in upstream OpenSSL that
> can be confirmed to be non-issues by inspection. So just ignore these
> warnings entirely.
>
> Also, move the dummy -J system include from
Looks I missed this one. It's OK for me.
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Friday, December 18, 2015 12:11 AM
> To: edk2-devel@lists.01.org; Long, Qin
> Cc:
On 17 December 2015 at 15:23, Zeng, Star wrote:
> On 2015/12/17 18:00, Ard Biesheuvel wrote:
>>
>> Clang does not allow straight assignment of va_list types, so use the
>> correct VA_COPY() instead.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>>
On 17 December 2015 at 15:10, Zeng, Star wrote:
> On 2015/12/17 18:01, Ard Biesheuvel wrote:
>>
>> C99 does not define left-shifting negative values, so make all
>> [positive] preprocessor constants unsigned explicitly, so they
>> do not become negative values after bitwise
On 17 December 2015 at 17:52, Long, Qin wrote:
> Looks I missed this one. It's OK for me.
>
> Reviewed-by: Qin Long
>
Thank you, Qin
Commited as SVN r19328
>> -Original Message-
>> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
>>
On 17 December 2015 at 18:05, Jordan Justen wrote:
> On 2015-12-17 00:14:04, Ard Biesheuvel wrote:
>> (adding Jordan)
>>
>> On 16 December 2015 at 14:45, Ard Biesheuvel
>> wrote:
>> > GCC_ASM_EXPORT() not only exports a symbol as a function,
I have gotten couple of responses regarding this support question but as far
as I understand, all supports are half-measured and led to no solution. I also
was told that the build environment I setup has something wrong but no one can
point to what is wrong. All I did was followed exactly the
Reviewed-by: Ye Ting
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang
Lubo
Sent: Friday, December 18, 2015 10:32 AM
To: edk2-devel@lists.01.org
Cc: Ye, Ting; Fu, Siyuan; Wu, Jiaxin
Subject: [edk2] [patch] NetworkPkg:Fix
When do UiApp remodeling task,miss clearing the screen before booting
the selected boot option,so cause some behaviors change.Now add the code
to fix this issue.
Cc: Liming Gao
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.0
Carsey, Jaben intel.com> writes:
>
> For a really simple experiment. If you run the HelloWorld app that is in
MdeModulePkg, does it's print out work?
>
> -Jaben
>
Thanks for your reply.
I will give you a little bit more information. I'm compiling using Visual
Studio 2013. I start my
Modify Ipmi2.0 definitions header files for data structure name suffix
for request/response data.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Daocheng Bu
CC: Jiewen Yao
---
MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
Mike,
Thanks your testing. I will add your comment when check-in the code.
Jeff
-Original Message-
From: Kinney, Michael D
Sent: Friday, December 18, 2015 10:20 AM
To: Fan, Jeff; edk2-devel@lists.01.org; Kinney, Michael D
Cc: Tian, Feng; Justen, Jordan L
Subject: RE: [Patch]
Ard:
Thanks for your contribution of CLANG X86 tool chain. We will verify X64
arch.
Thanks
Liming
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Thursday, December 17, 2015 6:01 PM
To: edk2-devel@lists.01.org; Gao, Liming
Cc: Ard Biesheuvel
Subject:
Thanks. It makes sense to add CompleteCode in response data structure, because
the IPMI library includes it in response data buffer.
Reviewed by: jiewen@intel.com
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Daocheng
Bu
Sent: Friday,
Reviewed-by: Liming Gao
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Thursday, December 17, 2015 6:01 PM
To: edk2-devel@lists.01.org; Gao, Liming
Cc: Ard Biesheuvel
Subject: [PATCH 1/8] MdePkg/BaseLib: do not rely on undefined
Reviewed-by: Liming Gao
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Thursday, December 17, 2015 6:01 PM
To: edk2-devel@lists.01.org; Gao, Liming
Cc: Ard Biesheuvel
Subject: [PATCH 6/8] BaseTools CLANG35: use -target in PP flags
Siyuan,
Some comments for this patch:
1) Please update all copyright year for the updated files.
2) Please add function description for
MnpAllocTxBuf/MnpFreeTxBuf/MnpAddFreeTxBuf/MnpRecycleTxBuf in corresponding
files.
3) I am curious the reason you don't put MnpRecycleTxBuf together with
Reviewed-by: Jeff Fan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Wednesday, December 16, 2015 6:17 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch 1/3] DuetPkg: Fix GCC error to avoid the
Reviewed-by: Jeff Fan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Wednesday, December 16, 2015 6:18 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch 2/3] DuetPkg: Fix GCC error to avoid the
Jeff,
With this change X64 OVMF boots. Thanks for the quick fix.
Please add a comment above declaration of structure MP_CPU_EXCHANGE_INFO that
the structure is required to be packed because fixed field offsets into this
structure are used in assembly code in this module.
With that comment
Jeff,
The updates to the series looks good.
Reviewed-by: Michael Kinney
Mike
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On
> Behalf Of Jeff Fan
> Sent: Thursday, December 17, 2015 6:17 AM
> To: edk2-devel@lists.01.org
Httpboot over Ipv4 or Ipv6 stack,for both Identity and chunked transfer
mode,when the last
data has been parsed by HttpLib, the HttpInstance->NextMsg pointer should point
a correct
location.Now after the first successful httpboot for ipv4 or ipv6,the
HttpInstance->NextMsg
point the character
Reviewed-by: Eric Dong
-Original Message-
From: Bi, Dandan
Sent: Thursday, December 17, 2015 5:52 PM
To: edk2-devel@lists.01.org
Cc: Gao, Liming; Dong, Eric
Subject: [patch] MdeModulePkg:Update Boot Manager form when enter it.
Currently BootManager is an
Reviewed-by: ruiyu...@intel.com
Thanks,
Ray
> 在 2015年12月16日,下午6:18,Liming Gao 写道:
>
> Move the global variable definitions into source code instead of head filer.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Liming Gao
Add BaseIpmiLibNull Library Class for BMC-Less platform.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Daocheng Bu
CC: Jiewen Yao
---
.../Library/BaseIpmiLibNull/BaseIpmiLibNull.c | 47 ++
call back this email.
Sorry
Thanks,
Amos
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Daocheng
Bu
Sent: Friday, December 18, 2015 12:40 PM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen
Subject: [edk2] [Patch]
Add DxeIpmiLibIpmiProtocol Library Class that will depend on
Ipmi stack driver produces Ipmi Protocol in Dxe Phase under SMS.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Daocheng Bu
CC: Jiewen Yao
---
call back this email.
Sorry
Thanks,
Amos
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Daocheng
Bu
Sent: Friday, December 18, 2015 12:40 PM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen
Subject: [edk2] [Patch]
Add IpmiLib header file for ipmi command submit.
In V2, change the buffer length for OEM extension.
Add more return status for robustness.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Daocheng Bu
CC: Jiewen Yao
---
Add IpmiLib header file for ipmi command submit.
In V3, change ';' position.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Daocheng Bu
CC: Jiewen Yao
---
MdeModulePkg/Include/Library/IpmiLib.h | 3 +--
1 file changed, 1
Add BaseIpmiLibNull Library Class for BMC-Less platform.
In V2, change for aligning with IpmiLib.h changes.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Daocheng Bu
CC: Jiewen Yao
---
Reviewed-by: Fu Siyuan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang
Lubo
Sent: Friday, December 18, 2015 10:32 AM
To: edk2-devel@lists.01.org
Cc: Ye, Ting ; Fu, Siyuan ; Wu,
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang
Lubo
Sent: Friday, December 18, 2015 10:32 AM
To: edk2-devel@lists.01.org
Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin
Subject: [edk2]
66 matches
Mail list logo