[edk2] [PATCH] StdLib: Clarify and improve comments.

2016-01-03 Thread Daryl McDaniel
StdLib: Clarify and improve comments. LibC/Locale/multibyte_Utf8.c LibC/Uefi/SysCalls.c Clarify and improve comments. Include/sys/termios.h Add parameter names to function prototypes as referenced in the comments. StdLibPrivateInternalFiles\Include\kfile.h Add comment for the fo_close

[edk2] [PATCH 6/8] NetworkPkg IpSecDxe: Fix a typo in function description

2016-01-03 Thread Hao Wu
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- NetworkPkg/IpSecDxe/IpSecImpl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NetworkPkg/IpSecDxe/IpSecImpl.c b/NetworkPkg/IpSecDxe/IpSecImpl.c index 6df83ec..854a9a5

[edk2] [PATCH 7/8] NetworkPkg IScsiDxe: Fix typos in function descriptions

2016-01-03 Thread Hao Wu
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- NetworkPkg/IScsiDxe/IScsiMisc.c | 2 +- NetworkPkg/IScsiDxe/IScsiMisc.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/NetworkPkg/IScsiDxe/IScsiMisc.c

Re: [edk2] [PATCH] MdeModulePkg: For RegularExpressionDxe use 'sprintf_s' to replace 'sprintf'.

2016-01-03 Thread El-Haj-Mahmoud, Samer
Reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: Qiu, Shumin [shumin@intel.com] Received: Sunday, 03 Jan 2016, 9:06PM To: El-Haj-Mahmoud, Samer [samer.el-haj-mahm...@hpe.com]; Shia, Cinnamon [cinnamon.s...@hpe.com] CC: edk2-devel@lists.01.org

[edk2] [PATCH] Python: Clean up and document how to escape the -# option.

2016-01-03 Thread Daryl McDaniel
AppPkg/.../Python: Clean up and document how to escape the -# option. Depending upon the version of Shell you are using, it may be necessary to escape the '#' character, when using the "-#" command-line option, so that the Shell doesn't interpret it as the start of a comment. The escape character

Re: [edk2] [Patch] NetworkPkg: Fix suspicious dereference of pointer before NULL check

2016-01-03 Thread Wu, Jiaxin
Leif, As you mentioned you prefer clarifications instead of any testes (AipHandleCount and AipHandleBuffer) checking, I don't have strong opinion for adding more tests checking for API or adding the clarifications on the guaranteed behavior of the code. I think both of them good to me. If you

[edk2] [PATCH] StdLib: Implement da_ConFlush() and flush I/O buffers when closing a console device.

2016-01-03 Thread Daryl McDaniel
StdLib: Implement da_ConFlush() and flush I/O buffers when closing a console device. Add header file Efi/SysEfi.h Implement function da_ConFlush() Modify da_ConClose() to flush its buffers and clean up better upon close. Construct the console instance using the new da_ConFlush() instead of the

[edk2] [PATCH] StdLib: Fix IIO_Write() to return the number of bytes consumed, not characters output.

2016-01-03 Thread Daryl McDaniel
StdLib: Fix IIO_Write() to return the number of bytes consumed, not characters output. Depending upon termios settings, writing to a terminal device may result in many more characters being output than were in the buffer provided to the IIO_Write() function. IIO_Write() is supposed to return

[edk2] FW: [PATCH] MdeModulePkg: For RegularExpressionDxe use 'sprintf_s' to replace 'sprintf'.

2016-01-03 Thread Qiu, Shumin
Hi Samer and Cinnamon, Do you have any comments? -Shumin -Original Message- From: Qiu, Shumin Sent: Wednesday, December 30, 2015 7:47 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin; Dong, Eric Subject: [PATCH] MdeModulePkg: For RegularExpressionDxe use 'sprintf_s' to replace 'sprintf'.

Re: [edk2] undefined Reference to 'strtof'

2016-01-03 Thread Daryl McDaniel
Michael, How would one reproduce the problem you are seeing? I don't see any problems when building or running any of the StdLib floating point test programs. This is just on Tile, Ia32 and X64, though. Sincerely, Daryl McDaniel > -Original Message- > From: edk2-devel

Re: [edk2] [PATCH] StdLib: Return and flush of proper number of bytes for IIO_Write()

2016-01-03 Thread Daryl McDaniel
Alexey, It turns out the problem is deeper than thought. Since IIO is for Terminal devices, depending upon the termios settings many more characters may be output than were present in the buffer provided as a parameter to IIO_Write(). This is due to TAB expansion, LF to CRLF conversion, and line

Re: [edk2] [Edk2] bug in nvme driver disk info protocol

2016-01-03 Thread Tian, Feng
Update edk2 mail list to edk2-devel@lists.01.org as the edk2-de...@lists.sourceforge.net was deprecated. From: Tian, Feng Sent: Monday, January 04, 2016 11:16 To: 'Anindya Rai' Cc: edk2-de...@lists.sourceforge.net; Simon

Re: [edk2] [PATCH 7/8] NetworkPkg IScsiDxe: Fix typos in function descriptions

2016-01-03 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu Sent: Monday, January 4, 2016 8:39 AM To: edk2-devel@lists.01.org; Fu, Siyuan Cc: Wu, Hao A Subject:

Re: [edk2] [PATCH 6/8] NetworkPkg IpSecDxe: Fix a typo in function description

2016-01-03 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu Sent: Monday, January 4, 2016 8:39 AM To: edk2-devel@lists.01.org; Fu, Siyuan Cc: Wu, Hao A Subject:

Re: [edk2] [PATCH] MdeModulePkg: For RegularExpressionDxe use 'sprintf_s' to replace 'sprintf'.

2016-01-03 Thread Shia, Cinnamon
Reviewed-by: Cinnamon Shia Thanks, Cinnamon Shia From: El-Haj-Mahmoud, Samer Sent: Monday, January 4, 2016 11:46 AM To: Shia, Cinnamon; shumin@intel.com Cc: edk2-devel@lists.01.org Subject: RE: [PATCH] MdeModulePkg: For RegularExpressionDxe use 'sprintf_s' to