[edk2] [Patch] StdLib: Fix compilation errors caused by previous commit of daConsole.c

2016-01-08 Thread Daryl McDaniel
Michael, Can you review this patch to verify that it fixes the problem you were seeing. Thanks, Daryl StdLib: Fix compilation errors caused by previous commit of daConsole.c Move functions da_ConFlush and da_ConClose to just before da_ConPoll so that they are defined after any calls to them. R

[edk2] [PATCH v2 1/2] BaseTools AARCH64: add separate GCC build rule for XIP objects

2016-01-08 Thread Ard Biesheuvel
This introduces a special .c to .obj build rule for GCC/AARCH64 that takes into account additional compiler flags that have been specified via *_*_*_CC_XIPFLAGS. These will be passed after (and in addition to) the ordinary CC_FLAGS. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-of

[edk2] [PATCH v2 0/2] BaseTools AARCH64: build XIP modules with strict alignment

2016-01-08 Thread Ard Biesheuvel
On AARCH64, before we turn on the MMU, unaligned accesses are not allowed. Since the idiom recognition employed by GCC may turn allowable sequences into sequences that result in such unaligned accesses (i.e., a sequence of byte wide loads in reverse order may be turned into a wider load and a rev i

[edk2] [PATCH v2 2/2] BaseTools AARCH64: build XIP modules with strict alignment

2016-01-08 Thread Ard Biesheuvel
GCC for AARCH64 recognizes byte swapping load and store sequences and may replace them with wider loads or stores combined with rev instructions. In some cases (i.e., with GCC version 5 and later) this may result in unaligned accesses, which are not allowed before we turn the MMU on. So build any

Re: [edk2] ArmVirt: About RTC PL031 in ACPI

2016-01-08 Thread Laszlo Ersek
On 01/08/16 10:59, Shannon Zhao wrote: > > > On 2016/1/8 17:39, Laszlo Ersek wrote: >> On 01/08/16 04:10, Shannon Zhao wrote: On 2016/1/7 22:25, Laszlo Ersek wrote: >> On 01/07/16 10:31, Shannon Zhao wrote: >> >> >> On 2016/1/7 16:16, Ard Biesheuvel wrot

Re: [edk2] ArmVirt: About RTC PL031 in ACPI

2016-01-08 Thread Shannon Zhao
On 2016/1/8 17:39, Laszlo Ersek wrote: > On 01/08/16 04:10, Shannon Zhao wrote: >> > >> > >> > On 2016/1/7 22:25, Laszlo Ersek wrote: >>> >> On 01/07/16 10:31, Shannon Zhao wrote: > > > On 2016/1/7 16:16, Ard Biesheuvel wrote: >>> >> On 7 January 2016 at 03:47

Re: [edk2] ArmVirt: About RTC PL031 in ACPI

2016-01-08 Thread Laszlo Ersek
On 01/08/16 04:10, Shannon Zhao wrote: > > > On 2016/1/7 22:25, Laszlo Ersek wrote: >> On 01/07/16 10:31, Shannon Zhao wrote: On 2016/1/7 16:16, Ard Biesheuvel wrote: >> On 7 January 2016 at 03:47, Shannon Zhao >> wrote: >> Hi, >> >> I notice that

Re: [edk2] [Patch V2 1/3] MdeModulePkg: Add new library class PciHostBridgeLib

2016-01-08 Thread Laszlo Ersek
On 01/08/16 02:16, Ni, Ruiyu wrote: > On 2016/1/8 3:19, Laszlo Ersek wrote: >> On 01/07/16 06:10, Ruiyu Ni wrote: >>> PciHostBridgeDxe driver needs PciHostBridgeLib implemented by platform >>> to provide the root bridge related information and may call into >>> PciHostBridgeLib when resource confli

Re: [edk2] [patch] SecurityPkg: Add Tpm2Startup return code check.

2016-01-08 Thread Zhang, Chao B
It is good to me. Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Yao, Jiewen Sent: Friday, January 08, 2016 4:23 PM To: edk2-de...@ml01.01.org Cc: Yao, Jiewen; Zhang, Chao B Subject: [patch] SecurityPkg: Add Tpm2Startup return code check. Tpm2Sta

[edk2] [patch] SecurityPkg: Clear AuthSession content after use.

2016-01-08 Thread jiewen yao
Some commands in Tpm2CommandLib accept AuthSession as input parameter and copy to local command buffer. After use, this AuthSession content should be zeroed, because there might be some secrete there. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao, Jiewen" Cc: "Zhang,

[edk2] [patch] SecurityPkg: Add Tpm2Startup return code check.

2016-01-08 Thread jiewen yao
Tpm2Startup does not check TPM device return code. It might cause problem, that error is not detected in Tcg2Peim, for example, S3 resume case. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao, Jiewen" Cc: "Zhang, Chao B" --- SecurityPkg/Library/Tpm2CommandLib/Tpm2Sta

Re: [edk2] [PATCH] SecurityPkg: TcgDxe, Tcg2Dxe, TrEEDxe: New PCD for TCG event log and TCG2 final event log area

2016-01-08 Thread Yao, Jiewen
Reviewed by: jiewen@intel.com -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang, Chao B Sent: Friday, January 08, 2016 3:34 PM To: edk2-de...@ml01.01.org Cc: Yao, Jiewen; Zhang, Chao B; Long, Qin Subject: [edk2] [PATCH] SecurityPkg: TcgDx

Re: [edk2] [PATCH] SecurityPkg: TcgDxe, Tcg2Dxe, TrEEDxe: New PCD for TCG event log and TCG2 final event log area

2016-01-08 Thread Long, Qin
Looks good to me. Reviewed-by: Qin Long Best Regards & Thanks, LONG, Qin > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Zhang, Chao B > Sent: Friday, January 08, 2016 3:34 PM > To: edk2-de...@ml01.01.org > Cc: Yao, Jiewen; Zhang, Chao B;