Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

2016-01-14 Thread Zeng, Star
On 2016/1/15 14:36, Ryan Harkin wrote: On 15 Jan 2016 01:41, "Zeng, Star" wrote: Hi Ryan, On 2016/1/15 3:10, Ryan Harkin wrote: Hi Star, This patch breaks the serial terminal for ARM FVP and Juno platforms. I assume it also breaks TC2 and other such "vexpress" platforms effected by this c

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

2016-01-14 Thread Ryan Harkin
On 15 Jan 2016 01:41, "Zeng, Star" wrote: > > Hi Ryan, > > > On 2016/1/15 3:10, Ryan Harkin wrote: >> >> Hi Star, >> >> This patch breaks the serial terminal for ARM FVP and Juno platforms. >> I assume it also breaks TC2 and other such "vexpress" platforms >> effected by this change. >> >> Whilst

[edk2] [patch 1/2] MdePkg: Update MorLock comment to latest doc.

2016-01-14 Thread jiewen yao
Microsoft updated secure MOR lock document with version 2. So we update comment here. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao, Jiewen" Cc: "Zhang, Chao B" --- .../IndustryStandard/MemoryOverwriteRequestControlLock.h | 16 1 file changed, 8 in

[edk2] [patch 0/2] Update Secure MOR implementation to revision 2.

2016-01-14 Thread jiewen yao
Microsoft secure MOR implementation is updated to revision 2. These series patches follow Secure MOR implementation update. jiewen yao (2): MdePkg: Update MorLock comment to latest doc. MdeModulePkg: Include MorLock check into variable driver. .MdeModulePkg/Universal/Variable/RuntimeDxe/TcgM

[edk2] [patch 2/2] MdeModulePkg: Include MorLock check into variable driver.

2016-01-14 Thread jiewen yao
Microsoft published secure MOR implementation at https://msdn.microsoft.com/en-us/library/windows/hardware/mt270973(v=vs.85).aspx with revision 2 update. See URL for tech detail. Previous revision 1 is handled in SecurityPkg\Tcg\ MemoryOverwriteRequestControlLock. But the VarCheck API can not satis

Re: [edk2] [patch] SecurityPkg: Update final event log calculation.

2016-01-14 Thread Zhang, Chao B
Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Yao, Jiewen Sent: Friday, January 15, 2016 12:06 PM To: edk2-de...@ml01.01.org Cc: Yao, Jiewen; Zhang, Chao B Subject: [patch] SecurityPkg: Update final event log calculation. This patch updated fina

Re: [edk2] [Patch V4 4/4] MdeModulePkg: Add generic PciHostBridgeDxe driver.

2016-01-14 Thread Tian, Feng
Reviewed-by: Feng Tian -Original Message- From: Ni, Ruiyu Sent: Wednesday, January 13, 2016 16:00 To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Fan, Jeff; Tian, Feng Subject: [Patch V4 4/4] MdeModulePkg: Add generic PciHostBridgeDxe driver. This driver links to PciHostBridgeLib provided by

Re: [edk2] [Patch V4 2/4] MdeModulePkg: Add PciHostBridgeLibNull

2016-01-14 Thread Tian, Feng
Reviewed-by: Feng Tian -Original Message- From: Ni, Ruiyu Sent: Wednesday, January 13, 2016 16:00 To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Fan, Jeff; Tian, Feng Subject: [Patch V4 2/4] MdeModulePkg: Add PciHostBridgeLibNull Contributed-under: TianoCore Contribution Agreement 1.0 Signe

Re: [edk2] [Patch V4 1/4] MdeModulePkg: Add new library class PciHostBridgeLib

2016-01-14 Thread Tian, Feng
Reviewed-by: Feng Tian A very trivial comment: why the file macro naming is _*__ rather than __*__ or _*_? -Original Message- From: Ni, Ruiyu Sent: Wednesday, January 13, 2016 16:00 To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Tian, Feng; Fan, Jeff; Kinney, Michael D Subject: [Patch V4

Re: [edk2] [PATCH] SecurityPkg: SecureBootConfigDxe: Fix string typo

2016-01-14 Thread Long, Qin
Reviewed-by: Qin Long Best Regards & Thanks, LONG, Qin > -Original Message- > From: Zhang, Chao B > Sent: Friday, January 15, 2016 9:39 AM > To: edk2-de...@ml01.01.org > Cc: Long, Qin; Fu, Siyuan; Zhang, Chao B > Subject: [PATCH] SecurityPkg: SecureBootConfigDxe: Fix string typo > > Fi

Re: [edk2] [patch] SecurityPkg: Correct NumberOfPCRBanks calculation.

2016-01-14 Thread Zhang, Chao B
Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Yao, Jiewen Sent: Friday, January 15, 2016 11:55 AM To: edk2-de...@ml01.01.org Cc: Yao, Jiewen; Zhang, Chao B Subject: [patch] SecurityPkg: Correct NumberOfPCRBanks calculation. Previously, NumberOfPC

Re: [edk2] [patch] SecurityPkg: Replace TREE macro with TCG2.

2016-01-14 Thread Zhang, Chao B
Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Yao, Jiewen Sent: Friday, January 15, 2016 11:49 AM To: edk2-de...@ml01.01.org Cc: Yao, Jiewen; Zhang, Chao B Subject: [patch] SecurityPkg: Replace TREE macro with TCG2. Since Tcg2Dxe driver follows T

[edk2] [patch] SecurityPkg: Update final event log calculation.

2016-01-14 Thread jiewen yao
This patch updated final event log calculation based on TCG EFI PROTOCOL rev9, 7.1.2 "All options implementation". The previous logic is to save event to final event log once GetEventLog() is called. 7.1.1 shows that we should save event log to both normal even log area and final event log area aft

[edk2] [patch] SecurityPkg: Correct NumberOfPCRBanks calculation.

2016-01-14 Thread jiewen yao
Previously, NumberOfPCRBanks is calculated based on TPM capability. However, there might be a case that TPM hardware support 1 algorithm, but BIOS does not support and BIOS mask it via PCD. This causes the conflict between HashAlgorithmBitmap and NumberOfPCRBanks. So we move the NumberOfPCRBanks ca

[edk2] [patch] SecurityPkg: Replace TREE macro with TCG2.

2016-01-14 Thread jiewen yao
Since Tcg2Dxe driver follows TCG spec, we should use TCG2 MACRO, instead of TREE macro. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao, Jiewen" Cc: "Zhang, Chao B" --- SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [edk2] [Patch V4 3/4] MdePkg: Add PciSegmentLib instance based on PciLib

2016-01-14 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Ni, Ruiyu Sent: Wednesday, January 13, 2016 4:00 PM To: edk2-devel@lists.01.org Cc: Ni, Ruiyu; Kinney, Michael D; Gao, Liming Subject: [Patch V4 3/4] MdePkg: Add PciSegmentLib instance based on PciLib This PciSegmentLib instance only supp

[edk2] [PATCH 2/2] ArmPkg: Bds: tranverse handles for fv file

2016-01-14 Thread Haojian Zhuang
BdsConnectAndUpdateDevicePath() won't set right handle if device path is file path or memory mapped. Now try to tranverse all handles for FvFile in Fv. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Haojian Zhuang --- ArmPkg/Library/BdsLib/BdsFilePath.c | 135

[edk2] [PATCH 1/2] ArmPkg: Bds: check path first for supporting fs

2016-01-14 Thread Haojian Zhuang
BdsFileSystemSupport() checks Handle first before validating device path of file. There's the potential issue at here. BdsConnectAndUpdateDevicePath() will skip to locate handle if it's file or memory mapped. Then BdsFileSystemSupport() tries to use the invalid Handle when it's not file path in fi

[edk2] [PATCH 0/2] Fix FvFile in ARM BDS

2016-01-14 Thread Haojian Zhuang
Fix to load Fv file from UEFI image. Haojian Zhuang (2): ArmPkg: Bds: check path first for supporting fs ArmPkg: Bds: tranverse handles for fv file ArmPkg/Library/BdsLib/BdsFilePath.c | 143 1 file changed, 80 insertions(+), 63 deletions(-) -- 1.9.1 __

Re: [edk2] [PATCH] SecurityPkg: SecureBootConfigDxe: Fix string typo

2016-01-14 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan -Original Message- From: Zhang, Chao B Sent: Friday, January 15, 2016 9:39 AM To: edk2-de...@ml01.01.org Cc: Long, Qin ; Fu, Siyuan ; Zhang, Chao B Subject: [PATCH] SecurityPkg: SecureBootConfigDxe: Fix string typo Fix transition string typo. Contributed-under

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

2016-01-14 Thread Zeng, Star
Hi Ryan, On 2016/1/15 3:10, Ryan Harkin wrote: Hi Star, This patch breaks the serial terminal for ARM FVP and Juno platforms. I assume it also breaks TC2 and other such "vexpress" platforms effected by this change. Whilst simple text input seems to work ok, cursor support does not. And we need

[edk2] [PATCH] SecurityPkg: SecureBootConfigDxe: Fix string typo

2016-01-14 Thread Zhang, Chao B
Fix transition string typo. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chao Zhang --- .../SecureBootConfigDxe/SecureBootConfigImpl.c | 6 +++--- .../SecureBootConfigDxe/SecureBootConfigStrings.uni | 4 ++-- 2 files changed, 5 inser

Re: [edk2] [PATCH V2] SecurityPkg: SecureBootConfigDxe: Move Secure Boot string update location

2016-01-14 Thread Fu, Siyuan
The patch is good. Please also update the copy right year to 2016. Reviewed-by: Fu Siyuan -Original Message- From: Zhang, Chao B Sent: Thursday, January 14, 2016 4:43 PM To: edk2-de...@ml01.01.org Cc: Dong, Eric ; Fu, Siyuan ; Zhang, Chao B Subject: [PATCH V2] SecurityPkg: SecureBootC

Re: [edk2] [PATCH V2] SecurityPkg: SecureBootConfigDxe: Move Secure Boot string update location

2016-01-14 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: Zhang, Chao B Sent: Thursday, January 14, 2016 4:43 PM To: edk2-de...@ml01.01.org Cc: Dong, Eric; Fu, Siyuan; Zhang, Chao B Subject: [PATCH V2] SecurityPkg: SecureBootConfigDxe: Move Secure Boot string update location ExtractConfig is cal

Re: [edk2] [PATCH V4 10/13] ArmPlatformPkg: Use SerialDxe in MdeModulePkg instead of EmbeddedPkg

2016-01-14 Thread Ryan Harkin
Hi Star, This patch breaks the serial terminal for ARM FVP and Juno platforms. I assume it also breaks TC2 and other such "vexpress" platforms effected by this change. Whilst simple text input seems to work ok, cursor support does not. And we need cursor support for Intel BDS. Below is my hack a

Re: [edk2] BaseTools: BuildReport.py crashes for FV_IMAGE provided by file

2016-01-14 Thread Zhu, Yonghong
Hi Eugene, I agree this is a bug for build report. We need to work out a solution for this case, thanks for report it. Best Regards, Zhu Yonghong From: Cohen, Eugene [mailto:eug...@hp.com] Sent: Wednesday, January 13, 2016 10:40 PM To: edk2-devel@lists.01.org; Zhu, Yonghong; Gao, Liming Subjec

[edk2] [PATCH V2] SecurityPkg: SecureBootConfigDxe: Move Secure Boot string update location

2016-01-14 Thread Zhang, Chao B
ExtractConfig is called many times, so it's not efficient to update Secure Boot STR_SECURE_BOOT_STATE_CONTENT, STR_CUR_SECURE_BOOT_MODE_CONTENT string in ExtractConfig. As these 2 strings are displayed on one form, so always update them when opening the form. Contributed-under: TianoCore Contri