[edk2] [patch 2/6] MdePkg: Add TPM TIS definition.

TPM TIS (TPM Interface Specification) is TCG standard. Add definition here. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao, Jiewen" CC: "Zhang, Chao B" --- MdePkg/Include/IndustryStandard/TpmTis.h | 183 +++ 1 file changed, 183 insertions

[edk2] [patch 5/6] SecurityPkg: Add TPM PTP detection in TPM12 device lib.

The TPM RequestUseTpm API can only set register to use the hardware, but it can not be used to distinguish TPM12 or TPM2 device. TPM PTP defines same address with TIS, so we need detect the TPM device is PTP or TIS in RequestUseTpm. Also, Tcg2Config driver call RequestUseTpm to detect TPM hardware

[edk2] [patch 4/6] SecurityPkg: Add TPM PTP support in TCG2 SMM.

TPM2 hardware may support PTP FIFO/TIS interface or PTP CRB interface. The original ACPI table only handles PTP FIFO/TIS interface. This patch adds PTP CRB interface support. The current logic is that SMM driver will runtime detect TPM device interface (CRB or FIFO/TIS) and publish TPM2 table based

[edk2] [patch 6/6] SecurityPkg: Add TPM PTP support in TCG2 Config.

This patch add PTP CRB support in BIOS Setup. It can: 1) Display the PTP capability (TIS/FIFO/CRB) 2) Display the PTP current interface (TIS/FIFO/CRB) 3) Let user select CRB/FIFO, if supported. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao, Jiewen" CC: "Zhang, Chao B

[edk2] [patch 0/6] Add TPM PTP CRB support.

This series patches enable TPM PTP CRB support in EDKII. TPM PTP (Platform TPM Profile) is TCG standard. It covers both FIFO/TIS and CRB (Command-Response-Buffer). jiewen yao (6): MdePkg: Add TPM PTP definition. MdePkg: Add TPM TIS definition. SecurityPkg: Add TPM PTP support in TPM2 device

[edk2] [patch 1/6] MdePkg: Add TPM PTP definition.

TPM PTP (Platform TPM Profile) is TCG standard. Add definition here. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao, Jiewen" CC: "Zhang, Chao B" --- MdePkg/Include/IndustryStandard/TpmPtp.h | 522 +++ 1 file changed, 522 insertions(+) cr

Re: [edk2] Help: NetworkStack requirement to generate DUID-LL(T) per own MAC address

Thanks Michael, Siyuan and Samer. We have used the Pcd to decide the type for Dhcp server and the setting is DUID-LLT to meet the requirement from customer datacenter, unfortunately, their environment only supports DUID-LL(T), the DUID-UUID is not a accepted type in their usage and they even ca

[edk2] [patch 3/6] SecurityPkg: Add TPM PTP support in TPM2 device lib.

TPM2 hardware may support PTP FIFO/TIS interface or PTP CRB interface. The original lib only handles PTP FIFO/TIS interface. This patch adds PTP CRB interface support. The current logic is that lib will runtime detect TPM device interface (CRB or FIFO/TIS) and call proper function to access hardwar

Re: [edk2] [PATCH v2] NetworkPkg:Fix Network memory leak when calling GetModeData interface

Hi, Lubo 1. Below lines in Ip6Dxe/ComponentName.c changes original If condition is incorrect. The first else means Status is an EFI error, so we shouldn't check the IsStarted flag. - if (!EFI_ERROR (Status) && Ip6ModeData.IsStarted) { -Status = NetLibIp6ToStr (&Ip6ModeData.ConfigData.Statio

[edk2] [PATCH v2] NetworkPkg:Fix Network memory leak when calling GetModeData interface

v2: * Check for NULL pointer before Free them. Multiple network protocols have a GetModeData() interface, which may allocate memory resource in the return mode data structure. It's callers responsibility to free these buffers. Cc: Fu Siyuan Cc: Ye Ting Cc: Wu Jiaxin Contributed-under: TianoCo

Re: [edk2] [Patch 2/2] NetworkPkg: Replace the internal function with exposed one

For the series of patches Reviewed-by: Hegde Nagaraj P -Original Message- From: Jiaxin Wu [mailto:jiaxin...@intel.com] Sent: Thursday, January 21, 2016 11:24 PM To: edk2-devel@lists.01.org Cc: Hegde, Nagaraj P; Ye Ting; Fu Siyuan Subject: [Patch 2/2] NetworkPkg: Replace the internal func

Re: [edk2] Help: NetworkStack requirement to generate DUID-LL(T) per own MAC address

A while ago, a change was added to EDK2 to introduce a Pcd to select either DUID-LLT or DUID-UUID. Did you look at modifying that PCD? Sent from my Android phone using Symantec TouchDown (www.symantec.com) -Original Message- From: Fu, Siyuan [siyuan...@intel.com] Received: Thursday, 21

Re: [edk2] Help: NetworkStack requirement to generate DUID-LL(T) per own MAC address

Thanks Michael, maybe use UUID is a good way to solve this issue. But I still curious why the server has such requirement which is apparent violate the RFC requirement. Could you provide more details? Best Regards Siyuan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lis

Re: [edk2] [patch] NetworkPkg:Fix Network memory leak when calling GetModeData interface

Thank you for your comments, I will make a new patch to fix the issue. -Original Message- From: Fu, Siyuan Sent: Friday, January 22, 2016 9:45 AM To: Zhang, Lubo; edk2-devel@lists.01.org Cc: Ye, Ting; Wu, Jiaxin Subject: RE: [patch] NetworkPkg:Fix Network memory leak when calling GetMod

Re: [edk2] [patch] NetworkPkg:Fix Network memory leak when calling GetModeData interface

Hi, Lubo Some comments as below: 1. Dhcp6Dxe,DnsDxe\ComponentName.c HttpBootDxe\HttpBootDhcp6.c UefiPxeBcDxe\PxeBcDhcp6.c Check for NULL pointer before free it. 2. DnsDxe\DnsImpl.c Ip6Dxe\ComponentName.c Mtftp6Dxe\Mtftp6Support.c There is memory leak if GetModeData return SUCCESS

Re: [edk2] [patch] MdeModulePkg:Fix Network memory leak when calling GetModeData interface

Hi, Lubo Pls ignore my previous mail. I just checked UEFI spec, it didn't mentioned the GroupTable, RouteTable and IcmpTypeList should be freed by caller. So I think we shouldn't make this change. Siyuan -Original Message- From: Fu, Siyuan Sent: Friday, January 22, 2016 9:26 AM To: Zh

Re: [edk2] [patch] MdeModulePkg:Fix Network memory leak when calling GetModeData interface

I will update the copyright year when I commit it, thanks. -Original Message- From: Fu, Siyuan Sent: Friday, January 22, 2016 9:26 AM To: Zhang, Lubo; edk2-devel@lists.01.org Cc: Ye, Ting; Wu, Jiaxin Subject: RE: [patch] MdeModulePkg:Fix Network memory leak when calling GetModeData inter

Re: [edk2] [patch] MdeModulePkg:Fix Network memory leak when calling GetModeData interface

Patch is good to me. Please also update the copyright year when commit it. Reviewed-by: Siyuan Fu -Original Message- From: Zhang, Lubo Sent: Thursday, January 21, 2016 10:11 AM To: edk2-devel@lists.01.org Cc: Fu, Siyuan ; Ye, Ting ; Wu, Jiaxin Subject: [patch] MdeModulePkg:Fix Netwo

Re: [edk2] S3SaveStateDxe.inf doesn't explicitly include SmbusLib, is it a bug?

Star， Thanks for explanation At 2016-01-22 08:49:08, "Zeng, Star" wrote: >Oh, yes, you are right. BootScriptWriteSmbusExecute will use definitions from >Smbus.h and SmbusLib.h, So we could not remove them from >InternalS3SaveState.h. But no SmbusLib interface will be consumed by >S3S

Re: [edk2] S3SaveStateDxe.inf doesn't explicitly include SmbusLib, is it a bug?

Oh, yes, you are right. BootScriptWriteSmbusExecute will use definitions from Smbus.h and SmbusLib.h, So we could not remove them from InternalS3SaveState.h. But no SmbusLib interface will be consumed by S3SaveStateDxe directly, so SmbusLib is not listed in S3SaveStateDxe.inf, that is expected.

Re: [edk2] [PATCH v2 00/14] ShellPkg: BCFG dump improvements

On 01/21/16 21:35, Ryan Harkin wrote: > On 21 January 2016 at 18:51, Laszlo Ersek wrote: >> On 01/21/16 19:25, Carsey, Jaben wrote: >>> For series. Reviewed-by: Jaben Carsey >> >> Thanks much; series committed as SVN r19706..r19719, inclusive. >> > Sorry, I wanted to give you a Reviewed-by and Te

Re: [edk2] [PATCH v2 00/14] ShellPkg: BCFG dump improvements

On 21 January 2016 at 18:51, Laszlo Ersek wrote: > On 01/21/16 19:25, Carsey, Jaben wrote: >> For series. Reviewed-by: Jaben Carsey > > Thanks much; series committed as SVN r19706..r19719, inclusive. > Sorry, I wanted to give you a Reviewed-by and Tested-by by got distracted by the SerialDxe stuf

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

On 01/21/16 20:47, Ryan Harkin wrote: > On 21 January 2016 at 18:14, Laszlo Ersek wrote: >> On 01/21/16 18:57, Ryan Harkin wrote: >>> On 21 January 2016 at 17:19, Laszlo Ersek wrote: >> Ryan, can you please test the following configuration: - your PCD update in place, but this three-par

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

On 21 January 2016 at 18:14, Laszlo Ersek wrote: > On 01/21/16 18:57, Ryan Harkin wrote: >> On 21 January 2016 at 17:19, Laszlo Ersek wrote: > >>> Ryan, can you please test the following configuration: >>> - your PCD update in place, but this three-part series of mine >>> *reverted* >>> >>> Thi

Re: [edk2] [PATCH v2 00/14] ShellPkg: BCFG dump improvements

On 01/21/16 19:25, Carsey, Jaben wrote: > For series. Reviewed-by: Jaben Carsey Thanks much; series committed as SVN r19706..r19719, inclusive. I'm unsure whom we should ping for refreshing the binaries under ShellBinPkg/ -- although I guess this is not very urgent. Cheers! Laszlo > >> -O

Re: [edk2] [PATCH v2 00/14] ShellPkg: BCFG dump improvements

For series. Reviewed-by: Jaben Carsey > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, January 21, 2016 9:07 AM > To: edk2-devel-01 > Cc: Carsey, Jaben ; Ryan Harkin > > Subject: [PATCH v2 00/14] ShellPkg: BCFG dump improvements > Importance: High >

Re: [edk2] [PATCH v2 01/14] ShellPkg: BcfgDisplayDump(): update whitespace & layout

Reviewed-by: Jaben Carsey > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, January 21, 2016 9:07 AM > To: edk2-devel-01 > Cc: Carsey, Jaben ; Ryan Harkin > > Subject: [PATCH v2 01/14] ShellPkg: BcfgDisplayDump(): update whitespace & > layout > Impor

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

On 01/21/16 18:57, Ryan Harkin wrote: > On 21 January 2016 at 17:19, Laszlo Ersek wrote: >> Ryan, can you please test the following configuration: >> - your PCD update in place, but this three-part series of mine >> *reverted* >> >> This should break the cursor movement keys again, and also bre

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

On 21 January 2016 at 17:19, Laszlo Ersek wrote: > On 01/21/16 18:02, Ryan Harkin wrote: >> On 21 January 2016 at 16:05, Laszlo Ersek wrote: >>> On 01/21/16 13:57, Ryan Harkin wrote: On 21 January 2016 at 11:46, Laszlo Ersek wrote: > adding Roy > > On 01/21/16 10:51, Ryan Harkin

[edk2] [Patch 1/2] MdeModulePkg: Define one function to create DNS QName

This patch is used to define a general function to create DNS QName. QName is a domain name represented as a sequence of labels, where each label consists of a length octet followed by that number of octets. The domain name terminates with the zero length octet for the null label of the root. Cc:

[edk2] [Patch 2/2] NetworkPkg: Replace the internal function with exposed one

This patch is used to replace the internal function with the exposed one defined in NetLib.h. Cc: Hegde Nagaraj P Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiaxin Wu --- NetworkPkg/DnsDxe/DnsImpl.c | 63 ---

[edk2] [Patch 0/2] Expose one function defined in DnsDxe to NetLib

The series of patches are used to expose one function defined in DnsDxe to NetLib. Cc: Hegde Nagaraj P Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiaxin Wu Jiaxin Wu (2): MdeModulePkg: Define a general function to create DNS QName Net

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

On 21 January 2016 at 17:44, Leif Lindholm wrote: > On Thu, Jan 21, 2016 at 05:36:41PM +, Ryan Harkin wrote: >> On 21 January 2016 at 17:32, Leif Lindholm wrote: >> > On Thu, Jan 21, 2016 at 06:19:22PM +0100, Laszlo Ersek wrote: >> >> Anyway, another question (for the ArmPlatformPkg maintaine

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

On Thu, Jan 21, 2016 at 05:36:41PM +, Ryan Harkin wrote: > On 21 January 2016 at 17:32, Leif Lindholm wrote: > > On Thu, Jan 21, 2016 at 06:19:22PM +0100, Laszlo Ersek wrote: > >> Anyway, another question (for the ArmPlatformPkg maintainers as well): > >> do you guys think that the PCD update

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

On 21 January 2016 at 17:32, Leif Lindholm wrote: > On Thu, Jan 21, 2016 at 06:19:22PM +0100, Laszlo Ersek wrote: >> Anyway, another question (for the ArmPlatformPkg maintainers as well): >> do you guys think that the PCD update in question should be commited to >> the repo, for the FVP (and maybe

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

On Thu, Jan 21, 2016 at 06:19:22PM +0100, Laszlo Ersek wrote: > Anyway, another question (for the ArmPlatformPkg maintainers as well): > do you guys think that the PCD update in question should be commited to > the repo, for the FVP (and maybe Foundation) DSC files? After all those > are mostly use

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

On 01/21/16 18:02, Ryan Harkin wrote: > On 21 January 2016 at 16:05, Laszlo Ersek wrote: >> On 01/21/16 13:57, Ryan Harkin wrote: >>> On 21 January 2016 at 11:46, Laszlo Ersek wrote: adding Roy On 01/21/16 10:51, Ryan Harkin wrote: > Hi Ray, > > On 21 January 2016 at 09

[edk2] [PATCH v2 14/14] ShellPkg: UefiShellBcfgCommandLib: bump VERSION_STRING

The changes due to the previous patches should be reflected in a higher minor version number. Cc: Jaben Carsey Cc: Ryan Harkin Suggested-by: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- Notes: v2: - new in v2 [Jaben] ShellPkg/L

[edk2] [PATCH v2 09/14] ShellPkg: BcfgDisplayDump(): calculate OptionalDataOffset explicitly

Eliminate some more repeated pointer arithmetic. This patch too is only refactoring. Cc: Jaben Carsey Cc: Ryan Harkin Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- Notes: v2: - clarify in the subject that the patch affects only the "bcfg dump"

[edk2] [PATCH v2 13/14] ShellPkg: BcfgDisplayDump(): print optional data with DumpHex()

The DumpHex() function produces very friendly output (known from DMPSTORE, for example); let's use it with "BCFG -v" as well. Cc: Jaben Carsey Cc: Ryan Harkin Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- Notes: v2: - clarify in the subject tha

[edk2] [PATCH v2 05/14] ShellPkg: BcfgDisplayDump(): enforce minimum size for Boot#### and co.

"3.1.1 Boot Manager Programming" in the UEFI 2.5 spec mandates that Boot and similar options contain EFI_LOAD_OPTION structures. The EFI_LOAD_OPTION structure encodes the fixed initial part of the payload, and we can (and should) use it to enforce a minimum size for variable contents. This pat

[edk2] [PATCH v2 10/14] ShellPkg: BcfgDisplayDump(): fix reporting of OptionalData

In this cleaned up form of BcfgDisplayDump(), it is easier to see that the OptionalDataOffset <= BufferSize expression, used to report whether optional data are *absent*, is incorrect. For any well-formed EFI_LOAD_OPTION, this inequality always holds. Optional data are present exactly if Op

[edk2] [PATCH v2 12/14] ShellPkg: elevate DumpHex() from Debug1-internal to generic-internal

The UEFI Shell specification classifies shell commands into various shell levels / profiles. Currently the DumpHex() internal function is only used by commands that belong to the Debug1 profile exclusively (i.e., they are not required to be present in other than Debug1 profiles): - SMBIOSVIEW - PC

[edk2] [PATCH v2 11/14] ShellPkg: BcfgDisplayDump(): fix ShellPrintEx() call site

This is likely a copy & paste error from the preceding ShellPrintHiiEx() function call. ShellPrintEx() takes no Language parameter, so remove the NULL argument, which is currently misinterpreted as a format string. This bug prevents the hexdump of optional data even when -v is passed to BCFG, and

[edk2] [PATCH v2 07/14] ShellPkg: BcfgDisplayDump(): call Description[Size] by name

Introduce two more helper variables to avoid repeated pointer arithmetic. This patch is not supposed to change behavior. Cc: Jaben Carsey Cc: Ryan Harkin Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- Notes: v2: - clarify in the subject that th

[edk2] [PATCH v2 04/14] ShellPkg: BcfgDisplayDump(): accumulate errors

Don't exit the command immediately when a variable access fails; continue processing after printing the error message. Let the final return status reflect any encountered errors. This patch is intended as a functional improvement. Cc: Jaben Carsey Cc: Ryan Harkin Contributed-under: TianoCore Co

[edk2] [PATCH v2 08/14] ShellPkg: BcfgDisplayDump(): eliminate FilePathList duplication

Copying and releasing each EFI_LOAD_OPTION.FilePathList under the name DevPath is wasteful -- we only need FilePathList for a single conversion to text. Do it directly from the EFI_LOAD_OPTION object. This patch is not supposed to change observable behavior. Cc: Jaben Carsey Cc: Ryan Harkin Con

[edk2] [PATCH v2 01/14] ShellPkg: BcfgDisplayDump(): update whitespace & layout

This patch incurs no functional changes, it just modifies some whitespace, so we can separate these non-functional changes from the functional changes in the next patches. Cc: Jaben Carsey Cc: Ryan Harkin Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- N

[edk2] [PATCH v2 06/14] ShellPkg: BcfgDisplayDump(): address FilePathListLength by name

The Buffer variable points at the beginning of an EFI_LOAD_OPTION structure. We might as well address the "FilePathListLength" member by name, rather than with *(UINT16*)(Buffer+4). This patch is not supposed to change behavior. Cc: Jaben Carsey Cc: Ryan Harkin Contributed-under: TianoCore Cont

[edk2] [PATCH v2 00/14] ShellPkg: BCFG dump improvements

Version 2 of . Changes relative to v1: - Bump the minor version numbers in the INF files of UefiShellBcfgCommandLib, UefiShellCommandLib, UefiShellDebug1CommandsLib [Jaben]. For the first of these, a final patch has been added. Fo

[edk2] [PATCH v2 02/14] ShellPkg: UefiShellBcfgCommandLib: drop unused string tokens

STR_GEN_PROBLEM_VAL, STR_GEN_TOO_MANY, and STR_BCFG_LOCATION_RANGE are not used in the C source code. Remove them to decrease clutter. Cc: Jaben Carsey Cc: Ryan Harkin Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- ShellPkg/Library/UefiShellBcfgCommandL

[edk2] [PATCH v2 03/14] ShellPkg: BcfgDisplayDump(): hoist NULL-init of DevPath[String]

It will help with error handling if we move these initializations near the top of the loop body. This patch is not supposed to change behavior. Cc: Jaben Carsey Cc: Ryan Harkin Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- Notes: v2: - clarify

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

On 21 January 2016 at 16:05, Laszlo Ersek wrote: > On 01/21/16 13:57, Ryan Harkin wrote: >> On 21 January 2016 at 11:46, Laszlo Ersek wrote: >>> adding Roy >>> >>> On 01/21/16 10:51, Ryan Harkin wrote: Hi Ray, On 21 January 2016 at 09:44, Ni, Ruiyu wrote: > It makes sense that

Re: [edk2] [PATCH] [ShellPkg] fix operator

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Thursday, January 21, 2016 8:13 AM > To: Carsey, Jaben ; Ryan Harkin > > Cc: edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] [ShellPkg] fix operator > Importance: H

Re: [edk2] [PATCH] [ShellPkg] fix operator

On 01/21/16 16:50, Carsey, Jaben wrote: > > >> -Original Message- >> From: Ryan Harkin [mailto:ryan.har...@linaro.org] >> Sent: Thursday, January 21, 2016 12:47 AM >> To: Laszlo Ersek >> Cc: Carsey, Jaben ; edk2-devel@lists.01.org > de...@ml01.01.org> >> Subject: Re: [PATCH] [ShellPkg] f

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

On 01/21/16 13:57, Ryan Harkin wrote: > On 21 January 2016 at 11:46, Laszlo Ersek wrote: >> adding Roy >> >> On 01/21/16 10:51, Ryan Harkin wrote: >>> Hi Ray, >>> >>> On 21 January 2016 at 09:44, Ni, Ruiyu wrote: It makes sense that F2 to F9 behaves like ESC because the Serial device do

Re: [edk2] [PATCH] [ShellPkg] fix operator

> -Original Message- > From: Ryan Harkin [mailto:ryan.har...@linaro.org] > Sent: Thursday, January 21, 2016 12:47 AM > To: Laszlo Ersek > Cc: Carsey, Jaben ; edk2-devel@lists.01.org de...@ml01.01.org> > Subject: Re: [PATCH] [ShellPkg] fix operator > Importance: High > > On 21 January 2

Re: [edk2] Help: NetworkStack requirement to generate DUID-LL(T) per own MAC address

On 21/01/16 10:13, Jim Hung (洪銘駿) wrote: There is one network issue in customer datacenter, the “ClientID/DUID/Link-Layer Address” is not bundled with the MAC from source network device if multi LANs on the system. And, this cause the PXE boot failure at customer datacenter environment. On ou

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

On 21 January 2016 at 11:46, Laszlo Ersek wrote: > adding Roy > > On 01/21/16 10:51, Ryan Harkin wrote: >> Hi Ray, >> >> On 21 January 2016 at 09:44, Ni, Ruiyu wrote: >>> It makes sense that F2 to F9 behaves like ESC because >>> the Serial device doesn't have enough buffer (FIFO) >>> to hold all

Re: [edk2] S3SaveStateDxe.inf doesn't explicitly include SmbusLib, is it a bug?

HI Star, I tried to remove SmbusLib.h from InternalS3SaveState.h., there will be build errors.Smbus related logic exists in S3SaveState.c At 2016-01-21 18:09:41, "Zeng, Star" wrote: >It is just to include header file, I believe it could be removed from >InternalS3SaveState.h. >What l

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

adding Roy On 01/21/16 10:51, Ryan Harkin wrote: > Hi Ray, > > On 21 January 2016 at 09:44, Ni, Ruiyu wrote: >> It makes sense that F2 to F9 behaves like ESC because >> the Serial device doesn't have enough buffer (FIFO) >> to hold all the escape sequence keys. >> >> Because the certain platform

[edk2] Help: NetworkStack requirement to generate DUID-LL(T) per own MAC address

Hi Sir, Here is the BIOS engineer from Quanta Computer Inc., there is a requirement from our customer regarding networkstack driver, can you please help on this? Issue: There is one network issue in customer datacenter, the “ClientID/DUID/Link-Layer Address” is not bundled with the MAC from sou

Re: [edk2] S3SaveStateDxe.inf doesn't explicitly include SmbusLib, is it a bug?

It is just to include header file, I believe it could be removed from InternalS3SaveState.h. What libraries a driver will link is not determined by source files, but inf file ( S3SaveStateDxe.inf)? Why does S3SaveStateDxe.inf finally link SmbusLib, it is because S3SaveStateDxe.inf link S3BootSc

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

Hi Ray, On 21 January 2016 at 09:44, Ni, Ruiyu wrote: > It makes sense that F2 to F9 behaves like ESC because > the Serial device doesn't have enough buffer (FIFO) > to hold all the escape sequence keys. > > Because the certain platform cannot handle escape > sequence keys like F2-F9 or cursor mo

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

It makes sense that F2 to F9 behaves like ESC because the Serial device doesn't have enough buffer (FIFO) to hold all the escape sequence keys. Because the certain platform cannot handle escape sequence keys like F2-F9 or cursor movement, I think it's reasonable to use a bigger FIFO other 1 in tha

[edk2] S3SaveStateDxe.inf doesn't explicitly include SmbusLib, is it a bug?

Hi All, I meet a issue that there is a get PCD assert for S3SaveStateDxe.inf. It is strange that I seached all the library and their child library in S3SaveStateDxe.inf , no PCD found related to this issue [LibraryClasses] UefiBootServicesTableLib MemoryAllocationLib UefiDriverEntry

Re: [edk2] [PATCH 04/13] ShellPkg: UefiShellBcfgCommandLib: accumulate errors

On 21 January 2016 at 08:47, Laszlo Ersek wrote: > On 01/21/16 09:24, Ryan Harkin wrote: >> Hi Laszlo, >> >> This series is looking great so far, I have yet to test it as I need >> to set my platform up to build Shell before I can do that, however, >> I've had a review of the patches and the only

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

On 21 January 2016 at 08:42, Laszlo Ersek wrote: > On 01/21/16 09:20, Ryan Harkin wrote: >> On 21 January 2016 at 08:14, Laszlo Ersek wrote: >>> On 01/21/16 06:42, Ni, Ruiyu wrote: Laszlo, When I re-think about the cursor issue, I am curious whether the function keys (F1/F2/...) wo

Re: [edk2] [patch] SecurityPkg: Update TCG PPI "1.3" for TCG2.

Yes. Thanks for the reminder. -Original Message- From: Zhang, Chao B Sent: Thursday, January 21, 2016 4:49 PM To: Yao, Jiewen; edk2-de...@ml01.01.org Subject: RE: [patch] SecurityPkg: Update TCG PPI "1.3" for TCG2. Jiewen: Please also update copyright. Reviewed-by: Chao Zhang

Re: [edk2] [patch] SecurityPkg: Update TCG PPI "1.3" for TCG2.

Jiewen: Please also update copyright. Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Yao, Jiewen Sent: Thursday, January 21, 2016 4:41 PM To: edk2-de...@ml01.01.org Cc: Yao, Jiewen; Zhang, Chao B Subject: [patch] SecurityPkg: Update TCG PPI

Re: [edk2] [PATCH 04/13] ShellPkg: UefiShellBcfgCommandLib: accumulate errors

On 01/21/16 09:24, Ryan Harkin wrote: > Hi Laszlo, > > This series is looking great so far, I have yet to test it as I need > to set my platform up to build Shell before I can do that, however, > I've had a review of the patches and the only thing I've noticed so > far is > > On 21 January 20

Re: [edk2] [PATCH] [ShellPkg] fix operator

On 21 January 2016 at 01:01, Laszlo Ersek wrote: > On 01/20/16 23:18, Ryan Harkin wrote: >> >> On 20 Jan 2016 21:23, "Carsey, Jaben" > > wrote: >>> >>> I will wait. >>> >>> -Jaben >>> >>> > -Original Message- >>> > From: Laszlo Ersek [mailto:ler...@redhat.com

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

On 01/21/16 09:20, Ryan Harkin wrote: > On 21 January 2016 at 08:14, Laszlo Ersek wrote: >> On 01/21/16 06:42, Ni, Ruiyu wrote: >>> Laszlo, >>> When I re-think about the cursor issue, I am curious whether the >>> function keys (F1/F2/...) work well in your platform. >>> I guess any keys that will

[edk2] [patch] SecurityPkg: Update TCG PPI "1.3" for TCG2.

The Tcg2Smm follows TCG PPI 1.3 specification. This patch updates the ASL code string to 1.3. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: "Yao, Jiewen" Cc: "Zhang, Chao B" --- SecurityPkg/Tcg/Tcg2Smm/Tpm.asl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [edk2] [PATCH 04/13] ShellPkg: UefiShellBcfgCommandLib: accumulate errors

Hi Laszlo, This series is looking great so far, I have yet to test it as I need to set my platform up to build Shell before I can do that, however, I've had a review of the patches and the only thing I've noticed so far is On 21 January 2016 at 01:11, Laszlo Ersek wrote: > Don't exit the com

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

On 21 January 2016 at 08:14, Laszlo Ersek wrote: > On 01/21/16 06:42, Ni, Ruiyu wrote: >> Laszlo, >> When I re-think about the cursor issue, I am curious whether the >> function keys (F1/F2/...) work well in your platform. >> I guess any keys that will translate to multiple bytes don't work. >> Co

Re: [edk2] [PATCH 3/3] MdeModulePkg: TerminalDxe: select the UART's default receive FIFO depth

On 01/21/16 06:42, Ni, Ruiyu wrote: > Laszlo, > When I re-think about the cursor issue, I am curious whether the > function keys (F1/F2/...) work well in your platform. > I guess any keys that will translate to multiple bytes don't work. > Correct? I never experienced this issue personally. Based