Re: [edk2] [PATCH] MdePkg: Update Base.h to fix compilation issues with ICC.

2016-01-30 Thread Jordan Justen
On 2016-01-30 19:44:26, Kinney, Michael D wrote: > Jordan, > > Good idea, but ECB compiler does not define __INTEL_COMPILER. > Ok. You can add my r-b for the patch: Reviewed-by: Jordan Justen > > > -Original Message- > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Be

Re: [edk2] [PATCH] MdePkg: Update Base.h to fix compilation issues with ICC.

2016-01-30 Thread Kinney, Michael D
Jordan, Good idea, but ECB compiler does not define __INTEL_COMPILER. Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jordan > Justen > Sent: Saturday, January 30, 2016 5:53 PM > To: Kinney, Michael D ; Marvin Haeuser > ; edk2-devel@lis

Re: [edk2] [PATCH] BaseTools: Update Edk2Setup.bat to support pre-defined EDK_TOOLS_BIN.

2016-01-30 Thread Marvin Häuser
Jordan, The actual issue with the new folder layout described in the instructions linkedby you is not the Multiple Workspaces feature, as the BASE_TOOLS_PATH andthus EDK_TOOLS_PATH will be searched for in WORKSPACE and all ofPACKAGES_PATH, but that the instructions propose the Win32 binary direc

Re: [edk2] [PATCH] BaseTools: Update Edk2Setup.bat to support pre-defined EDK_TOOLS_BIN.

2016-01-30 Thread Jordan Justen
Larry, Erik, Liming, >From talking to Marvin on IRC, I gather that he was trying to use edk2setup instead of edksetup for these instructions: https://github.com/tianocore/tianocore.github.io/wiki/GitHub_Access_and_Usage But, more generically I think it might be an incompatibility with the multip

Re: [edk2] [PATCH] MdePkg: Update Base.h to fix compilation issues with ICC.

2016-01-30 Thread Jordan Justen
On 2016-01-30 16:42:55, Kinney, Michael D wrote: > Reviewed-by: Michael Kinney > Mike, do you think the EBC compiler also defines __INTEL_COMPILER? If so, then this might work: #if defined(_MSC_EXTENSIONS) && !defined (__INTEL_COMPILER) -Jordan > > > -Original Message- > > From: edk

Re: [edk2] [PATCH] MdePkg: Update Base.h to fix compilation issues with ICC.

2016-01-30 Thread Kinney, Michael D
Reviewed-by: Michael Kinney Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Marvin > Haeuser > Sent: Friday, January 29, 2016 3:56 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH] MdePkg: Update Base.h to fix compilation issue

[edk2] [Patch] QuarkPlatformPkg/Readme.md: Move images to tianocore wiki

2016-01-30 Thread Michael Kinney
Move image files associated with Readme.md from tianocore website to tianocore wiki. Cc: Kelly Steele Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney --- QuarkPlatformPkg/Readme.md | 16 1 file changed, 8 insertions(+), 8 de

[edk2] [PATCH] BaseTools: Update Edk2Setup.bat to support pre-defined EDK_TOOLS_BIN.

2016-01-30 Thread Marvin Haeuser
Currently, the Edk2Setup script verifies that %EDK_TOOLS_PATH%\Bin\Win32\build.exe exists. The new folder layout described on the 'SourceForge to Github Quick Start' wiki page though suggests the Win32 build tools should be present as edk2-BaseTools-win32 folder in the parent directory of the edk2

Re: [edk2] Variable length PcdRsa2048Sha256PublicKeyBuffer PCD

2016-01-30 Thread Kinney, Michael D
Eugene, I can address the general PCD question. Dynamic PCDs can be stored in 3 different locations. VPD which is read-only, so the value can not be changed. UEFI Variable which is non-volatile and read-write, so the value and size can be changed. Database in a memory buffer that is volatil

[edk2] Variable length PcdRsa2048Sha256PublicKeyBuffer PCD

2016-01-30 Thread Cohen, Eugene
Dear SecurityPkg maintainer, The SecurityPkg Rsa2048Sha256 system depends on a dynamic PCD called gEfiSecurityPkgTokenSpaceGuid.PcdRsa2048Sha256PublicKeyBuffer . This stores a set of hashes used to verify public keys. It appears that the length of this PCD is determined at build time. How we

Re: [edk2] [PATCH 1/4] ArmPkg:Rectify file modes.

2016-01-30 Thread Leif Lindholm
On Fri, Jan 29, 2016 at 04:05:36PM +, evan.ll...@arm.com wrote: > From: Evan Lloyd > > Problems have been encountered because some of the source files have > execute permission set. This can cause git to report them as changed > when they are checked out onto a file system with inherited per

Re: [edk2] [patch 0/7] Add UEFI2.6 MemoryAttributesTable support.

2016-01-30 Thread Ard Biesheuvel
On 30 January 2016 at 04:17, Yao, Jiewen wrote: > Thanks for the clarification. I think you are right. > > I said "This table is used to retire old PropertiesTable", because UEFI2.6 > does not recommend using PropertiesTable to report RT information. > The future BIOS/OS should always produce/con