Re: [edk2] [PATCH] MdeModulePkg RamDiskDxe: Allocate Reserved memory

2016-04-14 Thread Tian, Feng
Yes. The RamDisk HII form is only for boot time use. PS: As for the NFIT table patch, we just got some feedbacks to ask us to append NFIT entry of reserved memory to existing NFIT table. We are working on this and will send the v2 soon. Thanks Feng -Original Message- From: Gary Lin [m

[edk2] [Patch] MdeModulePkg: Correct PlatformHookLibSerialPortPpi module type.

2016-04-14 Thread Liming Gao
This library instance is PEIM type, not BASE type. It has the PPI dependency for PEIM. Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- .../PlatformHookLibSerialPortPpi/PlatformHookLibSerialPortPpi.inf | 4 ++-- 1 file changed, 2 insertions

Re: [edk2] [patch] MdeModulePkg/HiiDatabaseDxe: Correct the ReallocatePool size

2016-04-14 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Bi, Dandan > Sent: Tuesday, April 12, 2016 6:44 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming; Dong, Eric > Subject: [patch] MdeModulePkg/HiiDatabaseDxe: Correct the ReallocatePool > size > > Cc: Liming Gao > Cc: Eric Dong > Con

Re: [edk2] [Patch] ShellPkg: Update ping command options to sync with Spec

2016-04-14 Thread Wu, Jiaxin
Jaben , Do you agree to support no source IP specified case? After update, Ping will select the first both connected and configured interface automatically instead of always the first NIC. If no objection, patch will be sent out for review. Thanks. Jiaxin > -Original Message- > From:

Re: [edk2] [PATCH] MdeModulePkg RamDiskDxe: Allocate Reserved memory

2016-04-14 Thread Gary Lin
On Fri, Apr 15, 2016 at 02:46:04AM +, Tian, Feng wrote: > Hi, Lin > > Could you introduce more details on this? > > "I applied the NFIT patch(*) and it complained the allocated memory is not > reserved so I wrote this patch." > > If os loader/app would like to create ramdisk for runtime use

[edk2] [PATCH] NetworkPkg: Don't need to update device path in home environment

2016-04-14 Thread Gary Li
Don't need to update device path in home environment Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gary Li --- NetworkPkg/HttpBootDxe/HttpBootClient.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/NetworkPkg/HttpBootDxe/HttpBootClient.c b/NetworkPkg/HttpBo

Re: [edk2] [PATCH] MdeModulePkg RamDiskDxe: Allocate Reserved memory

2016-04-14 Thread Tian, Feng
Hi, Lin Could you introduce more details on this? "I applied the NFIT patch(*) and it complained the allocated memory is not reserved so I wrote this patch." If os loader/app would like to create ramdisk for runtime use, it should invoke EFI_RAM_DISK_PROTOCOL to register the ramdisk using rese

Re: [edk2] [PATCH] MdeModulePkg RamDiskDxe: Allocate Reserved memory

2016-04-14 Thread Gary Lin
On Thu, Apr 14, 2016 at 12:29:04PM +0200, Laszlo Ersek wrote: > Gary, > > On 04/14/16 10:16, Gary Lin wrote: > > The memory space for the ramdisk was allocated by AllocatePool() which > > allocates the memory in BootServiceData, and then the ramdisk would be > > cleared after ExitBootService(). Th

Re: [edk2] [PATCH] SecuritPkg: DxeImageVerificationLib: Fix wrong verification logic in DBX & DBT

2016-04-14 Thread Long, Qin
This looks good to me. Thanks Kevin for creating the ref #. Best Regards & Thanks, LONG, Qin > -Original Message- > From: Zhang, Chao B > Sent: Friday, April 15, 2016 8:40 AM > To: Kevin Davis > Cc: edk2-de...@ml01.01.org; Laszlo Ersek; Long, Qin; Peter Jones > Subject: RE: [edk2] [PATC

Re: [edk2] [PATCH v1 1/1] BaseTools: Fix PLATFORM_DIR variable value.

2016-04-14 Thread Zhu, Yonghong
Reviewed-by: Yonghong Zhu Thanks Marvin . I will push this patch to Git Repository. Best Regards, Zhu Yonghong -Original Message- From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] Sent: Friday, April 15, 2016 12:28 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong

Re: [edk2] [PATCH v1 1/2] EdkCompatibilityPkg: Do not cast VA_LIST to a pointer for AARCH64.

2016-04-14 Thread Gao, Liming
The patch serials are good. I am curious who defines EFIAARCH64. Compiler? -Original Message- From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] Sent: Friday, April 15, 2016 4:48 AM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [PATCH v1 1/2] EdkCompatibilityPkg: Do not cast

Re: [edk2] [PATCH] SecuritPkg: DxeImageVerificationLib: Fix wrong verification logic in DBX & DBT

2016-04-14 Thread Zhang, Chao B
Hi all: Thank you very much for the info. Do you agree to add "[USRT 0001604]: Bug found in SecuritPkg: DxeImageVerificationLib" into the log & check in this patch? Thanks & Best regards Chao Zhang -Original Message- From: Kevin Davis [mailto:kevin.da...@insyde.com] Sent: Friday,

Re: [edk2] GenFds fails with MWS.

2016-04-14 Thread Zhu, Yonghong
Hi Marvin, Thanks for report it. I will first to reproduce and investigate. Best Regards, Zhu Yonghong From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] Sent: Friday, April 15, 2016 2:05 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong Subject: GenFds fails with MWS. Hello

Re: [edk2] [Patch 0/2] BaseTools: Update tool to handle PE image with .code section only

2016-04-14 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Zhu, Yonghong Sent: Thursday, April 14, 2016 10:43 AM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [Patch 0/2] BaseTools: Update tool to handle PE image with .code section only rebase the image which only has .code section, but

Re: [edk2] [Patch] BaseTools: Fix the bug to correctly handle the [BuildOptions]

2016-04-14 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Zhu, Yonghong Sent: Friday, April 15, 2016 12:44 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Laszlo Ersek Subject: [Patch] BaseTools: Fix the bug to correctly handle the [BuildOptions] the last fix call os.path.normpath() function,

Re: [edk2] OVMF build failure due to missing CommonMacros.inc

2016-04-14 Thread Zhu, Yonghong
Hi Bruce Cran, We already have patch to fix it, current the patch is in review phase. Thanks. Patch: [edk2] [Patch] BaseTools: Fix the bug to correctly handle the [BuildOptions] Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On B

[edk2] OVMF build failure due to missing CommonMacros.inc

2016-04-14 Thread Bruce Cran
I just pulled the latest code from git master and the OVMF build is failing because ResetVector.nasmb tries to include CommonMacros.inc and can't find it. -- Bruce Cran ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/l

Re: [edk2] [PATCH] SecuritPkg: DxeImageVerificationLib: Fix wrong verification logic in DBX & DBT

2016-04-14 Thread Kevin Davis
Chao, If you would like to reference the USRT's Mantis ticket, Dick Wilkins created Mantis ticket 1604. [USRT 0001604]: Bug found in SecuritPkg: DxeImageVerificationLib Thanks, Kevin 戴連輝 US mobile: +1 (503) 610-8080 US office: +1 (971) 222-3939 Taiwan mobile:  +886-9-7071-9364 -Original

Re: [edk2] [PATCH] SecuritPkg: DxeImageVerificationLib: Fix wrong verification logic in DBX & DBT

2016-04-14 Thread Kevin Davis
I agree with Peter. I just pinged the USRT about this. We can create a Mantis ticket for it and Chao can modify the Patch. Thanks, Kevin 戴連輝 US mobile: +1 (503) 610-8080 US office: +1 (971) 222-3939 Taiwan mobile:  +886-9-7071-9364 -Original Message- From: edk2-devel [mailto:edk2-dev

Re: [edk2] [PATCH] StdLib/LibC: Add __aeabi_ui2f and __aeabi_f2uiz

2016-04-14 Thread Michael Zimmermann
well I followed the existing design, which seems to be that only basic functions(the __aeabi_ files) are in the generic lib(which are duplicate in the StdLib anyway, is that on purpose?) Michael On Thu, Apr 14, 2016 at 9:30 PM, Daryl McDaniel wrote: > Michael, > > Thank you for the patches. > W

[edk2] [PATCH v1 1/2] EdkCompatibilityPkg: Do not cast VA_LIST to a pointer for AARCH64.

2016-04-14 Thread Marvin Häuser
Do not cast VA_LIST to a pointer for the AARCH64 architecture in EfiCommonLib. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Marvin Haeuser --- EdkCompatibilityPkg/Foundation/Library/EfiCommonLib/ReportStatusCode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[edk2] [PATCH v1 2/2] EdkCompatibilityPkg: Fix a typo.

2016-04-14 Thread Marvin Häuser
Fix a typo and a spacing mistake in EfiCommonLib. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Marvin Haeuser --- EdkCompatibilityPkg/Foundation/Library/EfiCommonLib/ReportStatusCode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/EdkCompatibi

Re: [edk2] [PATCH] SecuritPkg: DxeImageVerificationLib: Fix wrong verification logic in DBX & DBT

2016-04-14 Thread Peter Jones
On Thu, Apr 14, 2016 at 01:10:02AM +, Zhang, Chao B wrote: > Laszlo: >There is no CVE number. The issue was exposed during internal code >review. The code has been existing since 11/4/2014. So... why not? This is exactly the sort of issue that needs proper tracking. -- Peter _

Re: [edk2] [PATCH] StdLib/LibC: Add floorf

2016-04-14 Thread Daryl McDaniel
Michael, This patch has been queued for review. Results soon... Daryl McDaniel > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael > Zimmermann > Sent: Sunday, April 10, 2016 12:21 AM > To: edk2-devel@lists.01.org > Cc: Jaben Carsey ; D

Re: [edk2] [PATCH] StdLib/LibC: Add trunc

2016-04-14 Thread Daryl McDaniel
Michael, This patch has been queued for review. Results soon... Daryl McDaniel > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael > Zimmermann > Sent: Sunday, April 10, 2016 12:20 AM > To: edk2-devel@lists.01.org > Cc: Jaben Carsey ; D

Re: [edk2] [PATCH] StdLib/LibC: Add __aeabi_ui2f and __aeabi_f2uiz

2016-04-14 Thread Daryl McDaniel
Michael, Thank you for the patches. Would this patch be better placed in the ARM intrinsics package? If not, then I will add it to your other patches which I plan to integrate this weekend. Thanks, Daryl McDaniel > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.0

Re: [edk2] [Patch] BaseTools: Fix the bug to correctly handle the [BuildOptions]

2016-04-14 Thread Laszlo Ersek
On 04/14/16 18:44, Yonghong Zhu wrote: > the last fix call os.path.normpath() function, which removes the > trailing slash character, it cause NASM failure for ResetVector > driver. > > Cc: Liming Gao > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Y

[edk2] Propose moving "ECR1263: Customized Secure Boot" to staging

2016-04-14 Thread Jeremiah Cox
I would like to suggest that changes related to "ECR1263" and "Customized Secure Boot" be removed from the EDK2 trunk moved to a new feature branch under https://github.com/tianocore/edk2-staging. It has been brought to my attention that the specification for this ECR has some conflicting langu

[edk2] GenFds fails with MWS.

2016-04-14 Thread Marvin Häuser
Hello dear TianoCore developers, Liming, Yonghong, Today I wanted to try out the changes intoduced with the ‚BaseTools: fix PLATFORM_DIR variable value for multiple workspace‘ commit. After having fixed the ‚brace-mismatched‘ I sent as a patch earlier today, the build process works fine until G

Re: [edk2] [Patch] ShellPkg: Update ping command options to sync with Spec

2016-04-14 Thread David Van Arnem
On 04/13/2016 09:13 PM, Wu, Jiaxin wrote: Hi David and Laszlo, This patch is not focused on the discussion about the multiple NICs existed case, just use to update the ping command option. So, please don't misunderstand. Ah, ok. Sorry to clutter up this patch discussion then, I wanted to

Re: [edk2] Tianocore Staging Process

2016-04-14 Thread El-Haj-Mahmoud, Samer
Excellent! Thank you Tony. First feature branch request sent -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Mangefeste, Tony Sent: Wednesday, April 13, 2016 4:54 PM To: edk2-devel@lists.01.org Subject: [edk2] Tianocore Staging Process You

[edk2] [Patch] BaseTools: Fix the bug to correctly handle the [BuildOptions]

2016-04-14 Thread Yonghong Zhu
the last fix call os.path.normpath() function, which removes the trailing slash character, it cause NASM failure for ResetVector driver. Cc: Liming Gao Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/Common/Multip

Re: [edk2] [PATCH 3/3] BaseTools: handleWsMacro: keep trailing os.sep in WORKSPACE substitution

2016-04-14 Thread Zhu, Yonghong
Thanks. I will include your Patch1/3 to not search for TAB_WORKSPACE twice. Best Regards, Zhu Yonghong -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, April 15, 2016 12:23 AM To: Zhu, Yonghong ; edk2-devel-01 Cc: Gao, Liming Subject: Re: [PATCH 3/3] Bas

[edk2] [PATCH v1 1/1] BaseTools: Fix PLATFORM_DIR variable value.

2016-04-14 Thread Marvin Häuser
In commit 017fb1cd4c5e3c8b914eb217ac1760223687dad7, the PLATFORM_DIR macro has been updated to resolve to the correct path. However, it is incorrectly accessed via curved rather than curly braces by GenMake. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Marvin Haeuser ---

Re: [edk2] [PATCH 3/3] BaseTools: handleWsMacro: keep trailing os.sep in WORKSPACE substitution

2016-04-14 Thread Laszlo Ersek
On 04/14/16 17:54, Zhu, Yonghong wrote: > Hi Laszlo, > > Thanks for the fix, this patch can fix the bug. > for the patch3, I'd like to retire the os.path.normpath() since it may > normalization others. And direct to replace the $(workspace) with every > Package in the Packages_Path env to find

Re: [edk2] [PATCH v4] ArmPkg/AArch64Mmu: disable MMU during page table manipulations

2016-04-14 Thread Mark Rutland
On Thu, Apr 14, 2016 at 05:48:27PM +0200, Ard Biesheuvel wrote: > On ARM, manipulating live page tables is cumbersome since the architecture > mandates the use of break-before-make, i.e., replacing a block entry with > a table entry requires an intermediate step via an invalid entry, or TLB > confl

Re: [edk2] [PATCH 3/3] BaseTools: handleWsMacro: keep trailing os.sep in WORKSPACE substitution

2016-04-14 Thread Zhu, Yonghong
Hi Laszlo, Thanks for the fix, this patch can fix the bug. for the patch3, I'd like to retire the os.path.normpath() since it may normalization others. And direct to replace the $(workspace) with every Package in the Packages_Path env to find the correct path. Is it OK to you ? I attached one p

[edk2] [PATCH v4] ArmPkg/AArch64Mmu: disable MMU during page table manipulations

2016-04-14 Thread Ard Biesheuvel
On ARM, manipulating live page tables is cumbersome since the architecture mandates the use of break-before-make, i.e., replacing a block entry with a table entry requires an intermediate step via an invalid entry, or TLB conflicts may occur. Since it is not generally feasible to decide in the pag

[edk2] [PATCH 2/3] BaseTools: handleWsMacro: replace open-coded (back)slash with os.sep

2016-04-14 Thread Laszlo Ersek
Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- BaseTools/Source/Python/Common/MultipleWorkspace.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/Common/MultipleWorkspace.py b/

[edk2] [PATCH 3/3] BaseTools: handleWsMacro: keep trailing os.sep in WORKSPACE substitution

2016-04-14 Thread Laszlo Ersek
The NASM utility requires a trailing directory separator for its -I and -i options (this is a documented requirement). The INF file "OvmfPkg/ResetVector/ResetVector.inf" conforms to it: [BuildOptions] *_*_IA32_NASMB_FLAGS = -I$(WORKSPACE)/UefiCpuPkg/ResetVector/Vtf0/ *_*_X64_NASMB_FLAG

[edk2] [PATCH 1/3] BaseTools: handleWsMacro: don't search for TAB_WORKSPACE twice

2016-04-14 Thread Laszlo Ersek
The result of the first search can be used for both existence checking and substring extraction. Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- BaseTools/Source/Python/Common/MultipleWorkspace.py | 4 ++-- 1 file changed,

[edk2] [PATCH 0/3] BaseTools: keep trailing directory separator in WORKSPACE substitution

2016-04-14 Thread Laszlo Ersek
This fixes the error reported in . Public branch: . Cc: Yonghong Zhu Cc: Liming Gao Thanks Laszlo Laszlo Ersek (3): BaseTools: handleWsMacro: don't sear

Re: [edk2] HII incompatibility between edk2 and iPXE?

2016-04-14 Thread Andrew Fish
> On Apr 14, 2016, at 4:23 AM, Michael Brown wrote: > > On 13/04/16 15:55, Andrew Fish wrote: >>> OK, but why? What is the concrete purpose of this, that could not be >>> achieved by more simply having multiple EFI_HII_CONFIG_ACCESS_PROTOCOL >>> instances? >> >> I think it has to do with the

Re: [edk2] [Patch v2] BaseTools: fix the bug for [BuildOptions] of multiple workspace support

2016-04-14 Thread Zhu, Yonghong
Thanks Laszlo, I will fix it soon. Best Regards, Zhu Yonghong -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, April 14, 2016 9:30 PM To: Zhu, Yonghong Cc: Justen, Jordan L ; edk2-de...@ml01.01.org; Gao, Liming Subject: Re: [edk2] [Patch v2] BaseTools:

Re: [edk2] [Patch v2] BaseTools: fix the bug for [BuildOptions] of multiple workspace support

2016-04-14 Thread Laszlo Ersek
On 04/14/16 13:10, Laszlo Ersek wrote: > On 04/13/16 11:47, Yonghong Zhu wrote: >> when enable Multiple workspace and there have other option(eg: -I) before >> $(WORKSPACE), handleWsMacro cannot return correct which cause the >> ArmVirtPkg build failure. >> example: >> [BuildOptions] >> *_*_AARCH

Re: [edk2] [PATCH] ArmPlatformPkg/DS-5: fix 64-bit PE/COFF header parsing bug

2016-04-14 Thread Leif Lindholm
If this fixes a bug, by all means go ahead. Not sure I could honestly say I've reviewed it. Could Bernie (cc) have a look? / Leif On Thu, Apr 14, 2016 at 02:10:18PM +0200, Ard Biesheuvel wrote: > Pretty ping? > > On 8 April 2016 at 13:26, Ard Biesheuvel wrote: > > Ping? > > > > On 31 March

Re: [edk2] [PATCH v3] ArmPkg/AArch64Mmu: disable MMU during page table manipulations

2016-04-14 Thread Mark Rutland
On Thu, Apr 14, 2016 at 01:36:00PM +0200, Ard Biesheuvel wrote: > On 14 April 2016 at 13:17, Mark Rutland wrote: > > On Tue, Apr 12, 2016 at 08:57:46AM +0200, Ard Biesheuvel wrote: > > I take it that ArmReplaceLiveTranslationEntry isn't part of the static > > image (e.g. it gets relocated or copie

Re: [edk2] [PATCH] ArmPlatformPkg/DS-5: fix 64-bit PE/COFF header parsing bug

2016-04-14 Thread Ard Biesheuvel
Pretty ping? On 8 April 2016 at 13:26, Ard Biesheuvel wrote: > Ping? > > On 31 March 2016 at 09:36, Ard Biesheuvel wrote: >> The 64-bit version of the DS-5 debug script that retrieves the debug file >> path from the PE/COFF image in memory assumes that the PE/COFF header is >> packed, and that t

Re: [edk2] HII incompatibility between edk2 and iPXE?

2016-04-14 Thread Michael Brown
On 13/04/16 17:04, Gao, Liming wrote: UEFI spec Chapter 31 Human Interface Infrastructure Overview and Chapter section 2 Design discussion and Chapter 33 HII Configuration Processing and Browser Protocol section 2 Configuration Strings gives the details on UEFI HII design and Configuration str

Re: [edk2] [PATCH v3] ArmPkg/AArch64Mmu: disable MMU during page table manipulations

2016-04-14 Thread Ard Biesheuvel
On 14 April 2016 at 13:17, Mark Rutland wrote: > On Tue, Apr 12, 2016 at 08:57:46AM +0200, Ard Biesheuvel wrote: >> On ARM, manipulating live page tables is cumbersome since the architecture >> mandates the use of break-before-make, i.e., replacing a block entry with >> a table entry requires an i

Re: [edk2] HII incompatibility between edk2 and iPXE?

2016-04-14 Thread Michael Brown
On 13/04/16 15:55, Andrew Fish wrote: OK, but why? What is the concrete purpose of this, that could not be achieved by more simply having multiple EFI_HII_CONFIG_ACCESS_PROTOCOL instances? I think it has to do with the limitation of one protocol per handle. If there are multiple instances ho

Re: [edk2] [PATCH v3] ArmPkg/AArch64Mmu: disable MMU during page table manipulations

2016-04-14 Thread Mark Rutland
On Tue, Apr 12, 2016 at 08:57:46AM +0200, Ard Biesheuvel wrote: > On ARM, manipulating live page tables is cumbersome since the architecture > mandates the use of break-before-make, i.e., replacing a block entry with > a table entry requires an intermediate step via an invalid entry, or TLB > confl

Re: [edk2] [Patch v2] BaseTools: fix the bug for [BuildOptions] of multiple workspace support

2016-04-14 Thread Laszlo Ersek
On 04/13/16 11:47, Yonghong Zhu wrote: > when enable Multiple workspace and there have other option(eg: -I) before > $(WORKSPACE), handleWsMacro cannot return correct which cause the > ArmVirtPkg build failure. > example: > [BuildOptions] > *_*_AARCH64_PLATFORM_FLAGS == -I$(WORKSPACE)/ArmVirtPkg/

Re: [edk2] [PATCH] EmbeddedPkg: Add GICD table init macro for ACPI 6.0

2016-04-14 Thread Ard Biesheuvel
On 11 April 2016 at 18:53, Ard Biesheuvel wrote: > On 11 April 2016 at 14:31, Heyi Guo wrote: >> Hello, >> >> Any comments on this patch? >> > > I think it looks fine. Leif? > Pushed as d354963f0dc3 Thanks, ___ edk2-devel mailing list edk2-devel@lists

Re: [edk2] [PATCH v2] Ensure write-through behavior for NVMe devices

2016-04-14 Thread Laszlo Ersek
On 04/14/16 03:13, Hao Wu wrote: > After further investigation of SCSI & NVMe specs, we found that: > > For SCSI devices, there is a 'DPOFUA' bit which is returned in the > DEVICE-SPECIFIC PARAMETER field in response to a MODE SENSE command. This > bit tells whether a SCSI device supports the DPO

Re: [edk2] [PATCH] MdeModulePkg RamDiskDxe: Allocate Reserved memory

2016-04-14 Thread Laszlo Ersek
Gary, On 04/14/16 10:16, Gary Lin wrote: > The memory space for the ramdisk was allocated by AllocatePool() which > allocates the memory in BootServiceData, and then the ramdisk would be > cleared after ExitBootService(). This commit changes the allocated area > to EfiReservedMemoryType so that OS

Re: [edk2] [Patch] ShellPkg: Update ping command options to sync with Spec

2016-04-14 Thread Laszlo Ersek
On 04/14/16 05:13, Wu, Jiaxin wrote: > Hi David and Laszlo, > > This patch is not focused on the discussion about the multiple NICs > existed case, just use to update the ping command option. So, please > don't misunderstand. Ah, okay. Although this patch is worthwhile without any particular reas

Re: [edk2] [PATCH] ArmPkg: Fix XN attribute for device memory

2016-04-14 Thread Ard Biesheuvel
On 14 April 2016 at 11:24, Heyi Guo wrote: > Now XN attribute will be set automatically if the region is declared > as device memory. However, the function ArmMemoryAttributeToPageAttribute > is to get attribute for block and page descriptors, not for table > descriptors, so attribute TT_TABLE_*XN

[edk2] [PATCH] ArmPkg: Fix XN attribute for device memory

2016-04-14 Thread Heyi Guo
Now XN attribute will be set automatically if the region is declared as device memory. However, the function ArmMemoryAttributeToPageAttribute is to get attribute for block and page descriptors, not for table descriptors, so attribute TT_TABLE_*XN does not really take effect. Need to use TT_*XN_MA

[edk2] [PATCH] MdeModulePkg RamDiskDxe: Allocate Reserved memory

2016-04-14 Thread Gary Lin
The memory space for the ramdisk was allocated by AllocatePool() which allocates the memory in BootServiceData, and then the ramdisk would be cleared after ExitBootService(). This commit changes the allocated area to EfiReservedMemoryType so that OS can access it later. Contributed-under: TianoCor

[edk2] [Patch] BaseTools: fix a bug for PEI VPD Pcd collection

2016-04-14 Thread Yonghong Zhu
When a PEI phase VPD PCD only list in the DSC IA32 arch, then build X64 arch image, it missed to collect this PEI VPD pcd into VPD Pcd map file. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/AutoGen/AutoGen.py | 28

Re: [edk2] [PATCH] Initialize century of RTC CMOS.

2016-04-14 Thread He, Tim
Reviewed-by: Tim He -Original Message- From: Wei, David Sent: Wednesday, April 13, 2016 3:49 PM To: edk2-devel@lists.01.org Cc: He, Tim; ruiy...@intel.com Subject: [PATCH] Initialize century of RTC CMOS. Initialize century of RTC CMOS, in case that SetTime service does not set it. ---