[edk2] [Patch] MdeModulePkg FileExplorerLib: Add UefiHiiServicesLib dependency.

2016-05-03 Thread Eric Dong
FileExplorerLib depends on UefiHiiServicesLib, so add this missing library dependency back. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong --- MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf | 1 + 1 file changed, 1 insertion(+) diff --

Re: [edk2] [PATCH v2] NetworkPkg: Use UefiBootManagerLib API to create load option.

2016-05-03 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni >-Original Message- >From: Fu, Siyuan >Sent: Wednesday, May 4, 2016 1:58 PM >To: edk2-devel@lists.01.org >Cc: Ye, Ting ; Wu, Jiaxin ; Ni, Ruiyu > >Subject: [PATCH v2] NetworkPkg: Use UefiBootManagerLib API to create load >option. > >V2: >Remove unnecessary ZeroMem

[edk2] [PATCH v2] NetworkPkg: Use UefiBootManagerLib API to create load option.

2016-05-03 Thread Fu Siyuan
V2: Remove unnecessary ZeroMem and free load option. This patch updates the HTTP boot driver to use the API in UefiBootManagerLib to create new load option, to avoid duplicate code. Cc: Ye Ting Cc: Wu Jiaxin Cc: Ni Ruiyu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu

Re: [edk2] [RFC] EDK2 Platforms Proposal

2016-05-03 Thread Gao, Liming
Mike: I have some comments. 1) If the platforms wants to base on edk2 master, it is not suggested to be placed into edk2-platform repo. Right? 2) On add a new platform to edk2-platforms, who approves the request? Edk2 maintainer? Now, edk2 maintainer are edk2 package owner. So, for new platform

Re: [edk2] [Patch] NetworkPkg: Use UefiBootManagerLib API to create load option.

2016-05-03 Thread Ni, Ruiyu
Siyuan, I suggest you remove ZeroMem(). If EfiBootManagerInitializeLoadOption() fails, you needn't to free it through EfiBootManagerFreeLoadOption(). Regards, Ray >-Original Message- >From: Fu, Siyuan >Sent: Wednesday, May 4, 2016 10:03 AM >To: edk2-devel@lists.01.org >Cc: Ye, Ting ; Wu,

[edk2] [Patch 6/7] SecurityPkg OpalPasswordSmm: Enhance BlockSid Logic.

2016-05-03 Thread Eric Dong
BlockSid feature can be retrieve from the header info. Update the logic, check BlockSid capability before use it. Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong --- SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalPasswordSmm.c | 15 ++- 1 fil

[edk2] [Patch 7/7] SecurityPkg OpalPasswordSmm: Move BlockSid out of unlock process.

2016-05-03 Thread Eric Dong
The BlockSid feature is not depend on lock status, so move the send BlockSid command out of unlock process. Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong --- SecurityPkg/Tcg/Opal/OpalPasswordSmm/OpalPasswordSmm.c | 14 +++--- 1 file chang

[edk2] [Patch 3/7] SecurityPkg TcgStorageOpalLib: Check BlockSid capability.

2016-05-03 Thread Eric Dong
Check the BlockSid feature capability through check BlockSid header in the DiscoveryHeader. Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong --- SecurityPkg/Include/Library/TcgStorageOpalLib.h| 6 ++ SecurityPkg/Library/TcgStorageOpa

[edk2] [Patch 0/7] Enhance BlockSid releated logic.

2016-05-03 Thread Eric Dong
Enhance the BlockSid related logic. Eric Dong (7): SecurityPkg TcgStorageOpalLib: Update ComId for Block SID command. MdePkg: Add TCG_BLOCK_SID_FEATURE_DESCRIPTOR definition. SecurityPkg TcgStorageOpalLib: Check BlockSid capability. SecurityPkg OpalPasswordDxe: Change BlockSid position.

[edk2] [Patch 4/7] SecurityPkg OpalPasswordDxe: Change BlockSid position.

2016-05-03 Thread Eric Dong
The BlockSid feature is a global level feature instead of device level feature. So move the menu from device page to the main page. Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong --- SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c | 9 +---

[edk2] [Patch 5/7] SecurityPkg OpalPasswordDxe: Check BlockSid capability before send command.

2016-05-03 Thread Eric Dong
Not all opal device support BlockSid feature. So Add code logic to check the capability before send BlockSid command. Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong --- SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalDriver.c | 25 ++-

[edk2] [Patch 2/7] MdePkg: Add TCG_BLOCK_SID_FEATURE_DESCRIPTOR definition.

2016-05-03 Thread Eric Dong
Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong --- MdePkg/Include/IndustryStandard/TcgStorageCore.h | 12 MdePkg/Include/IndustryStandard/TcgStorageOpal.h | 1 + 2 files changed, 13 insertions(+) diff --git a/MdePkg/Include/IndustryS

[edk2] [Patch 1/7] SecurityPkg TcgStorageOpalLib: Update ComId for Block SID command.

2016-05-03 Thread Eric Dong
The ComId for Block SID authentication command is 0x0005 according to "TCG Storage Feature Set: Block SID Authentication Specification Version 1.0.0". Update code to follow this spec requirement. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong Cc: Feng, Tian ---

[edk2] [patch] MdeModulePkg/Sd: add Erase Block support on sd/emmc device

2016-05-03 Thread Feng Tian
It's done by producing EFI_ERASE_BLOCK_PROTOCOL protocol instance. Cc: Wu, Hao A Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian --- MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c | 411 ++ MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.h | 39 +

[edk2] [patch 5/5] MdeModulePkg/SdMmcPciHcDxe: Check SD's supported bus mode before switch

2016-05-03 Thread Feng Tian
Before switch to a bus mode, we need check if the SD device supports this bus mode. Cc: Wu, Hao A Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 54 +-- MdeModulePkg/Bus/Sd/SdBlockIoPei

[edk2] [patch 0/5] fixes several issues in EDKII SD stack

2016-05-03 Thread Feng Tian
The fixed issues include: 1. break cmd exec earlier if the card isn't identified successfully 2. Use BaseClk if the target clock is larger than BaseClk 3. Use PIO rather DMA mode for sample clock tuning to strictly follow SD HC spec. 4. Enhance error handling of tuning procedure 5. Check support

[edk2] [patch 3/5] MdeModulePkg/SdMmcPciHcDxe: Using PIO rather than DMA for clock tuning

2016-05-03 Thread Feng Tian
The original code is using ADMA mode to do clock tuning procedure. It may have problem on some SD/MMC host controllers as there is no way to know when to send next tuning cmd. Update it to PIO mode to strictly follow SD Host Controller Simplified Specification 3.0 Figure 2-29. By this way, if the

[edk2] [patch 2/5] MdeModulePkg/SdMmcPciHcDxe: Use BaseClk if the target clock is larger

2016-05-03 Thread Feng Tian
The original code has a bug to calculate which clock freq should be used when the target clock freq is larger than the BaseClock Freq provided by the system. Cc: Wu, Hao A Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdM

[edk2] [patch 4/5] MdeModulePkg/SdMmcPciHcDxe: Error handling enhance on tuning procedure

2016-05-03 Thread Feng Tian
Enhance the code to reset tuning circuit when tuning error case happens. Cc: Wu, Hao A Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c | 22 +++--- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c

[edk2] [patch 1/5] MdeModulePkg/SdMmcPciHcDxe: break cmd exec if the card isn't identified

2016-05-03 Thread Feng Tian
Check if the card is identified/initialized correctly. if not, break the following cmd execution through PassThru()/ResetDevice(). Cc: Wu, Hao A Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 33 +

Re: [edk2] [PATCH v2 3/3] IntelFrameworkModulePkg/BdsDxe: Show boot timeout message

2016-05-03 Thread Ni, Ruiyu
2 comments below. Regards, Ray >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Daniil >Egranov >Sent: Wednesday, May 4, 2016 9:34 AM >To: edk2-devel@lists.01.org >Cc: Fan, Jeff >Subject: [edk2] [PATCH v2 3/3] IntelFrameworkModulePkg/BdsDxe: Sh

Re: [edk2] [PATCH v2 2/3] IntelFrameworkModulePkg/BdsDxe: Fix for the BDS boot timeout

2016-05-03 Thread Ni, Ruiyu
3 comments below. Regards, Ray >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Daniil >Egranov >Sent: Wednesday, May 4, 2016 9:34 AM >To: edk2-devel@lists.01.org >Cc: Fan, Jeff >Subject: [edk2] [PATCH v2 2/3] IntelFrameworkModulePkg/BdsDxe: Fi

Re: [edk2] [PATCH v2 1/3] IntelFrameworkModulePkg/GenericBdsLib: Check for invalid device handle

2016-05-03 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni Regards, Ray >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Daniil >Egranov >Sent: Wednesday, May 4, 2016 9:34 AM >To: edk2-devel@lists.01.org >Cc: Fan, Jeff >Subject: [edk2] [PATCH v2 1/3] IntelFrameworkModulePkg/Gener

Re: [edk2] Csm16.bin(seabios) failed to work in OVMF.

2016-05-03 Thread Ni, Ruiyu
I encountered the same issue weeks ago. A quick but dirty fix is to change: UefiCpuPkg/CpuS3DataDxe/CpuS3Data.c: CpuS3DataInitialize() // // Allocate a 4KB reserved page below 1MB // - AcpiCpuData->StartupVector = BASE_1MB - 1; + ApiCpuData->StartupVector = BASE_512KB - 1; Copying Jeff.

Re: [edk2] [PATCH] SecurityPkg: SecureBootConfigDxe: Disable SecureBoot Enable/Disable in some case

2016-05-03 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan > -Original Message- > From: Zhang, Chao B > Sent: Wednesday, May 4, 2016 10:35 AM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Zhang, Chao B > > Subject: [PATCH] SecurityPkg: SecureBootConfigDxe: Disable SecureBoot > Enable/Disable in some case > > Disable

[edk2] [PATCH] SecurityPkg: SecureBootConfigDxe: Disable SecureBoot Enable/Disable in some case

2016-05-03 Thread Zhang, Chao B
Disable SecureBoot Enable/Disable feature when PhysicalPresence is not available, Since SecureBootEnable is protected with PhysicalPresence. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chao Zhang --- .../VariableAuthenticated/SecureBootConfigDxe/SecureBootConfig.vfr

[edk2] [Patch] NetworkPkg: Use UefiBootManagerLib API to create load option.

2016-05-03 Thread Fu Siyuan
This patch updates the HTTP boot driver to use the API in UefiBootManagerLib to create new load option, to avoid duplicate code. Cc: Ye Ting Cc: Wu Jiaxin Cc: Ni Ruiyu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan --- NetworkPkg/HttpBootDxe/HttpBootConfig.c

[edk2] [PATCH v2 0/3] IntelFrameworkModulePkg: Fixes for Intel BDS

2016-05-03 Thread Daniil Egranov
This set of patches fixes the following: Crash when BDS loads a device handle based onthe device path but the device driver has not been loaded. BDS boot timeout. Timeout progress message for RS-232 serial console. Changes since v1: Fixed patch 2/3 compilation issue. Thanks, Daniil Daniil Eg

[edk2] [PATCH v2 1/3] IntelFrameworkModulePkg/GenericBdsLib: Check for invalid device handle

2016-05-03 Thread Daniil Egranov
Added error control for invalid device handle when LocateDevicePath() fails. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daniil Egranov --- IntelFrameworkModulePkg/Library/GenericBdsLib/BdsBoot.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[edk2] [PATCH v2 2/3] IntelFrameworkModulePkg/BdsDxe: Fix for the BDS boot timeout

2016-05-03 Thread Daniil Egranov
The patch loads timeout value from the "Timeout" global variable and passes it to PlatformBdsEnterFrontPage(), which handles delay and key input. The PcdPlatformBootTimeOut is only used at the BDS entry point and updates the "Timeout" value. This will allow the modification of the timeout value th

[edk2] [PATCH v2 3/3] IntelFrameworkModulePkg/BdsDxe: Show boot timeout message

2016-05-03 Thread Daniil Egranov
The PlatformBdsShowProgress() supports graphics mode only, which is not applicable for RS-232 serial console. Show the progress message as a console text message in case PlatformBdsShowProgress() fails. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Daniil Egranov --- Int

[edk2] [Patch] MdeModulePkg: Refine SNP driver's media status check logic.

2016-05-03 Thread Fu Siyuan
Some UNDI drivers may not support the cable detect in UNDI INITIALIZE command, but support the media present check in UNDI GET_STATUS command. Current SNP driver will set the MediaPresentSupported field to FALSE in EFI_SIMPLE_NETWORK_MODE for such case, which forbid the media detect from the calle

Re: [edk2] [PATCH] MdeModulePkg: ScsiDiskDxe: cope with broken "Supported VPD Pages" VPD page

2016-05-03 Thread Tian, Feng
Laszlo, Could you explain more? Usb Flash drive is managed by UsbMassStorage driver, which is irrelevant with UefiScsiLib lib or ScsiDisk driver. Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Wednesday, May 4

Re: [edk2] [PATCH 17/19] IntelFspWrapperPkg/FspInit: Split FspInitPei to FspmWrapperPeim and FspsWrapperPeim.

2016-05-03 Thread Tim Lewis
1. Because we, per our custom tools and per our company policy, require that all source code exist underneath $(WORKSPACE). As previously discussed on this list, we think multiple workspaces makes our projects harder to maintain and harder to scan. Multiple workspaces was meant to be an O

[edk2] [RFC] EDK2 Platforms Proposal

2016-05-03 Thread Kinney, Michael D
Hello, Similar to edk2-staging, we also have a need to manage platforms that have been ported to edk2. Jordan has created a repository called edk2-platforms and has created a branch for the minnowboard-max that uses a validated release of the UDK 2015 for the dependent packages: https://g

[edk2] [PATCH] MdeModulePkg: ScsiDiskDxe: cope with broken "Supported VPD Pages" VPD page

2016-05-03 Thread Laszlo Ersek
The USB flash drive with Vendor ID 0x1516 (CompUSA) and Product ID 0x6221 returns a broken "Supported VPD Pages" VPD page. In particular, the PageLength field has the invalid value 0x0602 (decimal 1538). This prevents the loop from terminating that scans for the Block Limits VPD page code in ScsiD

Re: [edk2] Two PCI IO protocols getting produced by same GUID, how to open correct one?

2016-05-03 Thread Andrew Fish
> On May 3, 2016, at 8:59 AM, Kinney, Michael D > wrote: > > Shaveta, > > As long as all PCI I/O Protocol instances in the platform conform to UEFI > spec, it can work. > > Your original question was about how to tell that a handle has the PCI I/O > Protocol produced > By PCI Bus Driver o

Re: [edk2] Two PCI IO protocols getting produced by same GUID, how to open correct one?

2016-05-03 Thread Kinney, Michael D
Shaveta, As long as all PCI I/O Protocol instances in the platform conform to UEFI spec, it can work. Your original question was about how to tell that a handle has the PCI I/O Protocol produced By PCI Bus Driver or your emulation of PCI. If the PCI I/O Protocols are conformant, then It sho

Re: [edk2] [PATCH 17/19] IntelFspWrapperPkg/FspInit: Split FspInitPei to FspmWrapperPeim and FspsWrapperPeim.

2016-05-03 Thread Tim Lewis
Giri , I suggest you create a new package name, rather than use the same one with different semantics. Multiple workspaces is not ah option for us. Tim Sent from my Windows 10 phone From: Mudusuru, Giri P Sent: Tuesday, May 3, 2016 8:07 AM To: Tim Lew

Re: [edk2] [PATCH v3 1/2] ShellPkg/UefiDpLib: Fix the error message "Timer library instance error!"

2016-05-03 Thread Carsey, Jaben
Thanks! > -Original Message- > From: Zeng, Star > Sent: Monday, May 02, 2016 9:39 PM > To: Carsey, Jaben ; Cinnamon Shia > ; edk2-devel@lists.01.org > Cc: Qiu, Shumin ; samer.el-haj-mahm...@hpe.com > Subject: RE: [PATCH v3 1/2] ShellPkg/UefiDpLib: Fix the error message "Timer > library ins

Re: [edk2] [RFC PATCH 2/2] ArmVirtQemu: restrict RWX mappings

2016-05-03 Thread Ard Biesheuvel
On 3 May 2016 at 16:01, Laszlo Ersek wrote: > On 05/03/16 14:45, Ard Biesheuvel wrote: >> This reduces the amount of memory mapped as both writable and executable >> to the absolute minimum, by mapping all of memory non-executable by >> default, and using PermissionsPeCoffExtraActionLib to only ma

Re: [edk2] [RFC PATCH 2/2] ArmVirtQemu: restrict RWX mappings

2016-05-03 Thread Laszlo Ersek
On 05/03/16 14:45, Ard Biesheuvel wrote: > This reduces the amount of memory mapped as both writable and executable > to the absolute minimum, by mapping all of memory non-executable by > default, and using PermissionsPeCoffExtraActionLib to only map those > regions executable that require it for e

Re: [edk2] [RFC PATCH 0/2] ARM: reduce RWX mappings to absolute minimum

2016-05-03 Thread Ard Biesheuvel
On 3 May 2016 at 15:01, Michael Zimmermann wrote: > wouldn't it be even better to map everything (the whole 32/64bit addr range) > without any permissions(fault on read, write or exec), and then require the > platforms to map IO-registers properly? > We already do that. While we use a 1:1 mapping

Re: [edk2] [RFC PATCH 0/2] ARM: reduce RWX mappings to absolute minimum

2016-05-03 Thread Michael Zimmermann
wouldn't it be even better to map everything (the whole 32/64bit addr range) without any permissions(fault on read, write or exec), and then require the platforms to map IO-registers properly? Michael On Tue, May 3, 2016 at 2:45 PM, Ard Biesheuvel wrote: > From a security perspective, having an

[edk2] [RFC PATCH 2/2] ArmVirtQemu: restrict RWX mappings

2016-05-03 Thread Ard Biesheuvel
This reduces the amount of memory mapped as both writable and executable to the absolute minimum, by mapping all of memory non-executable by default, and using PermissionsPeCoffExtraActionLib to only map those regions executable that require it for execution. If possible, these regions are remapped

[edk2] [RFC PATCH 1/2] ArmPkg/PermissionsPeCoffExtraActionLib: introduce new library

2016-05-03 Thread Ard Biesheuvel
This introduces a new implementation of PeCoffExtraActionLib that remaps PE/COFF executable sections as read-only if the section attributes allow it (and if the module is not a runtime driver) Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmPkg/Libra

[edk2] [RFC PATCH 0/2] ARM: reduce RWX mappings to absolute minimum

2016-05-03 Thread Ard Biesheuvel
>From a security perspective, having any memory with both write and execute permissions is undesirable, and EDK2 at boot time has all of memory mapped RWX by default, so there is obviously some room for improvement here. This series aims to reduce the attack surface, by mapping the whole of system

Re: [edk2] [PATCH 17/19] IntelFspWrapperPkg/FspInit: Split FspInitPei to FspmWrapperPeim and FspsWrapperPeim.

2016-05-03 Thread Tim Lewis
Is this really a good idea, dropping 1.1 support? We don't maintain two separate trees for our products, just 1. There are several chipsets which have long life that will need additional features, but are only 1.1 Tim -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.

Re: [edk2] [PATCH] ArmPkg/ArmDmaLib: assert that consistent mappings are uncached

2016-05-03 Thread Ryan Harkin
On 20 April 2016 at 09:40, Ard Biesheuvel wrote: > DmaMap () only allows uncached mappings to be used for creating consistent > mappings with operation type MapOperationBusMasterCommonBuffer. However, > if the buffer passed to DmaMap () happens to be aligned to the CWG, there > is no need for a bo

Re: [edk2] [Patch 0/3] Use new BDS and UiApp for OvmfPkg

2016-05-03 Thread David Woodhouse
On Tue, 2016-05-03 at 12:37 +0200, Laszlo Ersek wrote: > > However, CSM is apparently generally borked at the moment (see > ), and I don't think I can > spend time on analyzing and fixing that. > > I guess this is not good news, but I thought it better

Re: [edk2] [Patch 0/3] Use new BDS and UiApp for OvmfPkg

2016-05-03 Thread Laszlo Ersek
On 08/04/15 13:07, Laszlo Ersek wrote: > On 08/04/15 12:42, David Woodhouse wrote: >> On Tue, 2015-08-04 at 03:16 +, Ni, Ruiyu wrote: >>> I forgot to emphasize that I only tested the QEMU boot timeout >>> feature after changing the QemuBootOrderLib. I don't know how to test >>> the boot order

Re: [edk2] Two PCI IO protocols getting produced by same GUID, how to open correct one?

2016-05-03 Thread Shaveta Leekha
-Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, May 03, 2016 1:15 PM To: Shaveta Leekha Cc: edk2-devel@lists.01.org Subject: Re: [edk2] Two PCI IO protocols getting produced by same GUID, how to open correct one? On 05/03/16 08:54, Shaveta Leekha wrote

Re: [edk2] [Patch v5 23/24] OvmfPkg: Use MdeModulePkg/BDS

2016-05-03 Thread Laszlo Ersek
Ray, On 05/03/16 07:35, Ruiyu Ni wrote: > By default the new MdeModulePkg/BDS is used. > If USE_OLD_BDS is defined to TRUE, IntelFrameworkModulePkg/BDS > is used. > > Fixes: https://github.com/tianocore/edk2/issues/62 > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: R

Re: [edk2] Two PCI IO protocols getting produced by same GUID, how to open correct one?

2016-05-03 Thread Shaveta Leekha
Please find the replies and doubts in-lined. Regards, Shaveta -Original Message- From: Tian, Feng [mailto:feng.t...@intel.com] Sent: Tuesday, May 03, 2016 1:02 PM To: Shaveta Leekha ; edk2-devel@lists.01.org Cc: Tian, Feng Subject: RE: Two PCI IO protocols getting produced by same GUID,

Re: [edk2] [Patch v5 12/24] OvmfPkg/PlatformBootManagerLib: Register boot options and hot keys

2016-05-03 Thread Laszlo Ersek
Hi Ray, On 05/03/16 07:35, Ruiyu Ni wrote: > The patch registers "Enter" key as the continue key (hot key to skip > the boot timeout wait), maps "F2" key to UI, and registers Shell > boot option. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni > Cc: Jordan J

Re: [edk2] [PATCH 1/5] MdePkg: Revert AuditMode/DeployedMode name definition

2016-05-03 Thread Fu, Siyuan
Series reviewed-by: Fu Siyuan > -Original Message- > From: Zhang, Chao B > Sent: Thursday, April 28, 2016 3:46 PM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Zeng, Star ; > Zhang, Chao B > Subject: [PATCH 1/5] MdePkg: Revert AuditMode/DeployedMode name > definition > > Revert Aud

Re: [edk2] [Patch v5 04/24] OvmfPkg/QemuNewBootOrderLib: Build with UefiBootManagerLib

2016-05-03 Thread Laszlo Ersek
I wanted to mention an opportunity for a micro-optimization: On 05/03/16 11:16, Laszlo Ersek wrote: > On 05/03/16 07:35, Ruiyu Ni wrote: >> NOTE: SetBootOrderFromQemu() interface is not changed. >> But when the old IntelFrameworkModulePkg/BDS is no longer used in >> OVMF and ArmVirtPkg, additional

Re: [edk2] [Patch v5 04/24] OvmfPkg/QemuNewBootOrderLib: Build with UefiBootManagerLib

2016-05-03 Thread Laszlo Ersek
On 05/03/16 07:35, Ruiyu Ni wrote: > NOTE: SetBootOrderFromQemu() interface is not changed. > But when the old IntelFrameworkModulePkg/BDS is no longer used in > OVMF and ArmVirtPkg, additional patch will be submitted to change > this interface to remove parameter BootOptionList. > > Contributed-u

Re: [edk2] [Patch v5 21/24] OvmfPkg/PlatformBootManagerLib: Fix gcc-4.8 Ia32 build failure

2016-05-03 Thread Laszlo Ersek
On 05/03/16 07:35, Ruiyu Ni wrote: > The Width and Height assignment suppresses an invalid gcc-4.8 warning > on Ia32. > These warnings look unjustified to me. Namely, near the beginning of > the function, there is a while(1) loop. In that loop, > ConvertBmpToGopBlt() is called unconditionally. If t

Re: [edk2] [Patch v5 00/24] Use MdeModulePkg/BDS in OVMF platform

2016-05-03 Thread Laszlo Ersek
Hi Ray, On 05/03/16 07:35, Ruiyu Ni wrote: > The patch serials creates a flag USE_OLD_BDS and by default the value > of the flag is FALSE so that the new MdeModulePkg/BDS is used. > User can define USE_OLD_BDS as TRUE to force to use IntelFrameworkModulePkg > /BDS. > > https://github.com/niruiyu/

Re: [edk2] [Patch V2] BaseTools: Support \x####\ in UNI files to specify non-ascii characters

2016-05-03 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Zhu, Yonghong > Sent: Tuesday, May 03, 2016 3:47 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [Patch V2] BaseTools: Support \x\ in UNI files to specify non- > ascii characters > > UNI spec updated to allow using \

[edk2] [Patch V2] BaseTools: Support \x####\ in UNI files to specify non-ascii characters

2016-05-03 Thread Yonghong Zhu
UNI spec updated to allow using \x\ to specify non-ascii characters, # is a hex digit. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu --- BaseTools/Source/Python/AutoGen/UniClassObject.py | 18 ++ 1 file changed, 14 inserti

Re: [edk2] Two PCI IO protocols getting produced by same GUID, how to open correct one?

2016-05-03 Thread Laszlo Ersek
On 05/03/16 08:54, Shaveta Leekha wrote: > Hi, > > I have a scenario where two separate drivers are installing/producing "PCI > IO" protocol with same GUID (gEfiPciIoProtocolGuid). > > Where: > > (1)One of the PCI Io protocol instance is produced by > "MdeModulePkg/Bus/Pci/PciBus" driver f

Re: [edk2] Two PCI IO protocols getting produced by same GUID, how to open correct one?

2016-05-03 Thread Tian, Feng
In your driver binding supported() of "Platform specific Sata controller driver", check the class code (PCI config space offset 09/0a/0bh) after getting the PciIo instance to see if it's the device you want to manage. If not, then it's not you want PS: which platform are you running? Why your p