[edk2] [PATCH v2 1/1] MdeModulePkg:DxeHttpLib: Add checks in HttpGenRequestMessage API

v2: More input validation based on Request and HeaderCount. HttpGenRequestMessage assumes that HTTP message would always contain a request-line, headers and an optional message body. However, subsequent to a HTTP PUT/POST request, HTTP requests would contain just the message body. This patch suppo

Re: [edk2] Two PCI IO protocols getting produced by same GUID, how to open correct one?

If you only need to support SATA/IDE Hard Drive, then you don't need ScsiBus/ScsiDisk. If you want to support SATA/IDE CDROM, you need add them in. If a HDD has been managed by EDKII ATA stack, a device path to it would be created. So one way to check is to see if such device path has existed.

Re: [edk2] [PATCH v1 1/1] MdeModulePkg:DxeHttpLib: Add checks in HttpGenRequestMessage API

Nagaraj, The check is correct but incomplete, the Request and HeaderCount should both zero or both not zero. Best Regards, Siyuan From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hegde, Nagaraj P Sent: Thursday, May 5, 2016 2:13 PM To: Fu, Siyuan ; Wu, Jiaxin ; edk2-dev

Re: [edk2] [PATCH v1 1/1] MdeModulePkg:DxeHttpLib: Add checks in HttpGenRequestMessage API

As Jiaxin pointed out in his reply, if ((Message->Data.Request != NULL && Url == NULL) || (Message->Data.Request != NULL && Message->HeaderCount == 0)) { return EFI_INVALID_PARAMETER; } looks to be a meaningful check to be in place. I will send a v2 patch. Regards, Nagaraj. From: Fu, Siy

[edk2] [PATCH] ShellPkg: Remove debug message in release binaries.

Use BaseDebugLibNull instance instead of UefiDebugLibConOut to remove the debug message in release Shell binaries. Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qiu Shumin --- ShellPkg/ShellPkg.dsc | 4 1 file changed, 4 insertions(+) diff --git a

Re: [edk2] Two PCI IO protocols getting produced by same GUID, how to open correct one?

Thanks for the response! So to access a SATA HDD, to send any command to SATA HDD or to probe SATA devices, we need this complete stack in place? And is there any existing command (any shell command that scans/discover SATA devices) in EDK2 to check whether HDD is scanned in the system? Thanks

Re: [edk2] Two PCI IO protocols getting produced by same GUID, how to open correct one?

AtaAtapiPassThru produces ATA_PASS_THRU and EXT_SCSI_PASS_THRU two protocol instances. AtaBus consumes ATA_PASS_THRU protocol to convert upper layer BlockIo request to ATA cmd and sent the cmd to specified ATA device. ScsiBus + ScsiDisk consume EXT_SCSI_PASS_THRU protocol to convert upper layer

Re: [edk2] [PATCH v1 1/1] MdeModulePkg:DxeHttpLib: Add checks in HttpGenRequestMessage API

Nagaraj, You are right, the HTTP 1.1 requests the client to put at least a Host header in all request messages, that means the Request and Header should be either both non-zero for a new request message, or bother zero for a subsequent message body. So I vote for the EFI_INVALID_PARAMETER, if t

Re: [edk2] [PATCH v1 1/1] MdeModulePkg:DxeHttpLib: Add checks in HttpGenRequestMessage API

Yeah, according UEFI Spec, in my understanding, only two extra cases are allowed: A. Body is not NULL and BodyLength is non-zero and all other fields are NULL or 0 (POST and PUT methods, depending on the size of the data) B. Body is NULL and BodyLength is 0 and all other fields are not NULL or n

Re: [edk2] Two PCI IO protocols getting produced by same GUID, how to open correct one?

Thanks Mike for the response! Hi All, Few doubts in SATA stack. I have seen at some places that in UEFI/EDK2, The complete ATA stack should be like: IdeControllerDxe + AtaAtapiPassThru+ AtaBus + ScsiBus

Re: [edk2] [PATCH v2 3/3] IntelFrameworkModulePkg/BdsDxe: Show boot timeout message

Regards, Ray >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Daniil >Egranov >Sent: Thursday, May 5, 2016 8:07 AM >To: Ni, Ruiyu ; edk2-devel@lists.01.org >Cc: Fan, Jeff >Subject: Re: [edk2] [PATCH v2 3/3] IntelFrameworkModulePkg/BdsDxe: Show

Re: [edk2] [PATCH v2 2/3] IntelFrameworkModulePkg/BdsDxe: Fix for the BDS boot timeout

Regards, Ray >-Original Message- >From: Daniil Egranov [mailto:daniil.egra...@arm.com] >Sent: Thursday, May 5, 2016 7:57 AM >To: Ni, Ruiyu ; edk2-devel@lists.01.org >Cc: Fan, Jeff >Subject: Re: [edk2] [PATCH v2 2/3] IntelFrameworkModulePkg/BdsDxe: Fix for the >BDS boot timeout > >Hi Ra

Re: [edk2] [PATCH] NetworkPkg: Discard TCP segment when no TCB found

On Thu, May 05, 2016 at 01:05:25AM +, Fu, Siyuan wrote: > Hi, Michael > > Sending this RST is required by TCP RFC793 as below: > > http://tools.ietf.org/html/rfc793#section-3.9 > > SEGMENT ARRIVES > > If the state is CLOSED (i.e., TCB does not exist) then > > all data in the inco

Re: [edk2] [PATCH v1 1/1] MdeModulePkg:DxeHttpLib: Add checks in HttpGenRequestMessage API

Hi Jiaxin, I believe in HTTP 1.1, servers do not accept Request methods without any header. In other words, "Host:" header is a must for all request methods. That was the reason I planned to put the construction of header parts inside the "if (Message->Data.Request != NULL" condition. Now, I wo

[edk2] [patch] MdeModulePkg/FileExplore: Make LibraryClass & Depex module type consistent

Cc: Liming Gao Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf

Re: [edk2] [Patch 0/7] Enhance BlockSid releated logic.

Two minor comments: 1. please use a new macro to describe the ComId used for BlockSID. 2. It looks the patch 7/7's comment is not very matched with the code. The code always does BlockSid operation no matter if it's in unlock process. Others look good to me. Reviewed-by: Feng Tian Thanks Feng

Re: [edk2] [PATCH v1 1/1] MdeModulePkg:DxeHttpLib: Add checks in HttpGenRequestMessage API

Hi Nagaraj, Constructing header parts seems should be outside the conditional of "if (Message->Data.Request != NULL)". if (HttpHdr != NULL) { // // Construct header // CopyMem (RequestPtr, HttpHdr, HttpHdrSize); RequestPtr += HttpHdrSize; } Others is good

Re: [edk2] [PATCH] NetworkPkg/HttpBootDxe: Fix for the issue that the HTTP boot option can't be booted more than once

The patch is good to me. Reviewed-by: Fu Siyuan > -Original Message- > From: Sunny Wang [mailto:sunnyw...@hpe.com] > Sent: Thursday, May 5, 2016 10:05 AM > To: edk2-devel@lists.01.org > Cc: el...@hpe.com; Fu, Siyuan ; Sunny Wang > > Subject: [PATCH] NetworkPkg/HttpBootDxe: Fix for the i

[edk2] [Patch] NetworkPkg: Fix a memory leak in HTTP boot driver.

We always need to call EfiBootManagerFreeLoadOption because the memory allocated for NewOption (description and device path) is no longer needed. Cc: Ye Ting Cc: Wu Jiaxin Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Fu Siyuan --- NetworkPkg/HttpBootDxe/HttpBootConfig

Re: [edk2] [PATCH v2] NetworkPkg: Use UefiBootManagerLib API to create load option.

You are right, I will fix it. > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Wang, Sunny (HPS SW) > Sent: Thursday, May 5, 2016 9:57 AM > To: Fu, Siyuan ; edk2-devel@lists.01.org > Cc: Ye, Ting ; Ni, Ruiyu ; Wu, Jiaxin > > Subject: Re: [edk

[edk2] [PATCH] NetworkPkg/HttpBootDxe: Fix for the issue that the HTTP boot option can't be booted more than once

This issue can be reproduced by the following steps: 1. Boot to HTTP boot option and the boot file is a ISO file like Ubuntu PE image. 2. Exit from boot option (GRUB) and then back to boot manager menu. 3. Boot to the same HTTP boot option again or a HTTP boot option pointing to the same HTTP ISO

Re: [edk2] [patch] MdeModulePkg/HiiDatabaseDxe: Fix memory leak issues in HiiDatabaseDxe

Reviewed-by: Qiu Shumin -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Wednesday, May 04, 2016 4:05 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin; Dong, Eric Subject: [edk2] [patch] MdeModulePkg/HiiDatabaseDxe: Fix memory leak is

Re: [edk2] [PATCH v2] NetworkPkg: Use UefiBootManagerLib API to create load option.

Hi Siyuan, I just found a possible memory leak issue with the following code block. Others look good to me. + Status = EfiBootManagerAddLoadOptionVariable (&NewOption, (UINTN) -1); + if (EFI_ERROR (Status)) { +EfiBootManagerFreeLoadOption (&NewOption); + } I think we always need to ca

Re: [edk2] [Patch 0/2] 0001-NetworkPkg-Ignore-BootFileName-if-it-is-overloaded

Series Reviewed-By: Wu Jiaxin > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu > Siyuan > Sent: Tuesday, May 3, 2016 1:36 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch 0/2] 0001-NetworkPkg-Ignore-BootFileName-if-it-is- > overload

Re: [edk2] [PATCH] NetworkPkg: Discard TCP segment when no TCB found

Hi, Michael Sending this RST is required by TCP RFC793 as below: http://tools.ietf.org/html/rfc793#section-3.9 SEGMENT ARRIVES If the state is CLOSED (i.e., TCB does not exist) then all data in the incoming segment is discarded. An incoming segment containing a RST is discarde

Re: [edk2] [Patch 0/2] Do not use hard coded TTL/ToS in PXE driver.

Series Reviewed-By: Wu Jiaxin > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu > Siyuan > Sent: Tuesday, May 3, 2016 10:26 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch 0/2] Do not use hard coded TTL/ToS in PXE driver. > > EFI_

[edk2] [Patch] SecurityPkg TcgStorageOpalLib: Check the capability before use.

For Pyrite SSC device, it may not supports Active Key, So add check logic before enable it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong Cc: Feng, Tian --- .../Library/TcgStorageOpalLib/TcgStorageOpalCore.c | 50 -- 1 file changed, 28 ins

Re: [edk2] [patch] Nt32Pkg: Fix SnpNt32 GetStatus bug

Reviewed-by: Jiaxin Wu > -Original Message- > From: Zhang, Lubo > Sent: Friday, April 29, 2016 10:09 AM > To: Fu, Siyuan ; edk2-devel@lists.01.org > Cc: Ye, Ting ; Wu, Jiaxin > Subject: RE: [edk2] [patch] Nt32Pkg: Fix SnpNt32 GetStatus bug > > A good comment to me, I will change it at

[edk2] [PATCH 7/7] CorebootPayloadPkg: Use serial drivers with PlatformHookLib

Use the serial drivers which update the serial PCDs from PlatformHookLib. Change-Id: Ie6a3526d56332ee1cf07edb24ff39634a981183f Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Lee Leahy --- CorebootPayloadPkg/CorebootPayloadPkg.fdf| 39 Core

[edk2] [PATCH 6/7] CorebootModulePkg/SerialDxe: Use PlatformHookLib

Copy the driver from MdeModulePkg/Universal/SerialDxe. Add PlatformHookLib to the Library section of the .inf file to adjust the PCDs for the UART. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Lee Leahy --- CorebootModulePkg/SerialDxe/SerialDxe.inf | 55 +++ Core

[edk2] [PATCH 4/7] CorebootPayloadPkg: Allow MaxLogicalProcessorNumber to be changed

Add a define and use it with MaxLogicalProcessorNumber to enable this PCD to be changed via the command line. Quark needs to set this value to one during the builds. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Lee Leahy --- CorebootPayloadPkg/CorebootPayloadPkgIa32.ds

[edk2] [PATCH 3/7] CorebootPayloadPkg: Make serial I/O configurable

Allow the serial port configuration to be overriden from the command line. Make the debug serial PCDs patchable in module. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Lee Leahy --- CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc| 73 --- CorebootP

[edk2] [PATCH 5/7] CorebootModulePkg/PciSioSerialDxe: Use PlatformHookLib

Copy the driver from MdeModulePkg/Bus/Pci/PciSioSerialDxe. Add PlatformHookLib to the Library section of the .inf file to adjust the PCDs for the UART. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Lee Leahy --- CorebootModulePkg/PciSioSerialDxe/ComponentName.c | 288

[edk2] [PATCH 1/7] CorebootPayloadPkg/PlatformHelperLib: Remove unreferenced function

Remove the PlatformFlashEraseWrite function which is not used within CorebootPayloadPkg. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Lee Leahy --- .../Include/Library/PlatformHelperLib.h| 38 +- .../Library/PlatformHelperLib/PlatformHelperDxe.c | 141

[edk2] [PATCH 2/7] CorebootPayloadPkg: Make shell selectable

Add all of the shell options from ShellBinPkg including building the shell from source. Enable link time optimization for GCC debug builds to keep the size under 0x3e. Test: Use -DSHELL_TYPE=BUILD_SHELL command line options to build the shell from source. Run the result on Galileo Gen2. Cha

Re: [edk2] [PATCH v2 3/3] IntelFrameworkModulePkg/BdsDxe: Show boot timeout message

Hi Ray, Thanks for the review. My answers below. Thanks, Daniil On 05/04/2016 12:07 AM, Ni, Ruiyu wrote: 2 comments below. Regards, Ray -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Daniil Egranov Sent: Wednesday, May 4, 2016 9:34 AM To:

Re: [edk2] [PATCH v2 2/3] IntelFrameworkModulePkg/BdsDxe: Fix for the BDS boot timeout

Hi Ray, Thank you for review and comments. Please see my answers below. Regards, Daniil On 05/04/2016 12:04 AM, Ni, Ruiyu wrote: 3 comments below. Regards, Ray -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Daniil Egranov Sent: Wednesday,

[edk2] [PATCH 1/1] Complete the Pkcs7VerifyDxe protocol

VerifySignature can be implemented using a mirror of the AuthenticodeVerify function that's already in use in the ImageVerificationDXE environment, so this patch simply wires up VerifySignature using that code. Signed-off-by: James Bottomley --- .../Pkcs7Verify/Pkcs7VerifyDxe/Pkcs7VerifyDxe.c

[edk2] [PATCH 0/1] Complete the Pkcs7VerifyDxe protocol

The tianocore implementation is currently incomplete, it does VerifyBuffer but not VerifySignature. We have a use for VerifySignature in some Linux projects because we currently roll our own openssl implementations for verifying authenticode signatures, but we'd like to drop all of our internal ss

Re: [edk2] [RFC 0/1] Complete the Pkcs7VerifyDxe protocol

On Wed, 2016-03-30 at 06:53 +, Long, Qin wrote: > Hi, James, > > Do we have final conclusion against the Pkcs7 protocol updates? > Will the VerifySignature interface be deprecated or re-enabled for > signed-image verification? We do now. We'll add a note to the standard explaining the probl

Re: [edk2] [Patch 0/2] Do not use hard coded TTL/ToS in PXE driver.

Thanks for fixing this. We noticed the same and were about to submit a patch. Series Reviewed-By: Samer El-Haj-Mahmoud -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu Siyuan Sent: Monday, May 2, 2016 9:26 PM To: edk2-devel@lists.01.org Subjec

Re: [edk2] [PATCH v1 1/1] NetworkPkg:HttpDxe: Code changes to support HTTP PUT/POST operations

Series Reviewed-By: Samer El-Haj-Mahmoud -Original Message- From: Hegde, Nagaraj P Sent: Wednesday, May 4, 2016 5:46 AM To: edk2-devel@lists.01.org Cc: jiaxin...@intel.com; siyuan...@intel.com; ting...@intel.com; El-Haj-Mahmoud, Samer Subject: [PATCH v1 1/1] NetworkPkg:HttpDxe: Code c

Re: [edk2] Two PCI IO protocols getting produced by same GUID, how to open correct one?

Shaveta, All UEFI drivers (not just ones for PCI controllers) are responsible for evaluating the ControllerHandle in their EFI Driver Binding Supported() and Start() APIs to make sure the ControllerHandle is the type the driver knows how to manage. If there is more than one driver that can cor

Re: [edk2] [RFC] EDK2 Platforms Proposal

Liming, Responses below. Mike > -Original Message- > From: Gao, Liming > Sent: Tuesday, May 3, 2016 10:43 PM > To: Kinney, Michael D ; edk2-devel@lists.01.org; > Kinney, > Michael D > Cc: Wu, Mike > Subject: RE: [RFC] EDK2 Platforms Proposal > > Mike: > I have some comments. > 1) I

Re: [edk2] [PATCH] MdeModulePkg: ScsiDiskDxe: cope with broken "Supported VPD Pages" VPD page

On 05/04/16 18:03, Laszlo Ersek wrote: > On 05/04/16 13:11, Laszlo Ersek wrote: >> On 05/04/16 02:58, Tian, Feng wrote: >>> Laszlo, >>> >>> Could you explain more? >>> >>> Usb Flash drive is managed by UsbMassStorage driver, which is irrelevant >>> with UefiScsiLib lib or ScsiDisk driver. >> >>

Re: [edk2] [PATCH] MdeModulePkg: ScsiDiskDxe: cope with broken "Supported VPD Pages" VPD page

On 05/04/16 13:11, Laszlo Ersek wrote: > On 05/04/16 02:58, Tian, Feng wrote: >> Laszlo, >> >> Could you explain more? >> >> Usb Flash drive is managed by UsbMassStorage driver, which is irrelevant >> with UefiScsiLib lib or ScsiDisk driver. > > Yeah, sorry about missing that part of the contex

[edk2] [PATCH] BaseTools AARCH64: set compiler flag -fno-pic explicitly

Android toolchain has fpic enabled by default so explicitly disabling it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Vishal Bhoj --- BaseTools/Conf/tools_def.template | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Conf/tools_def.template

Re: [edk2] [PATCH 17/19] IntelFspWrapperPkg/FspInit: Split FspInitPei to FspmWrapperPeim and FspsWrapperPeim.

Thank you. Tim Sent from my Windows 10 phone From: Mudusuru, Giri P Sent: Tuesday, May 3, 2016 11:06 PM To: Tim Lewis; Yao, Jiewen; edk2-devel@lists.01.org Cc: Rangarajan

Re: [edk2] [Patch v5 00/24] Use MdeModulePkg/BDS in OVMF platform

On 05/03/16 07:35, Ruiyu Ni wrote: > The patch serials creates a flag USE_OLD_BDS and by default the value > of the flag is FALSE so that the new MdeModulePkg/BDS is used. > User can define USE_OLD_BDS as TRUE to force to use IntelFrameworkModulePkg > /BDS. > > https://github.com/niruiyu/edk2/tree

Re: [edk2] Csm16.bin(seabios) failed to work in OVMF.

On 04/25/16 13:21, Laszlo Ersek wrote: > On 04/23/16 08:39, wq...@aliyun.com wrote: >> Hi everyone, >> I build the Csm16.bin from source code of seabios-1.9.2.tar.gz . And >> copy the Csm16.bin to OvmfPkg/Csm/Csm16/Csm16.bin , Build the OVMF_CODE.fd >> and OVMF_VARS.fd with command build -D C

Re: [edk2] Csm16.bin(seabios) failed to work in OVMF.

On 05/04/16 13:32, David Woodhouse wrote: > On Wed, 2016-05-04 at 13:27 +0200, Laszlo Ersek wrote: >> >> Hm, I don't think so. >> >> OVMF includes CpuS3DataDxe with SMM_REQUIRE=TRUE only. My understanding >> is that the reporter encountered the issue with CSM_ENABLE=TRUE, >> SMM_REQUIRE=FALSE. > >

Re: [edk2] Csm16.bin(seabios) failed to work in OVMF.

On Wed, 2016-05-04 at 13:27 +0200, Laszlo Ersek wrote: > > Hm, I don't think so. > > OVMF includes CpuS3DataDxe with SMM_REQUIRE=TRUE only. My understanding > is that the reporter encountered the issue with CSM_ENABLE=TRUE, > SMM_REQUIRE=FALSE. Of course, now we have SMM, perhaps we should rev

Re: [edk2] Csm16.bin(seabios) failed to work in OVMF.

On 05/04/16 06:44, Ni, Ruiyu wrote: > I encountered the same issue weeks ago. > A quick but dirty fix is to change: > UefiCpuPkg/CpuS3DataDxe/CpuS3Data.c: CpuS3DataInitialize() > // > // Allocate a 4KB reserved page below 1MB > // > - AcpiCpuData->StartupVector = BASE_1MB - 1; > + ApiCpuDat

Re: [edk2] [PATCH] MdeModulePkg: ScsiDiskDxe: cope with broken "Supported VPD Pages" VPD page

On 05/04/16 02:58, Tian, Feng wrote: > Laszlo, > > Could you explain more? > > Usb Flash drive is managed by UsbMassStorage driver, which is irrelevant with > UefiScsiLib lib or ScsiDisk driver. Yeah, sorry about missing that part of the context. So, the environment is the following: - The

[edk2] [PATCH v1 1/1] NetworkPkg:HttpDxe: Code changes to support HTTP PUT/POST operations

Code changes enables HttpDxe to handle PUT/POST operations. EfiHttpRequest assumes "Request" and "HttpMsg->Headers" can never be NULL. Also, HttpResponseWorker assumes HTTP Reponse will contain headers. We could have response which could contain only a string (HTTP 100 Continue) and no headers. Cod

[edk2] [PATCH] NetworkPkg: Discard TCP segment when no TCB found

The TCP driver should discard(ignore) the incoming TCP segment when there's no TCB found to handle it, because that TCP segment may be subjected to be received by other running Managed Network instance with it's own network stack to handle it. Force sending reset segment in this case would just dis

[edk2] [PATCH v1 1/1] MdeModulePkg:DxeHttpLib: Add checks in HttpGenRequestMessage API

HttpGenRequestMessage assumes that HTTP message would always contain a request-line, headers and an optional message body. However, subsequent to a HTTP PUT/POST request, HTTP requests would contain just the message body. This patch supports creation of such request messages with additional checks.

[edk2] [PATCH v2] MdeModulePkg: Refine SNP driver's media status check logic.

V2 Update: Refine variable and function description per Ye, Ting's comments. Some UNDI drivers may not support the cable detect in UNDI INITIALIZE command, but support the media present check in UNDI GET_STATUS command. Current SNP driver will set the MediaPresentSupported field to FALSE in EFI_S

Re: [edk2] [PATCH] MdeModulePkg NvmExpressDxe: Initialize IoAlign info for an NVMe device

Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Wu, Hao A Sent: Wednesday, May 4, 2016 4:29 PM To: edk2-devel@lists.01.org; Tian, Feng Cc: Wu, Hao A Subject: [PATCH] MdeModulePkg NvmExpressDxe: Initialize IoAlign info for an NVMe device The "IoAlign" field in EFI_BLOCK_I

[edk2] [PATCH] MdeModulePkg NvmExpressDxe: Initialize IoAlign info for an NVMe device

The "IoAlign" field in EFI_BLOCK_IO_MEDIA of an NVMe device is not initialized properly, leading to a zero value for this field. It should be initialized from the "IoAlign" field in the EFI_NVM_EXPRESS_PASS_THRU_MODE structure maintained by the NVMe controller. Contributed-under: TianoCore Contri

Re: [edk2] [Patch] MdeModulePkg: Refine SNP driver's media status check logic.

Siyuan, Some minor comments to the patch: 1. + // Whether UNDI support cable detect for INITIALIZE command, // i.e. + PXE_STATFLAGS_CABLE_DETECT_NOT_SUPPORTED Suggest to also include PXE_STATFLAGS_CABLE_DETECT_SUPPORTED if uses "i.e." here. 2. In the function header of PxeGetStatus(), there

[edk2] [patch] MdeModulePkg/HiiDatabaseDxe: Fix memory leak issues in HiiDatabaseDxe

Cc: Qiu Shumin Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Reviewed-by: Eric Dong --- .../Universal/HiiDatabaseDxe/ConfigRouting.c| 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/U

Re: [edk2] [Patch] MdeModulePkg FileExplorerLib: Add UefiHiiServicesLib dependency.

Reviewed-by: Liming Gao > -Original Message- > From: Dong, Eric > Sent: Wednesday, May 04, 2016 2:28 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [Patch] MdeModulePkg FileExplorerLib: Add UefiHiiServicesLib > dependency. > > FileExplorerLib depends on UefiHiiServicesLib

Re: [edk2] [PATCH v2] NetworkPkg: Use UefiBootManagerLib API to create load option.

Reviewed-by: Ye Ting -Original Message- From: Fu, Siyuan Sent: Wednesday, May 04, 2016 1:58 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Wu, Jiaxin ; Ni, Ruiyu Subject: [PATCH v2] NetworkPkg: Use UefiBootManagerLib API to create load option. V2: Remove unnecessary ZeroMem and free

Re: [edk2] Two PCI IO protocols getting produced by same GUID, how to open correct one?

-Original Message- From: af...@apple.com [mailto:af...@apple.com] Sent: Tuesday, May 03, 2016 9:44 PM To: Mike Kinney Cc: Shaveta Leekha ; Laszlo Ersek ; edk2-devel@lists.01.org Subject: Re: [edk2] Two PCI IO protocols getting produced by same GUID, how to open correct one? > On Ma

Re: [edk2] Two PCI IO protocols getting produced by same GUID, how to open correct one?

Thanks for the reply My replies are in-lined. Thanks and Regards, Shaveta -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Kinney, Michael D Sent: Tuesday, May 03, 2016 9:29 PM To: Shaveta Leekha ; Laszlo Ersek ; Kinney, Michael D Cc: edk2-devel

[edk2] [staging/HTTPS-TLS][PATCH] NetworkPkg: Handle HTTPS indefinite poll case

This patch is used to handle handle HTTPS indefinite poll case. Cc: El-Haj-Mahmoud Samer Cc: Ye Ting Cc: Fu Siyuan Cc: Long Qin Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiaxin Wu --- NetworkPkg/HttpDxe/HttpImpl.c | 55 ++ Network