[edk2] [PATCH] MdeModulePkg: FileExplorerLib: prevent freeing null pointer

when there's no volume label 'Info' can be NULL --- MdeModulePkg/Library/FileExplorerLib/FileExplorer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Library/FileExplorerLib/FileExplorer.c b/MdeModulePkg/Library/FileExplorerLib/FileExplorer.c index

Re: [edk2] [PATCH v4 0/2] Report ACPI NFIT for reserved memory RAM disks

Laszlo, My review on v4 was for the series (since the issues I had in the previous versions got addressed in v4). But I agree, we are missing the MdeModulePkg maintainers review. Feng, Star, Can you please help review this series that is back form 4/28? Thanks, --Samer -Original

Re: [edk2] [Patch] ShellPkg: Add argument to set block size for tftp command.

Why write the function UintnToAscDec to convert UINTN to ascii string? PrintLib can do that for you. Reviewed-by: Jaben Carsey > -Original Message- > From: Fu, Siyuan > Sent: Thursday, May 05, 2016 7:33 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben

Re: [edk2] [PATCH 1/7] CorebootPayloadPkg/PlatformHelperLib: Remove unreferenced function

Hi Laszlo, The error seems to be related to a missing PCD value and a reference to SecStartup which are unrelated to this patch. See the portion of the log below. Lee Leahy (425) 881-4919 Intel Corporation Suite 125 2700 - 156th Ave NE Bellevue, WA 98007-6554 "ld" -o

[edk2] [PATCH 4/4] EmbeddedPkg/Lan9118Dxe: remove redundant stalls

Now that the LAN9118-specific MMIO accessors provide the required delays, remove the redundant stalls. Stalls in delay loops are kept, as these give time for work to happen beyond synchronisation of the device register file. Cc: Ard Biesheuvel Cc: Leif Lindholm

[edk2] [PATCH 3/4] EmbeddedPkg/Lan9118Dxe: Use LAN9118 MMIO wrappers

Migrate the existing code to use the new LAN9118 MMIO wrappers, ensuring that timing requirements are respected. The newly redundant stalls will be removed in a subsequent patch. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Ryan Harkin

[edk2] [PATCH 2/4] EmbeddedPkg/Lan9118Dxe: add LAN9118 MMIO wrappers

As described in the LAN9118 datasheet, delays are necessary after some reads and writes in order to ensure subsequent reads do not see stale data. This patch adds helpers to provide these delays automatically, by performing dummy reads of the BYTE_TEST register (as recommended in the LAN9118

[edk2] [PATCH 0/4] EmbeddedPkg/Lan9118Dxe MMIO fixes

The LAN9118 driver uses memory fences in a novel but erroneous fashion, due to a misunderstanding of some under-commented code. This series fixes these erroneous uses, documenting the unusual requirements of the LAN9118 chip that lead us to this situation, and introduces new helpers to handle this

[edk2] [PATCH 1/4] Revert "EmbeddedPkg/Lan9118Dxe: use MemoryFence"

Commit a4626006bbf86113 ("EmbeddedPkg/Lan9118Dxe: use MemoryFence") replaced some stalls with memory fences, on the presumption that these were erroneously being used to order memory accesses. However, this was not the case. LAN9118 devices require a timing delay between state-changing

Re: [edk2] [PATCH v4 0/2] Report ACPI NFIT for reserved memory RAM disks

On 05/06/16 17:41, El-Haj-Mahmoud, Samer wrote: > What is the status of this series? It got reviewed a while ago, Where? I can only find my own review for v4 2/2, and your review for v4 0/2. But, patch #1 doesn't even seem to be part of the v4 posting (!), plus I can't find reviews from

Re: [edk2] [PATCH v4 0/2] Report ACPI NFIT for reserved memory RAM disks

What is the status of this series? It got reviewed a while ago, but it still not committed. From: El-Haj-Mahmoud, Samer Sent: Thursday, April 28, 2016 10:30 PM To: edk2-devel@lists.01.org; ler...@redhat.com; jordan.l.jus...@intel.com; hao.a...@intel.com Cc: hao.a...@intel.com Subject: RE:

Re: [edk2] [PATCH v1 1/1] NetworkPkg:HttpDxe: Code changes to support HTTP PUT/POST operations

Hi Siyuan, For PUT/POST requests, we would first have a request-response pair, following which we would do request calls with just message body till we are done with the upload file, without calling a response. So, we cannot treat NetMapIsEmpty as an error in HttpResponseWorker. I have added

Re: [edk2] [PATCH 00/13] ArmVirtPkg: move to MdeModulePkg BDS

On 5 May 2016 at 21:22, Laszlo Ersek wrote: > Based on Ray's recent patches for OvmfPkg, and what I learned from them. > > Fixes: . > > Public branch: > . > > I'm

Re: [edk2] [Patch] SecurityPkg: Cleanup unused structure definition

Reviewed-by: Fu Siyuan > -Original Message- > From: Wu, Jiaxin > Sent: Friday, May 6, 2016 2:20 PM > To: edk2-devel@lists.01.org > Cc: Zhang, Chao B ; Ye, Ting ; > Fu, Siyuan > Subject: [Patch]

Re: [edk2] [Patch] SecurityPkg: Cleanup unused structure definition

Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Wu, Jiaxin Sent: Friday, May 06, 2016 2:20 PM To: edk2-devel@lists.01.org Cc: Zhang, Chao B; Ye, Ting; Fu, Siyuan Subject: [Patch] SecurityPkg: Cleanup unused structure

[edk2] [Patch] SecurityPkg: Cleanup unused structure definition

This patch is used to cleanup unused structure definition. Cc: Zhang Chao B Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiaxin Wu ---