Re: [edk2] [PATCH] BaseTools: Add HII definitions from UEFI 2.6

2016-05-15 Thread Zhu, Yonghong
Hi Samer, I will remove the Trailing whitespace and push this patch. Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Bi, Dandan Sent: Thursday, May 12, 2016 11:27 AM To: Samer El-Haj-Mahmoud

Re: [edk2] [Patch] MdeModulePkg: Refine the code for DxeHttpLib

2016-05-15 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jiaxin Wu > Sent: Monday, May 16, 2016 11:47 AM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan

Re: [edk2] [PATCH 1/2] BootMaintenanceManagerUiLib: make gHiiDriverList STATIC

2016-05-15 Thread Gary Lin
On Mon, May 16, 2016 at 12:24:26PM +0800, Gary Lin wrote: > Make gHiiDriverList STATIC to avoid conflicting with the other > gHiiDriverList in MdeModulePkg/UiApp so that the linker won't > complain multiple definition of `gHiiDriverList'. > I just found Laszlo already sent the fixes. Please

[edk2] [PATCH 2/2] MdeModulePkg UiApp: make gHiiDriverList STATIC

2016-05-15 Thread Gary Lin
Make gHiiDriverList STATIC to avoid conflicting with the other gHiiDriverList in BootMaintenanceManagerUiLib so that the linker won't complain multiple definition of `gHiiDriverList'. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gary Lin ---

[edk2] [PATCH 1/2] BootMaintenanceManagerUiLib: make gHiiDriverList STATIC

2016-05-15 Thread Gary Lin
Make gHiiDriverList STATIC to avoid conflicting with the other gHiiDriverList in MdeModulePkg/UiApp so that the linker won't complain multiple definition of `gHiiDriverList'. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gary Lin ---

[edk2] [Patch] MdeModulePkg: Refine the code for DxeHttpLib

2016-05-15 Thread Jiaxin Wu
Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiaxin Wu --- MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff

Re: [edk2] [PATCH 0/2] Fix GCC build failures introduced with a85be3ae48a8

2016-05-15 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, May 13, 2016 5:51 PM > To: edk2-devel-01 > Cc: Ard Biesheuvel; Dong, Eric; Gerd Hoffmann; Gao, Liming > Subject: [PATCH 0/2] Fix GCC build failures introduced

Re: [edk2] [PATCH 0/2] add '!include' support to tools_def.txt parser

2016-05-15 Thread Gao, Liming
Does it support the relative path? > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Michael Zimmermann > Sent: Saturday, May 14, 2016 5:49 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH 0/2] add '!include'

Re: [edk2] [BaseTools] Does PACKAGES_PATH support !include ?

2016-05-15 Thread Gao, Liming
Andrew: I add the case to !include StdLib/StdLib.inc in Nt32Pkg.dsc, and I configure PACKAGES_PATH. It can build pass. There is no error. Here is my tree layout. Could you share your tree layout that expose this issue? Root -->edk2-BaseTools-win32 -->edk2 -->Conf -->Build set WORKSPACE=ROOT

Re: [edk2] [Patch 0/3] Fix BTS feature check issue

2016-05-15 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Friday, May 13, 2016 5:15 PM To: Kinney, Michael D ; edk2-de...@ml01.01.org Subject: Re: [edk2] [Patch 0/3] Fix BTS feature check issue On

Re: [edk2] [PATCH] MdePkg: remove Libray references from code base

2016-05-15 Thread Gao, Liming
Reviewed-by: Liming Gao From: Michael Zimmermann [mailto:sigmaepsilo...@gmail.com] Sent: Sunday, May 15, 2016 3:18 PM To: edk2-devel@lists.01.org ; Kinney, Michael D ; Gao, Liming Subject: [edk2]

Re: [edk2] [PATCH 0/2] Fix GCC build failures introduced with a85be3ae48a8

2016-05-15 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, May 13, 2016 5:51 PM > To: edk2-devel-01 > Cc: Ard Biesheuvel ; Dong, Eric > ; Gerd

Re: [edk2] [PATCH v4] SecurityPkg/DxeImageVerificationLib: Add DEBUG messages for image verification failures

2016-05-15 Thread Zhang, Chao B
Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Cinnamon Shia [mailto:cinnamon.s...@hpe.com] Sent: Friday, May 13, 2016 12:25 PM To: edk2-devel@lists.01.org Cc: ler...@redhat.com; samer.el-haj-mahm...@hpe.com; Zhang, Chao B;

Re: [edk2] [PATCH] Emulator Pkg Assert at "Bad signature"

2016-05-15 Thread Jordan Justen
Refer to EmulatorPkg/Contributions.txt for Signed-off-by/Contributed-under. Do you have your full name set with git config user.name? For example, I use: git config --global user.name "Jordan Justen" If you update your user.name or user.email settings, then you can fix the commit author with:

Re: [edk2] a minor logic error in PcAtChipsetPkg\Library\AcpiTimerLib\AcpiTimerLib.c

2016-05-15 Thread Zeng, Star
The patch has been pushed at dde4aedc35ee3c06b67c1a5c4f392e7a0b0f8254. Thanks for the contribution. Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of wang xiaofeng Sent: Friday, May 13, 2016 10:56 AM To: Zeng, Star Cc:

[edk2] [PATCH] Emulator Pkg Assert at "Bad signature"

2016-05-15 Thread Pedroa
--- EmulatorPkg/EmuGopDxe/GopInput.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/EmulatorPkg/EmuGopDxe/GopInput.c b/EmulatorPkg/EmuGopDxe/GopInput.c index a1f636a..505f340 100644 --- a/EmulatorPkg/EmuGopDxe/GopInput.c +++ b/EmulatorPkg/EmuGopDxe/GopInput.c @@ -389,7

[edk2] [PATCH] ShellPkg if user press "shift" key under shell command line that have incorrect behavior

2016-05-15 Thread Pedroa
when the user press "shift" key , the shell core read the data from STDIN and thought that a bad value so it resume then reset the position of the cursor and keep waiting for user input. if use "ReadKeyStroke" function to read STDIN when it read a "shift" key ,it would return a value

[edk2] [PATCH] MdePkg: remove Libray references from code base

2016-05-15 Thread Michael Zimmermann
as reported on github: https://github.com/tianocore/edk2/issues/79 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Zimmermann --- .../PeiDxePostCodeLibReportStatusCode.inf | 4 ++--