Re: [edk2] [Patch] BaseTools: support private package definition

2016-05-16 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: Zhu, Yonghong Sent: Tuesday, May 10, 2016 6:17 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [Patch] BaseTools: support private package definition EDKII build spec and DEC spec updated to support private package definition. If

[edk2] [Patch] BootMaintenanceManagerUiLib: Rollback changes for BootNext.

2016-05-16 Thread Eric Dong
Commit a85be3ae48a8aaa40b755cd0ff7270c67cfed585 imports errors for BootNext question, this patch rollback the related changes. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong Cc: Liming Gao --- .../BootMaintenanceManagerCustomizedUiSupport.c| 65

Re: [edk2] [patch] MdeModulePkg/UiApp: Enhance the error handling

2016-05-16 Thread Qiu, Shumin
Reviewed-by: Qiu Shumin -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan Bi Sent: Tuesday, May 17, 2016 1:41 PM To: edk2-devel@lists.01.org Cc: Qiu, Shumin; Dong, Eric Subject: [edk2] [patch] MdeModulePkg/UiApp: Enhance the error handling W

Re: [edk2] [Patch] BaseTools/GenFds: enhance to get TOOL_CHAIN_TAG and TARGET value

2016-05-16 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Zhu, Yonghong > Sent: Wednesday, May 11, 2016 9:17 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [Patch] BaseTools/GenFds: enhance to get TOOL_CHAIN_TAG and > TARGET value > > when user don't set TOOL_CHAIN_TAG and TAR

[edk2] [patch] MdeModulePkg/UiApp: Enhance the error handling

2016-05-16 Thread Dandan Bi
When the parameter is unsupported or invalid, should exit the function. Cc: Qiu Shumin Cc: Eric Dong Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi Reviewed-by: Eric Dong --- MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupport.c | 2 ++ 1 file changed

Re: [edk2] [PATCH 1/6] MdeModulePkg: Terminate two unterminated VA_COPYs in CheckRemainingSpaceForConsistencyInternal()

2016-05-16 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Zenith432 > Sent: Monday, May 16, 2016 11:49 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH 1/6] MdeModulePkg: Terminate two unterminated > VA_COPYs in CheckR

Re: [edk2] [PATCH 2/6] MdePkg: Reinitialize twice-iterated VA_LIST in variadic function UefiDevicePathLibCatPrint()

2016-05-16 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Zenith432 > Sent: Monday, May 16, 2016 11:50 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH 2/6] MdePkg: Reinitialize twice-iterated VA_LIST in > variadic fun

Re: [edk2] [PATCH 4/6] BaseTools: Eliminate two shift-negative-value in FvLib.c

2016-05-16 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Zenith432 > Sent: Monday, May 16, 2016 11:52 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH 4/6] BaseTools: Eliminate two shift-negative-value in > FvLib.c >

Re: [edk2] [Patch] MdeModulePkg UiApp: Add "Enter Setup" status code.

2016-05-16 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Dong, Eric > Sent: Tuesday, May 17, 2016 10:12 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [Patch] MdeModulePkg UiApp: Add "Enter Setup" status code. > > The original BdsDxe driver has "Enter Setup" status code > whi

Re: [edk2] [PATCH 0/2] Fix GCC build failures introduced with a85be3ae48a8

2016-05-16 Thread Gao, Liming
Laszlo: I push these two patches at 17da28~7b1351. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, May 13, 2016 5:51 PM > To: edk2-devel-01 > Cc: Ard Biesheuvel ; Dong, Eric > ; Gerd Hoffmann ; Gao, Liming > > Subject: [PATCH 0/2] Fix GCC build fai

[edk2] [Patch] MdeModulePkg UiApp: Add "Enter Setup" status code.

2016-05-16 Thread Eric Dong
The original BdsDxe driver has "Enter Setup" status code while current code not. This patch restores it. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong Cc: Liming Gao --- MdeModulePkg/Application/UiApp/FrontPage.c | 8 1 file changed, 8 insertions(+)

[edk2] [Patch 0/4] MdeModulePkg/PciBus Do not improperly degrade resource

2016-05-16 Thread Ruiyu Ni
The patch serials refined the PciBus code and adds a new feature following PI spec 1.4a to not improperly degrade resource. Ruiyu Ni (4): MdeModulePkg/PciBus: use better name for local variables. MdeModulePkg/PciBus: Remove unused fields in PCI_BAR MdeModulePkg/PciBus: Use shorter global var

[edk2] [Patch 2/4] MdeModulePkg/PciBus: Remove unused fields in PCI_BAR

2016-05-16 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jeff Fan --- MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.h | 4 +--- MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 3 +-- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/MdeModule

[edk2] [Patch 3/4] MdeModulePkg/PciBus: Use shorter global variable name

2016-05-16 Thread Ruiyu Ni
Remove "Efi" from gEfiIncompatiblePciDeviceSupport to shorten the global variable name. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jeff Fan --- MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.c| 6 +++--- MdeModulePkg/Bus/Pci/PciBusDxe/PciBus.h

[edk2] [Patch 1/4] MdeModulePkg/PciBus: use better name for local variables.

2016-05-16 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jeff Fan --- .../Bus/Pci/PciBusDxe/PciResourceSupport.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciResourceSupport.c b/

[edk2] [Patch 4/4] MdeModulePkg/PciBus: do not improperly degrade resource

2016-05-16 Thread Ruiyu Ni
PciBus driver originally always degrade (64->32) the MMIO resource for PCI BAR when the PCI device contains option ROM. But the degrade causes the PCI device can only use resource below 4GB which makes the resource allocation fails when the PCI device wants very big MMIO. The patch follows the PI s

Re: [edk2] [patch] MdeModulePkg/SetupBrowser: Clean the BufferValue for string before use

2016-05-16 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Bi, Dandan > Sent: Thursday, May 12, 2016 2:23 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Dong, Eric > Subject: [patch] MdeModulePkg/SetupBrowser: Clean the BufferValue for > string before use > > When copy new string conten

Re: [edk2] [staging/branch]: RISC-V

2016-05-16 Thread Yao, Jiewen
Hi Abner Thanks. There are some typo on the readme.md accroding => according deisgned => designed With typo fixed, reviewed-by: jiewen@intel.com Thank you Yao Jiewen > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Abner Chang > Sent: M

Re: [edk2] [PATCH] Emulator Pkg Assert at "Bad signature"

2016-05-16 Thread Jordan Justen
Reviewed-by: Jordan Justen I found one more case that needed the same update. I pushed your patch as 8b3ccf1. Thanks! -Jordan On 2016-05-16 17:51:33, Pedroa wrote: > OK ,have done. > > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Pedroa Liu > --- > EmulatorPkg

Re: [edk2] [PATCH] ShellPkg if user press "shift" key under shell command line that have incorrect behavior

2016-05-16 Thread Qiu, Shumin
Reviewed-by: Qiu Shumin From: Pedroa [mailto:pedroa@insyde.com] Sent: Monday, May 16, 2016 9:18 PM To: edk2-devel-01 Cc: Qiu, Shumin; Carsey, Jaben Subject: Re: [edk2][PATCH] ShellPkg if user press "shift" key under shell command line that have incorrect behavior if 'ReadKeyStroke' function

Re: [edk2] [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add SMRR PhysBase/PhysMask fields check

2016-05-16 Thread Yao, Jiewen
Reviewed by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Michael Kinney > Sent: Tuesday, May 17, 2016 4:40 AM > To: edk2-devel@lists.01.org > Cc: Tian, Feng ; Yao, Jiewen ; > Fan, Jeff > Subject: [edk2] [Patch] UefiC

Re: [edk2] [PATCH] Emulator Pkg Assert at "Bad signature"

2016-05-16 Thread Pedroa
OK ,have done. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Pedroa Liu --- EmulatorPkg/EmuGopDxe/GopInput.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/EmulatorPkg/EmuGopDxe/GopInput.c b/EmulatorPkg/EmuGopDxe/GopInput.c index a1f636a..505f340 10

Re: [edk2] [PATCH] CorebootPayloadPkg: Use generic PciBus/PciHostBridge driver

2016-05-16 Thread Leahy, Leroy P
Please hold off on this patch until the one for MdeModulePkg is merged Lee Leahy (425) 881-4919 Intel Corporation Suite 125 2700 - 156th Ave NE Bellevue, WA 98007-6554 -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Maurice Ma Sent: Monday,

Re: [edk2] [PATCH] MdeModulePkg: Skip invalid bus number scanning in PciBusDxe driver

2016-05-16 Thread Leahy, Leroy P
Reviewed-by: Lee Leahy Lee Leahy (425) 881-4919 Intel Corporation Suite 125 2700 - 156th Ave NE Bellevue, WA 98007-6554 -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Maurice Ma Sent: Monday, May 16, 2016 2:26 PM To: edk2-devel@lists.01.org Cc:

Re: [edk2] [BaseTools] Does PACKAGES_PATH support !include ?

2016-05-16 Thread Gao, Liming
Andrew: To be consisted with system PATH style in windows and linux, we choose to use : in windows, and : in linux. For error handing, I agree to enhance BaseTools report the meaning warning if the path in PACKAGES_PATH doesn't exist. Thanks Liming > -Original Message- > From: af.

[edk2] [PATCH] CorebootPayloadPkg: Use generic PciBus/PciHostBridge driver

2016-05-16 Thread Maurice Ma
Current CorebootPayloadPkg uses PciBusNoEnumerationDxe and PciRootBridgenoEnumerationDxe copied from the DuetPkg. Now it will switch to use the standard PciBusDxe and PciHostBridgeDxe from MdeModulePkg. As a result, a coreboot specific PciHostBridgeLib is added to collect pre-allocated PCI resource

[edk2] PcRtcAcpiTableChangeCallback question

2016-05-16 Thread Anbazhagan, Baraneedharan
Hi, PcRtcAcpiTableChangeCallback doesn't seem to be called if gEfiAcpiTableGuid or gEfiAcpi10TableGuid is already installed before PcRtc module gets loaded. Whether ACPI table Guid can be checked in system configuration table and then register a callback if it's not available or register a sing

[edk2] [PATCH] MdeModulePkg: Skip invalid bus number scanning in PciBusDxe driver

2016-05-16 Thread Maurice Ma
When PcdPciDisableBusEnumeration is enabled, the PciBus driver might get into a dead loop if the secondary bus register on PCI bridge is not programmed or programmed improperly. Adding this check to avoid any potential dead loop caused by this. Cc: Feng Tian Cc: Star Zeng Contributed-under: Tian

[edk2] [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add SMRR PhysBase/PhysMask fields check

2016-05-16 Thread Michael Kinney
From: Jeff Fan SMRR range size and alignment should follow the rules like MTRR: a. The minimum range size is 4 KBytes and the base address of the range must be on at least a 4-KByte boundary. b. For ranges greater than 4 KBytes, each range must be of length 2^n and its base address must be

Re: [edk2] [BaseTools] Does PACKAGES_PATH support !include ?

2016-05-16 Thread Andrew Fish
> On May 16, 2016, at 9:56 AM, Andrew Fish wrote: > >> >> On May 16, 2016, at 6:55 AM, Andrew Fish wrote: >> >> >>> On May 15, 2016, at 11:48 PM, Gao, Liming wrote: >>> >>> PACKAGES_PATH >> >> It seems to depend on sequence? I'm using master non Windows so running the >> Python directly.

Re: [edk2] [BaseTools] Does PACKAGES_PATH support !include ?

2016-05-16 Thread Andrew Fish
> On May 16, 2016, at 6:55 AM, Andrew Fish wrote: > > >> On May 15, 2016, at 11:48 PM, Gao, Liming wrote: >> >> PACKAGES_PATH > > It seems to depend on sequence? I'm using master non Windows so running the > Python directly. I just moved StdLib and MdeModulePkg > Liming, I think I figure

[edk2] [PATCH 3/6] OvmfPkg: Duplicate twice-iterated VA_LIST passed as argument to XenStoreVSPrint()

2016-05-16 Thread Zenith432
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zenith432 --- OvmfPkg/XenBusDxe/XenStore.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/OvmfPkg/XenBusDxe/XenStore.c b/OvmfPkg/XenBusDxe/XenStore.c index 61976f9..aea887b 100644 --- a/OvmfPkg/XenBusD

[edk2] [PATCH 6/6] IntelFrameworkModulePkg: Eliminate indirection of null pointer in LegacyBiosInt86()

2016-05-16 Thread Zenith432
The replaced code is a legitimate attempt to index an array based at address zero in x86 real-mode. However, ISO C (both C89 and C99) consider dereferencing a null pointer in this manner to be undefined behavior - which is therefore not portable. Most compilers seem to generate working code for t

[edk2] [PATCH 5/6] DuetPkg: Eliminate indirection of null pointer in LegacyBiosInt86()

2016-05-16 Thread Zenith432
The replaced code is a legitimate attempt to index an array based at address zero in x86 real-mode. However, ISO C (both C89 and C99) consider dereferencing a null pointer in this manner to be undefined behavior - which is therefore not portable. Most compilers seem to generate working code for t

[edk2] [PATCH 4/6] BaseTools: Eliminate two shift-negative-value in FvLib.c

2016-05-16 Thread Zenith432
clang 3.8 flags -Wshift-negative-value warning, which turns fatal due to use of -Werror. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zenith432 --- BaseTools/Source/C/Common/FvLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source

[edk2] [PATCH 2/6] MdePkg: Reinitialize twice-iterated VA_LIST in variadic function UefiDevicePathLibCatPrint()

2016-05-16 Thread Zenith432
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zenith432 --- MdePkg/Library/UefiDevicePathLib/DevicePathToText.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c b/MdePkg/Library/UefiDevicePathLib/DevicePathToText.c

[edk2] [PATCH 1/6] MdeModulePkg: Terminate two unterminated VA_COPYs in CheckRemainingSpaceForConsistencyInternal()

2016-05-16 Thread Zenith432
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zenith432 --- MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c b/MdeModulePkg/Universal/Variable/RuntimeDxe/Vari

[edk2] Nevermind (Re: a85be3ae breaks OVMF build on Linux)

2016-05-16 Thread Gabriel L. Somlo
On Mon, May 16, 2016 at 11:39:40AM -0400, Gabriel L. Somlo wrote: > I build OVMF on Linux (F20 specifically) with the following command: > > build -a X64 -t GCC49 -p OvmfPkg/OvmfPkgX64.dsc > > Following commit a85be3ae (BootMaintenanceManagerUiLib: change code > for customization), the bui

[edk2] a85be3ae breaks OVMF build on Linux

2016-05-16 Thread Gabriel L. Somlo
I build OVMF on Linux (F20 specifically) with the following command: build -a X64 -t GCC49 -p OvmfPkg/OvmfPkgX64.dsc Following commit a85be3ae (BootMaintenanceManagerUiLib: change code for customization), the build breaks with the following error: /home/somlo/KVM-OSX/SCRATCH/edk2/MdeModu

Re: [edk2] [BaseTools] Does PACKAGES_PATH support !include ?

2016-05-16 Thread Andrew Fish
> On May 15, 2016, at 11:48 PM, Gao, Liming wrote: > > PACKAGES_PATH It seems to depend on sequence? I'm using master non Windows so running the Python directly. I just moved StdLib and MdeModulePkg ~/work/src/edk2/ BaseTools Conf edk2/StdLib edk22/MdeModulePkg Added !include

Re: [edk2] [PATCH] ShellPkg if user press "shift" key under shell command line that have incorrect behavior

2016-05-16 Thread Pedroa
if 'ReadKeyStroke' function return EFI_NOT_READY then skip it, but if the return value is EFI_DEVICE_ERROR ,empty the currentString buffer. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Pedroa Liu --- ShellPkg/Application/Shell/FileHandleWrappers.c | 6 ++ 1 file ch

Re: [edk2] [Patch] SecurityPkg: Use PcdGet32() to access PcdPeiCoreMaxFvSupported

2016-05-16 Thread Zhang, Chao B
Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Gao, Liming Sent: Monday, May 16, 2016 3:35 PM To: edk2-devel@lists.01.org Cc: Zhang, Chao B Subject: [Patch] SecurityPkg: Use PcdGet32() to access PcdPeiCoreMaxFvSupported FixedPcdGet32() limits Pcd

[edk2] [staging/branch]: RISC-V

2016-05-16 Thread Abner Chang
Create a new branch (RISC-V) on edk2-stanging for RISC-V edk2 port. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Abner Chang --- Readme.MD | 20 1 file changed, 20 insertions(+) create mode 100644 Readme.MD diff --git a/Readme.MD b/Readme.MD new f

[edk2] [Patch] SecurityPkg: Use PcdGet32() to access PcdPeiCoreMaxFvSupported

2016-05-16 Thread Liming Gao
FixedPcdGet32() limits PcdPeiCoreMaxFvSupported type as FixedAtBuild. PcdGet32() allows PCD be configured as FixedAtBuild or PatchableInModule. Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 10 +-