[edk2] Driver dependency on boot

2016-05-18 Thread Iru Cai
Hi, I'm having some dependency problem when developing on edk2. I've written a CCID device driver which provides a protocol EFI_CCID_PROTOCOL with GUID gEfiCcidProtocolGuid. And I have another application called ccidboot to be run on boot that uses gEfiCcidProtocolGuid, I set the module type as DX

Re: [edk2] edk2-staging/HTTPS-TLS

2016-05-18 Thread Long, Qin
Personally, I prefer to use the second option for this kind of sync-up. Of cause, we need to have good senses about which updates will impact this staging feature. Best Regards & Thanks, LONG, Qin > -Original Message- > From: Wu, Jiaxin > Sent: Thursday, May 19, 2016 11:35 AM > To: El

Re: [edk2] HTTP Boot crashed when downloading remote image

2016-05-18 Thread Gary Lin
On Thu, May 19, 2016 at 02:11:34AM +, Wu, Jiaxin wrote: > Thanks Gary. We also found that if TCP CompletionToken is not signaled, it > should not be closed directly by calling CloseEvent after timeout > happened(Still in the TCP RcvTokenList). If not, any exception behavior may > be triggere

[edk2] [patch] NetworkPkg: Refine codes of Http boot driver.

2016-05-18 Thread Zhang Lubo
When downloading a big image as ram disk iso,we can print the progress message on screen to enhance the user experience. Cc: Ye Ting Cc: Fu Siyuan Cc: Wu Jiaxin Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo --- NetworkPkg/HttpBootDxe/HttpBootClient.c | 29

Re: [edk2] Acquire the permission to commit code in edk2-staging tree

2016-05-18 Thread Jordan Justen
On 2016-05-18 18:13:18, Gao, Liming wrote: > Jordan and Mike: > For new package and platform, I think we can grant access to new > owner. Do you think so? > When discussing the staging process, I thought that staging branches would have package maintainer sponsors that would own sync'ing upda

[edk2] [PATCH 2/2] NetworkPkg/TcpDxe: Remove the status check of SockProcessRcvToken

2016-05-18 Thread Gary Lin
SockProcessRcvToken only returns the number of the received bytes, not an EFI Status. Cc: "Siyuan Fu" Cc: "Jiaxin Wu" Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gary Lin --- NetworkPkg/TcpDxe/SockInterface.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-)

[edk2] [PATCH 1/2] NetworkPkg/HttpDxe: Don't free Wrap in HttpTcpReceiveNotifyDpc

2016-05-18 Thread Gary Lin
The HTTP Token Wrap is created in EfiHttpResponse() and then passed to the deferred Receive event callback, HttpTcpReceiveNotifyDpc. HttpTcpReceiveHeader and HttpTcpReceiveBody use a Tcp polling loop to monitor the socket status and trigger the Receive event when a new packet arrives. The Receive e

Re: [edk2] edk2-staging/HTTPS-TLS

2016-05-18 Thread Wu, Jiaxin
Hi all, There are two ways to sync HTTPS-TLS branch with EDK2 master: 1. Sync all changes in EDK2 master to branch by rebasing the whole feature branch. Need frequency request to sync edk2-staging/master to latest edk2/master. This way can also keep branch code go straight with edk2/master. 2.

Re: [edk2] [RFC] Proposal to organize packages into directories

2016-05-18 Thread Lohr, Paul A
Hi Mike, I think it looks good! My only real comment is that I would like both Intel Framework PKGs to be in the deprecated area. Seems Jiewn offered the same comment. Paul A. Lohr - Server Firmware Enabling 512.239.9073 (cell) 512.794.5044 (work) -Original Message- From: edk2-devel

Re: [edk2] [PATCH] [MdePkg/BaseLib]: Remove overreaction to SourceLen in StrCpyS

2016-05-18 Thread Yao, Jiewen
Yes, that is good suggestion to avoid confusing in the future. I agree with you that we can add comment. 1) The StrXXXS is similar as C11 version strXXX_s. (8 APIs, 4 UNICODE version + 4 ASCII version) 2) No copying has occurred if the function returns an error Thank you Yao Jiewen

Re: [edk2] Using the Shell to launch a kernel using a RAMDISK

2016-05-18 Thread Tian, Feng
Samer, I am ok to add an item/option to allow user choose ramdisk memory type. But I don't know how to organize the form to show that straightforwardly, for example, how to add an item for those chosen by File Explorer. Look forward to see your patch:) Thanks Feng -Original Message- F

Re: [edk2] [Patch 2/2] PcAtChipsetPkg/PcRtc: get century RTC address in entry point

2016-05-18 Thread Ni, Ruiyu
Laszlo, My understanding is: you have concern why I only call GetCenturyRtcAddress() in RTC driver's entry point, but don't write the century value to CMOS. Is my understanding correct? Because RTC's entry point calls PcRtcInit(), which calls PcRtcSetTime(), which writes the century value to CMOS,

Re: [edk2] [PATCH] MdeModulePkg NvmExpressDxe: Add BlockIo2 support

2016-05-18 Thread Tian, Feng
Looks good to me Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Wu, Hao A Sent: Friday, May 6, 2016 4:01 PM To: edk2-devel@lists.01.org; Tian, Feng Cc: Wu, Hao A Subject: [PATCH] MdeModulePkg NvmExpressDxe: Add BlockIo2 support Together with EFI_BLOCK_IO_PROTOCOL, EFI_B

Re: [edk2] [PATCH v2 3/3] MdeModulePkg: Add NvmExpressLib.

2016-05-18 Thread Tian, Feng
Ok, I am not aware that you will contribute Firmware Management Protocol to EDKII. So this library will be used by EDKII NvmExpress driver. PS: We will check in NvmExpress non-blocking support to the repo soon. Hope it will not bring big merge issue to your patch. Thanks Feng -Original Mes

Re: [edk2] HTTP Boot crashed when downloading remote image

2016-05-18 Thread Wu, Jiaxin
Thanks Gary. We also found that if TCP CompletionToken is not signaled, it should not be closed directly by calling CloseEvent after timeout happened(Still in the TCP RcvTokenList). If not, any exception behavior may be triggered while more packets continue received but only timeout happened (do

Re: [edk2] HTTP Boot crashed when downloading remote image

2016-05-18 Thread Gary Lin
On Wed, May 18, 2016 at 01:54:24PM +, El-Haj-Mahmoud, Samer wrote: > Gary, > > The EDK2 list blocked the wireshark attachment. Can you put it on a share and > send a link please? We are trying to look at this internally as well. Hi Samer and Laszlo, I've found the root cause. I'll send a pat

Re: [edk2] [PATCH] OvmfPkg: prevent 64-bit MMIO BAR degradation if there is no CSM

2016-05-18 Thread Ni, Ruiyu
Laszlo, All are good except: can you use EfiCreateProtocolNotifyEvent() exposed by UefiLib? Regards, Ray >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo >Ersek >Sent: Thursday, May 19, 2016 6:13 AM >To: edk2-devel-01 >Cc: Ni, Ruiyu ; Ju

Re: [edk2] [PATCH] [Vlv2TbltDevicePkg] Update the core version string to UEFI 2.50.

2016-05-18 Thread Wei, David
I am OK with this patch. Reviewed-by: zwei4 Thanks, David Intel SSG BIOS -Original Message- From: Bruce Cran [mailto:br...@cran.org.uk] Sent: Thursday, May 19, 2016 3:27 AM To: edk2-devel@lists.01.org Cc: He, Tim ; Wei, David Subject: Re: [edk2] [PATCH] [Vlv2TbltDevicePkg] Upda

Re: [edk2] Filesystem installation issue on SATA HDD

2016-05-18 Thread Tian, Feng
Hi, Shaveta Which platform are you using? Where the BIOS code comes from? You may have to add some debug messages to your code to trace that. (You can add debug message to DiskIo.c to see if each DiskIo.Read() is successful or not) Thanks Feng -Original Message- From: Shaveta Leekha [m

Re: [edk2] [Patch 0/2] Save the Boot mode info for later use.

2016-05-18 Thread Dong, Eric
Please help to check in the code. > -Original Message- > From: Gao, Liming > Sent: Thursday, May 19, 2016 9:25 AM > To: Dong, Eric; edk2-devel@lists.01.org > Subject: RE: [edk2] [Patch 0/2] Save the Boot mode info for later use. > > Reviewed-by: Liming Gao > > -Original Message-

Re: [edk2] [Patch 0/2] Save the Boot mode info for later use.

2016-05-18 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric Dong Sent: Wednesday, May 18, 2016 1:13 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch 0/2] Save the Boot mode info for later use. In current code, we use differe

Re: [edk2] [Patch 0/3] Remove invalid keyword "bds" in UiApp related modules.

2016-05-18 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Eric Dong Sent: Wednesday, May 18, 2016 2:52 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch 0/3] Remove invalid keyword "bds" in UiApp related modules. In current cod

Re: [edk2] Acquire the permission to commit code in edk2-staging tree

2016-05-18 Thread Gao, Liming
Jordan and Mike: For new package and platform, I think we can grant access to new owner. Do you think so? Thanks Liming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chang, Abner (HPS SW/FW Technologist) Sent: Wednesday, May 18, 2016 12:01 PM

Re: [edk2] [Patch V3 2/2] QuarkSocPkg/SmmCpuFeaturesLib: Add SMRR PhysBase/PhysMask fields check

2016-05-18 Thread Fan, Jeff
Reviewed-by: Jeff Fan -Original Message- From: Kinney, Michael D Sent: Thursday, May 19, 2016 5:19 AM To: edk2-devel@lists.01.org Cc: Fan, Jeff; Yao, Jiewen; Tian, Feng Subject: [Patch V3 2/2] QuarkSocPkg/SmmCpuFeaturesLib: Add SMRR PhysBase/PhysMask fields check SMRR range size and al

Re: [edk2] [Patch V3 1/2] UefiCpuPkg/SmmCpuFeaturesLib: Add SMRR PhysBase/PhysMask fields check

2016-05-18 Thread Fan, Jeff
It looks better. Reviewed-by: Jeff Fan -Original Message- From: Kinney, Michael D Sent: Thursday, May 19, 2016 5:19 AM To: edk2-devel@lists.01.org Cc: Fan, Jeff; Yao, Jiewen; Tian, Feng Subject: [Patch V3 1/2] UefiCpuPkg/SmmCpuFeaturesLib: Add SMRR PhysBase/PhysMask fields check SMRR

Re: [edk2] [BaseTools] RuleOverride = BINARY code location?

2016-05-18 Thread Andrew Fish
> On May 18, 2016, at 5:43 PM, Gao, Liming wrote: > > Andrew: > |.bin will search the file with the postfix .bin in INF file directory and > its output directory. So, there may be more than .bin files are found. Please > see the code login in GetFileList() from > C:\R9Tip\edk2\BaseTools\Sour

Re: [edk2] [BaseTools] RuleOverride = BINARY code location?

2016-05-18 Thread Gao, Liming
Andrew: |.bin will search the file with the postfix .bin in INF file directory and its output directory. So, there may be more than .bin files are found. Please see the code login in GetFileList() from C:\R9Tip\edk2\BaseTools\Source\Python\GenFds\Section.py. Thanks Liming From: edk2-devel [ma

Re: [edk2] [PATCH 3/5] CorebootPayloadPkg: Add coreboot PlatfromBootManagerLib implementation

2016-05-18 Thread Leahy, Leroy P
Reviewed-by: Lee Leahy Does not impact Galileo Gen2. Lee Leahy (425) 881-4919 Intel Corporation Suite 125 2700 - 156th Ave NE Bellevue, WA 98007-6554 -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Maurice Ma Sent: Wednesday, May 18, 2016 2:2

Re: [edk2] [PATCH 2/5] CorebootModulePkg: Add video resolution PCD initialization

2016-05-18 Thread Leahy, Leroy P
Reviewed-by: Lee Leahy Does not impact Galileo Gen2. Lee Leahy (425) 881-4919 Intel Corporation Suite 125 2700 - 156th Ave NE Bellevue, WA 98007-6554 -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Maurice Ma Sent: Wednesday, May 18, 2016 2:1

Re: [edk2] [PATCH] [MdePkg/BaseLib]: Remove overreaction to SourceLen in StrCpyS

2016-05-18 Thread Palmer, Thomas
Hi Jiewen, Thank you for the good response. I will admit to not being familiar with the C11 spec. I had to search the web for appropriate documentation for strcpy_s. I am familiar with the strlcpy from BSD and so I was expecting that behavior. Having read about the C11 do

Re: [edk2] [PATCH 1/5] CorebootModulePkg: Convert TAB to white space for CbSupportDxe driver

2016-05-18 Thread Leahy, Leroy P
Reviewed-by: Lee Leahy Works on Galileo Gen2. Lee Leahy (425) 881-4919 Intel Corporation Suite 125 2700 - 156th Ave NE Bellevue, WA 98007-6554 -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Maurice Ma Sent: Wednesday, May 18, 2016 2:19 PM To:

[edk2] [Patch 2/7] UefiCpuPkg/PiSmmCpuDxeSmm: Move forward MP sync data initialization

2016-05-18 Thread Michael Kinney
From: Jeff Fan Move MP sync data initialization in front of the place that initialize page table, because the page fault spin lock is allocated in InitializeMpSyncData() while it is initialized in SmmInitPageTable(). Cc: Michael Kinney Cc: Feng Tian Contributed-under: TianoCore Contribution Ag

[edk2] [Patch 3/7] UefiCpuPkg/PiSmmCpuDxeSmm: Using global semaphores in aligned buffer

2016-05-18 Thread Michael Kinney
From: Jeff Fan Update all global semaphores to the ones in allocated aligned semaphores buffer. Cc: Michael Kinney Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan Reviewed-by: Feng Tian --- UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c | 10 +++---

[edk2] [Patch 7/7] UefiCpuPkg/PiSmmCpuDxeSmm: Using MSRs semaphores in aligned buffer

2016-05-18 Thread Michael Kinney
From: Jeff Fan Update MSRs semaphores to the ones in allocated aligned semaphores buffer. If MSRs semaphores is not enough, allocate one page more. Cc: Michael Kinney Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan Reviewed-by: Feng Tian --- Uef

[edk2] [Patch 4/7] UefiCpuPkg/PiSmmCpuDxeSmm: Allocate buffer for each CPU semaphores

2016-05-18 Thread Michael Kinney
From: Jeff Fan Allocate each CPU semaphores in allocated aligned semaphores buffer. And add it into semaphores structure. Cc: Michael Kinney Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan Reviewed-by: Feng Tian --- UefiCpuPkg/PiSmmCpuDxeSmm/MpS

[edk2] [Patch 5/7] UefiCpuPkg/PiSmmCpuDxeSmm: Using CPU semaphores in aligned buffer

2016-05-18 Thread Michael Kinney
From: Jeff Fan Update each CPU semaphores to the ones in allocated aligned semaphores buffer. Cc: Michael Kinney Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan Reviewed-by: Feng Tian --- UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 78 +

[edk2] [Patch 1/7] UefiCpuPkg/PiSmmCpuDxeSmm: Allocate buffer for global semaphores

2016-05-18 Thread Michael Kinney
From: Jeff Fan Get semaphores alignment/size requirement and allocate aligned buffer for all global spin lock and semaphores. Cc: Michael Kinney Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan Reviewed-by: Feng Tian --- UefiCpuPkg/PiSmmCpuDxeSmm

[edk2] [Patch 6/7] UefiCpuPkg/PiSmmCpuDxeSmm: Allocate buffer for MSRs semaphores

2016-05-18 Thread Michael Kinney
From: Jeff Fan Allocate MSRs semaphores in allocated aligned semaphores buffer. And add it into semaphores structure. Cc: Michael Kinney Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan Reviewed-by: Feng Tian --- UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c

[edk2] [Patch 0/7] Allocate aligned buffer for all semaphores

2016-05-18 Thread Michael Kinney
>From Intel(R) 64 and IA-32 Architectures Software Developer's Manual, one lock or semaphore is suggested to be present within a cache line. If the processors are based on Intel NetBurst microarchitecture, two cache lines are suggested. This could minimize the bus traffic required to service lock

[edk2] [RFC] Structured PCD Proposal

2016-05-18 Thread Kinney, Michael D
Hello, Here is a brief description of a proposal to add support for Structured PCDs. The concept is to associate a standard C data structure with a VOID* PCD and use C language syntax to reference fields in the C data structure to override values in a DSC file and access fields in extensions to th

Re: [edk2] System Table and more

2016-05-18 Thread Andrew Fish
> On May 18, 2016, at 2:57 PM, Laszlo Ersek wrote: > > And, the availability of all of the arch protocols implies (as far as I > remember -- sorry I won't do a detailed tally now) that all gRT-> > fields have been filled in with valid function pointers (by the DXE > drivers that produce the

[edk2] [PATCH v1] ShellPkg/Bcfg: Add support for 'addp' command.

2016-05-18 Thread Marvin Häuser
Until now the 'addp' command has been handled in the same way as 'add'. Just copy the DevicePath starting from the Hard Drive node when 'addp' is used. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Marvin Haeuser --- ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfg

[edk2] [PATCH v1] ShellPkg: Also accept gEfiUnicodeCollation2ProtocolGuid for parsing.

2016-05-18 Thread Marvin Häuser
The EFI_UNICODE_COLLATION_PROTOCOL can have two different GUIDs. Look for both to support more UEFI implementations. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Marvin Haeuser --- ShellPkg/Application/Shell/Shell.c | 11 +-- 1 file changed, 9 insertions(+), 2 d

Re: [edk2] [RFC] Add more flexible PCD value formats in DEC/DSC files

2016-05-18 Thread Andrew Fish
> On May 18, 2016, at 2:27 PM, Kinney, Michael D > wrote: > > Hi Andrew, > > Stay tuned. I have an additional [RFC] I am writing up now for associating > C structures with PCDs. > I look forward to reviewing the new RFC. Thanks, Andrew Fish > These value format extensions are useful for

Re: [edk2] [PATCH] IntelFsp2Pkg/FspApi.h: Add comment for structure definition.

2016-05-18 Thread Yao, Jiewen
Thanks. Will do that. > -Original Message- > From: Mudusuru, Giri P > Sent: Thursday, May 19, 2016 6:37 AM > To: Yao, Jiewen ; edk2-devel@lists.01.org > Cc: Yarlagadda, Satya P ; Ma, Maurice > ; Rangarajan, Ravi P > ; Mudusuru, Giri P > > Subject: RE: [PATCH] IntelFsp2Pkg/FspApi.h: Add co

Re: [edk2] [PATCH] [MdePkg/BaseLib]: Remove overreaction to SourceLen in StrCpyS

2016-05-18 Thread Yao, Jiewen
Hi I have seen some confusing on the StrCpyS design. [Background] We designed StrCpyS to replace StrCpy purposely to address the concern that StrCpyS might be used by mistake. strcpy is marked as banned API in SDL in 2006, and it is well known potential security issue. We reviewed EDKII code, f

[edk2] [PATCH] OvmfPkg: prevent 64-bit MMIO BAR degradation if there is no CSM

2016-05-18 Thread Laszlo Ersek
According to edk2 commit "MdeModulePkg/PciBus: do not improperly degrade resource" and to the EFI_INCOMPATIBLE_PCI_DEVICE_SUPPORT_PROTOCOL definition in the Platform Init 1.4a specification, a platform can provide such a protocol in order to influence the PCI resource allocation performed by th

[edk2] edk2-staging/HTTPS-TLS

2016-05-18 Thread El-Haj-Mahmoud, Samer
Jiaxin, The HTTPs-TLS branch is behind EDK2 master, and they are quite a few conflicts to try to keep up with both. Can you please sync the branch from EDK2 master? Thanks, --Samer ___ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.o

Re: [edk2] System Table and more

2016-05-18 Thread Laszlo Ersek
On 05/18/16 23:20, Aaron Viviano wrote: > Hello, > I'm new to creating modules for EDK2, so my apologies if this is a basic > question. > > I'm trying to find out when and if the SystemTable, gRT, and gBS > pointers can ever be null while my EDk2 application is running. I've > looked at various d

Re: [edk2] System Table and more

2016-05-18 Thread Carsey, Jaben
Those pointers are dependent on library constructors from associated libraries. You need to correctly include the library to make them function. The table pointer in your module's entry point should always be valid though. -Jaben > -Original Message- > From: edk2-devel [mailto:edk2-dev

Re: [edk2] [RFC] Add more flexible PCD value formats in DEC/DSC files

2016-05-18 Thread Kinney, Michael D
Hi Andrew, Stay tuned. I have an additional [RFC] I am writing up now for associating C structures with PCDs. These value format extensions are useful for assigning values to fields, Especially some of the character constant ones of a PCD is associated with some of the ACPI tags. Mike > --

[edk2] System Table and more

2016-05-18 Thread Aaron Viviano
Hello, I'm new to creating modules for EDK2, so my apologies if this is a basic question. I'm trying to find out when and if the SystemTable, gRT, and gBS pointers can ever be null while my EDk2 application is running. I've looked at various documents, such as the Module Writers Guide, but I ca

Re: [edk2] [RFC] Add more flexible PCD value formats in DEC/DSC files

2016-05-18 Thread Andrew Fish
> On May 18, 2016, at 12:22 PM, Kinney, Michael D > wrote: > > Hello, > > Today, the DEC/DSC specifications limit the PCD value formats > to the following: > > BOOLEAN TRUE or FALSE > UINT88-bit decimal or hexadecimal value > UINT16 16-bit decimal or hexadecimal value > UINT32 3

[edk2] [PATCH 2/5] CorebootModulePkg: Add video resolution PCD initialization

2016-05-18 Thread Maurice Ma
The video console resolution related PCDs are required to be initialized after switching to use the generic BdsDxe driver in MdeModulePkg. Cc: Prince Agyeman Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Maurice Ma --- CorebootModulePkg/CbSupportDxe/CbSupportDxe.c | 1

[edk2] [Patch V3 0/2] Add SMRR PhysBase/PhysMask fields check

2016-05-18 Thread Michael Kinney
Update SmmCpuFeaturesLib instances that support SMRR to check the SMMRR base and size. New in V3 = Skip SMRR programming on APs if SMRR base/size is invalid so monarch CPU can print debug message and halt Michael Kinney (2): UefiCpuPkg/SmmCpuFeaturesLib: Add SMRR PhysBase/PhysMask fiel

[edk2] [PATCH 4/5] CorebootPayloadPkg: Switch to use generic BdxDxe driver

2016-05-18 Thread Maurice Ma
Switch over to use BdxDxe generic driver in MdeModulePkg. Cc: Prince Agyeman Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Maurice Ma --- CorebootPayloadPkg/CorebootPayloadPkg.fdf| 3 ++- CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc| 32 +++

[edk2] [PATCH 5/5] CorebootPayloadPkg: Remove BdsPlatform library

2016-05-18 Thread Maurice Ma
Since the new BdsDxe driver in MdeModulePkg is used, the old BdsPlatform library is not used any more and should be removed. Cc: Prince Agyeman Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Maurice Ma --- .../Library/PlatformBdsLib/BdsPlatform.c | 1019 ---

[edk2] [Patch V3 1/2] UefiCpuPkg/SmmCpuFeaturesLib: Add SMRR PhysBase/PhysMask fields check

2016-05-18 Thread Michael Kinney
SMRR range size and alignment should follow the rules like MTRR: a. The minimum range size is 4 KBytes and the base address of the range must be on at least a 4-KByte boundary. b. For ranges greater than 4 KBytes, each range must be of length 2^n and its base address must be aligned on a 2^n

[edk2] [PATCH 3/5] CorebootPayloadPkg: Add coreboot PlatfromBootManagerLib implementation

2016-05-18 Thread Maurice Ma
In order to use the generic BdsDxe in MdeModulePkg, a platform specific PlatfromBootManagerLib is required. This library will help update the ConIn, ConOut and ErrOut variables. Cc: Prince Agyeman Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Maurice Ma --- CorebootPayl

[edk2] [Patch V3 2/2] QuarkSocPkg/SmmCpuFeaturesLib: Add SMRR PhysBase/PhysMask fields check

2016-05-18 Thread Michael Kinney
SMRR range size and alignment should follow the rules like MTRR: a. The minimum range size is 4 KBytes and the base address of the range must be on at least a 4-KByte boundary. b. For ranges greater than 4 KBytes, each range must be of length 2^n and its base address must be aligned on a 2^n

[edk2] [PATCH 1/5] CorebootModulePkg: Convert TAB to white space for CbSupportDxe driver

2016-05-18 Thread Maurice Ma
Convert TAB to white space for CbSupportDxe driver. Cc: Prince Agyeman Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Maurice Ma --- CorebootModulePkg/CbSupportDxe/CbSupportDxe.c | 142 +- 1 file changed, 71 insertions(+), 71 deletions(-) diff --

[edk2] [PATCH 0/5] CorebootPayloadPkg: Switch to use BdxDxe driver in MdeModulePkg

2016-05-18 Thread Maurice Ma
This is part of the clean-up for CorebootModulePkg and CorebootPayloadPkg. The current CorebootPayloadPkg uses the BdxDxe driver from IntelFrameworkModulePkg. Now it will switch over to use the BdxDxe driver in MdeModulePkg instead. A new coreboot PlatformBootManagerLib instance is created and th

Re: [edk2] [Patch 0/4] MdeModulePkg/PciBus Do not improperly degrade resource

2016-05-18 Thread Laszlo Ersek
On 05/18/16 17:08, Ni, Ruiyu wrote: > I agree to put ecr number in commit message. Series Tested-by: Laszlo Ersek I'll soon submit a patch that enables this new functionality for OvmfPkg. Thank you! Laszlo >> 在 2016年5月18日,下午7:35,Laszlo Ersek 写道: >> >> On 05/18/16 10:16, Ni, Ruiyu wrote:

Re: [edk2] [Patch V2 1/2] UefiCpuPkg/SmmCpuFeaturesLib: Add SMRR PhysBase/PhysMask fields check

2016-05-18 Thread Kinney, Michael D
Jeff, The other option is to skip SMRR programming on APs if the base/mask are not valid And have the CPU with IsMonarch TRUE do debug message and halt. Mike > -Original Message- > From: Fan, Jeff > Sent: Tuesday, May 17, 2016 10:33 PM > To: Kinney, Michael D ; edk2-devel@lists.01.org >

Re: [edk2] [PATCH] [MdePkg/BaseLib]: Remove overreaction to SourceLen in StrCpyS

2016-05-18 Thread Bruce Cran
On 5/18/2016 10:00 AM, Thomas Palmer wrote: I will publicly speculate that most uses/users of StrCpyS expect it to copy as much of the source string as possible instead of ASSERT'ing or returning an error (and copying nothing) when the source string is longer than the destination buffer. If the

Re: [edk2] [PATCH] [Vlv2TbltDevicePkg] Update the core version string to UEFI 2.50.

2016-05-18 Thread Bruce Cran
Since the MBMAX firmware is now being built against the UDK2015 branch, the 'Core Version' string in PlatformSetupDxe should be updated to UEFI 2.50. Obviously, this patch should be applied to the UDK2015 branch. On 05/18/2016 01:24 PM, Bruce Cran wrote: Also, see https://github.com/bcran/ed

[edk2] [PATCH] [Vlv2TbltDevicePkg] Update the core version string to UEFI 2.50.

2016-05-18 Thread Bruce Cran
Also, see https://github.com/bcran/edk2/commit/349b5ee989a876457e65176556a164a1825531d5 . >From 349b5ee989a876457e65176556a164a1825531d5 Mon Sep 17 00:00:00 2001 From: Bruce Cran Date: Wed, 18 May 2016 13:22:46 -0600 Subject: [PATCH] [Vlv2TbltDevicePkg] Update the core version string to UEFI

[edk2] [RFC] Add more flexible PCD value formats in DEC/DSC files

2016-05-18 Thread Kinney, Michael D
Hello, Today, the DEC/DSC specifications limit the PCD value formats to the following: BOOLEAN TRUE or FALSE UINT88-bit decimal or hexadecimal value UINT16 16-bit decimal or hexadecimal value UINT32 32-bit decimal or hexadecimal value UINT64 64-bit decimal or hexadecimal val

Re: [edk2] [PATCH] Emulator Pkg add 'Alt' key map

2016-05-18 Thread Jordan Justen
When you run "git log -1", does the author show as: Pedroa or Pedroa Liu If it is the first, can you fix your git user.name setting? I mentioned how you might fix it in the previous patch, but maybe it didn't work? Also, for the patch subject, can you instead use something like: EmulatorP

[edk2] [PATCH] CorebootModulePkg: Use PCD for memory type information initialization

2016-05-18 Thread Maurice Ma
CorebootModulePkg currently uses a hardcoded table for memory type initialization. It might need to be adjusted by platform to reduce the memory fragmentation. So changing to use PCDs rather than constant values to facilitate the customization. Cc: Prince Agyeman Contributed-under: TianoCore Cont

Re: [edk2] Where is the edk2-devel posting archives?

2016-05-18 Thread Jordan Justen
On 2016-05-18 01:49:38, Shi, Steven wrote: > Hello, > Where can I find the edk2 prior postings? The below Edk2-devel Archives link > is empty. > > https://lists.01.org/pipermail/edk2-devel/ > [cid:image001.png@01D1B125.4323EFF0] > Hmm, I notice that 01.org appears to have 'reset' the list's cus

Re: [edk2] [PATCH] [MdePkg/BaseLib]: Remove overreaction to SourceLen in StrCpyS

2016-05-18 Thread Carsey, Jaben
Due to the fact that I spent lots of time on the shell which is an application that can be loaded on firmware anywhere and is frequently used during the testing and development of new firmware, I found almost the entire sting manipulation function set to be so ASSERT filled that it was very unhe

Re: [edk2] [PATCH] Emulator Pkg add 'Alt' key map

2016-05-18 Thread Andrew Fish
Reviewed-by: Andrew Fish > On May 17, 2016, at 5:49 AM, Pedroa wrote: > > Add 'Alt' key map. > > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Pedroa Liu > --- > EmulatorPkg/Unix/Host/X11GraphicsWindow.c | 16 > 1 file changed, 16 insertions(+) >

Re: [edk2] [PATCH] [MdePkg/BaseLib]: Remove overreaction to SourceLen in StrCpyS

2016-05-18 Thread Carsey, Jaben
Sure. Reviewed by: Jaben Carsey -Jaben > On May 18, 2016, at 9:44 AM, El-Haj-Mahmoud, Samer > wrote: > > Thanks Jaben! > > Will you give it a reviewed-by ? > > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Carsey, Jaben > Sent: Wedn

Re: [edk2] SD is not getting detected in linux

2016-05-18 Thread Andrew Fish
> On May 18, 2016, at 12:47 AM, Meenakshi Aggarwal > wrote: > > Hi Ard, > > > I am doing this uprev'ing activity in parallel, but I am facing some issues > like, > > 1. Compilation issue in RELEASE mode with latest edk2 (shared earlier in edk2 > mailing list) > > > /home/tools/meena

Re: [edk2] [PATCH] [MdePkg/BaseLib]: Remove overreaction to SourceLen in StrCpyS

2016-05-18 Thread El-Haj-Mahmoud, Samer
Thanks Jaben! Will you give it a reviewed-by ? -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Carsey, Jaben Sent: Wednesday, May 18, 2016 11:25 AM To: Palmer, Thomas ; jim_dai...@dell.com; edk2-devel@lists.01.org Cc: Kinney, Michael D ; Carsey,

Re: [edk2] [PATCH] [MdePkg/BaseLib]: Remove overreaction to SourceLen in StrCpyS

2016-05-18 Thread Carsey, Jaben
> -Original Message- > From: Palmer, Thomas [mailto:thomas.pal...@hpe.com] > Sent: Wednesday, May 18, 2016 9:21 AM > To: jim_dai...@dell.com; Carsey, Jaben ; edk2- > de...@lists.01.org > Cc: Kinney, Michael D ; Yao, Jiewen > ; Gao, Liming > Subject: RE: [edk2] [PATCH] [MdePkg/BaseLib]: R

Re: [edk2] [PATCH] [MdePkg/BaseLib]: Remove overreaction to SourceLen in StrCpyS

2016-05-18 Thread Palmer, Thomas
My comment at bottom. Sorry, HPE is an Outlook shop. -Original Message- From: jim_dai...@dell.com [mailto:jim_dai...@dell.com] Sent: Wednesday, May 18, 2016 11:17 AM To: jaben.car...@intel.com; Palmer, Thomas ; edk2-devel@lists.01.org Cc: michael.d.kin...@intel.com; jiewen@intel.co

Re: [edk2] [PATCH] [MdePkg/BaseLib]: Remove overreaction to SourceLen in StrCpyS

2016-05-18 Thread Jim_Dailey
Dell Customer Communication >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Thomas Palmer >> Sent: Wednesday, May 18, 2016 9:01 AM >> To: edk2-devel@lists.01.org >> Cc: Kinney, Michael D ; Yao, Jiewen >> ; Gao, Liming >> Subject: [edk2] [P

Re: [edk2] [PATCH] [MdePkg/BaseLib]: Remove overreaction to SourceLen in StrCpyS

2016-05-18 Thread Carsey, Jaben
> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Thomas Palmer > Sent: Wednesday, May 18, 2016 9:01 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Yao, Jiewen > ; Gao, Liming > Subject: [edk2] [PATCH] [MdePkg/BaseLib]: Remove ove

[edk2] [PATCH] [MdePkg/BaseLib]: Remove overreaction to SourceLen in StrCpyS

2016-05-18 Thread Thomas Palmer
The StrCpyS function is "safe" because the destination buffer will not be overwritten and the string will have a NULL terminator byte. Today, StrCpyS will also refuse to copy the string if its length is greater than the size of the destination buffer. However, this behavior is not documented in th

Re: [edk2] [BaseTools] RuleOverride = BINARY code location?

2016-05-18 Thread Andrew Fish
> On May 18, 2016, at 7:24 AM, Gao, Liming wrote: > > Andrew: > GenFds tool finds the matched Ffs [Rules] and apply it. The extra section > may be described in [Rules] section or be auto added as padding for other > section data alignment. > Liming, This is the Rule in question. [Rule.C

[edk2] [PATCH v2 1/3] MdePkg: Add a header for NVMe v1.1 spec. definitions.

2016-05-18 Thread darbin . emm . reyes
From: Darbin Reyes Adds a public header for NVMe v1.1 spec. definitions. The majority of these definitions where copied from a private header in MdeModulePkg/Bus/Pci/NvmExpress/NvmExpressHci.h. Additional definitions were added e.g. the NVMe Smart Health Log and Firmware Info. Log structures. The

[edk2] [PATCH v2 0/3] *** Add Nvme.h and NvmExpressLib ***

2016-05-18 Thread darbin . emm . reyes
From: Darbin Reyes *** Add Nvme.h and NvmExpressLib *** Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Darbin Reyes Reviewed-by: Samer El-Haj-Mahmoud Darbin Reyes (3): MdePkg: Add a header for NVMe v1.1 spec. definitions. MdeModulePkg: Move/Replace NvmExpressHci.h

Re: [edk2] [Patch 0/4] MdeModulePkg/PciBus Do not improperly degrade resource

2016-05-18 Thread Ni, Ruiyu
I agree to put ecr number in commit message. Thanks, Ray > 在 2016年5月18日,下午7:35,Laszlo Ersek 写道: > > On 05/18/16 10:16, Ni, Ruiyu wrote: >>> -Original Message- >>> From: Laszlo Ersek [mailto:ler...@redhat.com] >>> Sent: Tuesday, May 17, 2016 8:23 PM >>> To: Ni, Ruiyu >>> Cc: edk2-de...@

Re: [edk2] [PATCH v3 2/2] BaseTools: add '!include' support to tools_def.txt parser

2016-05-18 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael Zimmermann Sent: Tuesday, May 17, 2016 3:54 PM To: edk2-devel@lists.01.org Subject: [edk2] [PATCH v3 2/2] BaseTools: add '!include' support to tools_def.txt parser

Re: [edk2] Using the Shell to launch a kernel using a RAMDISK

2016-05-18 Thread Laszlo Ersek
On 05/18/16 16:31, El-Haj-Mahmoud, Samer wrote: > Thanks Laszlo. I am familiar with those documents, and did review > them in USWG when the feature was introduced. Ah, great, then you know much more about the background and use cases than I do :) > And most of the content of those ECRs is now pub

Re: [edk2] Using the Shell to launch a kernel using a RAMDISK

2016-05-18 Thread El-Haj-Mahmoud, Samer
Thanks Laszlo. I am familiar with those documents, and did review them in USWG when the feature was introduced. And most of the content of those ECRs is now publically available in the UEFI Spec. None of them discuss or hint to an HII menu or its design. -Original Message- From: Lasz

Re: [edk2] Using the Shell to launch a kernel using a RAMDISK

2016-05-18 Thread Laszlo Ersek
On 05/18/16 16:09, El-Haj-Mahmoud, Samer wrote: > Thanks Laszlo! > > I missed that thread. > > I did not participate in the original design either (where is the original > design anyway? Is it public on the EDK2 list)? Probably on the closed USWG mailing list, and/or attached to (similarly clos

Re: [edk2] [BaseTools] RuleOverride = BINARY code location?

2016-05-18 Thread Gao, Liming
Andrew: GenFds tool finds the matched Ffs [Rules] and apply it. The extra section may be described in [Rules] section or be auto added as padding for other section data alignment. Thanks Liming -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of A

Re: [edk2] Using the Shell to launch a kernel using a RAMDISK

2016-05-18 Thread El-Haj-Mahmoud, Samer
Thanks Laszlo! I missed that thread. I did not participate in the original design either (where is the original design anyway? Is it public on the EDK2 list)? Feng, Do you mind if I submit a patch to update the HII to support allocating Reserved memory RAM Disks? This will help a lot in troub

Re: [edk2] Using the Shell to launch a kernel using a RAMDISK

2016-05-18 Thread Laszlo Ersek
On 05/18/16 15:48, El-Haj-Mahmoud, Samer wrote: > Does it make sense to update the RAM Disk HII (at > \MdeModulePkg\Universal\Disk\RamDiskDxe) to allow creating a RAM Disk > of Type Reserved, for this kind of testing? That's exactly what I suggested in http://thread.gmane.org/gmane.comp.bios.edk2

Re: [edk2] [PATCH v2 0/3] *** Add Nvme.h and NvmExpressLib ***

2016-05-18 Thread El-Haj-Mahmoud, Samer
Series Reviewed-By: Samer El-Haj-Mahmoud -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Reyes, Darbin Sent: Tuesday, May 17, 2016 4:16 PM To: edk2-devel@lists.01.org Cc: feng.t...@intel.com; Reyes, Darbin ; liming@intel.com; michael.d.kin

Re: [edk2] HTTP Boot crashed when downloading remote image

2016-05-18 Thread El-Haj-Mahmoud, Samer
Gary, The EDK2 list blocked the wireshark attachment. Can you put it on a share and send a link please? We are trying to look at this internally as well. Thanks, --Samer -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gary Lin Sent: Tuesday, May

Re: [edk2] [PATCH v2 3/3] MdeModulePkg: Add NvmExpressLib.

2016-05-18 Thread El-Haj-Mahmoud, Samer
Feng, We plan on submitting updates to NvmExpressDxe to implement Firmware Management Protocol, which will use this library. Also part of this patch is to change existing NvmExpressDxe code (partially) to start using the shared library. We also have proprietary code (in non EDK2 drivers) that

Re: [edk2] Using the Shell to launch a kernel using a RAMDISK

2016-05-18 Thread El-Haj-Mahmoud, Samer
Does it make sense to update the RAM Disk HII (at \MdeModulePkg\Universal\Disk\RamDiskDxe) to allow creating a RAM Disk of Type Reserved, for this kind of testing? -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Wednesday, M

[edk2] [PATCH] IntelFsp2WrapperPkg/FspmWrapperPeim: Update debug message match code.

2016-05-18 Thread Jiewen Yao
Update function name in debug message to match code. Cc: Giri P Mudusuru Cc: Amy Chan Cc: Maurice Ma Cc: Ravi P Rangarajan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c | 2 +- 1 file changed, 1 ins

Re: [edk2] Where is the edk2-devel posting archives?

2016-05-18 Thread Laszlo Ersek
On 05/18/16 10:49, Shi, Steven wrote: > Hello, > Where can I find the edk2 prior postings? The below Edk2-devel Archives link > is empty. > > https://lists.01.org/pipermail/edk2-devel/ > [cid:image001.png@01D1B125.4323EFF0] For the new list: http://news.gmane.org/gmane.comp.bios.edk2.devel For

[edk2] [PATCH] IntelFsp2Pkg/FspApi.h: Add comment for structure definition.

2016-05-18 Thread Jiewen Yao
Add doxygen style comment for structure definition. Cc: Giri P Mudusuru Cc: Satya P Yarlagadda Cc: Maurice Ma Cc: Ravi P Rangarajan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- IntelFsp2Pkg/Include/FspEas/FspApi.h | 33

Re: [edk2] [Patch 2/2] PcAtChipsetPkg/PcRtc: get century RTC address in entry point

2016-05-18 Thread Laszlo Ersek
On 05/18/16 07:20, Ruiyu Ni wrote: > When ACPI table is installed before PcRtc driver runs, > the ACPI table installation callback isn't called which causes the > century value isn't written to the CMOS. > The patch calls GetCenturyRtcAddress() in entry point to fix > the bug. > > Contributed-unde

  1   2   >