Re: [edk2] [BaseTools] PACKAGES_PATH issue?

2016-05-20 Thread Andrew Fish
Liming, I found one more issues. My ACPI tables are breaking the build. It looks like the failure is no input files. What I've figured out in GetFileList() is FfsInf.EfiOutputPath is constructed incorrectly. The path does not included the prefix from the PACKAGES_PATH and thus the directory doe

Re: [edk2] [RFC] Structured PCD Proposal

2016-05-20 Thread Andrew Fish
> On May 20, 2016, at 12:34 PM, Kinney, Michael D > wrote: > > Andrew, > > I hope there is not a misunderstanding in the include file used by a DEC file > for a PCD. > > It is not a parallel include file. The same include file is used in DEC > parsing and > by modules/libs that access the

Re: [edk2] [PATCH] MdePkg/BaseLib: do not rely on undefined behavior in arithmetic shift

2016-05-20 Thread Felix Poludov
Here is another case of shifting a negative value: It's CoreRestoreTpl (MdeModulePkg\Core\Dxe\Event\Tpl.c): while (((-2 << NewTpl) & gEventPending) != 0) { } -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gao, Liming Sent: Thursday, December

[edk2] TCP4: Failure to Acknowledge due to DPC Dispatch Nesting

2016-05-20 Thread Cohen, Eugene
We have isolated a problem where the TCP4 driver fails to acknowledge received data under certain circumstances. Background on DPCs: The DPC mechanism allows functions to be called at a later point in time at a requested TPL level. Functions are queued through the DPC Protocol's QueueDpc inte

Re: [edk2] [RFC] Structured PCD Proposal

2016-05-20 Thread Kinney, Michael D
Andrew, I hope there is not a misunderstanding in the include file used by a DEC file for a PCD. It is not a parallel include file. The same include file is used in DEC parsing and by modules/libs that access the same Structured PCD. This is especially important for sharing a .h file betwee

Re: [edk2] [RFC] Structured PCD Proposal

2016-05-20 Thread Andrew Fish
> On May 20, 2016, at 10:48 AM, Kinney, Michael D > wrote: > > Andrew, > > 1) I think the strongest concern is on use of CLANG/AST. I will look at your > ideas and > some other ideas I have thought of as well to use standard C compiler that > is already > installed to build FW to suppo

Re: [edk2] [PATCH] MdePkg/WSMT.h: update header comment to use official URL link.

2016-05-20 Thread El-Haj-Mahmoud, Samer
Thanks for fixing it.. I was wondering what that URL was, and had to ping MS about it. Reviewed-by: Samer El-Haj-Mahmoud -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiewen Yao Sent: Thursday, May 19, 2016 7:58 PM To: edk2-devel@lists.01.o

Re: [edk2] [patch] NetworkPkg: Refine codes of Http boot driver.

2016-05-20 Thread El-Haj-Mahmoud, Samer
Yes this is probably better than HTTP drivers directly printing on console -Original Message- From: Fu, Siyuan [mailto:siyuan...@intel.com] Sent: Thursday, May 19, 2016 9:04 PM To: El-Haj-Mahmoud, Samer ; Zhang, Lubo ; edk2-devel@lists.01.org Cc: Ye, Ting ; Wu, Jiaxin Subject: RE: [ed

Re: [edk2] [RFC] Structured PCD Proposal

2016-05-20 Thread Kinney, Michael D
Andrew, 1) I think the strongest concern is on use of CLANG/AST. I will look at your ideas and some other ideas I have thought of as well to use standard C compiler that is already installed to build FW to support Structured PCD features. 2) The other concern I see here is extending Pcd

Re: [edk2] Driver dependency on boot

2016-05-20 Thread Andrew Fish
> On May 20, 2016, at 12:36 AM, Iru Cai wrote: > > It's a good idea, but I still have some problems. My ccidboot driver has > different behaviors depending on whether a CCID card is plugged in, so I > think I also need a timer event to check if gEfiCcidProtocolGuid is > installed to a handle in

Re: [edk2] [RFC] Structured PCD Proposal

2016-05-20 Thread Kinney, Michael D
Laszlo, Your feedback is consistent with Andrews. I will see if we can implement the Structured PCD feature without using CLANG frontend and Python bindings. CLANG/Python was a very valuable toolset to prototype and evaluate a number of design options quickly. Andrew has suggested maximizin

Re: [edk2] [Patch] BaseTools: Fix GenFds issue to wrongly get file without postfix.

2016-05-20 Thread Andrew Fish
Reviewed-by: Andrew FIsh Thanks you for the quick fix. Andrew Fish > On May 20, 2016, at 1:42 AM, Liming Gao wrote: > > GenFds GenSection will search the output file based on the file extension. > If the output file has no extension, it should be skip. > > Cc: Andrew Fish > Contributed-unde

[edk2] [PATCH] IntelFsp2WrapperPkg: Update gFspWrapperTokenSpaceGuid to gIntelFsp2WrapperTokenSpaceGuid.

2016-05-20 Thread Jiewen Yao
We updated gIntelFspPkgTokenSpaceGuid to gIntelFsp2PkgTokenSpaceGuid in IntelFsp2Pkg, but we miss the update in IntelFsp2WrapperPkg. This patch fixed the issue and made them consistent. Cc: Giri P Mudusuru Cc: Satya P Yarlagadda Cc: Maurice Ma Cc: Ravi P Rangarajan Contributed-under: TianoCore

Re: [edk2] [PATCH] MdePkg: Follow PI1.4a to update the comments of EndOfDxe and SmmReadyToLock

2016-05-20 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Friday, May 20, 2016 2:42 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Gao, Liming > > Subject: [PATCH] MdePkg: Follow PI1.4a to update the comments of > EndOfDxe and SmmReadyToLock > > Cc: Jiewen Y

[edk2] [PATCH] IntelFsp2WrapperPkg: Update gFspWrapperTokenSpaceGuid to gIntelFsp2WrapperTokenSpaceGuid.

2016-05-20 Thread Jiewen Yao
We updated gIntelFspPkgTokenSpaceGuid to gIntelFsp2PkgTokenSpaceGuid in IntelFsp2Pkg, but we miss the update in IntelFsp2WrapperPkg. This patch fixed the issue and made them consistent. Cc: Giri P Mudusuru Cc: Satya P Yarlagadda Cc: Maurice Ma Cc: Ravi P Rangarajan Contributed-under: TianoCore

Re: [edk2] [Patch] NetworkPkg: Need update Http token status while timeout happened

2016-05-20 Thread Gary Lin
On Fri, May 20, 2016 at 03:24:29PM +0800, Jiaxin Wu wrote: > Http token status should be updated to EFI_TIMEOUT while timeout > happened by any abruptly interrupted (e.g. network disconnection, > cable plug/unplug...). Otherwise, HttpBootDxe driver will continue > treat it as no error happened, and

Re: [edk2] [RFC] Structured PCD Proposal

2016-05-20 Thread Laszlo Ersek
On 05/19/16 19:39, Kinney, Michael D wrote: > >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Laszlo Ersek >> Sent: Thursday, May 19, 2016 2:26 AM >> To: Kinney, Michael D >> Cc: edk2-devel@lists.01.org >> Subject: Re: [edk2] [RFC] Stru

[edk2] [Patch] BaseTools: Fix GenFds issue to wrongly get file without postfix.

2016-05-20 Thread Liming Gao
GenFds GenSection will search the output file based on the file extension. If the output file has no extension, it should be skip. Cc: Andrew Fish Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- BaseTools/Source/Python/GenFds/Section.py | 2 +- 1 file chang

Re: [edk2] [BaseTools] RuleOverride = BINARY code location?

2016-05-20 Thread Gao, Liming
Andrew: Thanks for your point out. It is bug. Your fix is correct. I will send the patch for it. Thanks Liming > -Original Message- > From: af...@apple.com [mailto:af...@apple.com] > Sent: Friday, May 20, 2016 1:25 PM > To: Gao, Liming > Cc: edk2-devel > Subject: Re: [edk2] [BaseTool

[edk2] [PATCH v2] BaseTools: Add error condition for the path in PACKAGES_PATH env

2016-05-20 Thread Liming Gao
From: "Zhu, Yonghong" This patch adds two error conditions: 1) if one path in PACKAGES_PATH doesn't exist. 2) if the space exists in the PACKAGES_PATH. In V2, highlight one path in PACKAGES_PATH env doesn't exist. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Z

Re: [edk2] Driver dependency on boot

2016-05-20 Thread Gao, Liming
You can try creating two event notification functions. One is to notify gEfiCcidProtocolGuid to run the logic with device plug-in, another is notify ReadyToBoot event to run the logic without device plug-in. Thanks Liming From: Iru Cai [mailto:mytbk920...@gmail.com] Sent: Friday, May 20, 2016 3:

Re: [edk2] HTTP Boot crashed when downloading remote image

2016-05-20 Thread Wu, Jiaxin
Gary, Timeout case could happened by any abruptly interrupted (e.g. network disconnection, cable plug/unplug...). Some exception behavior may happened while Timeout triggered. The rootcause as I descripted below: If TCP CompletionToken is not signaled, it should not be closed directly by calli

Re: [edk2] Driver dependency on boot

2016-05-20 Thread Iru Cai
It's a good idea, but I still have some problems. My ccidboot driver has different behaviors depending on whether a CCID card is plugged in, so I think I also need a timer event to check if gEfiCcidProtocolGuid is installed to a handle in time. However, I need the code executed before the boot man

Re: [edk2] [PATCH] MdePkg: Clarification to the return status of EFI_PEIM_NOTIFY_ENTRY_POINT

2016-05-20 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Zeng, Star > Sent: Wednesday, May 18, 2016 5:08 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [PATCH] MdePkg: Clarification to the return status of > EFI_PEIM_NOTIFY_ENTRY_POINT > > In Previous PI spec (< PI1.4a) Volum

Re: [edk2] [PATCH 0/2] Follow PI1.4a to fix artificial limitation of PCD SkuId range

2016-05-20 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Star Zeng > Sent: Friday, May 20, 2016 2:49 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH 0/2] Follow PI1.4a to fix artificial limitation of PCD > SkuId rang

[edk2] [Patch] NetworkPkg: Need update Http token status while timeout happened

2016-05-20 Thread Jiaxin Wu
Http token status should be updated to EFI_TIMEOUT while timeout happened by any abruptly interrupted (e.g. network disconnection, cable plug/unplug...). Otherwise, HttpBootDxe driver will continue treat it as no error happened, and its ReceivedSize will be updated to ContentLength directly. Moreov

Re: [edk2] [PATCH] MdePkg: Follow PI1.4a to update the comments of EndOfDxe and SmmReadyToLock

2016-05-20 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Zeng, Star > Sent: Friday, May 20, 2016 2:42 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Gao, Liming > > Subject: [PATCH] MdePkg: Follow PI1.4a to update the comments of > EndOfDxe and SmmReadyToLock > > Cc: Jiewen Yao > Cc:

Re: [edk2] [PATCH] MdePkg: Update EFI_RESOURCE_ATTRIBUTE_READ_ONLY_PROTECTABLE to 0x00080000

2016-05-20 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Zeng, Star > Sent: Wednesday, May 18, 2016 2:02 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [PATCH] MdePkg: Update > EFI_RESOURCE_ATTRIBUTE_READ_ONLY_PROTECTABLE to 0x0008 > > Previous PI spec (< PI1.4a) has EFI_