Serials Reviewed-by: Sriram Subramanian
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu Siyuan
Sent: Thursday, May 26, 2016 6:34 AM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch 0/2]
For this, and the related patch for OVMF:
Reviewed-by: Jordan Justen
On 2016-05-25 16:03:36, Laszlo Ersek wrote:
> The PlatformBootManagerWaitCallback() function sets White.Reserved to
> 0xFF; it should be 0x00. Also, use a more compact form to assign the
> component
Push at 8ac46e4ef76ee56778430bb3dbcc545cce49d208
From: Michael Zimmermann [mailto:sigmaepsilo...@gmail.com]
Sent: Tuesday, May 17, 2016 3:55 PM
To: Gao, Liming
Cc: edk2-devel@lists.01.org
Subject: Re: [edk2] [PATCH 0/2] add '!include' support to
Reviewed-by: Ruiyu Ni
>-Original Message-
>From: Laszlo Ersek [mailto:ler...@redhat.com]
>Sent: Thursday, May 26, 2016 7:04 AM
>To: edk2-devel-01
>Cc: Andrew Fish ; Justen, Jordan L
>; Ni, Ruiyu
Reviewed-by : Samer El-Haj-Mahmoud
-Original Message-
From: Fu Siyuan [siyuan...@intel.com]
Received: Wednesday, 25 May 2016, 9:04PM
To: edk2-devel@lists.01.org [edk2-devel@lists.01.org]
Subject: [edk2] [Patch 0/2] Stop-the-timer-before-clean-IP-service
Fu Siyuan (2):
Serials Reviewed-by: Wu Jiaxin
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu
> Siyuan
> Sent: Thursday, May 26, 2016 9:04 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [Patch 0/2]
Hello,
I have gone through all the feedback I have received and have updated this
proposal. Here is a summary of the changes in V2:
* IntelFrameworkModulePkg -> Deprecated
* IntelFrameworkPkg -> Deprecated
* IntelFspPkg -> Deprecated
* IntelFspWrapperPkg
Hi, Eugene
The FIN_SENT flag seems OK because an incoming TCP message won't override this
flag, while the other control flag like the TIMER_REXMIT and RTT are more
complex which need case by case analysis. There is no DPC mechanism when
writing the first revision TCP code, so I think we need
Reviewed-by: Zhang Lubo
-Original Message-
From: Wu, Jiaxin
Sent: Wednesday, May 25, 2016 4:28 PM
To: edk2-devel@lists.01.org
Cc: Ye, Ting ; Fu, Siyuan ; Zhang, Lubo
Subject: [Patch 2/2] NetworkPkg:
Current SNP UNDI Initialize command does not follow the UEFI Spec
to update the SNP MediaPresent field. The result for the Initialize
command execution check should be:
StatFlags: (1) Monitor the upper two bits (14 & 15) in the field to know
whether the command has been executed by the UNDI (Not
Serials Reviewed-by: Fu Siyuan
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Jiaxin Wu
> Sent: Wednesday, May 25, 2016 4:28 PM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting ; Zhang, Lubo
In Ip6CleanService()it first cleaned some resources, then stop the timer .
While before the timer stopped it may try to access some already freed
data, which may generate an exception.
This patch updates the driver to stop the timer event before starting to
clean up the service data.
Cc: Wu
Fu Siyuan (2):
MdeModulePkg: Stop the timer before clean IP service.
NetworkPkg: Stop the timer before clean IP service.
MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Driver.c | 18 ++---
NetworkPkg/Ip6Dxe/Ip6Driver.c | 31 ---
2 files changed, 25
In Ip4CleanService()it first cleaned some resources, then stop the timer .
While before the timer stopped it may try to access some already freed
data, which may generate an exception.
This patch updates the driver to stop the timer event before starting to
clean up the service data.
Cc: Wu
The PlatformBootManagerWaitCallback() function sets White.Reserved to
0xFF; it should be 0x00. Also, use a more compact form to assign the
component fields.
Suggested-by: Jordan Justen
Cc: Andrew Fish
Cc: Jordan Justen
Cc:
> On May 25, 2016, at 3:03 PM, Jordan Justen wrote:
>
> On 2016-05-25 14:13:03, Laszlo Ersek wrote:
>> On 05/25/16 21:53, Jordan Justen wrote:
>>> On 2016-05-25 10:23:56, Laszlo Ersek wrote:
On 05/25/16 19:00, Jordan Justen wrote:
> On 2016-05-25 05:36:43,
From: Darbin Reyes
Adds a public header for NVMe v1.1 spec. definitions. The majority
of these definitions where copied from a private header in
MdeModulePkg/Bus/Pci/NvmExpress/NvmExpressHci.h. Additional
definitions were added e.g. the NVMe Smart Health Log and
From: Darbin Reyes
*** Move NvmExpress definitions to public Nvme.h ***
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Darbin Reyes
Reviewed-by: Samer El-Haj-Mahmoud
Darbin Reyes (2):
From: Darbin Reyes
Move NvmExpressHci.h definitions to a public industry standard
header in MdePkg. The NvmExpressHci.h contains definitions based
on the NVMe v1.1 specification. These definitions should be in
a public header so that clients of the NVMe passthru
On 2016-05-25 14:13:03, Laszlo Ersek wrote:
> On 05/25/16 21:53, Jordan Justen wrote:
> > On 2016-05-25 10:23:56, Laszlo Ersek wrote:
> >> On 05/25/16 19:00, Jordan Justen wrote:
> >>> On 2016-05-25 05:36:43, Laszlo Ersek wrote:
> OVMF's Platform BDS used to have a nice progress bar (with
>
On 05/25/16 21:53, Jordan Justen wrote:
> On 2016-05-25 10:23:56, Laszlo Ersek wrote:
>> On 05/25/16 19:00, Jordan Justen wrote:
>>> On 2016-05-25 05:36:43, Laszlo Ersek wrote:
OVMF's Platform BDS used to have a nice progress bar (with
IntelFrameworkModulePkg BDS). We can restore it by
On 2016-05-25 10:23:56, Laszlo Ersek wrote:
> On 05/25/16 19:00, Jordan Justen wrote:
> > On 2016-05-25 05:36:43, Laszlo Ersek wrote:
> >> OVMF's Platform BDS used to have a nice progress bar (with
> >> IntelFrameworkModulePkg BDS). We can restore it by copying the
> >>
The current GenCfgOpt tool does not generate bit fields in BSF.
This change will allow bit fields to be created in BSF for a specific
FSP UPD item. The argument for the tool is also updated to be in sync
with the old usage model in IntelFspPkg.
Cc: Jiewen Yao
Cc: Giri P
On 05/25/16 19:00, Jordan Justen wrote:
> On 2016-05-25 05:36:43, Laszlo Ersek wrote:
>> OVMF's Platform BDS used to have a nice progress bar (with
>> IntelFrameworkModulePkg BDS). We can restore it by copying the
>> PlatformBootManagerWaitCallback() function verbatim from
>>
>>
Reviewed-by: Thomas Palmer
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gao,
Liming
Sent: Sunday, May 22, 2016 9:33 PM
To: Yao, Jiewen ; edk2-devel@lists.01.org
Cc: Kinney, Michael D
Thanks Jiaxin. I will pull the code and let you know if I run into issues
-Original Message-
From: Wu, Jiaxin [mailto:jiaxin...@intel.com]
Sent: Tuesday, May 24, 2016 10:17 PM
To: El-Haj-Mahmoud, Samer ;
edk2-devel@lists.01.org
Subject: RE:
Reviewed-by: Samer El-Haj-Mahmoud
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Tian,
Feng
Sent: Wednesday, May 25, 2016 12:23 AM
To: Wu, Hao A ; edk2-devel@lists.01.org
Cc: Tian, Feng
Reviewed-by: Samer El-Haj-Mahmoud
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiaxin Wu
Sent: Wednesday, May 25, 2016 3:28 AM
To: edk2-devel@lists.01.org
Cc: Ye Ting ; Zhang Lubo ; Fu
> On May 25, 2016, at 10:00 AM, Jordan Justen wrote:
>
> On 2016-05-25 05:36:43, Laszlo Ersek wrote:
>> OVMF's Platform BDS used to have a nice progress bar (with
>> IntelFrameworkModulePkg BDS). We can restore it by copying the
>> PlatformBootManagerWaitCallback()
On 2016-05-25 05:36:43, Laszlo Ersek wrote:
> OVMF's Platform BDS used to have a nice progress bar (with
> IntelFrameworkModulePkg BDS). We can restore it by copying the
> PlatformBootManagerWaitCallback() function verbatim from
>
> Nt32Pkg/Library/PlatformBootManagerLib/PlatformBootManager.c
>
> On May 25, 2016, at 9:43 AM, Shi, Steven wrote:
>
> Hi Andrew,
> For the Clang LTO generate wrong code on Qemu X64 issue, I found it is
> related to the high address (>2G) wrong sign-extend displacements to 64 bits.
> E.g. I hope “jmp qword ptr 0xfffcdd54[0]” in 64
In the course of porting OvmfPkg to the MdeModulePkg BDS, commit
817fb3ac2a78
OvmfPkg/PlatformBootManagerLib: Add EnableQuietBoot & DisableQuietBoot
open-coded the EnableQuietBoot() function (and its dependencies / friends)
from IntelFrameworkModulePkg BDS.
This code duplication can be
The BootLogoUpdateProgress() function uses the
EFI_GRAPHICS_OUTPUT_BLT_PIXEL type in its parameter list, but the protocol
header that defines this type is not included. This breaks dependent C
source files that don't otherwise include the GraphicsOutput protocol
header. Supply the necessary
OVMF used to have a progress bar, but it went lost with the port to
MdeModulePkg BDS. I never considered this a major issue, but the
progress bar does look nice, and given how simply it can be reinstated
(using MdeModulePkg libraries), we should do that.
ArmVirtPkg never had a progress bar; this
In the course of porting ArmVirtPkg to the MdeModulePkg BDS, commit
1f73aef50c5e
ArmVirtPkg/PlatformBootManagerLib: add EnableQuietBoot & DisableQuietBoot
open-coded the EnableQuietBoot() function (and its dependencies / friends)
from IntelFrameworkModulePkg BDS.
This code duplication can be
OVMF's Platform BDS used to have a nice progress bar (with
IntelFrameworkModulePkg BDS). We can restore it by copying the
PlatformBootManagerWaitCallback() function verbatim from
Nt32Pkg/Library/PlatformBootManagerLib/PlatformBootManager.c
It can be tested by passing the following option to
ArmVirtPkg's Platform BDS has never had a progress bar. We can easily add
one, by copying the PlatformBootManagerWaitCallback() function verbatim
from
Nt32Pkg/Library/PlatformBootManagerLib/PlatformBootManager.c
It can be tested by passing the following option to QEMU (5 seconds):
-boot
OVMF (unlike ArmVirtPkg) has traditionally cleared the screen after
connecting devices. This is not really necessary, and keeping the logo up
while the progress bar is advancing at the bottom looks great. So don't
clear the screen.
Cc: Jordan Justen
Cc: Ruiyu Ni
On 05/24/16 22:53, Jordan Justen wrote:
> Reviewed-by: Jordan Justen
Thank you guys for the reviews. Commit
855743f7177459bea95798e59b6b18dab867710c.
Cheers
Laszlo
> On 2016-05-18 15:12:53, Laszlo Ersek wrote:
>> According to edk2 commit
>>
>> "MdeModulePkg/PciBus:
Thanks Jaben, David, I am trying to link JSON parser to a UEFI driver which
uses mathlib, stringlib etc.. Let me try to create wrappers which uses
calls form MdePkg/MdeModulePkg.
Thanks,
Jabir
On Mon, May 23, 2016 at 10:51 PM, David Van Arnem
wrote:
> On 05/23/2016 08:15
On 05/24/16 23:15, Jordan Justen wrote:
> Series Reviewed-by: Jordan Justen
Thanks all for the reviews. Commit range
8caa3caaed4b32d699b79c6d5aaa606b52d740e7..d85c5e31ed2b550dd801f82e4ddb5f7583332098.
Cheers
Laszlo
> On 2016-05-17 12:59:10, Laszlo Ersek wrote:
>>
Jiaxin Wu (2):
MdePkg: Correct EFI_HTTP_CONFIGURE return status value
NetworkPkg: Correct HttpConfigure parameter check
MdePkg/Include/Protocol/Http.h | 1 -
NetworkPkg/HttpDxe/HttpImpl.c | 9 +
NetworkPkg/HttpDxe/HttpImpl.h | 1 -
3 files changed, 5 insertions(+), 6 deletions(-)
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Zhang Lubo
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiaxin Wu
---
MdePkg/Include/Protocol/Http.h | 1 -
1 file changed, 1 deletion(-)
diff --git
When HttpConfigData is NULL, HttpConfigure should not return
EFI_INVALID_PARAMETER.
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Zhang Lubo
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiaxin Wu
---
Reviewed-by: Eric Dong
> -Original Message-
> From: Bi, Dandan
> Sent: Friday, May 20, 2016 10:12 AM
> To: edk2-devel@lists.01.org
> Cc: Cecil Sheng; Qiu, Shumin; Dong, Eric
> Subject: [PATCH v2] MdeModulePkg/DisplayEngine: Fix memory leak issues in
> DisplayEngine
45 matches
Mail list logo