I've done some experimentation on the memory logging and if possible it is very
useful to have 4 stack frames (non-LTO) as it is common for the
MemoryAllocationLib to to call a sequence of Internal functions, so to find the
calling spot in the driver you need 4 entries.
For example:
FunctionTh
Reviewed-by: Cinnamon Shia
-Original Message-
From: Liming Gao [mailto:liming@intel.com]
Sent: Thursday, June 30, 2016 10:38 AM
To: edk2-devel@lists.01.org
Cc: Shia, Cinnamon
Subject: [Patch] IntelFrameworkModulePkg StatusCode RuntimeDxe: Remove
duplicated structure.
RUNTIME_MEMOR
Jordan,
Thanks for the suggestions.
I agree with both of your suggestions.
What's your plan about BltLib in OptionRomPkg?
Thanks,
Ray
> -Original Message-
> From: Justen, Jordan L
> Sent: Thursday, June 30, 2016 1:54 PM
> To: Ni, Ruiyu ; edk2-devel@lists.01.org
> Subject: Re: [edk2] [PAT
The v2 delta is reviewed by: jiewen@intel.com
> -Original Message-
> From: Zeng, Star
> Sent: Thursday, June 30, 2016 1:34 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Gao, Liming
> ; Zhu, Yonghong
> Subject: [PATCH V2 00/11] Enhance memory profile for memory leak
> detection
I have two suggestions:
1. Split "MdeModulePkg: Add FrameBufferBltLib" into two patches. I
prefer to add the library "interface" first (.dec and library .h
files fist), and then add the library implementation second. I like
to think about the interface as separate from the implementation.
This tool depends on DIA2Dump.exe (VS) or nm (gcc) to parse debug entry.
Usage: MemoryProfileSymbolGen.py [--version] [-h] [--help] [-i inputfile
[-o outputfile]]
Copyright (c) 2016, Intel Corporation. All rights reserved.
Options:
--version show program's version number and exit
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng
Reviewed-by: Jiewen Yao
---
.../DxeMemoryProfileLib.c | 102 ++
.../MemoryAllocationLib.c | 1057
.../UefiMemoryAllocationProfi
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng
Reviewed-by: Jiewen Yao
---
.../MemoryAllocationLib.c | 1140
.../SmmMemoryAllocationProfileLib.inf | 62 ++
.../SmmMemoryAllocationProfil
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng
---
.../DxeCoreMemoryAllocationLib.inf | 13 +-
.../DxeCoreMemoryAllocationLib.uni | 4 +-
...b.inf => DxeCoreMemoryAllocationProfileLib.inf} | 24 +-
.../DxeCoreMe
Current memory profile feature:
1. Shows which line of code calls gBS->AllocateXXX(). But most entries
are from MemoryAllocationLib.
2. Records at the start.
3. Records all modules.
Enhanced memory profile feature:
1. User can know which line of code calls AllocateXXX() API instead of
gBS->Allocat
Current memory profile feature:
1. Shows which line of code calls gBS->AllocateXXX(). But most entries
are from MemoryAllocationLib.
2. Records at the start.
3. Records all modules.
Enhanced memory profile feature:
1. User can know which line of code calls AllocateXXX() API instead of
gBS->Allocat
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng
---
.../MemoryAllocationLib.c | 188 +++--
.../PiSmmCoreMemoryAllocationLib.inf | 11 +-
.../PiSmmCoreMemoryAllocationLib.uni |
1. Implement include GetRecordingState/SetRecordingState/Record for
memory profile protocol.
2. Consume PcdMemoryProfilePropertyMask to support disable recording
at the start.
3. Consume PcdMemoryProfileDriverPath to control which drivers need
memory profile data.
Cc: Jiewen Yao
Contributed-under
Provides services to record memory profile of multilevel caller.
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng
Reviewed-by: Jiewen Yao
---
MdeModulePkg/Include/Library/MemoryProfileLib.h | 53 +
MdeModulePkg/MdeModulePkg
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng
Reviewed-by: Jiewen Yao
---
.../MemoryProfileInfo/MemoryProfileInfo.c | 884 +
.../MemoryProfileInfo/MemoryProfileInfo.inf| 3 +-
2 files changed, 725 insertion
1. Produce SMM memory profile protocol.
2. Consume PcdMemoryProfilePropertyMask to support disable recording
at the start.
3. Consume PcdMemoryProfileDriverPath to control which drivers need
memory profile data.
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by:
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng
---
MdeModulePkg/Core/Dxe/Mem/MemoryProfileRecord.c | 26 +
1 file changed, 26 insertions(+)
diff --git a/MdeModulePkg/Core/Dxe/Mem/MemoryProfileRecord.c
b/MdeModulePkg/Core/
Reviewed-by: Giri P Mudusuru
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Wu, Jiaxin
> Sent: Wednesday, June 29, 2016 2:35 AM
> To: Laszlo Ersek ; edk2-devel-01 de...@ml01.01.org>
> Cc: Fu, Siyuan
> Subject: Re: [edk2] [PATCH 2/6] Netw
Reviewed-by: Giri P Mudusuru
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Kinney, Michael D
> Sent: Wednesday, June 29, 2016 2:26 PM
> To: Laszlo Ersek ; edk2-devel-01 de...@ml01.01.org>; Kinney, Michael D
> Cc: Fan, Jeff
> Subject: R
Reviewed-by: Giri P Mudusuru
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Kinney, Michael D
> Sent: Wednesday, June 29, 2016 2:27 PM
> To: Laszlo Ersek ; edk2-devel-01 de...@ml01.01.org>; Kinney, Michael D
> Subject: Re: [edk2] [PATCH
All,
I forgot to mention the differences between last version and this version.
This version doesn't remove the BltLib in OptionRomPkg so in all, it doesn't
touch OptionRomPkg
and OvmfPkg which depends on BltLib.
This version also adopts Laszlo's suggestion to use opaque struct style to hide
the
Reviewed-by: Giri P Mudusuru
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Hao Wu
> Sent: Wednesday, June 29, 2016 6:57 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Yao, Jiewen
> Subject: [edk2] [PATCH v2] IntelFsp2WrapperPkg: Add
The driver uses the GraphicsInfo HOB and GraphicsDeviceInfo HOB
passed from PEI to find the graphics controller to manage and
produce the GraphicsOutput protocol.
GraphicsInfo HOB and GraphicsDeviceInfo HOB are created by
a PEIM which initializes the graphics controller hardware in
PEI phase.
Con
Reviewed-by: Giri P Mudusuru
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Hao Wu
> Sent: Wednesday, June 29, 2016 6:22 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Yao, Jiewen
> Subject: [edk2] [PATCH] IntelFsp2WrapperPkg: Add NUL
The patch serials add FrameBufferBltLib and GraphicsOutputDxe driver to
MdeModulePkg.
FrameBufferBltLib provides interfaces to perform UEFI Graphics
Output Protocol Video BLT operations
GraphicsOutputDxe uses the GraphicsInfo HOB and GraphicsDeviceInfo HOB
passed from PEI to find the graphics contr
This library provides interfaces to perform UEFI Graphics
Output Protocol Video BLT operations.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni
Cc: Feng Tian
Cc: Justen Jordan
Cc: Laszlo Ersek
---
MdeModulePkg/Include/Library/FrameBufferBltLib.h | 94 +++
..
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni
Cc: Liming Gao
---
MdePkg/Include/Guid/GraphicsInfoHob.h | 17 -
MdePkg/MdePkg.dec | 1 +
2 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/MdePkg/Include/Guid/Graphi
Series Reviewed-by: Samer El-Haj-Mahmoud
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu Siyuan
Sent: Wednesday, June 29, 2016 10:08 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch 0/2] Update-PXE-driver-to-follow-edk2-coding-standards
Reviewed-by: Giri P Mudusuru
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Fan, Jeff
> Sent: Wednesday, June 29, 2016 8:21 PM
> To: Gao, Liming ; edk2-devel@lists.01.org
> Subject: Re: [edk2] [Patch] IntelFrameworkModulePkg StatusCode
> Ru
Reviewed-by: Giri P Mudusuru
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Gao, Liming
> Sent: Tuesday, June 28, 2016 11:37 PM
> To: Laszlo Ersek ; edk2-devel-01 de...@ml01.01.org>
> Subject: Re: [edk2] [PATCH 1/6] EdkCompatibilityPkg: f
Reviewed-by: Giri P Mudusuru
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Jiewen Yao
> Sent: Tuesday, June 28, 2016 7:30 PM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Fan, Jeff
>
> Subject: [edk2] [PATCH] MdeModulePkg/PiSmm
> On Jun 29, 2016, at 8:14 PM, Gao, Liming wrote:
>
> Andrew:
> Thanks for your detail information.
> 1) We did the test to disable header file dependency, and find there is
> no obvious performance improvement.
It seemed like doing build on a target that had just built the slowest
ope
Reviewed-by: Jeff Fan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Thursday, June 30, 2016 10:38 AM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch] IntelFrameworkModulePkg StatusCode RuntimeDxe: Remove
duplicated structur
Andrew:
Thanks for your detail information.
1) We did the test to disable header file dependency, and find there is no
obvious performance improvement.
2) Build tool has genc and genmake target. Have you tried them?
3) We are evaluating to enable multiple thread in GenFd phase.
Hi,
I have two comments for this patch:
(1) Could you describe what's the purpose of below change? If it's for another
bug fix, we need to submit it in a separate patch.
- MmioWrite32 (MmioConf0, 0x2003CC00);
+ MmioWrite32 (MmioConf0, 0x2003CD00);
(2) For SF_DEVICE_ID0_W25QXX, we do have a
Reviewed-by: David Wei
Thanks,
David Wei
Intel SSG BIOS Team
-Original Message-
From: Lu, ShifeiX A
Sent: Tuesday, June 21, 2016 3:42 PM
To: edk2-devel@lists.01.org
Cc: Wei; Wei, David
Subject: [Patch] Vlv2TbltDevicePkg:Add PiSmmCommunication&PiSmmCpuDxeSmm of
Series Reviewed-by: Zhang Lubo
-Original Message-
From: Fu, Siyuan
Sent: Thursday, June 30, 2016 10:08 AM
To: edk2-devel@lists.01.org
Cc: Wu, Jiaxin ; Zhang, Lubo
Subject: [Patch 1/2] MdeModulePkg: Update PXE driver to follow edk2 coding
standards.
Cc: Wu Jiaxin
Cc: Zhang Lubo
Contr
Laszlo:
I have sent the patch to fix it. Besides, I suggest to update Ovmf DSC/FDF to
use StatusCode Router and Handler from MdeModulePkg instead of
IntelFrameworkModulePkg.
Thanks
Liming
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> G
RUNTIME_MEMORY_STATUSCODE_HEADER has been moved into MdeModulePkg public header
file Include/Guid/MemoryStatusCodeRecord.h. It should be removed from the
driver.
Cc: Cinnamon Shia
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao
---
.../Universal/StatusCode/Run
Reviewed-by: David Wei
Thanks,
David Wei
Intel SSG BIOS Team
-Original Message-
From: Guo, Mang
Sent: Wednesday, June 29, 2016 1:13 PM
To: edk2-devel@lists.01.org
Cc: Wei, David
Subject: [PATCH] Vlv2TbltDevicePkg: Enable PCIE port 2 by default to support
dual
Jordan,
I misunderstood your option.
I am fine to add a new library class FrameBufferBltLib and leave BltLib as is.
Thanks,
Ray
-Original Message-
From: Justen, Jordan L
Sent: Thursday, June 30, 2016 4:42 AM
To: Ni, Ruiyu ; edk2-devel@lists.01.org
Subject: Re: [edk2] [PATCH 0/9] Add Fram
Cc: Wu Jiaxin
Cc: Zhang Lubo
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Fu Siyuan
---
MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcSupport.c | 4 ++--
MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcSupport.h | 4 ++--
2 files changed, 4 insertions(+), 4 deletio
Fu Siyuan (2):
MdeModulePkg: Update PXE driver to follow edk2 coding standards.
NetworkPkg: Update PXE driver to follow edk2 coding standards.
MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcSupport.c | 4 ++--
MdeModulePkg/Universal/Network/UefiPxeBcDxe/PxeBcSupport.h | 4 ++--
NetworkPkg/
Cc: Wu Jiaxin
Cc: Zhang Lubo
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Fu Siyuan
---
NetworkPkg/UefiPxeBcDxe/PxeBcSupport.c | 6 +++---
NetworkPkg/UefiPxeBcDxe/PxeBcSupport.h | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/NetworkPkg/UefiPxe
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Wu, Hao A
> Sent: Thursday, June 30, 2016 9:57 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Yao, Jiewen
> Subject: [PATCH v2] IntelFsp2WrapperPkg: Add error handling for possible
> NULL ptr dereference
>
> Possible NULL
Possible NULL pointer dereference for FspmHeaderPtr/FspsHeaderPtr in
module FspmWrapperPeim/FspsWrapperPeim.
Add error handling codes to avoid this issue.
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu
---
IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWr
Possible NULL pointer dereference for FspmHeaderPtr/FspsHeaderPtr in
module FspmWrapperPeim/FspsWrapperPeim.
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu
---
IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c | 1 +
IntelFsp2WrapperPkg/FspsWrap
Yes. I will make one patch to fix it. Thanks for your report.
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Thursday, June 30, 2016 1:40 AM
To: Bruce Cran ; Cinnamon Shia ;
edk2-de...@ml01.01.org
Cc: Tian, Feng ; Gao, Liming ; Zeng,
Star
Subject: Re: [edk2] [PATCH v2] MdeModulePkg/MemoryS
> On Jun 29, 2016, at 3:06 PM, Kinney, Michael D
> wrote:
>
> Why can't we simply use the target.txt TOOL_CHAIN_CONF define
> in target.txt as it works today? You could split tools_def.txt
> into several versions, with the default one being the maintained
> one and developers can opt into comm
> On Jun 29, 2016, at 3:19 PM, Kinney, Michael D
> wrote:
>
> Liming,
>
> Thank you Liming and Jordan for all the effort on the conversion
> tool and patches to update all packages with NASM support and the
> work done to verify that the NASM files produced the same object
> code as MASM.
>
Liming,
Thank you Liming and Jordan for all the effort on the conversion
tool and patches to update all packages with NASM support and the
work done to verify that the NASM files produced the same object
code as MASM.
A follow up question I have for the EDK II community is if there
is interest
> On Jun 29, 2016, at 2:55 PM, Jordan Justen wrote:
>
> On 2016-06-29 14:43:30, Andrew Fish wrote:
>>
>>> On Jun 29, 2016, at 2:40 PM, Jordan Justen
>>> wrote:
>>>
>>> Second, didn't Andrew find that parsing tools_def.txt was taking a
>>> significant amount of time during each build invocati
Reviewed-by: Michael Kinney
Mike
> -Original Message-
> From: Yao, Jiewen
> Sent: Wednesday, June 29, 2016 2:46 PM
> To: edk2-devel@lists.01.org
> Cc: Fan, Jeff ; Kinney, Michael D
> ;
> Laszlo Ersek
> Subject: [PATCH V2] MdeModulePkg/PiSmmCore: Replace BASE_4GB with MAX_ADDRESS
> che
Jordan,
My mistake. I responded to the wrong email.
Additional responses below.
Mike
> -Original Message-
> From: Justen, Jordan L
> Sent: Wednesday, June 29, 2016 2:40 PM
> To: Kinney, Michael D ; Shi, Steven
> ;
> edk2-devel@lists.01.org; Gao, Liming ; Kinney, Michael D
>
> Cc:
On 2016-06-29 12:30:35, Olaf Hering wrote:
> Adjust the code to look forward instead of backwards.
> Existing gcc releases are known to work or break. Upcoming gcc releases
> are assumed to work like the last handled gcc version does.
> Doing it that way will reduce the burden to update the script
On 2016-06-29 14:43:30, Andrew Fish wrote:
>
> > On Jun 29, 2016, at 2:40 PM, Jordan Justen
> > wrote:
> >
> > Second, didn't Andrew find that parsing tools_def.txt was taking a
> > significant amount of time during each build invocation?
>
> It was getting parsed 47 times, when it should only
On 06/29/16 23:45, Jiewen Yao wrote:
> PI specification Vol 4 - SMM does not have any limitation of BASE_4GB for SMM.
> So we should replace BASE_4GB check with MAX_ADDRESS check to make sure
> the SMM memory is accessible by SMM Core.
>
> Cc: Jeff Fan
> Cc: Michael D Kinney
> Cc: Laszlo Ersek
On 2016-06-29 14:31:49, Andrew Fish wrote:
>
> > On Jun 29, 2016, at 2:02 PM, Jordan Justen
> > wrote:
> >
> > On 2016-06-28 08:18:57, Shi, Steven wrote:
> >> Both GCC and LLVM 3.8 64bits support new variable argument (VA)
> >
> > Which versions of GCC? Maybe we should define MS_VA_LIST on the
PI specification Vol 4 - SMM does not have any limitation of BASE_4GB for SMM.
So we should replace BASE_4GB check with MAX_ADDRESS check to make sure
the SMM memory is accessible by SMM Core.
Cc: Jeff Fan
Cc: Michael D Kinney
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement
> On Jun 29, 2016, at 2:40 PM, Jordan Justen wrote:
>
> Second, didn't Andrew find that parsing tools_def.txt was taking a
> significant amount of time during each build invocation?
It was getting parsed 47 times, when it should only get parsed one time. I
thought that bug got fixed.
If you
PI specification Vol 4 - SMM does not have any limitation of BASE_4GB for SMM.
So we should replace BASE_4GB check with MAX_ADDRESS check to make sure
the SMM memory is accessible by SMM Core.
Cc: Jeff Fan
Cc: Michael D Kinney
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement
Why didn't you reply to my message where I made the related comments?
It kind of confuses the email threading this way...
On 2016-06-29 14:04:49, Kinney, Michael D wrote:
> Jordan,
>
> Steven has been maintaining a public branch of this work at:
>
> https://github.com/shijunjing/edk2/tree
>
> T
> On Jun 29, 2016, at 2:02 PM, Jordan Justen wrote:
>
> On 2016-06-28 08:18:57, Shi, Steven wrote:
>> Both GCC and LLVM 3.8 64bits support new variable argument (VA)
>
> Which versions of GCC? Maybe we should define MS_VA_LIST on the
> command line for toolchains that can support this?
>
Mayb
On 06/29/16 22:42, Gerd Hoffmann wrote:
> Hi,
>
>> ... Hm, actually, I have one suspect. In your report, you said the
>> boot option called "UEFI PXEv4" worked fine. "EFI Network" didn't, and
>> it was higher up in the boot order.
>>
>> I think "EFI Network" could be a left-over boot option (fro
Reviewed-by: Michael Kinney
Mike
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Tuesday, June 28, 2016 6:26 AM
> To: edk2-devel-01
> Cc: Kinney, Michael D ; Steele, Kelly
>
> Subject: [PATCH 3/6] QuarkPlatformPkg: fix ASSERT_EFI_ERROR() typos
>
> A number
Reviewed-by: Michael Kinney
Mike
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
> Ersek
> Sent: Tuesday, June 28, 2016 6:26 AM
> To: edk2-devel-01
> Cc: Fan, Jeff
> Subject: [edk2] [PATCH 5/6] UefiCpuPkg: fix ASSERT_EFI_ERROR() typ
> On Jun 29, 2016, at 2:23 PM, Kinney, Michael D
> wrote:
>
> Reviewed-by: Michael Kinney
>
Reviewed-by: Andrew Fish
>> -Original Message-
>> From: Shi, Steven
>> Sent: Tuesday, June 28, 2016 8:19 AM
>> To: edk2-devel@lists.01.org; Gao, Liming
>> Cc: Kinney, Michael D ; af...@apple
Reviewed-by: Michael Kinney
> -Original Message-
> From: Shi, Steven
> Sent: Tuesday, June 28, 2016 8:19 AM
> To: edk2-devel@lists.01.org; Gao, Liming
> Cc: Kinney, Michael D ; af...@apple.com; Shi,
> Steven
>
> Subject: [PATCH 6/7] QuarkSocPkg-OhicPei: Fix wrong operator
>
> LANG38 f
Jordan,
Steven has been maintaining a public branch of this work at:
https://github.com/shijunjing/edk2/tree
The latest patch series appears to be in the following branch:
https://github.com/shijunjing/edk2/tree/review4
Why do you think we do not need a new tool chain tag for CLANG based stati
On 2016-06-28 08:18:57, Shi, Steven wrote:
> Both GCC and LLVM 3.8 64bits support new variable argument (VA)
Which versions of GCC? Maybe we should define MS_VA_LIST on the
command line for toolchains that can support this?
-Jordan
> intrinsics for Microsoft ABI, enable these new VA intrinsics f
The subject prefix should be: "BaseTools/GenFw"
Should this patch move before 1/7?
-Jordan
On 2016-06-28 08:18:56, Shi, Steven wrote:
> Add support to convert missing Elf relocation types
> (R_X86_64_PLT32, R_X86_64_GOTPCREL, R_X86_64_REX_GOTPCRELX)
> to PeCoff, which are required by LTO image.
Andrew,
I agree that we need to root cause and fix this code issue.
I also like idea of doing RELEASE/DEBUG/NOOPT builds to make sure code changes
do not introduce build failures.
Mike
> -Original Message-
> From: af...@apple.com [mailto:af...@apple.com]
> Sent: Wednesday, June 29, 201
This should be 3 separate commits. It should be obvious in the commit
subject line what toolchain is being added.
Can you post a public branch with your commits? Maybe on a personal
github fork of the edk2 repo.
On 2016-06-28 08:18:55, Shi, Steven wrote:
> Enable three new toolchains: CLANG38, CL
Hi,
> ... Hm, actually, I have one suspect. In your report, you said the
> boot option called "UEFI PXEv4" worked fine. "EFI Network" didn't, and
> it was higher up in the boot order.
>
> I think "EFI Network" could be a left-over boot option (from the old
> IntelFrameworkModulePkg BDS) that do
On 2016-06-29 06:24:31, Ruiyu Ni wrote:
> The patch serials refine the FrameBufferBltLib in OptionRomPkg and move it to
> MdeModulePkg. Based on the library, a generic GOP driver GraphicsOutputDxe
> is developed and added to MdeModulePkg.
>
> Ruiyu Ni (9):
> OptionRomPkg: Refine FrameBufferBltLi
On 06/29/16 21:30, Olaf Hering wrote:
> Adjust the code to look forward instead of backwards.
> Existing gcc releases are known to work or break. Upcoming gcc releases
> are assumed to work like the last handled gcc version does.
> Doing it that way will reduce the burden to update the script for e
> On Jun 28, 2016, at 8:18 AM, Shi, Steven wrote:
>
> Enable three new toolchains: CLANG38, CLANGSCAN38 and GCC53.
> (1)CLANG38 uses Clang3.8.0, enable LLVM Link Time Optimization (LTO)
> and code size optimization flag (-Oz) by default for aggressive code
> size improvement. CLANG38 X64 code is
> On Jun 28, 2016, at 8:18 AM, Shi, Steven wrote:
>
> Quark AcpiPlatform module cannot link successfully by CLANG38
> with Oz optimization level. Add a work around to downgrade the
> optimization to O1.
>
We should fix the code too. These bugs are usually structure assignments in the
scope of
On 06/29/16 15:24, Ruiyu Ni wrote:
> The patch serials refine the FrameBufferBltLib in OptionRomPkg and move it to
> MdeModulePkg. Based on the library, a generic GOP driver GraphicsOutputDxe
> is developed and added to MdeModulePkg.
>
> Ruiyu Ni (9):
> OptionRomPkg: Refine FrameBufferBltLib to
Andrew,
I agree. I will work with Steven on this module to improve its compiler
compatibility.
Mike
> -Original Message-
> From: af...@apple.com [mailto:af...@apple.com]
> Sent: Wednesday, June 29, 2016 10:57 AM
> To: Shi, Steven
> Cc: edk2-devel ; Gao, Liming ;
> Kinney,
> Michael D
> On Jun 28, 2016, at 8:18 AM, Shi, Steven wrote:
>
> The MRC use the memset() in the code and assume the compiler to offer
> such builtin fuctions. Add work around to permit compiler add builtin
> functions in this module. Also MRC mix some inline assembly,
> e.g. asm("rdtsc":"=a"(tscL),"=d"(ts
On 06/29/16 16:47, Bruce Cran wrote:
> On 6/27/2016 1:25 AM, Cinnamon Shia wrote:
>> Let data of DXE memory status code can be used by other modules.
>> 1. Save the address of DXE memory status code table to
>> DxeConfigurationTable.
>> 2. Save the address of SMM memory status code table to
>> SmmC
On 06/29/16 16:30, Michael Brown wrote:
> On 29/06/16 02:52, Gary Lin wrote:
>> On Tue, Jun 28, 2016 at 01:43:31PM +0100, Michael Brown wrote:
>>> diff --git a/src/interface/efi/efi_hii.c b/src/interface/efi/efi_hii.c
>>> index 0ea970e..506fc88 100644
>>> --- a/src/interface/efi/efi_hii.c
>>> +++ b
Reviewed-by: Giri P Mudusuru
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Star Zeng
> Sent: Wednesday, June 29, 2016 7:24 AM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen
> Subject: [edk2] [PATCH] MdeModulePkg VariableInfo: Fix GCC bu
On 6/27/2016 1:25 AM, Cinnamon Shia wrote:
Let data of DXE memory status code can be used by other modules.
1. Save the address of DXE memory status code table to DxeConfigurationTable.
2. Save the address of SMM memory status code table to SmmConfigurationTable.
3. Move RUNTIME_MEMORY_STATUSCODE
Yes. It should related to PIC/PIE code. I will correct my commit log later.
Thank you let me know it.
Steven Shi
Intel\SSG\STO\UEFI Firmware
Tel: +86 021-61166522
iNet: 821-6522
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Wednesday, June 29,
On 29 June 2016 at 15:59, Shi, Steven wrote:
> Ok, will separate it. Thank you to let me know it.
>
BTW, your commit log suggests that these relocation types are somehow
related to LTO, but I think they are more related to PIC/PIE code,
right? So even if you disable LTO, you may encounter these
On 29/06/16 02:52, Gary Lin wrote:
On Tue, Jun 28, 2016 at 01:43:31PM +0100, Michael Brown wrote:
diff --git a/src/interface/efi/efi_hii.c b/src/interface/efi/efi_hii.c
index 0ea970e..506fc88 100644
--- a/src/interface/efi/efi_hii.c
+++ b/src/interface/efi/efi_hii.c
@@ -117,6 +117,7 @@ static vo
GCC build failure: 'RealCommSize' may be used uninitialized
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng
---
MdeModulePkg/Application/VariableInfo/VariableInfo.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/MdeModulePkg/Application/Varia
Ok, will separate it. Thank you to let me know it.
Steven Shi
Intel\SSG\STO\UEFI Firmware
Tel: +86 021-61166522
iNet: 821-6522
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Wednesday, June 29, 2016 9:30 PM
> To: Shi, Steven
> Cc: edk2-devel-01
Thanks Laszlo.
You have sharp eyes to catch the minus 1 issue. :)
Thank you
Yao Jiewen
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Wednesday, June 29, 2016 9:47 PM
To: Yao, Jiewen ; edk2-de...@ml01.01.org
Cc: Kinney, Michael D ; Fan, Jeff
Subject: Re: [edk2] [PATCH] MdeModulePkg/PiSmmC
On 06/29/16 15:28, Yao, Jiewen wrote:
> I forget to mention:
>
> I agree with you on #2 -
> (2) The comparison is not appropriate here (after the patch); it is toostrict.
>
> BASE_4GB is an exclusive limit, hence the pre-patch status is good. But
> MAX_ADDRESS is an inclusive limit, so the condit
On 06/29/16 15:02, Yao, Jiewen wrote:
> HI Laszlo
>
> I appreciate your careful review.
>
> I would like to clarify why we did not consider adding check for integer
> overflow.
>
> The EDKII security model is that:
>
> 1) We trust any internal data communication before EndOfDxe. We
> have
On 06/29/16 14:25, Gerd Hoffmann wrote:
> Hi,
>
>>> bootindex not working is still there, with both old and new ipxe rom
>>> builds.
>>
>> Hrmph. That is strange. Can you please give me a bit more info?
>>
>> I'm asking because I tested the following configuration last night:
>> - I350-T2V2 virt
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni
Cc: Liming Gao
---
MdePkg/Include/Guid/GraphicsInfoHob.h | 17 -
MdePkg/MdePkg.dec | 1 +
2 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/MdePkg/Include/Guid/Graphi
Laszlo,
Thank you for the sharing. Your patches really help to improve the EDKII code
quality.
Regards,
Ray
>-Original Message-
>From: Laszlo Ersek [mailto:ler...@redhat.com]
>Sent: Wednesday, June 29, 2016 7:50 PM
>To: Ni, Ruiyu ; edk2-devel-01
>Cc: Carsey, Jaben ; Qiu, Shumin
>Subjec
On 28 June 2016 at 17:18, Shi, Steven wrote:
> Add support to convert missing Elf relocation types
> (R_X86_64_PLT32, R_X86_64_GOTPCREL, R_X86_64_REX_GOTPCRELX)
> to PeCoff, which are required by LTO image.
>
Could you please put the changes that affect other architectures in a
separate patch?
Th
I forget to mention:
I agree with you on #2 - (2) The comparison is not appropriate here (after the
patch); it is too strict.
BASE_4GB is an exclusive limit, hence the pre-patch status is good. But
MAX_ADDRESS is an inclusive limit, so the condition should be
CpuStart + PhysicalSize - 1 <= MA
Using UINT8* can remove the unnecessary VOID* type cast.
The patch also rename the BltMemSrc/BltMemDest to Source/Destination.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni
Cc: Laszlo Ersek
Cc: Jordan Justen
---
.../Library/FrameBufferBltLib/FrameBufferBltLib.
The bug can be reproduced by the BltLibSample application
TestMove1() test case. The old code cannot handle the case
when the source and destination video is overlapped.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni
Cc: Laszlo Ersek
Cc: Jordan Justen
---
Optio
1 - 100 of 121 matches
Mail list logo
