Re: [edk2] [PATCH] MdeModulePkg/Bds: MemoryTypeInformation excludes boot option mem use

2016-07-05 Thread Wang, Sunny (HPS SW)
The patch looks good. I also tested this patch on my system to boot a large size HTTP image (.iso), and it works well. Thanks for quickly working out the permanent fix. Reviewed-by: Sunny Wang Regards, Sunny Wang -Original Message- From: Ruiyu Ni [mailto:ruiyu...@intel.com] Sent: Tue

Re: [edk2] [PATCH] CryptoPkg: Fix openssl bn_exp to avoid alloca on RVCT

2016-07-05 Thread Long, Qin
Will check this. I didn't validate RVCT build before. I am curious if this is one new link issue? Best Regards & Thanks, LONG, Qin > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Cohen, Eugene > Sent: Wednesday, July 06, 2016 4:07 AM > To

[edk2] [PATCH] EmbeddedPkg/AcpiLib: add GICC table init macro for ACPI 6.0

2016-07-05 Thread Graeme Gregory
ACPI 6.0 added a processor efficiency field and 3 reserved bytes at the end of the GICC structure so add a new macro to initialise the new field. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Graeme Gregory --- EmbeddedPkg/Include/Library/AcpiLib.h | 9 + 1 file

[edk2] [PATCH] CryptoPkg: Fix openssl bn_exp to avoid alloca on RVCT

2016-07-05 Thread Cohen, Eugene
One more thing, I'm not sure how you want to address it, upstreaming or modifying the edk2 patch... We also ran into an issue where we had to qualify the __GNUC__ check to exclude RVCT so that alloca wasn't used for allocations (it caused linker errors trying to get library support that didn't

Re: [edk2] [PATCH] CryptoPkg: update openssl to ignore RVCT 3079

2016-07-05 Thread Cohen, Eugene
> > corrects x509_vfy.c(875): error C3017: ok may be used before being > set > > > > Change-Id: I0d38193569b29f96861a191908c343831fd957c2 > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Eugene Cohen > > Can we "fix" the upstream code instead? No objection here - co

Re: [edk2] [PATCH] CryptoPkg: update openssl to ignore RVCT 3079

2016-07-05 Thread Long, Qin
Yes, this unset issue was already fixed in OpenSSL HEAD. The patch is OK for me to ignore the warning for current 1.0.2 version. Or we can backport some cleanups into our 1.0.2xx patch. Best Regards & Thanks, LONG, Qin > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@l

Re: [edk2] [PATCH] CryptoPkg: update openssl to ignore RVCT 3079

2016-07-05 Thread David Woodhouse
On Tue, 2016-07-05 at 15:53 +, Cohen, Eugene wrote: > Getting openssl 1.0.2g building with ARM RVCT requires a change to ignore an > unset > variable used before set was necessary. > > corrects x509_vfy.c(875): error C3017: ok may be used before being set > > Change-Id: I0d38193569b29f96861a

[edk2] [PATCH] CryptoPkg: update openssl to ignore RVCT 3079

2016-07-05 Thread Cohen, Eugene
Getting openssl 1.0.2g building with ARM RVCT requires a change to ignore an unset variable used before set was necessary. corrects x509_vfy.c(875): error C3017: ok may be used before being set Change-Id: I0d38193569b29f96861a191908c343831fd957c2 Contributed-under: TianoCore Contribution Agreeme

Re: [edk2] [PATCH 3/4] MdeModulePkg/PciBusDxe: recognize hotplug-capable PCIe ports

2016-07-05 Thread Laszlo Ersek
On 07/05/16 12:54, Laszlo Ersek wrote: > On 07/04/16 09:38, Ni, Ruiyu wrote: >> Adding Kinney. >> >> Laszlo, >> Your patch assumes all PCIE slot are hot plug capable. > > Yes, it does assume that. > >> But why PCIE spec 3.0 chapter 7.8.9 Slot Capabilities Register (Offset 14h) >> contains a BIT c

Re: [edk2] [PATCH] OvmfPkg/build.sh: update gcc detection

2016-07-05 Thread Laszlo Ersek
On 06/30/16 12:16, Laszlo Ersek wrote: > On 06/30/16 07:00, Olaf Hering wrote: >> On Wed, Jun 29, Jordan Justen wrote: >> >>> Missing Contributed-under. (See OvmfPkg/Contributions.txt) >> >> Looks like this project tries to avoid simple fixes from third party. > > It's not the case. Every project

Re: [edk2] multiprocessing in PEI?

2016-07-05 Thread Fan, Jeff
When CPU MP PPI installed, CPU MP PPI Services will be fully usable. Thanks! Jeff -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, July 05, 2016 9:10 PM To: Kinney, Michael D; Fan, Jeff; Justen, Jordan L Cc: Paolo Bonzini; edk2-devel-01 Subject: Re: [edk2] m

Re: [edk2] multiprocessing in PEI?

2016-07-05 Thread Laszlo Ersek
On 07/05/16 12:01, Laszlo Ersek wrote: > Not sure if we should add this client code to OvmfPkg/PlatformPei, due > to the DEPEX. OvmfPkg/PlatformPei is the PEIM that installs the > permanent PEI RAM, so if we added this DEPEX to it, that would force > CpuMpPei to run from temporary PEI RAM. I don't

[edk2] UEFI driver for USB CDC ACM Serial device

2016-07-05 Thread GN Keshava
Hi all, I'm new to UEFI development. So far, I have learnt about UEFI shell, build procedure and application basics. My task is to communicate to a custom board from UEFI using uefi app through a USB serial cable from the PC. Currently, the PC is booted to UEFI shell and connected the board thro

Re: [edk2] [PATCH 3/4] MdeModulePkg/PciBusDxe: recognize hotplug-capable PCIe ports

2016-07-05 Thread Laszlo Ersek
On 07/04/16 09:38, Ni, Ruiyu wrote: > Adding Kinney. > > Laszlo, > Your patch assumes all PCIE slot are hot plug capable. Yes, it does assume that. > But why PCIE spec 3.0 chapter 7.8.9 Slot Capabilities Register (Offset 14h) > contains a BIT called Hot-Plug Capable? > Does your patch also need

Re: [edk2] [PATCH v2] MdeModulePkg/MemoryStatusCode: Expose the DXE memory status code table.

2016-07-05 Thread Laszlo Ersek
On 07/04/16 08:20, Gao, Liming wrote: > Laszlo: > MdeModulePkg ones follows PI spec to implement StatusCode > Router/Handler and provide StatusCode service. It allows the > different status code handlers to be registered. > IntelFrameworkModulePkg one just provides StatusCode service. It has > no R

Re: [edk2] [Patch] MdeModulePkg: Fix IPv4 stack potential disappeared issue

2016-07-05 Thread Zhang, Lubo
The patch is good to me, already tested. Reviewed-by: Zhang Lubo -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiaxin Wu Sent: Thursday, June 30, 2016 3:59 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Zhang, Lubo ; Fu, Siyuan Subject: [edk2]

[edk2] multiprocessing in PEI?

2016-07-05 Thread Laszlo Ersek
Hi, for this item : RFE: OvmfPkg: Set MSR_IA32_FEATURE_CONTROL by following QEMU fw_cfg file the goal is to do the following: - fetch a UINT64 value from QEMU via fw_cfg - write that UINT64 value to a specific MSR on *all* logical processors (BS

Re: [edk2] [PATCH] MdeModulePkg/Bds: MemoryTypeInformation excludes boot option mem use

2016-07-05 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Ni, Ruiyu Sent: Tuesday, July 5, 2016 5:47 PM To: edk2-devel@lists.01.org Cc: Sunny Wang ; Zeng, Star Subject: [PATCH] MdeModulePkg/Bds: MemoryTypeInformation excludes boot option mem use The patch re-orders the sequences by putting upda

[edk2] [PATCH] MdeModulePkg/Bds: MemoryTypeInformation excludes boot option mem use

2016-07-05 Thread Ruiyu Ni
The patch re-orders the sequences by putting updating memory type information before loading the boot option so that the reserved memory usage by HTTP RAM disk boot can be excluded by the memory type information updating. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu

[edk2] [patch] MdeModulePkg/HiiDB: Record fail info if fail to save data for EfiVarStore

2016-07-05 Thread Dandan Bi
HiiConfigRoutingRouteConfig function returns 'Progress' to indicate the failure info in the ConfigResp string. But when fail to route the ConfigResp for EfiVarStore, it doesn't return the correct failure info. Now this patch is to fix this issue and add debug info let user know the reason of failur

[edk2] [patch] MdeModulePkg/BootMaintUi: Add error handling codes when AllocatePool fail

2016-07-05 Thread Dandan Bi
The AllocateCopyPool in function ExtractFileNameFromDevicePath may return NULL, so need to do error handling. This patch is to add error handling codes for function ExtractFileNameFromDevicePath and its caller functions. Cc: Eric Dong Cc: Hao Wu Contributed-under: TianoCore Contribution Agreemen

Re: [edk2] [PATCH v2] MdeModulePkg UefiPxeBcDxe: Fix build error for lastest VS2015 compiler

2016-07-05 Thread Wu, Jiaxin
Reviewed-By: Wu Jiaxin Best Regards! Jiaxin > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Hao Wu > Sent: Tuesday, July 5, 2016 12:59 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Ye, Ting ; Fu, > Siyuan ; Wu, Jiaxin > Subject: [edk2

[edk2] [PATCH] Change ShellPkg&ShellBinPkg maintainer

2016-07-05 Thread Ruiyu Ni
Since Shumin has left Intel to pursue a better job, I will temporary be on his position to maintain ShellPkg and ShellBinPkg with Jaben. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Carsey Jaben --- Maintainers.txt | 4 ++-- 1 file changed, 2 insertions(+)