Reviewed-by: Giri P Mudusuru
> -Original Message-
> From: Gao, Liming
> Sent: Friday, July 8, 2016 7:49 AM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Mudusuru, Giri P
>
> Subject: [Patch 2/5] IntelFsp2WrapperPkg
> SecFspWrapperPlatformSecLibSample: Remove MASM/GAS files
>
> Keep
Reviewed-by: Giri P Mudusuru
> -Original Message-
> From: Gao, Liming
> Sent: Friday, July 8, 2016 7:49 AM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Mudusuru, Giri P
>
> Subject: [Patch 1/5] IntelFsp2WrapperPkg BaseFspWrapperApiLib: Remove
> MASM/GAS files
>
> Keep NASM file on
Reviewed-by: Giri P Mudusuru
> -Original Message-
> From: Gao, Liming
> Sent: Friday, July 8, 2016 7:49 AM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Mudusuru, Giri P
>
> Subject: [Patch 3/5] IntelFsp2Pkg BaseFspDebugLibSerialPort: Remove
> MASM/GAS files
>
> Keep NASM file only
Reviewed-by: Giri P Mudusuru
> -Original Message-
> From: Gao, Liming
> Sent: Friday, July 8, 2016 7:49 AM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Mudusuru, Giri P
>
> Subject: [Patch 4/5] IntelFsp2Pkg BaseFspSwitchStackLib: Remove MASM/GAS
> files
>
> Keep NASM file only for
Reviewed-by: Giri P Mudusuru
> -Original Message-
> From: Gao, Liming
> Sent: Friday, July 8, 2016 7:49 AM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Mudusuru, Giri P
>
> Subject: [Patch 5/5] IntelFsp2Pkg SecFspSecPlatformLibNull: Remove
> MASM/GAS files
>
> Keep NASM file only
Keep NASM file only for new added modules.
Cc: Jiewen Yao
Cc: Giri Mudusuru
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao
---
.../BaseFspSwitchStackLib.inf | 2 -
.../Library/BaseFspSwitchStackLib/Ia32/Stack.asm | 77 -
Keep NASM file only for new added modules.
Cc: Jiewen Yao
Cc: Giri Mudusuru
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao
---
.../SecFspSecPlatformLibNull/Ia32/Flat32.asm | 131 -
.../Library/SecFspSecPlatformLibNull/Ia32/Flat32.s |
Keep NASM file only for new added modules.
Cc: Jiewen Yao
Cc: Giri Mudusuru
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao
---
.../BaseFspDebugLibSerialPort.inf | 2 --
.../BaseFspDebugLibSerialPort/Ia32/FspDebug.asm| 34
Keep NASM file only for new added modules.
Cc: Jiewen Yao
Cc: Giri Mudusuru
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao
---
.../Ia32/PeiCoreEntry.S| 130
.../Ia32/PeiCoreEntry.asm | 140
After NASM source files are added, MASM/GAS source files will not be kept for
new added modules and packages. IntelFsp2Pkg and IntelFps2WrapperPkg are added
recently. They can be regarded as new packages. So, these changes remove
MASM/GAS source files and keep NASM only for these two packages.
Keep NASM file only for new added modules.
Cc: Jiewen Yao
Cc: Giri Mudusuru
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao
---
.../BaseFspWrapperApiLib/BaseFspWrapperApiLib.inf | 2 -
.../Library/BaseFspWrapperApiLib/X64/Thunk64To32.S | 230 ---
On 8 July 2016 at 15:48, Shi, Steven wrote:
> Hi Ard,
> You know, edk2 enforce the Elf section generation by link script
> \BaseTools\Scripts\GccBase.lds. In the below part of GccBase.lds, you can see
> edk2 has force linker to put .rodata into .text section. This is why I hope
> to add SHF_EXE
Hi Ard,
You know, edk2 enforce the Elf section generation by link script
\BaseTools\Scripts\GccBase.lds. In the below part of GccBase.lds, you can see
edk2 has force linker to put .rodata into .text section. This is why I hope to
add SHF_EXECINSTR flag in the section check logic.
.text : ALIG
On 07/08/16 12:33, Ard Biesheuvel wrote:
> On 8 July 2016 at 12:31, Laszlo Ersek wrote:
>> This patch ports Gary's OvmfPkg commit 14b2ebc30c8b to ArmVirtPkg.
>>
>> Turns out Gary's argument in 14b2ebc30c8b is not only valid for Xen. The
>> same situation arises with QEMU if:
>> - the user specifie
On 8 July 2016 at 12:31, Laszlo Ersek wrote:
> This patch ports Gary's OvmfPkg commit 14b2ebc30c8b to ArmVirtPkg.
>
> Turns out Gary's argument in 14b2ebc30c8b is not only valid for Xen. The
> same situation arises with QEMU if:
> - the user specifies no boot order via fw_cfg at all (so QemuBootOr
This patch ports Gary's OvmfPkg commit 14b2ebc30c8b to ArmVirtPkg.
Turns out Gary's argument in 14b2ebc30c8b is not only valid for Xen. The
same situation arises with QEMU if:
- the user specifies no boot order via fw_cfg at all (so QemuBootOrderLib
won't touch the boot order), and
- the varstor
Reviewed-by: Star Zeng
-Original Message-
From: Wu, Hao A
Sent: Friday, July 8, 2016 12:35 PM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A ; Zeng, Star
Subject: [PATCH] MdeModulePkg MemoryProfile: ASSERT to ensure 'DriverInfoData'
is not NULL
Code logic ensures that the pointer 'DriverIn
On 07/08/16 10:59, Fan, Jeff wrote:
> Laszlo,
>
> Thanks your feedback and provided the history on MTRRs sync code.
>
> DEBUG () running on Aps is a common issue to be avoided.
> For MtrrLib, DEBUG() is using DEBUG_CACHE for debug purpose only.
> Usually, MTRRs setting should be same between BSP/
On 8 July 2016 at 10:42, Shi, Steven wrote:
> Add SHF_EXECINSTR attribute flag in logic to check Elf Text and
> Data section type.
Why?
> Also fix some typo in the code comments and
> Debug strings.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Steven Shi
> ---
>
Laszlo,
Thanks your feedback and provided the history on MTRRs sync code.
DEBUG () running on Aps is a common issue to be avoided.
For MtrrLib, DEBUG() is using DEBUG_CACHE for debug purpose only. Usually,
MTRRs setting should be same between BSP/Aps. Dump MTRRs are enough for BSP.
Maybe, we co
On Fri, Jul 8, 2016 at 9:42 AM, Shi, Steven wrote:
> LANG38 uses Clang3.8.0, enable LLVM Link Time Optimization (LTO)
> and code size optimization flag (-Oz) by default for aggressive code
> size improvement. CLANG38 X64 code is small code model + PIE.
>
> Test pass platforms: OVMF (OvmfPkgIa32.ds
Reviewed-by: Ye Ting
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang
Lubo
Sent: Friday, July 8, 2016 3:51 PM
To: edk2-devel@lists.01.org
Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin
Subject: [edk2] [patch] NetworkPkg: Fix Assert issue in iSCSI
Both GCC and LLVM 3.8 64bits support new variable argument (VA)
intrinsics for Microsoft ABI, enable these new VA intrinsics for
GNUC family 64bits code build. These VA intrinsics are only
permitted use in 64bits code, so not use them in 32bits code build.
The original 32bits GNU VA intrinsics has
Please review my new commits in public branch:
https://github.com/shijunjing/edk2/commits/llvm_v2
I did below enhancements according feedback to
V1(https://github.com/shijunjing/edk2/commits/review5):
1. Remove the Quark platform work around and code clean work from this serial
patches.
2. Seper
Use explicit CopyMem to replace compiler builtin to do the structure
values assignment.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Steven Shi
Reviewed-by: Jaben Carsey
---
ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c | 2 +-
1 file changed, 1 insertion(+), 1 dele
GCC5 enable GCC Link Time Optimization (LTO) and code size
optimization (–Os) for aggressive code size improvement.
GCC5 X64 code is small code model + position independent
code (PIE).
Test pass platforms: OVMF (OvmfPkgIa32.dsc, OvmfPkgX64.dsc) and
Quark (Quark.dsc).
Test compiler and linker versi
Add support to convert new Elf relocation types
(R_X86_64_PLT32, R_X86_64_GOTPCREL, R_X86_64_GOTPCRELX,
R_X86_64_REX_GOTPCRELX) to PeCoff, which are required by
position independent code (PIC) built Elf image.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Steven Shi
---
CLANGSCAN38 is based on CLANG38 to seamlessly integrate Clang
scan-build analyzer infrastructure into edk2 build infrastructure.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Steven Shi
---
BaseTools/Conf/build_rule.template | 7 ++-
BaseTools/Conf/tools_def.template |
Add SHF_EXECINSTR attribute flag in logic to check Elf Text and
Data section type. Also fix some typo in the code comments and
Debug strings.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Steven Shi
---
BaseTools/Source/C/GenFw/Elf64Convert.c | 10 +-
1 file chan
LANG38 uses Clang3.8.0, enable LLVM Link Time Optimization (LTO)
and code size optimization flag (-Oz) by default for aggressive code
size improvement. CLANG38 X64 code is small code model + PIE.
Test pass platforms: OVMF (OvmfPkgIa32.dsc, OvmfPkgX64.dsc).
Test compiler and linker version: LLVM 3.
Jeff,
On 07/08/16 09:45, Jeff Fan wrote:
> SetMemoryAttributes() will sync BSP's MTRRs settings to all APs by
> StartupAllAPs
> service in serial mode. It may caused much performance impact if there are too
> much processors in system. This update is to invoke StartupAllAps in parallel
> mode. IA
On 8 July 2016 at 10:21, Gao, Liming wrote:
> Ard:
> For big change with lots of patches, we could send branch for code review,
> not need send every patch.
>
> This change is not big. It only includes 7 patches. So, you think he needs
> to send his patches for review. Right?
>
Yes. For me
Ard:
For big change with lots of patches, we could send branch for code review,
not need send every patch.
This change is not big. It only includes 7 patches. So, you think he needs to
send his patches for review. Right?
Thanks
Liming
> -Original Message-
> From: edk2-devel [mailto
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang
Lubo
Sent: Friday, July 8, 2016 3:51 PM
To: edk2-devel@lists.01.org
Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin
Subject: [edk2] [patch] NetworkPkg: Fix Assert issue in iSCS
On 8 July 2016 at 04:37, Shi, Steven wrote:
> Hi Ard,
> I've put v2 in the subject and change the branch name to
> https://github.com/shijunjing/edk2/commits/llvm_v2 . You can review all my
> serial patches in the branch link, and let me know if you need me send the
> patches in the mail list a
On 07/08/16 08:21, Giri P Mudusuru wrote:
> - accessibla to accessible
> - exeuction to execution
>
> Cc: Jordan Justen
> Cc: Laszlo Ersek
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Giri P Mudusuru
> ---
> OvmfPkg/VirtioBlkDxe/VirtioBlk.c | 6 +++
Reviewed-By: Wu Jiaxin
Best Regards!
Jiaxin
> -Original Message-
> From: Zhang, Lubo
> Sent: Friday, July 8, 2016 3:51 PM
> To: edk2-devel@lists.01.org
> Cc: Fu, Siyuan ; Ye, Ting ; Wu,
> Jiaxin
> Subject: [patch] NetworkPkg: Fix Assert issue in iSCSI driver.
>
> The bug existed in rep
The bug existed in replacing AsciiStrToUnicodeStr with AsciiStrToUnicodeStrS,
since MacString now is a pointer, the value sizeof(MacString)/sizeof
(MacString[0])
is not correct here as the third parameter.
Cc: Fu Siyuan
Cc: Ye Ting
Cc: Wu Jiaxin
Contributed-under: TianoCore Contribution Agreem
SetMemoryAttributes() will sync BSP's MTRRs settings to all APs by StartupAllAPs
service in serial mode. It may caused much performance impact if there are too
much processors in system. This update is to invoke StartupAllAps in parallel
mode. IA32 SDM does suggest to program MTRRs in parallel mode
Hi Marvin, Rafael,
Thank you for your studies on FSP.
FSP is a self-contained binary. Since the silicon code implementation is based
on edk2, some modules are redundant like PeiCore, DxeIpl as Rafael explained
below (Thanks Rafael).
While it is redundant, it is a small price to make FSP binar
40 matches
Mail list logo
