[edk2] [PATCH] IntelFsp2Pkg: Remove CarBase and CarSize from FSP_GLOBAL_DATA

2016-07-19 Thread Satya Yarlagadda
CarBase and CarSize in Fsp Global data strcture are no longer needed as Boot loader doesn't pass them to FSP even incase BL chooses to skip calling the FspTempRamInit API. Incase of FspTempramInit is called we can use the PCDs to identify the CarBase and Size. Hence removeing the relevent code.

[edk2] [Patch] BaseTools: report error if source module INF is only list in FDF file

2016-07-19 Thread Yonghong Zhu
If source module INF is not listed in DSC, it will not be built. And it is listed in FDF, GenFds will fail to find its build output. To reminder user this issue early, build tool should report failure to user in early phase. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 S

Re: [edk2] Instance of library class [ArmMmuLib] is not found

2016-07-19 Thread Michael Zimmermann
Hi, since commit '5db1cce ArmPkg ArmVirtPkg MdeModulePkg: switch to separate ArmMmuLib' you need to add ArmMmuLib to your platform's dsc file: ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf Thanks Michael On Tue, Jul 19, 2016 at 10:52 PM, jl < bm-2cto8lkixyzgzhxhxgubvmuwykw4tg5...@bitmess

Re: [edk2] [staging/HTTPS-TLS][PATCH] CryptoPkg: Multiple bugs fix in TlsLib

2016-07-19 Thread Long, Qin
Reviewed-by: Qin Long Best Regards & Thanks, LONG, Qin > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Jiaxin Wu > Sent: Wednesday, July 20, 2016 1:01 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting; Long, Qin > Subject: [edk2] [staging/HTT

Re: [edk2] [Patch] MdePkg BaseLib: Add the missing nasm source file InternalSwitchStack.nasm

2016-07-19 Thread Fan, Jeff
Reviewed-by: Jeff Fan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Thursday, July 14, 2016 2:03 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch] MdePkg BaseLib: Add the missing nasm source file InternalSwitchStack.nasm

[edk2] [patch] MdeModulePkg: add generic SataController driver.

2016-07-19 Thread Feng Tian
This SataController driver is used to provide a generic solution for those IDE/SATA/AHCI spec compliance host controllers. If there is special reqirement on timing setting or something else, user could override this driver to customize a specific one. Cc: Michael Kinney Cc: Amy Chan Cc: Giri P

[edk2] [staging/HTTPS-TLS][PATCH] CryptoPkg: Multiple bugs fix in TlsLib

2016-07-19 Thread Jiaxin Wu
This path made the following update: * Fix X64 build error * Correct and refine Set/Get compression method * Fix GetHostPublicCert() failure Cc: Long Qin Cc: Ye Ting Cc: Palmer Thomas Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiaxin Wu --- CryptoPkg/Include/Librar

Re: [edk2] [Patch V2] UefiCpuPkg/PiSmmCpuDxeSmm: SMM_CPU_DATA_BLOCK is not cleared

2016-07-19 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael Kinney Sent: Wednesday, July 20, 2016 7:38 AM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Laszlo Ersek ; Fan, Jeff Subject: [edk2] [Patch V2] UefiCpuPk

Re: [edk2] [PATCH] EmmcBlockIo: fix to get CSD data

2016-07-19 Thread Tian, Feng
Hi, Haojian Why I didn't get the lowest byte data is because it's CRC field. I thought nobody will care about it. My assumption is incorrect for your usage model? Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Haojian Zhuang Sent:

[edk2] [Patch V2] UefiCpuPkg/PiSmmCpuDxeSmm: SMM_CPU_DATA_BLOCK is not cleared

2016-07-19 Thread Michael Kinney
From: Jeff Fan The commit 8b9311 changed the zeroing of mSmmMpSyncData of type SMM_DISPATCHER_MP_SYNC_DATA by the following patch. -ZeroMem (mSmmMpSyncData, mSmmMpSyncDataSize); +mSmmMpSyncData->SwitchBsp = FALSE; mSmmMpSyncDataSize not only includes SMM_DISPATCHER_MP_SYNC_DATA, but al

[edk2] Instance of library class [ArmMmuLib] is not found

2016-07-19 Thread jl
Hey there, what is wrong with this build --verbose: Build environment: Linux-4.1.12-gentoo-x86_64- AMD_A10-7700K_Radeon_R7,_10_Compute_Cores_4C+6G-with-gentoo-2.2 Build start time: 20:36:36, Jul.19 2016 WORKSPACE= /home/xxx/devel/firmware/edk2 ECP_SOURCE = /home/xxx/devel/firmware/

Re: [edk2] [PATCH v3 0/5] Fix echo to display special characters

2016-07-19 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Monday, July 18, 2016 3:10 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH v3 0/5] Fix echo to display special characters > Importance: High

Re: [edk2] [RFC] Email tags for Bugzilla and administrative events

2016-07-19 Thread Kinney, Michael D
Hi Michael, We have edk2-devel mailing list today for patch submissions/review and design/implementation discussions. The commit messages in the future should include a link to the Bugzilla issue(s) the patch addresses. If there are lively discussion on edk2-devel on root causing a bug or dis

Re: [edk2] [RFC] Email tags for Bugzilla and administrative events

2016-07-19 Thread Michael Zimmermann
how will this work side-by-side with the mailing list? It kinda sounds like a mailing list replacement, and you probably don't want to have separate mailing list topics and bugzilla reports about the same thing. Thanks Michael On Tue, Jul 19, 2016 at 7:24 PM, Kinney, Michael D < michael.d.kin...@

Re: [edk2] [RFC] Email tags for Bugzilla and administrative events

2016-07-19 Thread Kinney, Michael D
Laszlo, Thanks for the feedback. A few responses embedded below. I agree there are many ways to organize this content inside Bugzilla and that we can refine the products/components/fields as we use it. Mike > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: We

Re: [edk2] [PATCH] ShellPkg: Fix VS2010/2012 build failure

2016-07-19 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Bi, > Dandan > Sent: Monday, July 18, 2016 8:07 PM > To: Ni, Ruiyu ; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] ShellPkg: Fix VS2010/2012 build failure > Impo

Re: [edk2] [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: SMM_CPU_DATA_BLOCK is not cleared

2016-07-19 Thread Fan, Jeff
Laszlo, Yes. We hit the issue at normal boot on some platform. I agree we could update comments to mention the CandidateBsp array of BOOLEANs also. Thanks! Jeff -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, July 19, 2016 7:25 PM To: Kinney, Michael D ;

Re: [edk2] [Patch 1/4] UefiCpuPkg/CpuDxe: StartupAllAPs in parallel mode

2016-07-19 Thread Fan, Jeff
Laszlo, Good suggestion! I could exchange the commit order of Patch 1/4 and Patch 2/4. Thanks! Jeff -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, July 19, 2016 6:48 PM To: Fan, Jeff ; edk2-de...@ml01.01.org Cc: Kinney, Michael D ; Tian, Feng Subject: R

Re: [edk2] [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: SMM_CPU_DATA_BLOCK is not cleared

2016-07-19 Thread Laszlo Ersek
On 07/19/16 04:58, Michael Kinney wrote: > From: Jeff Fan > > The commit 8b9311 changed the zeroing of mSmmMpSyncData of type > SMM_DISPATCHER_MP_SYNC_DATA by the following patch. > -ZeroMem (mSmmMpSyncData, mSmmMpSyncDataSize); > +mSmmMpSyncData->SwitchBsp = FALSE; > > mSmmMpSyncDataS

Re: [edk2] [Patch 3/4] UefiCpuPkg/MtrrLib: Add notes for usage by BSP/APs

2016-07-19 Thread Laszlo Ersek
On 07/19/16 02:57, Jeff Fan wrote: > Except for MtrrSetAllMtrrs(), others services are not suggested to be invoked > by > APs because they are not necessary and may invoke DEBUG() to dump MTRR > setting. > > Cc: Feng Tian > Cc: Michael Kinney > Cc: Laszlo Ersek > Contributed-under: TianoCore

Re: [edk2] [Patch 1/4] UefiCpuPkg/CpuDxe: StartupAllAPs in parallel mode

2016-07-19 Thread Laszlo Ersek
On 07/19/16 02:57, Jeff Fan wrote: > SetMemoryAttributes() will sync BSP's MTRRs settings to all APs by > StartupAllAPs > service in serial mode. It may caused much performance impact if there are too > much processors in system. This update is to invoke StartupAllAps in parallel > mode. IA32 SDM

[edk2] [PATCH] EmmcBlockIo: fix to get CSD data

2016-07-19 Thread Haojian Zhuang
The CSD structure is a 128-bit structure. But EmmcGetCsd() only loads 120 bits with 8-bit offset. Now fix it. Signed-off-by: Haojian Zhuang --- MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockIo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Bus/Sd/EmmcDxe/EmmcBlockI