On 29 July 2016 at 08:09, Ard Biesheuvel wrote:
> On 29 July 2016 at 06:47, Gao, Liming wrote:
>> Ard:
>> Thanks for your update. I have some comments for them.
>> 1) It uses GCC as Link for GCC44-GCC49. Have you done verification on them?
>> I verify GCC49 in OVMFIa32X64 platform. It works.
>
When creating a UNI file if there is a name conflict, add an index from 0 to
the file name
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: hesschen
---
.../Source/Python/UPT/GenMetaFile/GenDecFile.py| 5 +++--
.../Source/Python/UPT/GenMetaFile/GenInfFile.py| 7 +
On 29 July 2016 at 06:47, Gao, Liming wrote:
> Ard:
> Thanks for your update. I have some comments for them.
> 1) It uses GCC as Link for GCC44-GCC49. Have you done verification on them? I
> verify GCC49 in OVMFIa32X64 platform. It works.
Yes, I tested all of them.
> 2) After this change, how
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: Gao, Liming
Sent: Thursday, July 28, 2016 4:46 PM
To: edk2-devel@lists.01.org
Cc: Zhu, Yonghong
Subject: [Patch 1/3] BaseTools: Correct ReadMe.txt file with CRLF line ending
Cc: Yonghong Zhu
Contributed-un
Ard:
Thanks for your update. I have some comments for them.
1) It uses GCC as Link for GCC44-GCC49. Have you done verification on them? I
verify GCC49 in OVMFIa32X64 platform. It works.
2) After this change, how to append new link option in platform DSC? Use style
-Wl, ?
3) I see GCC5 uses gc
On 7/28/16 6:46 PM, Kinney, Michael D wrote:
Built-in archives for edk2-devel and edk2-bugs and now enabled.
Thanks!
--
Bruce
___
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Fix the following error from gcc:
Vlv2TbltDevicePkg/PlatformPei/MemoryCallback.c: In function
‘MemoryDiscoveredPpiNotifyCallback’:
Vlv2TbltDevicePkg/PlatformPei/MemoryCallback.c:115:20: error: variable ‘Status’
set but not used [-Werror=unused-but-set-variable]
Cc: David Wei
Cc: "Wu, Hao A"
C
gcc issued the error of "multiple deifintion" since gBS was also defined
in MdePkg/Library/UefiBootServicesTableLib. Actually those global variables,
gBS, pBS, and pRS, in PpmPolicy.h were only used in one function. Besides,
gBS and pRS were not really used. Remove gBS and pRS and declare pBS in
Pp
Fix the following error from gcc:
Vlv2TbltDevicePkg/PpmPolicy/PpmPolicy.c: In function ‘PpmPolicyEntry’:
Vlv2TbltDevicePkg/PpmPolicy/PpmPolicy.c:50:29: error: variable ‘MaxRatio’ set
but not used [-Werror=unused-but-set-variable]
Cc: David Wei
Contributed-under: TianoCore Contribution Agreement
Fix the following errors from gcc:
Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscOemType0x90Function.c: In function
‘JudgeHandleIsPCIDevice’:
Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscOemType0x90Function.c:164:22: error:
variable ‘DevicePath’ set but not used [-Werror=unused-but-set-variable]
Vlv2TbltDevicePkg
Fix the following errors from gcc:
Vlv2TbltDevicePkg/FvbRuntimeDxe/FvbService.c: In function ‘FvbWriteBlock’:
Vlv2TbltDevicePkg/FvbRuntimeDxe/FvbService.c:368:44: error: variable
‘FwhInstance’ set but not used [-Werror=unused-but-set-variable]
Vlv2TbltDevicePkg/FvbRuntimeDxe/FvbService.c: In fun
Fix the following errors from gcc:
Vlv2TbltDevicePkg/Library/MultiPlatformLib/MultiPlatformLib.c: In function
‘MultiPlatformInfoInit’:
Vlv2TbltDevicePkg/Library/MultiPlatformLib/MultiPlatformLib.c:47:14: error:
variable ‘Status’ set but not used [-Werror=unused-but-set-variable]
Vlv2TbltDeviceP
The code in _S3SUPPORT_ in PchAccess.h wasn't used in anywhere. Also,
The declaration of MCRX and MCR made gcc generate the error of
"multiple definition". Just remove the unused code to avoid any
potential issue.
Cc: David Wei
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by
This series amend the build script of Vlv2TbltDevicePkg and fix the
error messages from gcc. I've built the firmware with gcc 6.1.1 on openSUSE
Tumbleweed, and the firmware binary[*] was generated successfully (but not
guaranteed to work).
[*] Vlv2TbltDevicePkg/Stitch/MNW2MAX_X64_D_0093_01_GCC.bin
Fix the following errors from gcc:
Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.c: In function
‘GetIntegratedIntelVbtPtr’:
Vlv2TbltDevicePkg/VlvPlatformInitDxe/IgdOpRegion.c:145:33: error: variable
‘VbtSize’ set but not used [-Werror=unused-but-set-variable]
Vlv2TbltDevicePkg/VlvPlatformIni
Fix the following error from gcc:
Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c: In function ‘BdsLockFv’:
Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c:2170:31: error: variable
‘Data’ set but not used [-Werror=unused-but-set-variable]
Cc: David Wei
Cc: "Wu, Hao A"
Cc: "Lu, Sh
Fix the following error from gcc:
Vlv2TbltDevicePkg/Wpce791/LpcDriver.c: In function ‘LpcDriverStart’:
Vlv2TbltDevicePkg/Wpce791/LpcDriver.c:239:27: error: variable ‘LpcDev’ set but
not used [-Werror=unused-but-set-variable]
Cc: David Wei
Contributed-under: TianoCore Contribution Agreement 1.0
Fix the following error from gcc:
Vlv2TbltDevicePkg/PlatformInitPei/PlatformEarlyInit.c: In function
'GetWakeupEventAndSaveToHob':
Vlv2TbltDevicePkg/PlatformInitPei/PlatformEarlyInit.c:147:11: error: variable
'WakeEventData' set but not used [-Werror=unused-but-set-variable]
Although the functi
Fix the following errors from gcc:
Vlv2TbltDevicePkg/PlatformSetupDxe/SetupInfoRecords.c: In function
‘PrepareSetupInformation’:
Vlv2TbltDevicePkg/PlatformSetupDxe/SetupInfoRecords.c:540:31: error: variable
‘EeState’ set but not used [-Werror=unused-but-set-variable]
Vlv2TbltDevicePkg/PlatformSe
Fix the following errors from gcc:
Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c: In function
'PlatformUpdateTables':
Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c:236:63: warning: variable
'LocalApicCounter' set but not used [-Wunused-but-set-variable]
Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatfor
gBS is already defined in
MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.c
Remove the declaration of gBS and include the proper header file to
access the variable.
Suggested-by: David Wei
Cc: David Wei
Cc: "Wu, Hao A"
Cc: "Lu, ShifeiX A"
Contributed-under: TianoCore Contribu
mGlobalNvsArea wasn't declared as extern in AcpiPlatform.h and the header
was included in AcpiPlatform.c and AcpiPlatformHooks.c. Although it's
declared as extern in AcpiPlatformHooks.c, gcc still created an instance
of mGlobalNvsArea in AcpiPlatformHooks.c since the header was expanded
first and t
Fix the following errors from gcc:
Vlv2TbltDevicePkg/PlatformDxe/Platform.c: In function ‘InitPciDevPME’:
Vlv2TbltDevicePkg/PlatformDxe/Platform.c:516:26: error: variable ‘Status’ set
but not used [-Werror=unused-but-set-variable]
Vlv2TbltDevicePkg/PlatformDxe/Platform.c: In function ‘InitTherma
We only enable "-Wno-unused-but-set-variable" for the release build
and gcc would complain that the varible passed to ASSERT_EFI_ERROR
wasn't used in the debug build. Just don't define MDEPKG_NDEBUG for
the debug build to make gcc happy with ASSERT_EFI_ERROR.
Suggested-by: Laszlo Ersek
Cc: David
Fix the following errors from gcc:
Vlv2TbltDevicePkg/PlatformInitPei/PchInitPeim.c: In function 'IchRcrbInit':
Vlv2TbltDevicePkg/PlatformInitPei/PchInitPeim.c:513:36: error: variable
'PlatformCpuInfo' set but not used [-Werror=unused-but-set-variable]
Vlv2TbltDevicePkg/PlatformInitPei/PchInitPeim
Take the gcc version detection from OvmfPkg/build.sh instead of the
hardcoded GCC46.
Cc: David Wei
Cc: "Wu, Hao A"
Cc: "Lu, ShifeiX A"
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Gary Lin
Reviewed-by: David Wei
---
Vlv2TbltDevicePkg/bld_vlv.sh | 24
Reviewed-by: David Wei
Thanks,
David Wei
Intel SSG BIOS Team
-Original Message-
From: Lu, ShifeiX A
Sent: Thursday, July 28, 2016 4:21 PM
To: edk2-devel@lists.01.org
Cc: Wei; Wei, David
Subject: [Patch] Vlv2DeviceRefCodePkg&Vlv2DevicePkg:Add sampl
Reviewed-by: David Wei
Thanks,
David Wei
Intel SSG BIOS Team
-Original Message-
From: Lu, ShifeiX A
Sent: Friday, July 29, 2016 10:27 AM
To: edk2-devel@lists.01.org
Cc: Wei; Wei, David
Subject: [Patch] Vlv2TbltDevicePkg:Signal EndOfDxe Event.
Acc
Support new syntax in package DEC file as below:
[Includes.Common.Private]
[Ppis.Common.Private]
[Guids.Common.Private]
[Protocols.Common.Private]
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: hesschen
---
.../Source/Python/UPT/GenMetaFile/GenDecFile.py| 9 +++-
According to PI spec,EndOfDxe Event should be signaled
before DxeSmmReadyToLock protocol installation.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: lushifex
---
.../Library/PlatformBdsLib/BdsPlatform.c | 37 +-
.../Library/PlatformBdsLib/Pl
Reviewed-by: Liming Gao
> -Original Message-
> From: Zhu, Yonghong
> Sent: Thursday, July 28, 2016 9:33 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [Patch V2] BaseTools: Add build info for binary modules that only
> list
> in FDF file
>
> If the binary module is list
Felix:
Thanks for your report. We will fix it in BaseTools to align to UNI spec.
Thanks
Liming
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Felix Poludov
> Sent: Wednesday, July 27, 2016 9:50 PM
> To: Kinney, Michael D ; edk2-
> de...@l
Reviewed-by: Jeff Fan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Thursday, July 28, 2016 4:46 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch 2/3] MdePkg PeiDxePostCodeLibReportStatusCode: Correct
files with CRLF line
Bruce,
Built-in archives for edk2-devel and edk2-bugs and now enabled.
Mike
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Bruce
> Cran
> Sent: Thursday, July 28, 2016 5:18 PM
> To: Laszlo Ersek ; edk2-devel-01
> Subject: Re: [edk2] Ingebr
On 7/28/16 1:13 PM, Laszlo Ersek wrote:
The direct (and less important) issue is that we might have to find a
new archival service. And that our gmane links captured in various
places would break.
Since this ML is on Mailman, maybe Intel (i.e. owners of 01.org) can
enable the built-in archive
Hi,
for me it's already down.
If you can afford additional server usage and there is a good server
application which does something like gmane that probably would be the best
solution.
This way you'd have your own official archives and you don't have to rely
on 3rd-party services.
Thanks
Michael
> On Jul 28, 2016, at 12:13 PM, Laszlo Ersek wrote:
>
> Dire news:
>
> https://lars.ingebrigtsen.no/2016/07/28/the-end-of-gmane/
> http://lwn.net/Articles/695695/
>
> The direct (and less important) issue is that we might have to find a
> new archival service. And that our gmane links captured
Dire news:
https://lars.ingebrigtsen.no/2016/07/28/the-end-of-gmane/
http://lwn.net/Articles/695695/
The direct (and less important) issue is that we might have to find a
new archival service. And that our gmane links captured in various
places would break.
The indirect (and hugely important) is
Personally,
I see that we have two classes of data we have external references to in the
codebase.
We have data that is in a standards-maintained spec like ACPI, UEFI, etc. This
might be something like FPDT, which is a reservation in ACPI, but also has a
litany of definitions contained within
> On Jul 28, 2016, at 10:58 AM, Mudusuru, Giri P
> wrote:
>
> Hi Tim,
> Yes it is historical, and if we want to change that let's define the
> guidelines.
>
> In initial review added to IntelSiliconPkg but looking at other usage and to
> keep it consistent I have moved to MdePkg.
>
> For e
Hi Tim,
Yes it is historical, and if we want to change that let's define the
guidelines.
In initial review added to IntelSiliconPkg but looking at other usage and to
keep it consistent I have moved to MdePkg.
For example HPET and SPMI is another example which falls under the same bucket
from
Mike --
Not quite. That table has historically been a registry of claimed table IDs
similar to the registry for \EFI directory names. As noted, there is a link to
a page that gives the links to the actual spec, which is hosted by Intel (or
Microsoft or Xen) The listing in this table is not an e
Tim,
The 'DMAR' table is defined in the ACPI Specification.
This is similar to 'DBG2':
MdePkg/Include/IndustryStandard/DebugPort2Table.h
And 'SPCD':
MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h
Mike
> -Original Message-
> From: edk2-devel [mailto:edk2-deve
Laszlo --
I hear what you are saying. However, I think this is a different case:
1) How many ARM-defined standards are in the MdePkg\Include\IndustryStandards.h
file? By my count, none. This is by design. They are all in other packages.
DMAR is there because it was grandfathered in from a gener
On 07/28/16 18:00, Tim Lewis wrote:
> Giri --
>
> Is MdePkg the right place for this? This appears to be an
> Intel-specific definition, right? I understand that it was in
> IndustryStandard for EdkCompatibilityPkg, but it might do better now
> in the IntelSiliconPkg.
DMAR is defined by a widely
Giri --
Is MdePkg the right place for this? This appears to be an Intel-specific
definition, right? I understand that it was in IndustryStandard for
EdkCompatibilityPkg, but it might do better now in the IntelSiliconPkg.
Regards,
Tim
-Original Message-
From: edk2-devel [mailto:edk2-de
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Gao, Liming
> Sent: Thursday, July 28, 2016 1:46 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Carsey, Jaben
> Subject: [Patch 3/3] ShellPkg: Correct files with CRLF line ending
> Importance: High
>
> Cc: Ruiyu Ni
> Cc: Jaben
On 07/28/16 15:55, Fan, Jeff wrote:
> Laszlo,
>
> Many thanks for your verification.
>
> Your dump information and analysis result are very useful. I guess the issue
> happened at
>UefiCpuPkg\PiSmmCpuDxeSmm\Ia32\MpFuncs.nasm:80 a32 jmp dword
> 0x20:0x0
>
> The Proteted mode CS
On 28 July 2016 at 15:41, Jeremy Linton wrote:
> SMBIOS data is consumed by a wide range of enterprise applications.
>
> Fill in the basic requirements of the SMBIOS specification by hardcoding
> the minimum required structures and data using Juno information. Only the
> juno revision, memory rang
Sure Jiewen. Will add these two defines and send v2 patch.
Thanks,
-Giri
> -Original Message-
> From: Yao, Jiewen
> Sent: Thursday, July 28, 2016 12:28 AM
> To: Mudusuru, Giri P ; edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Gao, Liming
>
> Subject: RE: [edk2] [PATCH] MdePkg: Add Dm
SMBIOS data is consumed by a wide range of enterprise applications.
Fill in the basic requirements of the SMBIOS specification by hardcoding
the minimum required structures and data using Juno information. Only the
juno revision, memory ranges and CPU types are dynamic.
Add the resulting Juno Smb
On Thu, Jul 28, 2016 at 09:10:10AM -0500, Jeremy Linton wrote:
> On 07/28/2016 06:35 AM, Leif Lindholm wrote:
> >Thanks Jeremy, this looks good to me.
> >
> >I have one comment on (EDK2) 2/3 and a minor one on (OpenPlatformPkg)
> >2/3. As I said in the comment, I would be happy to fix the EDK2 one
On 07/28/2016 06:35 AM, Leif Lindholm wrote:
Thanks Jeremy, this looks good to me.
I have one comment on (EDK2) 2/3 and a minor one on (OpenPlatformPkg)
2/3. As I said in the comment, I would be happy to fix the EDK2 one on
commit if you're happy with the proposed change?
Sure, tweak away..
On 07/28/2016 06:23 AM, Leif Lindholm wrote:
On Wed, Jul 27, 2016 at 02:24:35PM -0500, Jeremy Linton wrote:
The code to detect what juno revision we are running on
is fairly small put it in a common header where it may be
used in a couple places.
Contributed-under: TianoCore Contribution Agreem
Laszlo,
Many thanks for your verification.
Your dump information and analysis result are very useful. I guess the issue
happened at
UefiCpuPkg\PiSmmCpuDxeSmm\Ia32\MpFuncs.nasm:80 a32 jmp dword
0x20:0x0
The Proteted mode CS in current GDT table is not 0x20. But the PiSmmCpuDxeSmm
On Wed, Jul 27, 2016 at 04:03:28PM +0200, Laszlo Ersek wrote:
> On 07/27/16 06:53, Alive 4ever wrote:
> > Greetings, developers!
> >
> > I am having some issue with OVMF on qemu with vmware vga.
>
> OVMF does not have a GOP driver for vmware vga.
>
> > I hope support for qemu vmware vga will be
On 07/25/16 04:52, Jeff Fan wrote:
> We add MP Initialize Library defined in
> UefiCpuPkg/Include/Library/MpInitLib.h.
> It will provide basic functionalities of MP services and could be consumed by
> CPU MP PEI and CPU MP DXE to produce CPU MP PPI and CPU MP Protocol. Then most
> of code could be
Thanks Jeremy, this looks good to me.
I have one comment on (EDK2) 2/3 and a minor one on (OpenPlatformPkg)
2/3. As I said in the comment, I would be happy to fix the EDK2 one on
commit if you're happy with the proposed change?
For OpenPlatformPkg, I think these three patches can be folded into
o
On Wed, Jul 27, 2016 at 02:24:38PM -0500, Jeremy Linton wrote:
> Create the edk2 INF/metadata required to build the SmbiosPlatformDxe.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jeremy Linton
> ---
> .../Juno/SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 68
> +++
On Wed, Jul 27, 2016 at 02:24:35PM -0500, Jeremy Linton wrote:
> The code to detect what juno revision we are running on
> is fairly small put it in a common header where it may be
> used in a couple places.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jeremy Linton
On Wed, Jul 27, 2016 at 03:24:17PM +0100, Leif Lindholm wrote:
> Graeme/Evan?
>
In this case Sudeep is the expert, I don't know enough about LPI or Juno
to review.
Graeme
> On 27 July 2016 at 10:58, Sudeep Holla wrote:
> > ACPI 6.0 introduced LPI(Low Power Idle) states that provides an alterna
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao
---
BaseTools/ReadMe.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/BaseTools/ReadMe.txt b/BaseTools/ReadMe.txt
index 6330b14..be9ff2a 100644
--- a/BaseTools/ReadMe.t
edk2 project source files are CRLF line ending. BaseTools\Scripts\PatchCheck.py
script can detect Line ending issue in patch.
Liming Gao (3):
BaseTools: Correct ReadMe.txt file with CRLF line ending
MdePkg PeiDxePostCodeLibReportStatusCode: Correct files with CRLF line
ending
ShellPkg:
Cc: Ruiyu Ni
Cc: Jaben Carsey
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao
---
.../UefiHandleParsingLib/UefiHandleParsingLib.h| 6 ++--
.../UefiHandleParsingLib/UefiHandleParsingLib.uni | 18 +-
.../UefiShellCommandLib/UefiShellCommandLib.h
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao
---
.../PeiDxePostCodeLibReportStatusCode.inf | 4 ++--
.../PeiDxePostCodeLibReportStatusCode.uni | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
d
This is an sample WSMT table, which we only
update BIT0 and BIT1 of Protections flags fields.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: lushifex
---
Vlv2DeviceRefCodePkg/AcpiTablesPCAT/AcpiTables.inf | 3 +-
Vlv2DeviceRefCodePkg/AcpiTablesPCAT/Wsmt/Wsmt.aslc | 60 ++
Reviewed-by: Yonghong Zhu
I will push this patch if there no more comment .
Best Regards,
Zhu Yonghong
-Original Message-
From: Chen, Hesheng
Sent: Wednesday, July 27, 2016 2:15 PM
To: edk2-devel@lists.01.org
Cc: Zhu, Yonghong ; Chen, Hesheng
Subject: [patch] BaseTools/Ecc: GUID ch
Edk2 enables Os option and ms_va_list in GCC tool chain.
This change makes VA_LIST is not pointer, and cause GCC failure.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao
---
.../EdkIIGlueLib/Library/DxeReportStatusCodeLib/ReportStatusCodeLib.c | 2 +-
.../EdkI
Thanks. It looks good.
Reviewed-by: jiewen@intel.com
Do you think we can define below MACRO too?
#define EFI_ACPI_DMAR_DRHD_FLAG_INCLUDE_PCI_ALL BIT0
#define EFI_ACPI_DMAR_ATSR_FALG_ALL_PORTS BIT0
> -Original Message-
> From: Mudusuru, Giri P
> Sent: Thursday, July 28, 2016 2:46
69 matches
Mail list logo
