[edk2] [PATCH] IntelFsp2Pkg: Converted PatchFvUserManual from .docx to .md format

2016-08-04 Thread Giri P Mudusuru
Converted the the word format of the documentation into markdown format for PatchFvUserManual Cc: Jiewen Yao Cc: Maurice Ma Cc: Satya Yarlagadda Cc: Satya Yarlagadda Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Giri P Mudusuru --- .../Tools/UserManuals/PatchFvUserMa

Re: [edk2] [PATCH] IntelFsp2Pkg: Only include required header files in FspEas.h

2016-08-04 Thread Mudusuru, Giri P
Reviewed-by: Giri P Mudusuru > -Original Message- > From: Ma, Maurice > Sent: Thursday, August 4, 2016 9:20 PM > To: edk2-devel@lists.01.org > Cc: Ma, Maurice ; Yao, Jiewen > ; Mudusuru, Giri P > Subject: [edk2] [PATCH] IntelFsp2Pkg: Only include required header files in > FspEas.h > >

Re: [edk2] [PATCH 10/17] NetworkPkg DSC: Add build option to disable deprecated APIs

2016-08-04 Thread Wu, Jiaxin
Reviewed-By: Wu Jiaxin Best Regards! Jiaxin > -Original Message- > From: Wu, Hao A > Sent: Friday, August 5, 2016 8:53 AM > To: edk2-devel@lists.01.org; Gao, Liming > Cc: Wu, Hao A ; Fu, Siyuan ; > Wu, Jiaxin > Subject: [PATCH 10/17] NetworkPkg DSC: Add build option to disable > depre

Re: [edk2] [PATCH 16/17] UefiCpuPkg DSC: Add build option to disable deprecated APIs

2016-08-04 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu Sent: Friday, August 5, 2016 8:53 AM To: edk2-devel@lists.01.org; Gao, Liming Cc: Wu, Hao A ; Fan, Jeff Subject: [edk2] [PATCH 16/17] UefiCpuPkg DSC: Add

Re: [edk2] [PATCH 15/17] SourceLevelDebugPkg DSC: Add build option to disable deprecated APIs

2016-08-04 Thread Ni, Ruiyu
Since Jeff is happy on vocation, so Reviewed-by: Ruiyu Ni >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu >Sent: Friday, August 5, 2016 8:53 AM >To: edk2-devel@lists.01.org; Gao, Liming >Cc: Wu, Hao A ; Fan, Jeff >Subject: [edk2] [PATCH

[edk2] [PATCH] IntelFsp2Pkg: Only include required header files in FspEas.h

2016-08-04 Thread Maurice Ma
Current FspEas.h file includes Uefi.h which also refers to lots of other UEFI header files not used by FSP consumer. It caused many unnecessary header file overhead for a bootloader that consumes FSP, such as coreboot. This change reduces the required header file number down to 3. Cc: Jiewen Yao

Re: [edk2] Breaking change issue with NetworkPkg/Ip6Dxe/Ip6ConfigImlp.[c, h]

2016-08-04 Thread Ye, Ting
Hi Larry, We are very sorry about the impact you suffered today. We made the change in early 2013 to support the existing NVRAM variable when firmware image was updated from IA32 to X64. Unfortunately we introduced an incompatibility issue as you raised. Now we prefer to keep the existing defin

Re: [edk2] [PATCH 17/17] CryptoPkg DSC: Add build option to disable deprecated APIs

2016-08-04 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: Wu, Hao A Sent: Friday, August 05, 2016 8:53 AM To: edk2-devel@lists.01.org; Gao, Liming Cc: Wu, Hao A ; Long, Qin ; Ye, Ting Subject: [PATCH 17/17] CryptoPkg DSC: Add build option to disable deprecated APIs Add the following definition

Re: [edk2] [PATCH 17/17] CryptoPkg DSC: Add build option to disable deprecated APIs

2016-08-04 Thread Long, Qin
Reviewed-by: Qin Long > -Original Message- > From: Wu, Hao A > Sent: Friday, August 05, 2016 8:53 AM > To: edk2-devel@lists.01.org; Gao, Liming > Cc: Wu, Hao A; Long, Qin; Ye, Ting > Subject: [PATCH 17/17] CryptoPkg DSC: Add build option to disable > deprecated APIs > > Add the followi

Re: [edk2] [PATCH 13/17] SecurityPkg DSC: Add build option to disable deprecated APIs

2016-08-04 Thread Zhang, Chao B
Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Wu, Hao A Sent: Friday, August 05, 2016 8:53 AM To: edk2-devel@lists.01.org; Gao, Liming Cc: Wu, Hao A; Zhang, Chao B Subject: [PATCH 13/17] SecurityPkg DSC: Add build option to disable deprecated AP

Re: [edk2] [PATCH 08/17] MdeModulePkg DSC: Add build option to disable deprecated APIs

2016-08-04 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Wu, Hao A Sent: Friday, August 5, 2016 8:53 AM To: edk2-devel@lists.01.org; Gao, Liming Cc: Wu, Hao A ; Tian, Feng ; Zeng, Star Subject: [PATCH 08/17] MdeModulePkg DSC: Add build option to disable deprecated APIs Add the f

[edk2] [patch 2/2] MdeModulePkg/Browser: Share default if some default value are not specified

2016-08-04 Thread Dandan Bi
Add a new implementation policy of getting default in SetupBrowser. The new policy is only for the situation that a question has default value but doesn't have default value for all supported default type. In this case, we will choose the smallest default id from the existing defaults, and share it

[edk2] [patch 0/2] Share default value if some default value are not specified

2016-08-04 Thread Dandan Bi
Add a new implementation policy of get default value in HiiDatabaseDxe and SetupBrowserDxe. The new policy is only for the situation that a question has default value but doesn't have default value for all supported default type. In this case, we will choose the smallest default id from the existin

[edk2] [patch 1/2] MdeModulePkg/HiiDB: Share default if some default value are not specified

2016-08-04 Thread Dandan Bi
Add a new implementation policy of getting default in HiiDatabase. The new policy is only for the situation that a question has default value but doesn't have default value for all supported default type. In this case, we will choose the smallest default id from the existing defaults, and share its

Re: [edk2] [PATCH 11/17] PcAtChipsetPkg DSC: Add build option to disable deprecated APIs

2016-08-04 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Hao Wu >Sent: Friday, August 5, 2016 8:53 AM >To: edk2-devel@lists.01.org; Gao, Liming >Cc: Wu, Hao A ; Ni, Ruiyu >Subject: [edk2] [PATCH 11/17] PcAtChipsetPkg DSC: Add bui

Re: [edk2] [PATCH 14/17] ShellPkg DSC: Add build option to disable deprecated APIs

2016-08-04 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni >-Original Message- >From: Wu, Hao A >Sent: Friday, August 5, 2016 8:53 AM >To: edk2-devel@lists.01.org; Gao, Liming >Cc: Wu, Hao A ; Carsey, Jaben ; >Ni, Ruiyu >Subject: [PATCH 14/17] ShellPkg DSC: Add build option to disable deprecated >APIs > >Add the followi

Re: [edk2] [PATCH 01/17] FatPkg DSC: Add build option to disable deprecated APIs

2016-08-04 Thread Ni, Ruiyu
Reviewed-by: Ruiyu Ni >-Original Message- >From: Wu, Hao A >Sent: Friday, August 5, 2016 8:53 AM >To: edk2-devel@lists.01.org; Gao, Liming >Cc: Wu, Hao A ; Ni, Ruiyu >Subject: [PATCH 01/17] FatPkg DSC: Add build option to disable deprecated APIs > >Add the following definition in the [

Re: [edk2] [PATCH 08/17] MdeModulePkg DSC: Add build option to disable deprecated APIs

2016-08-04 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Wu, Hao A Sent: Friday, August 5, 2016 8:53 AM To: edk2-devel@lists.01.org; Gao, Liming Cc: Wu, Hao A ; Tian, Feng ; Zeng, Star Subject: [PATCH 08/17] MdeModulePkg DSC: Add build option to disable deprecated APIs Add the following defi

Re: [edk2] [PATCH 04/17] IntelFsp2Pkg DSC: Add build option to disable deprecated APIs

2016-08-04 Thread Yao, Jiewen
IntelFspXXXPkg are reviewed by: jiewen@intel.com > -Original Message- > From: Wu, Hao A > Sent: Friday, August 5, 2016 8:53 AM > To: edk2-devel@lists.01.org; Gao, Liming > Cc: Wu, Hao A ; Yao, Jiewen > Subject: [PATCH 04/17] IntelFsp2Pkg DSC: Add build option to disable > deprecated

[edk2] [PATCH 05/17] IntelFsp2WrapperPkg DSC: Add build option to disable deprecated APIs

2016-08-04 Thread Hao Wu
Add the following definition in the [BuildOptions] section in package DSC files to disable APIs that are deprecated: [BuildOptions] *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- IntelFsp2

[edk2] [PATCH 17/17] CryptoPkg DSC: Add build option to disable deprecated APIs

2016-08-04 Thread Hao Wu
Add the following definition in the [BuildOptions] section in package DSC files to disable APIs that are deprecated: [BuildOptions] *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES Cc: Qin Long Cc: Ting Ye Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu ---

[edk2] [PATCH 02/17] IntelFrameworkModulePkg DSC: Add build option to disable deprecated APIs

2016-08-04 Thread Hao Wu
Add the following definition in the [BuildOptions] section in package DSC files to disable APIs that are deprecated: [BuildOptions] *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- IntelFramew

[edk2] [PATCH 11/17] PcAtChipsetPkg DSC: Add build option to disable deprecated APIs

2016-08-04 Thread Hao Wu
Add the following definition in the [BuildOptions] section in package DSC files to disable APIs that are deprecated: [BuildOptions] *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- PcAtChipset

[edk2] [PATCH 16/17] UefiCpuPkg DSC: Add build option to disable deprecated APIs

2016-08-04 Thread Hao Wu
Add the following definition in the [BuildOptions] section in package DSC files to disable APIs that are deprecated: [BuildOptions] *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- UefiCpuPkg/

[edk2] [PATCH 09/17] MdePkg DSC: Add build option to disable deprecated APIs

2016-08-04 Thread Hao Wu
Add the following definition in the [BuildOptions] section in package DSC files to disable APIs that are deprecated: [BuildOptions] *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES Cc: Michael D Kinney Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

[edk2] [PATCH 13/17] SecurityPkg DSC: Add build option to disable deprecated APIs

2016-08-04 Thread Hao Wu
Add the following definition in the [BuildOptions] section in package DSC files to disable APIs that are deprecated: [BuildOptions] *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- SecurityP

[edk2] [PATCH 10/17] NetworkPkg DSC: Add build option to disable deprecated APIs

2016-08-04 Thread Hao Wu
Add the following definition in the [BuildOptions] section in package DSC files to disable APIs that are deprecated: [BuildOptions] *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES Cc: Siyuan Fu Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu

[edk2] [PATCH 14/17] ShellPkg DSC: Add build option to disable deprecated APIs

2016-08-04 Thread Hao Wu
Add the following definition in the [BuildOptions] section in package DSC files to disable APIs that are deprecated: [BuildOptions] *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES Cc: Jaben Carsey Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu

[edk2] [PATCH 15/17] SourceLevelDebugPkg DSC: Add build option to disable deprecated APIs

2016-08-04 Thread Hao Wu
Add the following definition in the [BuildOptions] section in package DSC files to disable APIs that are deprecated: [BuildOptions] *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- SourceLevel

[edk2] [PATCH 12/17] PerformancePkg DSC: Add build option to disable deprecated APIs

2016-08-04 Thread Hao Wu
Add the following definition in the [BuildOptions] section in package DSC files to disable APIs that are deprecated: [BuildOptions] *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES Cc: Daryl McDaniel Cc: Jaben Carsey Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

[edk2] [PATCH 03/17] IntelFrameworkPkg DSC: Add build option to disable deprecated APIs

2016-08-04 Thread Hao Wu
Add the following definition in the [BuildOptions] section in package DSC files to disable APIs that are deprecated: [BuildOptions] *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- IntelFramew

[edk2] [PATCH 06/17] IntelFspPkg DSC: Add build option to disable deprecated APIs

2016-08-04 Thread Hao Wu
Add the following definition in the [BuildOptions] section in package DSC files to disable APIs that are deprecated: [BuildOptions] *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- IntelFspP

[edk2] [PATCH 08/17] MdeModulePkg DSC: Add build option to disable deprecated APIs

2016-08-04 Thread Hao Wu
Add the following definition in the [BuildOptions] section in package DSC files to disable APIs that are deprecated: [BuildOptions] *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES Cc: Feng Tian Cc: Star Zeng Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu

[edk2] [PATCH 07/17] IntelFspWrapperPkg DSC: Add build option to disable deprecated APIs

2016-08-04 Thread Hao Wu
Add the following definition in the [BuildOptions] section in package DSC files to disable APIs that are deprecated: [BuildOptions] *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- IntelFspW

[edk2] [PATCH 00/17] Add build option to disable deprecated APIs

2016-08-04 Thread Hao Wu
This patch series will add the following definition in the [BuildOptions] section in package DSC files to disable APIs that are deprecated: [BuildOptions] *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES Hao Wu (17): FatPkg DSC: Add build option to disable deprecated APIs IntelFramewo

[edk2] [PATCH 01/17] FatPkg DSC: Add build option to disable deprecated APIs

2016-08-04 Thread Hao Wu
Add the following definition in the [BuildOptions] section in package DSC files to disable APIs that are deprecated: [BuildOptions] *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- FatPkg/FatP

[edk2] [PATCH 04/17] IntelFsp2Pkg DSC: Add build option to disable deprecated APIs

2016-08-04 Thread Hao Wu
Add the following definition in the [BuildOptions] section in package DSC files to disable APIs that are deprecated: [BuildOptions] *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- IntelFsp2

Re: [edk2] Managing GCC Assembly Code Size (AArch64)

2016-08-04 Thread Cohen, Eugene
Ard, as usual you rock... > FYI there is a null token \() for GAS which you can use to concatenate > a string with a macro argument, e.g., > >.macro func, x >.globl \x >.type \x, %function >.section .text.\x > \x\(): > .endm > Using the GAS .macro syntax this all collapses nice

Re: [edk2] Managing GCC Assembly Code Size (AArch64)

2016-08-04 Thread Ard Biesheuvel
On 4 August 2016 at 21:18, Ard Biesheuvel wrote: > On 4 August 2016 at 20:08, Cohen, Eugene wrote: >> Ard and Leif, >> >> I've been too backlogged to provide a real patchset at this point but wanted >> to get your approval on this proposal... >> >> >> As you know we have some code size sensitive

Re: [edk2] Managing GCC Assembly Code Size (AArch64)

2016-08-04 Thread Ard Biesheuvel
On 4 August 2016 at 20:08, Cohen, Eugene wrote: > Ard and Leif, > > I've been too backlogged to provide a real patchset at this point but wanted > to get your approval on this proposal... > > > As you know we have some code size sensitive uncompressed XIP stuff going on. > For C code we get dea

Re: [edk2] [PATCH] BaseTools X64: fold PLT relocations into simple relative references

2016-08-04 Thread Ard Biesheuvel
> On 4 aug. 2016, at 21:03, Nicolas Owens wrote: > > ard, > > i think you need to have R_X86_64_PLT32 case in WriteRelocations64. > without that, i still hit the invalid relocation message. > Good point. I will send out a v2 tomorrow >> On 08/04/2016 01:45 AM, Ard Biesheuvel wrote: >> For X

Re: [edk2] [PATCH] BaseTools X64: fold PLT relocations into simple relative references

2016-08-04 Thread Nicolas Owens
ard, i think you need to have R_X86_64_PLT32 case in WriteRelocations64. without that, i still hit the invalid relocation message. On 08/04/2016 01:45 AM, Ard Biesheuvel wrote: > For X64/GCC, we use position independent code with hidden visibility > to inform the compiler that symbols references

[edk2] Managing GCC Assembly Code Size (AArch64)

2016-08-04 Thread Cohen, Eugene
Ard and Leif, I've been too backlogged to provide a real patchset at this point but wanted to get your approval on this proposal... As you know we have some code size sensitive uncompressed XIP stuff going on. For C code we get dead code stripping thanks to the "-ffunction-sections" switch w

Re: [edk2] [PATCH 3/3] BaseTools GCC/ARM: add -fno-builtin to CC flags

2016-08-04 Thread Michael Zimmermann
not directly related but could we add nostdinc too? At least for my platform that works perfectly and it prevents you from accidentally including any libc/libgcc/whatever headers from your toolchain.(nostdlib is already enabled) Thanks Michael On Thu, Aug 4, 2016 at 4:42 PM, Ard Biesheuvel wrote

[edk2] [PATCH 0/3] Build fixes for ARM/OpenSSL

2016-08-04 Thread Ard Biesheuvel
This series addresses some issues that cause the build to be broken for ARM GCC5 at the moment when including OpensslLib in the build. Ard Biesheuvel (3): ArmPkg/ArmSoftFloatLib: disable LTO build for GCC ArmPkg/CompilerIntrinsicsLib: make the default memset() weak BaseTools GCC/ARM: add -fn

[edk2] [PATCH 3/3] BaseTools GCC/ARM: add -fno-builtin to CC flags

2016-08-04 Thread Ard Biesheuvel
Avoid build errors when including OpensslLib, which may throw undefined reference errors for builtin functions if -fno-builtin is not specified (and it is already set for IA32, X64 and AARCH64) So set it for ARM as well. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Bi

[edk2] [PATCH 2/3] ArmPkg/CompilerIntrinsicsLib: make the default memset() weak

2016-08-04 Thread Ard Biesheuvel
The ARM compiler intrinsics library defines __aeabi_memset() and memset() in the same object, which means that both will be pulled in if either is referenced. The IntrinsicLib in CryptoPkg defines its own, preferred memset(), which may clash with our memset(). So make our version weak. Contribute

[edk2] [PATCH 1/3] ArmPkg/ArmSoftFloatLib: disable LTO build for GCC

2016-08-04 Thread Ard Biesheuvel
Building ArmSoftFloatLib with LTO results in errors like .../bin/ld: softfloat.obj: plugin needed to handle lto object .../bin/ld: __aeabi_dcmpge.obj: plugin needed to handle lto object .../bin/ld: __aeabi_dcmplt.obj: plugin needed to handle lto object .../bin/ld: internal error ../../ld/l

Re: [edk2] [PATCH] PcdBdsLinuxSupport default value

2016-08-04 Thread Leif Lindholm
On Wed, Aug 03, 2016 at 06:10:48PM -0500, Daniil Egranov wrote: > The built-in Linux Loader is obsolete and not included in most builds. > The patch sets the PcdBdsLinuxSupport default value to FALSE and prevents > ArmBds from looking for built-in Linux Loader by default and ASSERTing > when it ca

Re: [edk2] [PATCH 3/3] SecurityPkg Tcg2: Remove internal implementation of IsZeroBuffer()

2016-08-04 Thread Zhang, Chao B
Reviewed-by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Wu, Hao A Sent: Thursday, August 04, 2016 9:24 AM To: edk2-devel@lists.01.org Cc: Wu, Hao A; Yao, Jiewen; Zhang, Chao B Subject: [PATCH 3/3] SecurityPkg Tcg2: Remove internal implementation of IsZeroB

Re: [edk2] [PATCH] BaseTools X64: fold PLT relocations into simple relative references

2016-08-04 Thread Ard Biesheuvel
On 4 August 2016 at 10:58, Shi, Steven wrote: > OK, it is. But it is a bit not very clear. > Did you read the elaborate comment block explaining that (and why) it is appropriate to treat R_X86_64_PLT32 as a R_X86_64_PC32 relocation? This is not generally true, but it is true for UEFI since we don

Re: [edk2] [PATCH] BaseTools X64: fold PLT relocations into simple relative references

2016-08-04 Thread Shi, Steven
OK, it is. But it is a bit not very clear. Steven Shi Intel\SSG\STO\UEFI Firmware Tel: +86 021-61166522 iNet: 821-6522 > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Thursday, August 04, 2016 4:55 PM > To: Shi, Steven > Cc: Zhu, Yo

Re: [edk2] [PATCH] BaseTools X64: fold PLT relocations into simple relative references

2016-08-04 Thread Ard Biesheuvel
On 4 August 2016 at 10:54, Shi, Steven wrote: > Hi Ard, > I don't see you add below code for case R_X86_64_PLT32. Is it right? > > *(UINT32 *)Targ = (UINT32) (*(UINT32 *)Targ > + (mCoffSectionsOffset[Sym->st_shndx] - SymShdr->sh_addr) > - (SecOffset - SecShd

Re: [edk2] [PATCH] BaseTools X64: fold PLT relocations into simple relative references

2016-08-04 Thread Shi, Steven
Hi Ard, I don't see you add below code for case R_X86_64_PLT32. Is it right? *(UINT32 *)Targ = (UINT32) (*(UINT32 *)Targ + (mCoffSectionsOffset[Sym->st_shndx] - SymShdr->sh_addr) - (SecOffset - SecShdr->sh_addr)); Steven Shi Intel\SSG\STO\UEFI Firmware Te

[edk2] [PATCH] BaseTools X64: fold PLT relocations into simple relative references

2016-08-04 Thread Ard Biesheuvel
For X64/GCC, we use position independent code with hidden visibility to inform the compiler that symbols references are never resolved at runtime, which removes the need for PLTs and GOTs. However, in some cases GCC has been reported to still emit PLT based relocations, which we need to handle in t

Re: [edk2] [PATCH 0/3] Add APIs IsZeroBuffer and IsZeroGuid in BaseMemoryLib

2016-08-04 Thread Wu, Hao A
> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo > Ersek > Sent: Thursday, August 04, 2016 4:07 PM > To: Wu, Hao A > Cc: edk2-de...@ml01.01.org; Leif Lindholm (Linaro address); Ard Biesheuvel > Subject: Re: [edk2] [PATCH 0/3] Add APIs IsZe

Re: [edk2] [PATCH 0/3] Add APIs IsZeroBuffer and IsZeroGuid in BaseMemoryLib

2016-08-04 Thread Laszlo Ersek
Hello Hao, On 08/04/16 03:24, Hao Wu wrote: > The patch series will add two APIs in BaseMemoryLib: > 1. IsZeroBuffer() > The API is used to check if the contents of a buffer are all zeros. > > 2. IsZeroGuid() > The API is used to check if the given GUID is a zero GUID. > > In order to resolve buil