Re: [edk2] [PATCH V1] SecurityPkg: AuthVariableLib: Fix potential inconsistency corner case for Time Auth variable

Reviewed-by: Star Zeng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang, Chao B Sent: Tuesday, August 16, 2016 10:39 AM To: edk2-devel@lists.01.org Cc: Fu, Siyuan ; Zhang, Chao B ; Zeng, Star Subject: [edk2] [PATCH V1] SecurityPkg: AuthVar

Re: [edk2] [PATCH 01/11] MdePkg/UefiSpec.h: Align function header of ResetSystem to UEFI Spec

Reviewed-by: Liming Gao > -Original Message- > From: Ni, Ruiyu > Sent: Wednesday, August 10, 2016 1:56 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [PATCH 01/11] MdePkg/UefiSpec.h: Align function header of > ResetSystem to UEFI Spec > > Contributed-under: TianoCore Cont

Re: [edk2] USB 3.1 Support in UEFI

Hello Feng, Thank you for the reply. I understood, USB type C displayport alternate mode needs mux switch, and hence should be supported by silicon vendor. Whether DisplayPort is supported ? (not usb type c, i just need to use DisplayPort (instead of vga display, i want to use displayport and su

Re: [edk2] [PATCH] SecurityPkg: AuthVariableLib: Fix potential inconsistency corner case for Time Auth variable 2 steps are used to create/delete a time based variable. For create, step 1: Insert Sign

Liming: Thanks for remind. I have resent V1 patch to fix this problem. Thanks & Best regards Chao Zhang -Original Message- From: Gao, Liming Sent: Tuesday, August 16, 2016 11:05 AM To: Zhang, Chao B; edk2-devel@lists.01.org Cc: Fu, Siyuan; Zhang, Chao B; Zeng, Star Subject: RE: [ed

Re: [edk2] DHCP Automatic Configure at Driver Connect

Eugene, > > > > In my memory, we only talked about the performance issue before. > > > > Here, I understand your requirement: 1) The network interface > > > > should be in > > > > *un- > > > > configured* status at each boot time until the third part > > > > configuration; > > Yes, we would like

Re: [edk2] [PATCH] SecurityPkg: AuthVariableLib: Fix potential inconsistency corner case for Time Auth variable 2 steps are used to create/delete a time based variable. For create, step 1: Insert Sign

Chao: Please short the title, and move the detail in commit description. -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang, Chao B Sent: Tuesday, August 16, 2016 10:25 AM To: edk2-devel@lists.01.org Cc: Fu, Siyuan ; Zhang, Chao B ; Zeng, S

Re: [edk2] [PATCH V1] SecurityPkg: AuthVariableLib: Fix potential inconsistency corner case for Time Auth variable

Reviewed-by: Fu Siyuan > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Zhang, Chao B > Sent: Tuesday, August 16, 2016 10:39 AM > To: edk2-devel@lists.01.org > Cc: Fu, Siyuan ; Zhang, Chao B > ; Zeng, Star > Subject: [edk2] [PATCH V1] Secu

[edk2] [PATCH V1] SecurityPkg: AuthVariableLib: Fix potential inconsistency corner case for Time Auth variable

2 steps are used to create/delete a time based variable. For create, step 1: Insert Signer Cert to CertDB. Step 2: Insert Payload to Variable. For delete, step 1: Delete Variable. Step 2: Delete Cert from CertDB. System may breaks between step 1 & step 2, so CertDB may contains useless Cert in

Re: [edk2] [PATCH] ArmVirtPkg: Add NFIT report feature for ArmVirtPkg for ramdisks

Hi Laszlo, Thank you for reviewing the patch. -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Tuesday, August 16, 2016 2:08 AM To: Sajjan, Vikas C Cc: edk2-devel@lists.01.org ; ard.biesheu...@linaro.org; leif.lindh...@linaro.org; Shannon Zhao (Linaro address)

[edk2] [PATCH] SecurityPkg: AuthVariableLib: Fix potential inconsistency corner case for Time Auth variable 2 steps are used to create/delete a time based variable. For create, step 1: Insert Signer C

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Chao Zhang --- SecurityPkg/Library/AuthVariableLib/AuthService.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SecurityPkg/Library/AuthVariableLib/AuthService.c b/SecurityPkg/Library/AuthVariableLib/Auth

Re: [edk2] Setting BuildOptions by module type does not seem to work

Hi, This style has been defined in DSC spec 1.26. It can be downloaded from https://github.com/tianocore/tianocore.github.io/wiki/EDK%20II%20Specifications Thanks Liming From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Kurt Kennett Sent: Tuesday, August 16, 2016 1:56 AM T

Re: [edk2] [Patch] MdePkg: Fix guid conflict.

Reviewed-by: Liming Gao > -Original Message- > From: Dong, Eric > Sent: Friday, August 12, 2016 10:10 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Cecil Sheng > Subject: [Patch] MdePkg: Fix guid conflict. > > Update Image Decoder Protocol GUID value to fix GUID > conflict with E

Re: [edk2] IP4 Config Troubles with DHCP

> > Actually, you don't need to retry the UDP configuration loop according > > the Ip4Mode.IsConfigured flag. You are only recommended to set a timer > > to check the mapping status after the configuration: > > > > For example: > > Status = Nlc->Udp4->Configure(Nlc->Udp4, &Nlc->UdpConfig); > >

Re: [edk2] DHCP Automatic Configure at Driver Connect

Hi Eugene, I think we need fully understand your usage before analyzing the problem. Could you please explain more details? You mentioned you only wanted to enable the network interface when directed by an application. If so, is it possible that you don't connect your network device until you r

Re: [edk2] AppPkg with python enabled - build fails

After tweaking the build flags, got this to build on fedora22 just for testing. The Python.Efi does not launch in EDK shell - throws an error Error: Image at 00074E03000 start failed: Aborted. (there is another python assertion failure before this line) We also tried to build this in a different

Re: [edk2] [PATCH] ArmVirtPkg: Add NFIT report feature for ArmVirtPkg for ramdisks

On 08/09/16 11:55, Sajjan, Vikas C wrote: > Adding Maintainers. > > -Original Message- > From: Sajjan, Vikas C > Sent: Tuesday, August 09, 2016 1:28 PM > To: edk2-devel@lists.01.org > Cc: Sajjan, Vikas C > Subject: [PATCH] ArmVirtPkg: Add NFIT report feature for ArmVirtPkg for > ramdisk

Re: [edk2] Setting BuildOptions by module type does not seem to work

Okay this seems to work: [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] Thanks Andrew. (doesn't match the spec though :) ) K2 -Original Message- From: af...@apple.com [mailto:af...@apple.com] Sent: Monday, August 15, 2016 10:30 AM To: Kurt Kennett Cc: edk2-devel Subject: Re: [edk2]

Re: [edk2] Setting BuildOptions by module type does not seem to work

> On Aug 15, 2016, at 9:34 AM, Kurt Kennett wrote: > > No, I had not tried that. I tried it now and it does not seem to work. > > I have: > > [BuildOptions.AARCH64.common] >*_VS2015x86_AARCH64_DLINK_FLAGS = /BORK > > [BuildOptions.AARCH64.common.DXE_RUNTIME_DRIVER] >*_VS2015x86_AARCH

Re: [edk2] Setting BuildOptions by module type does not seem to work

No, I had not tried that. I tried it now and it does not seem to work. I have: [BuildOptions.AARCH64.common] *_VS2015x86_AARCH64_DLINK_FLAGS = /BORK [BuildOptions.AARCH64.common.DXE_RUNTIME_DRIVER] *_VS2015x86_AARCH64_DLINK_FLAGS = /PLOR [BuildOptions.AARCH64.common.EDKII.DXE_RUNTIME_D

Re: [edk2] Setting BuildOptions by module type does not seem to work

> On Aug 15, 2016, at 9:10 AM, Kurt Kennett wrote: > > DSC spec (January 2016 1.26) says I can do this: > > (Section 3.6 pp 76) > > ... > * [BuildOptions.$(arch).CodeBase.Edk2ModuleType] > ... > > And this works fine: > > [BuildOptions.AARCH64.common] >*_VS2015x86_*_DLINK_FLAGS = /BORK >

Re: [edk2] [MdeModulePkg][PeiCore] I seemed to have crashed the PEI Core by grabbing memory from PeiTemporaryRamBase?

> On Aug 15, 2016, at 8:54 AM, Gao, Liming wrote: > > Andrew: > In permanent memory, PeiCore places heap base as stack top. Heap is above > stack. There is no hole between them. SEC needs to follow this layout and > migrate the temporary memory to permanent memory. It should copy TemporaryRam

[edk2] Setting BuildOptions by module type does not seem to work

DSC spec (January 2016 1.26) says I can do this: (Section 3.6 pp 76) ... * [BuildOptions.$(arch).CodeBase.Edk2ModuleType] ... And this works fine: [BuildOptions.AARCH64.common] *_VS2015x86_*_DLINK_FLAGS = /BORK But when I also do: [BuildOptions.AARCH64.common.DXE_RUNTIME_DRIVER] *_VS2

Re: [edk2] [MdeModulePkg][PeiCore] I seemed to have crashed the PEI Core by grabbing memory from PeiTemporaryRamBase?

Andrew: In permanent memory, PeiCore places heap base as stack top. Heap is above stack. There is no hole between them. SEC needs to follow this layout and migrate the temporary memory to permanent memory. It should copy TemporaryRam HEAP and STACK range separately. HEAP range is specified by

Re: [edk2] [PATCH] BaseTools/Source/C/GenFv/GenFvInternalLib.c

Yes. BaseTools Win32 Binary will auto be updated based on BaseTools source. Thanks Liming From: Duran, Leo [mailto:leo.du...@amd.com] Sent: Monday, August 15, 2016 9:13 PM To: Zhu, Yonghong ; Ard Biesheuvel Cc: Gao, Liming ; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH] BaseTools/Source/C/

Re: [edk2] DHCP Automatic Configure at Driver Connect

Jiaxin, > > > In my memory, we only talked about the performance issue before. > > > Here, I understand your requirement: 1) The network interface should > > > be in > > > *un- > > > configured* status at each boot time until the third part > > > configuration; Yes, we would like a policy setting

Re: [edk2] [Patch] MdeModulePkg: Fix potential failure if UseDefaultAddress configured

Tested-by: Eugene Cohen with the provision that Configure() retries are maintained for TCP cases > -Original Message- > From: Jiaxin Wu [mailto:jiaxin...@intel.com] > Sent: Sunday, August 14, 2016 8:47 PM > To: edk2-devel@lists.01.org > Cc: Cohen, Eugene ; Ye Ting ; > Fu Siyuan > Subjec

Re: [edk2] IP4 Config Troubles with DHCP

Jiaxin, > Actually, you don't need to retry the UDP configuration loop according > the Ip4Mode.IsConfigured flag. You are only recommended to set a > timer to check the mapping status after the configuration: > > For example: > Status = Nlc->Udp4->Configure(Nlc->Udp4, &Nlc->UdpConfig); > if

Re: [edk2] [PATCH] BaseTools/Source/C/GenFv/GenFvInternalLib.c

> -Original Message- > From: Zhu, Yonghong [mailto:yonghong@intel.com] > Sent: Sunday, August 14, 2016 7:16 PM > To: Ard Biesheuvel ; Duran, Leo > > Cc: Gao, Liming ; edk2-devel@lists.01.org; Zhu, > Yonghong > Subject: RE: [edk2] [PATCH] BaseTools/Source/C/GenFv/GenFvInternalLib.c >

[edk2] [Patch 1/3 V2] BaseTools: Add the PKCS7 tool

Provide the PKCS7 Tool to support the CertType - EFI_CERT_TYPE_PKCS7_GUID, then user can use this tool to add EFI_FIRMWARE_IMAGE_AUTHENTICATION for a binary. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- BaseTools/Conf/tools_def.template

[edk2] [PATCH] UefiCpuPkg: MTRR_PHYSMASK.Valid should be one bit instead of 8 bits

Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Feng Tian --- UefiCpuPkg/Include/Register/ArchitecturalMsr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UefiCpuPkg/Include/Register/ArchitecturalMsr.h b/UefiCpuPkg/Include/Register/Archi

Re: [edk2] [Patch 1/3] BaseTools: Add the PKCS7 tool

Thanks. I will update it and send a new version. Best Regards, Zhu Yonghong -Original Message- From: Yao, Jiewen Sent: Monday, August 15, 2016 4:32 PM To: Zhu, Yonghong ; edk2-devel@lists.01.org Cc: Gao, Liming Subject: RE: [Patch 1/3] BaseTools: Add the PKCS7 tool Hello In order to m

Re: [edk2] [Patch 1/3] BaseTools: Add the PKCS7 tool

Hello In order to make PKCS7 tool be consistent with RSA2048SHA256, I suggest we use "Pkcs7Sign.py" instead of GenFirmwareImageAuthPkcs7.py. > -Original Message- > From: Zhu, Yonghong > Sent: Monday, August 15, 2016 4:18 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Yao, Jiewen >

[edk2] [Patch 3/3] BaseTools: FMP capsule add the support to generate auth info

Current BaseTools cannot generate EFI_FIRMWARE_IMAGE_AUTHENTICATION for FMP capsule. this patch fix it by FDF spec's update to add the definition for CERTIFICATE_GUID and MONOTONIC_COUNT. BaseTools call the tool by CERTIFICATE_GUID to generate the certdata and fill the header info. Cc: Liming Gao

[edk2] [Patch 1/3] BaseTools: Add the PKCS7 tool

Provide the PKCS7 Tool to support the CertType - EFI_CERT_TYPE_PKCS7_GUID, then user can use this tool to add EFI_FIRMWARE_IMAGE_AUTHENTICATION for a binary. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- BaseTools/Conf/tools_def.template

[edk2] [Patch 0/3] BaseTools: Add the support for FMP capsule generate auth info

Current BaseTools cannot support the EFI_FIRMWARE_IMAGE_AUTHENTICATION struct for FMP capsule. # typedef struct { # UINT64MonotonicCount; # WIN_CERTIFICATE_UEFI_GUID AuthInfo; # } EFI_FIRMWARE_IMAGE_AUTHENTICATION; Patch 1: add the PKCS7 Tool to support CertType - EFI_CERT

[edk2] [Patch 2/3] BaseTools: Rsa2048Sha256Sign add new option to support Monotonic count

the EFI_FIRMWARE_IMAGE_AUTHENTICATION struct require the AuthInfo which is a signature across the image data and the Monotonic Count value, so we add the new option to support Monotonic count. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu ---

Re: [edk2] [PATCH v1 1/1] MdeModulePkg/PeiCore: Fix ConverSinglePpiPointer () typo.

Just pushed the patch at de74668f5ea713b7e91e01318f0d15d2bf0effce. Thanks, Star -Original Message- From: Tian, Feng Sent: Monday, August 15, 2016 9:32 AM To: Zeng, Star ; marvin.haeu...@outlook.com; edk2-devel@lists.01.org Cc: Tian, Feng Subject: RE: [PATCH v1 1/1] MdeModulePkg/PeiCore: