*v2: update the commit log and refine the code comments.
Cc: Ye Ting
Cc: Fu Siyuan
Cc: Zhang Lubo
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiaxin Wu
Jiaxin Wu (2):
NetworkPkg/IpSecDxe: Fix UEFI IKE Initial Exchange failure
NetworkPkg/IpSecDxe: Fix wrong IKE h
*v2: update the commit log.
IKE Initial Exchange message should cover below process:
InitiatorResponder
Message1 HDR,SAil,KEi,Ni -->
Message2 <-- HDR,SArl,KEr,Nr,[CERTREQ]
Message3 HDR,SK{} -->
Message4 <--
*v2: update the commit log and refine the code comments.
There are three kinds of IKE Exchange process:
#1. Initial Exchange
#2. CREATE_CHILD_SA_Exchange
#3. Information Exchange
The IKE header "FLAG" update is incorrect in #2 and #3 exchange,
which may cause the continue session failure. This pa
Reviewed-by: Liming Gao
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Yonghong Zhu
> Sent: Thursday, August 18, 2016 10:28 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [Patch] BaseTools: check CONF_PATH env to get
Jiaxin,
We will verify the patch and update you the result.
Thanks,
Naveen
-Original Message-
From: Wu, Jiaxin [mailto:jiaxin...@intel.com]
Sent: Thursday, August 18, 2016 11:12 AM
To: Santhapur Naveen; Wu, Jiaxin; edk2-devel@lists.01.org
Cc: Ye, Ting; Fu, Siyuan; Sivaraman Nainar; Madh
Naveen,
Can you help to verify this patch to support the classless IP.
Thanks,
Jiaxin
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Jiaxin Wu
> Sent: Thursday, August 18, 2016 1:39 PM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting ; Fu, Siy
The IP address should not be treated as classful one if DHCP options
contain a classless IP with its true subnet mask. Otherwise, DHCPv4
TransmitReceive() will failed. This real subnet mask will be parsed
and recorded in DhcpSb->Netmask. So, we need check it before get the
IP's corresponding subnet
Adds the RAMDisk support to ArmVirtPkg platforms.
This patch actually ports OvmfPkg commit 259d87146b07 to
ArmVirtPkg.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Vikas C Sajjan
---
ArmVirtPkg/ArmVirt.dsc.inc | 7 +++
ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
Since ArmVirt.dsc.inc is included in all the ArmVirt dsc files,
move inclusion of AcpiTableDxe.inf to ArmVirt.dsc.inc.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Vikas C Sajjan
---
ArmVirtPkg/ArmVirt.dsc.inc | 6 ++
ArmVirtPkg/ArmVirtQemu.dsc | 1 -
Ar
This series adds ramdisk driver support to ArmVirtPkg platforms.
It actually ports OvmfPkg commit 259d87146b07 to ArmVirtPkg.
changes since v1:
- Made changes as suggested by Laszlo Ersek
a] clarified in the commit message (including the subject line)
that this patch is actually
we need to locate the FSP Info Header before the stack is initialized to
access the cfg region for any UPD. Hence adding the
AsmGetFspInfoHeaderNoStack function to support it.
Note: This function is there in IntelFspPkg but got removed in IntelFsp2Pkg
Cc: Maurice Ma
Cc: Jiewen Yao
Cc: Giri P Mu
Serial reviewed-by: Chao Zhang
Thanks & Best regards
Chao Zhang
-Original Message-
From: Wu, Hao A
Sent: Thursday, August 18, 2016 12:54 PM
To: edk2-devel@lists.01.org; Gao, Liming
Cc: Wu, Hao A; Yao, Jiewen; Zhang, Chao B
Subject: [PATCH v2 6/6] SecurityPkg Tcg2: Remove use of modul
Changes made comparing V1:
1. Use assembly to implement the IsZeroBuffer() API for the following
library instances:
BaseMemoryLibMmx
BaseMemoryLibOptDxe
BaseMemoryLibOptPei
BaseMemoryLibRepStr
BaseMemoryLibSse2
2. Utilize XMM regesters and related instructions in assembly codes for
BaseMemoryLibSs
Add the implementation of API IsZeroBuffer() via assembly for the
following library instances:
BaseMemoryLibMmx
BaseMemoryLibOptDxe
BaseMemoryLibOptPei
BaseMemoryLibRepStr
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: H
Add the implementation of API IsZeroBuffer() via assembly in
BaseMemoryLibSse2.
The assembly codes use SSE2 XMM registers and related instructions.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu
---
.../BaseMem
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu
---
MdePkg/Include/Library/BaseMemoryLib.h | 22 +-
MdePkg/Library/BaseMemoryLib/MemLibGuid.c | 31 -
MdePkg/L
Add the implementation of API IsZeroBuffer() via C language for the
following library instances:
BaseMemoryLib
PeiMemoryLib
UefiMemoryLib
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu
---
MdePkg/Include/Library
Before adding API IsZeroBuffer() in BaseMemoryLib at MdePkg, rename the
internal implementations of IsZeroBuffer() within SecurityPkg/Tcg modules
to avoid breaking bisection.
Cc: Jiewen Yao
Cc: Chao Zhang
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao
This commit removes the internal implementation of the function
InternalIsZeroBuffer(). Instead, it will use the API IsZeroBuffer() from
BaseMemoryLib in MdePkg.
Cc: Jiewen Yao
Cc: Chao Zhang
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu
---
Secu
Yeah, thanks for digging this out. Classless IP was not considered here.
Jiaxin
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Fu,
> Siyuan
> Sent: Thursday, August 18, 2016 11:21 AM
> To: Santhapur Naveen ; Ye, Ting
> ; edk2-devel@lists.
Naveen,
I see it, the corresponding GIT version is
ce964733292e31dce34e0be651f20a9d79884132.
I believe it's a regression bug, the change assume the IP address is always
classful. I think it should check the option list to see if a subnet mask
option is present.
Could you please file a new bu
Please find the below details and snapshot.
Revision: 21543
Author: Wu.Jiaxin
Date: Thursday, June 18, 2015 6:13:15 AM
Message: MdeModulePkg: Remove DHCP4.TransmitReceive() and DORA process
dependency.
Modified: /trunk/MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Impl.c
Contributed-under
Use FSP binary from GitHub: https://github.com/IntelFsp/FSP/tree/Braswell.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Guo Mang
---
BraswellPlatformPkg/PlatformFvBinPkg.fdf |2 +-
BraswellPlatformPkg/PlatformPkg.fdf |2 +-
ChvFspBinPkg/Include/FspUpdVpd.h
Hi Eugene,
If you propose separating DHCP process from DHCP policy setting, I think it is
more like to update/clarify existing behavior defined in IP4Config2/IP6Config
of UEFI specification. How about we move the discussion to UNST forum, in order
to draw more attention for the topic?
Thanks,
CLANG38 IA32 Arch also requires this change.
> -Original Message-
> From: Shi, Steven
> Sent: Wednesday, August 17, 2016 9:02 PM
> To: edk2-devel@lists.01.org; Gao, Liming
> Cc: ard.biesheu...@linaro.org; Shi, Steven
> Subject: [PATCH] BaseTools-CLANG38: Add O3 in Dlink2 flag
>
> CLANG
Reviewed by: Maurice Ma
-Original Message-
From: Agyeman, Prince
Sent: Wednesday, August 17, 2016 1:16 PM
To: edk2-devel@lists.01.org
Cc: Ma, Maurice; Leahy, Leroy P
Subject: [PATCH 1/2] CorebootPayloadPkg : Added MpInitLib to
CorebootPayloadPkg.dsc
MpInitLib is consumed by CpuDxe
Co
Reviewed by: Maurice Ma
-Original Message-
From: Agyeman, Prince
Sent: Wednesday, August 17, 2016 1:16 PM
To: edk2-devel@lists.01.org
Cc: Ma, Maurice; Leahy, Leroy P
Subject: [PATCH 2/2] CorebootPayloadPkg: fixed GCC49 and GCC5 hang in PeiCore
Section alignment of .data in GCC49 and GCC
I searched the log messages:
Revision: 21543
Author: edk2buildsystem
Date: Friday, July 01, 2016 5:05:51 AM
Message:
MdeModulePkg VariableInfo: Fix GCC build failure
GCC build failure: 'RealCommSize' may be used uninitialized
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.
Thanks David. I'll fix it.
-Original Message-
From: Wei, David
Sent: Thursday, August 18, 2016 10:41 AM
To: Guo, Mang ; edk2-devel@lists.01.org; Wu, Mike
; Rangarajan, Ravi P ;
Mudusuru, Giri P ; Zimmer, Vincent
; Ma, Maurice ; Wang, Stephanie
Cc: Wu, Mike ; Rangarajan, Ravi P
; M
Eugene,
> > Ip4Config2OnDhcp4SbInstalled() maybe confused you, but it's not
> > accurate as you said "when the DHCP SB is installed you do a configure
> automatically".
> > It's more proper to say "IPv4 driver is requiring DHCP SB due to it
> > detects the DHCP policy." In such a case, it's reason
Hi, Naveen
May I know the GIT version of the 21543, or the subject of the commit message?
I can't see the svn revision number on my side.
Thanks
Siyuan
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Santhapur Naveen
> Sent: Wednesday, Aug
Please fix below unknown characters.
@@ -38,16 +38,16 @@ This code combines elements from github, intel.com/fsp and
firmware.intel.com
d. Change folder name from
"C:\MyWorkspace\edk2-platforms\BaseTools\Bin\edk2-BaseTools-win32�
to "C:\MyWorkspace\edk2-platforms\BaseTools\Bin\win
FspUpdVpd.h can be downloaded from FSP GitHub Repo:
https://github.com/IntelFsp/FSP/tree/Braswell.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Guo Mang
---
ChvFspBinPkg/Include/FspUpdVpd.h | 510 ---
1 file changed, 510 deletions(-
Use FSP binary from GitHub: https://github.com/IntelFsp/FSP/tree/Braswell.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Guo Mang
---
BraswellPlatformPkg/PlatformFvBinPkg.fdf |2 +-
BraswellPlatformPkg/PlatformPkg.fdf |2 +-
ChvFspBinPkg/Include/FspUpdVpd.h
Add CONF_PATH env check. First priority is user set the conf dir by
--conf option, then the CONF_PATH env, the last one is the standard
WORKSPACE(PACKAGE_PATH)/Conf.
Also print the conf path directory in the build log.
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-
Reviewed-by: Michael Kinney
> -Original Message-
> From: Zeng, Star
> Sent: Tuesday, August 16, 2016 7:27 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Kinney, Michael D
> ;
> Gao, Liming ; Paolo Bonzini ;
> Lohr, Paul A
>
> Subject: [PATCH] PcAtChipsetPkg AcpiTimerLib: Wait 363
Hi Paolo,
We did some experiments to wait for the next ACPI Timer tick, and they did
not improve the results.
On real HW, the I/O Port read of the ACPI Timer takes ~1 uS, and an ACPI Timer
tick is about 0.25 uS, so the action to read the counter takes 4 times longer
than a single count.
If the
The thunk generation is needlessly complex, given that it attempts to
deal with variable length instructions, which don't exist on AArch64.
So replace it with a simple template coded in assembler, with a matching
struct definition in C. That way, we can create and manipulate the thunks
easily with
Instead of pessimistically copying at least 64 bytes from the VM stack
to the native stack, and popping off the register arguments again
before doing the native call, try to avoid touching the stack completely
if the VM stack frame is < 64 bytes. Also, if the stack frame does exceed
64 bytes, there
The prototypes of EbcInterpret() and ExecuteEbcImageEntryPoint() are
private to the AARCH64 implementation of EbcDxe, so we can shuffle
the arguments around a bit and make the assembler thunking clue a lot
simpler.
For ExecuteEbcImageEntryPoint(), this involves passing the EntryPoint
argument as t
Change to consistent // style comments. Also, remove bogus global
definitions for external functions, and move the real exports to
the top of the file.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel
---
MdeModulePkg/Universal/EbcDxe/AArch64/EbcLowLevel.S |
This is v3 of my proposed changes to the AARCH64 implementation of EbcDxe
contributed by Jeff Brasen, of which Leif has sent a version out early
this morning.
Ard Biesheuvel (4):
MdeModulePkg/EbcDxe AARCH64: clean up comment style in ASM file
MdeModulePkg/EbcDxe AARCH64: use a fixed size thunk
On Wed, Aug 17, 2016 at 03:55:01PM +0200, Laszlo Ersek wrote:
> On 08/17/16 15:47, Ard Biesheuvel wrote:
> > On 17 August 2016 at 15:45, Leif Lindholm wrote:
> >> Since we now have EBC support for AArch64, enable it by default
> >> on the QEMU platform.
> >>
> >> Contributed-under: TianoCore Contr
On 17 August 2016 at 15:55, Laszlo Ersek wrote:
> On 08/17/16 15:47, Ard Biesheuvel wrote:
>> On 17 August 2016 at 15:45, Leif Lindholm wrote:
>>> Since we now have EBC support for AArch64, enable it by default
>>> on the QEMU platform.
>>>
>>> Contributed-under: TianoCore Contribution Agreement
On 08/17/16 15:47, Ard Biesheuvel wrote:
> On 17 August 2016 at 15:45, Leif Lindholm wrote:
>> Since we now have EBC support for AArch64, enable it by default
>> on the QEMU platform.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Leif Lindholm
>> ---
>> ArmVirtP
On 17 August 2016 at 15:45, Leif Lindholm wrote:
> Since we now have EBC support for AArch64, enable it by default
> on the QEMU platform.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Leif Lindholm
> ---
> ArmVirtPkg/ArmVirtQemu.dsc | 1 +
> ArmVirtPkg/A
On 17 August 2016 at 15:45, Leif Lindholm wrote:
> From: Jeff Brasen
>
> Adds support for the EBC VM for AARCH64 platforms
>
> Submitted on behalf of a third-party: The Linux Foundation
> This contribution is licensed under the BSD license as found at
> http://opensource.org/licenses/bsd-license.
Import the AArch64 EBC implementation from
https://source.codeaurora.org/external/server/edk2-blue/
Tested with MdeModulePkg/Application/HelloWorld built for EBC.
Changes from RFC (affecting 1/2 only):
- Added contributed-under tag after discussion with other stewards.
The agreed interpretation
Since we now have EBC support for AArch64, enable it by default
on the QEMU platform.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Leif Lindholm
---
ArmVirtPkg/ArmVirtQemu.dsc | 1 +
ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 5 +
2 files changed, 6 insertions
From: Jeff Brasen
Adds support for the EBC VM for AARCH64 platforms
Submitted on behalf of a third-party: The Linux Foundation
This contribution is licensed under the BSD license as found at
http://opensource.org/licenses/bsd-license.php
[Taken from https://source.codeaurora.org/external/server
On 17 August 2016 at 14:24, Shi, Steven wrote:
>>
>
>> Could you try putting -O2 in the DLINK2_FLAGS for Clang 38? (i.e., so
>
>> that the last -O option the linker sees is not -Oz)
>
>>
>
> Ard,
>
> Add -O2 or -O3 in DLINK2_FLAGS works as below, thank your suggestion!
>
Good to know!
Thanks,
Ar
CLANG38 build fail after CC_FLAG is added in the link rule.
This failure is because the CLANG38 enable the LTO through LLVMgold.so
linker plugin, but the LLVMgold.so plugin cannot accept the clang -Oz
CC flag as build option. After CC_FLAG is added in the link rule,
the LLVMgold.so plugin reports l
>
> Could you try putting -O2 in the DLINK2_FLAGS for Clang 38? (i.e., so
> that the last -O option the linker sees is not -Oz)
>
Ard,
Add -O2 or -O3 in DLINK2_FLAGS works as below, thank your suggestion!
"/home/jshi19/clang38/bin/clang" -o
/home/jshi19/edk2-fork/Build/OvmfX64/RELEASE_CLAN
Jiaxin,
> Ip4Config2OnDhcp4SbInstalled() maybe confused you, but it's not accurate
> as you said "when the DHCP SB is installed you do a configure automatically".
> It's more proper to say "IPv4 driver is requiring DHCP SB due to it detects
> the
> DHCP policy." In such a case, it's reasonable wi
On 17 August 2016 at 13:38, Shi, Steven wrote:
> Hi Ard,
>
> CLANG38 has a build failure as below for this patch. This failure is because
> the CLANG38 enable the LTO through LLVMgold.so linker plugin, but the
> LLVMgold.so plugin cannot accept the clang -Oz cc flag as build option.
> After CC_FLA
Hello,
We happened to observe that the IPv4 PXE boot was happening
successfully for both classless and classful IPs until the EDKII revision
21542. It has been found that there are some changes made in the revision 21543
and the IPv4 PXE boot is failing for classless IP addresses. The
Hi Ard,
CLANG38 has a build failure as below for this patch. This failure is because
the CLANG38 enable the LTO through LLVMgold.so linker plugin, but the
LLVMgold.so plugin cannot accept the clang -Oz cc flag as build option. After
CC_FLAG is added in the link rule, the LLVMgold.so plugin repo
Current BaseTools query the BuildOptions not cover the case that use
'COMMON' as CodeBase, while DSC spec allow this usage. This Patch add
support for such 'common.DXE_RUNTIME_DRIVER' as the Scope2 in the query
Condition.
Cc: Liming Gao
Cc: Kurt Kennett
Contributed-under: TianoCore Contribution
On 17/08/2016 04:26, Star Zeng wrote:
> Compute the number of ticks to wait to measure TSC frequency.
> Instead of (ACPI_TIMER_FREQUENCY / 1) = 357 and 357 * 1 = 357,
> use 363 * 9861 = 3579543 Hz which is within 2 Hz of ACPI_TIMER_FREQUENCY.
> 363 counts is a calibration time of 101.
59 matches
Mail list logo
