Re: [edk2] [PATCH v3 0/2] Add Ramdisk support to ArmVirtPkg platforms

-Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Friday, August 19, 2016 6:58 PM To: Sajjan, Vikas C ; edk2-de...@ml01.01.org; ard.biesheu...@linaro.org; leif.lindh...@linaro.org Cc: Wei, Dong (Office of the CTO) Subject: Re: [PATCH v3 0/2] Add Ramdisk support to

Re: [edk2] [PATCH] IntelFsp2Pkg: Add function to get FspInfoHeader before stack is ready

Reviewed-by: Giri P Mudusuru > -Original Message- > From: Yarlagadda, Satya P > Sent: Wednesday, August 17, 2016 10:21 PM > To: edk2-devel@lists.01.org > Cc: Ma, Maurice ; Yao, Jiewen > ; Mudusuru, Giri P > Subject: [PATCH] IntelFsp2Pkg: Add function to get FspInfoHeader before stack >

Re: [edk2] OVMF not booting when built with GCC5 toolset?

On 8/19/2016 8:35 AM, Bruce Cran wrote: When I built and ran it using the same commands (with the exception of adding "-vnc :0" to the qemu cmdline) I got the same problem as before, and serial.log contained just: SecCoreStartupWithStack(0x30202C78SecCoreStartupWithStack(0x30202C78SecCoreStart

Re: [edk2] OVMF not booting when built with GCC5 toolset?

On 8/18/2016 8:08 PM, Shi, Steven wrote: I build OVMF GCC X64 image, can boot Qemu into shell with below commands. I can enter shell, reconnect -r, exit to setup, and the vga display looks good to me. What build command did you use? build -t GCC5 -a X64 -p OvmfPkg/OvmfPkgX64.dsc -n 5 -b DEB

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

On 08/19/16 04:26, Laszlo Ersek wrote: > On 08/19/16 04:00, Fan, Jeff wrote: >> Laszlo, >> >> I could revert this patch firstly. > > Thank you, that would be very kind. > >> Could you please dig out the OVMF to address the potential issue, then I >> could re-commit it for those platforms require

Re: [edk2] [PATCH 00/11] OvmfPkg, ArmVirtPkg: GOP driver for the VirtIo GPU (virtio-gpu-pci)

On 08/19/16 15:06, Ard Biesheuvel wrote: > On 19 August 2016 at 14:49, Laszlo Ersek wrote: >> This series solves >> . In particular, >> it gives AARCH64 guests running on KVM a clean, uncorrupted graphical >> console. >> > > Impressive! I su

Re: [edk2] [PATCH 0/6] PiDxeS3BootScriptLib: Support multiple PCI segment

Reviewed by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Friday, August 19, 2016 3:35 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen ; > Kinney, Michael D ; Chan Amy > ; Laszlo Ersek ; Steele, Kelly > ; Wei, David ; Zhang, Chao B > > Subject: [PAT

Re: [edk2] [PATCH v3 0/2] Add Ramdisk support to ArmVirtPkg platforms

On 08/19/16 08:55, Vikas C Sajjan wrote: > This series adds ramdisk driver support to ArmVirtPkg platforms. > It actually ports OvmfPkg commit 259d87146b07 to ArmVirtPkg. > > changes since v2: >- Made changes as suggested by Laszlo Ersek > a] Moved inclusion of AcpiTableDxe.inf to end o

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

On 08/19/16 04:57, Zeng, Star wrote: > On 2016/8/19 10:45, Zeng, Star wrote: >> On 2016/8/19 10:26, Laszlo Ersek wrote: >>> On 08/19/16 04:00, Fan, Jeff wrote: Laszlo, I could revert this patch firstly. >>> >>> Thank you, that would be very kind. >>> Could you please dig out the

Re: [edk2] [PATCH 11/11] ArmVirtPkg: remove PcdKludgeMapPciMmioAsCached

On 19 August 2016 at 14:49, Laszlo Ersek wrote: > In ARM/AARCH64 guests that run on KVM, we can now use virtio-gpu-pci, so > PcdKludgeMapPciMmioAsCached is no longer necessary. Standard VGA continues > to work on TCG without the kludge. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Ref: https://t

Re: [edk2] [PATCH 07/11] ArmVirtPkg/ArmVirtQemu: include VirtioGpuDxe in the platform DSC/FDF files

On 19 August 2016 at 14:49, Laszlo Ersek wrote: > At this stage, the driver builds, and suffices for testing binding and > unbinding. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Ref: https://tianocore.acgmultimedia.com/show_bug.cgi?id=66 > Contributed-under: TianoCore Contribution Agreement 1.0

Re: [edk2] [PATCH 00/11] OvmfPkg, ArmVirtPkg: GOP driver for the VirtIo GPU (virtio-gpu-pci)

On 19 August 2016 at 14:49, Laszlo Ersek wrote: > This series solves > . In particular, > it gives AARCH64 guests running on KVM a clean, uncorrupted graphical > console. > Impressive! I suppose this means no direct frame buffer access for t

[edk2] [PATCH 11/11] ArmVirtPkg: remove PcdKludgeMapPciMmioAsCached

In ARM/AARCH64 guests that run on KVM, we can now use virtio-gpu-pci, so PcdKludgeMapPciMmioAsCached is no longer necessary. Standard VGA continues to work on TCG without the kludge. Cc: Ard Biesheuvel Cc: Jordan Justen Ref: https://tianocore.acgmultimedia.com/show_bug.cgi?id=66 Contributed-unde

[edk2] [PATCH 08/11] OvmfPkg/VirtioGpuDxe: initialize and tear down VirtIo GPU device

This patch implements the steps listed in section "3.1.1 Driver Requirements: Device Initialization" of the Virtio V1.0 Committee Spec 04. The VirtIo GPU is brought up in VirtioGpuDriverBindingStart(), and down in VirtioGpuDriverBindingStop(). We also add an ExitBootServices() callback that resets

[edk2] [PATCH 09/11] OvmfPkg/VirtioGpuDxe: provide functions for sending VirtIo GPU commands

In this patch we add a "workhorse" function called VirtioGpuSendCommand(), and implement seven simple RPCs atop, for the command types listed in "OvmfPkg/Include/IndustryStandard/VirtioGpu.h". These functions will be called by our EFI_GRAPHICS_OUTPUT_PROTOCOL implementation. Cc: Ard Biesheuvel C

[edk2] [PATCH 00/11] OvmfPkg, ArmVirtPkg: GOP driver for the VirtIo GPU (virtio-gpu-pci)

This series solves . In particular, it gives AARCH64 guests running on KVM a clean, uncorrupted graphical console. Anatomy of the series: - Patches 01 and 02 fix small bugs in QemuVideoDxe and Virtio10Dxe, so that virtio-vga is bound only

[edk2] [PATCH 07/11] ArmVirtPkg/ArmVirtQemu: include VirtioGpuDxe in the platform DSC/FDF files

At this stage, the driver builds, and suffices for testing binding and unbinding. Cc: Ard Biesheuvel Cc: Jordan Justen Ref: https://tianocore.acgmultimedia.com/show_bug.cgi?id=66 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- ArmVirtPkg/ArmVirtQemu.dsc

[edk2] [PATCH 03/11] OvmfPkg/PlatformBootManagerLib: relax device class requirement for ConOut

This will add virtio-gpu-pci devices to ConOut automatically. For further benefit, the change also allows OVMF to use the legacy-free / secondary VGA adapter (added in QEMU commit 63e3e24d, "vga: add secondary stdvga variant") as console. ArmVirtPkg's PlatformBootManagerLib already filters with I

[edk2] [PATCH 02/11] OvmfPkg/Virtio10Dxe: don't bind virtio-vga

Commit 9399f68ae359 ("OvmfPkg: Virtio10Dxe: non-transitional driver for virtio-1.0 PCI devices") created a "competition" between Virtio10Dxe and QemuVideoDxe for virtio-vga devices. The binding order between these drivers is unspecified, and the wrong order effectively breaks commit 94210dc95e9f ("

[edk2] [PATCH 04/11] OvmfPkg/IndustryStandard: add type definitions for the virtio GPU device

The GPU additions to VirtIo 1.0 are a work in progress. Mark the relevant URLs in the source code. Incorporate the absolute minimum from the WIP spec that is necessary for implementing a GOP driver. Add the VIRTIO_SUBSYSTEM_GPU_DEVICE macro to "IndustryStandard/Virtio10.h", since all other such ma

[edk2] [PATCH 01/11] OvmfPkg/QemuVideoDxe: don't incorrectly bind virtio-gpu-pci

The PCI (Vendor ID, Device ID) pair (0x1af4, 0x1050) stands for both the virtio-vga and the virtio-gpu-pci device models of QEMU. They differ in two things: - the former has a VGA-compatibility linear framebuffer on top of the latter, - the former has PCI_CLASS_DISPLAY_VGA device class, while t

[edk2] [PATCH 10/11] OvmfPkg/VirtioGpuDxe: implement EFI_GRAPHICS_OUTPUT_PROTOCOL

In this patch we replace our "dummy" Graphics Output Protocol interface with the real one. We exploit that EFI_GRAPHICS_OUTPUT_BLT_PIXEL and VirtioGpuFormatB8G8R8X8Unorm have identical representations; this lets us forego any pixel format conversions in the guest. For messaging the VirtIo GPU devic

[edk2] [PATCH 06/11] OvmfPkg: include VirtioGpuDxe in the platform DSC/FDF files

At this stage, the driver builds, and suffices for testing binding and unbinding. Cc: Ard Biesheuvel Cc: Jordan Justen Ref: https://tianocore.acgmultimedia.com/show_bug.cgi?id=66 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- OvmfPkg/OvmfPkgIa32.dsc

[edk2] [PATCH 05/11] OvmfPkg/VirtioGpuDxe: introduce with Component Name 2 and Driver Binding

This patch adds the skeleton of the driver: it implements the Component Name 2 Protocol and the Driver Binding Protocol, in accordance with the generic and GOP-specific requirements set forth in the UEFI spec and the Driver Writers' Guide. The basic idea is that VGPU_DEV abstracts the virtio GPU

Re: [edk2] [PATCH] BaseTools/GenFv: allow TE/PE images with no .reloc section

On 19 August 2016 at 09:51, Gao, Liming wrote: > Ard: > RelocationsStripped is decided by Pe32.FileHeader.Characteristics > EFI_IMAGE_FILE_RELOCS_STRIPPED flag. Per PE/COFF spec, if > IMAGE_FILE_RELOCS_STRIPPED flag is set, the image must therefore be loaded at > its preferred base address. I

[edk2] Incorrect invocation of SmiManage()?

Hi, The SMM specification (Vol4. PI v1.4) says in the description of the SmiManage() function: " If NULL is passed in HandlerType, then only those registered handler functions which passed NULL as their HandlerType will be called. If NULL is passed in HandlerType, then Context should be NULL, Com

Re: [edk2] [patch] MdeModulePkg:Fix bug in function AsciiStrToIp4.

Cosmetic comment: if (!NET_IS_DIGIT(*Ip4Str)) { ^ Add a space here Reviewed-by: Hegde Nagaraj P -Original Message- From: Zhang Lubo [mailto:lubo.zh...@intel.com] Sent: Friday, August 19, 2016 1:23 PM To: edk2-devel@lists.01.org Cc: Fu Siyuan ;

[edk2] [patch] MdeModulePkg:Fix bug in function AsciiStrToIp4.

If a FQDN contains 3 dots '.' like "a.b.c.com", the AsciiStrToIp4 will return success as the HostName has a valid IP address. So we need to check if it is a decimal character before using AsciiStrDecimalToUintn. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo Cc:

Re: [edk2] [PATCH] BaseTools/GenFv: allow TE/PE images with no .reloc section

Ard: RelocationsStripped is decided by Pe32.FileHeader.Characteristics EFI_IMAGE_FILE_RELOCS_STRIPPED flag. Per PE/COFF spec, if IMAGE_FILE_RELOCS_STRIPPED flag is set, the image must therefore be loaded at its preferred base address. If the image could be loaded at other address, it should n

[edk2] [PATCH 5/6] QuarkSocPkg/QuarkSocPkg.dsc: Declare PciSegmentLib

PiDxeS3BootScriptLib has been updated to consume PciSegmentLib instead of PciLib to support multiple PCI segment. Cc: Jiewen Yao Cc: Michael D Kinney Cc: Chan Amy Cc: Kelly Steele Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- QuarkSocPkg/QuarkSocPkg.dsc

[edk2] [PATCH 6/6] SecurityPkg/SecurityPkg.dsc: Declare PciSegmentLib

PiDxeS3BootScriptLib has been updated to consume PciSegmentLib instead of PciLib to support multiple PCI segment. Cc: Jiewen Yao Cc: Michael D Kinney Cc: Chan Amy Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- SecurityPkg/SecurityPkg.dsc |

[edk2] [PATCH 0/6] PiDxeS3BootScriptLib: Support multiple PCI segment

Support multiple PCI segment for PCI_CONFIG2 opcodes. PiDxeS3BootScriptLib needs to be updated to consume PciSegmentLib instead of PciLib. That means platforms need to add PciSegmentLib declaration like below in platform dsc if the PciSegmentLib was not declared in platform dsc before. PciSegment

[edk2] [PATCH 1/6] MdeModulePkg PiDxeS3BootScriptLib: Remove the trailing white spaces

Cc: Jiewen Yao Cc: Michael D Kinney Cc: Chan Amy Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- .../PiDxeS3BootScriptLib/BootScriptExecute.c | 288 +++--- .../BootScriptInternalFormat.h | 2 +- .../Library/PiDxeS3BootScr

[edk2] [PATCH 2/6] MdeModulePkg PiDxeS3BootScriptLib: Support multiple PCI segment

Support multiple PCI segment for PCI_CONFIG2 opcodes. PiDxeS3BootScriptLib needs to be updated to consume PciSegmentLib instead of PciLib. That means platforms need to add PciSegmentLib declaration like below in platform dsc if the PciSegmentLib was not declared in platform dsc before. PciSegment

[edk2] [PATCH 4/6] QuarkPlatformPkg: Declare PciSegmentLib in platform dsc

PiDxeS3BootScriptLib has been updated to consume PciSegmentLib instead of PciLib to support multiple PCI segment. That means platforms need to add PciSegmentLib declaration in platform dsc if the PciSegmentLib was not declared in platform dsc before. For platforms only have one segment, MdePkg/Lib

[edk2] [PATCH 3/6] Vlv2TbltDevicePkg: Declare PciSegmentLib in platform dsc

PiDxeS3BootScriptLib has been updated to consume PciSegmentLib instead of PciLib to support multiple PCI segment. That means platforms need to add PciSegmentLib declaration in platform dsc if the PciSegmentLib was not declared in platform dsc before. For platforms only have one segment, MdePkg/Lib

[edk2] [PATCH v3 2/2] ArmVirtPkg: Add Ramdisk support to ArmVirtPkg platforms

Adds the RAMDisk support to ArmVirtPkg platforms. This patch actually ports OvmfPkg commit 259d87146b07 to ArmVirtPkg. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Vikas C Sajjan --- ArmVirtPkg/ArmVirt.dsc.inc | 11 +++ ArmVirtPkg/ArmVirtQemuFvMain.fdf

[edk2] [PATCH v3 1/2] ArmVirtPkg: Move inclusion of AcpiTableDxe.inf to ArmVirt.dsc.inc

Since ArmVirt.dsc.inc is included in all the ArmVirt dsc files, move inclusion of AcpiTableDxe.inf to ArmVirt.dsc.inc. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Vikas C Sajjan --- ArmVirtPkg/ArmVirt.dsc.inc | 6 ++ ArmVirtPkg/ArmVirtQemu.dsc | 1 - Ar

[edk2] [PATCH v3 0/2] Add Ramdisk support to ArmVirtPkg platforms

This series adds ramdisk driver support to ArmVirtPkg platforms. It actually ports OvmfPkg commit 259d87146b07 to ArmVirtPkg. changes since v2: - Made changes as suggested by Laszlo Ersek a] Moved inclusion of AcpiTableDxe.inf to end of file b] Moved gEfiMdeModulePkgTokenSpaceG