Re: [edk2] [Patch 0/6] Fixed bugs in MpInitLib

2016-08-24 Thread Tian, Feng
Looks good to me Reviewed-by: Feng Tian Thanks Feng -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff Fan Sent: Wednesday, August 24, 2016 10:45 PM To: edk2-devel@lists.01.org Subject: [edk2] [Patch 0/6] Fixed bugs in

Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

2016-08-24 Thread Zhang, Lubo
Hi Naveen I update the SVN and now the revision is 22467. The HttpBootDxe revision is 22104,patch is - Fix IPv6 HTTPClient vendor class data The HttpDxe revision is 21740, patch is - NetworkPkg: Fix typos in comments. But I suggest you to download the

Re: [edk2] I found a fun bug in the Shell today. Looks like we have been getting lucky?

2016-08-24 Thread Andrew Fish
> On Aug 24, 2016, at 5:59 PM, Andrew Fish wrote: > > I was tracking down a data corruption issue when paging was enabled on an > edk2 shell command. The crash was in a custom ConSpliter over writing a DXE > Core data structure. The buffer overflow seemed to be caused by the

[edk2] I found a fun bug in the Shell today. Looks like we have been getting lucky?

2016-08-24 Thread Andrew Fish
I was tracking down a data corruption issue when paging was enabled on an edk2 shell command. The crash was in a custom ConSpliter over writing a DXE Core data structure. The buffer overflow seemed to be caused by the Console getting confused on the location of the end of the screen. I set a

Re: [edk2] [PATCH 2/5] ArmVirtPkg: implement FdtPciHostBridgeLib

2016-08-24 Thread Ard Biesheuvel
On 24 August 2016 at 17:01, Laszlo Ersek wrote: > On 08/22/16 02:35, Ard Biesheuvel wrote: >> Implement PciHostBridgeLib for DT platforms that expose a PCI root bridge >> via a pci-host-ecam-generic DT node. The DT parsing logic is copied from >> the PciHostBridgeDxe

Re: [edk2] [PATCH 3/3] Revert "ShellPkg: Move FindFirstCharacter/GetNextParameter to ShellCommandLib"

2016-08-24 Thread Shah, Tapan
Have you already pushed this change? -Original Message- From: Shah, Tapan Sent: Tuesday, August 23, 2016 8:45 AM To: 'Ruiyu Ni' ; edk2-devel@lists.01.org Cc: Jaben Carsey Subject: RE: [edk2] [PATCH 3/3] Revert "ShellPkg: Move

Re: [edk2] [PATCH 2/5] ArmVirtPkg: implement FdtPciHostBridgeLib

2016-08-24 Thread Laszlo Ersek
On 08/22/16 02:35, Ard Biesheuvel wrote: > Implement PciHostBridgeLib for DT platforms that expose a PCI root bridge > via a pci-host-ecam-generic DT node. The DT parsing logic is copied from > the PciHostBridgeDxe implementation in ArmVirtPkg, with the one notable > difference that we don't set

[edk2] [Patch 1/6] UefiCpuPkg/MpInitLib: Move timeout delay to WakupAp()

2016-08-24 Thread Jeff Fan
After sending the 1st broadcast INIT-SIPI-SIPI, BSP will collect APs count after one specified timeout delay. However, WakupAp() will restore reset vector immediately after sending 1st broadcast INIT-SIPI-SIPI. Some processors may not complete executing reset vector code. This fix is to move

[edk2] [Patch 3/6] UefiCpuPkg/MpInitLib: Rename EndOfPeiFlag to SaveRestoreFlag

2016-08-24 Thread Jeff Fan
It will be used by DxePeiLib also. Cc: Michael Kinney Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- UefiCpuPkg/Library/MpInitLib/MpLib.c| 2 +-

[edk2] [Patch 2/6] UefiCpuPkg/MpInitLib: Move allocating reserved memory for AP loop code

2016-08-24 Thread Jeff Fan
In Exit Boot Services callback function, we cannot use allocate memory services because it may change the memory map that has been gotten by OS. This fix is to move allocating reserved memory for AP loop code to InitMpGlobalData() and save the memory address in one global variable. Cc: Michael

[edk2] [Patch 5/6] UefiCpuPkg/MpInitLib: Move two functions location

2016-08-24 Thread Jeff Fan
Just move BackupAndPrepareWakeupBuffer() and RestoreWakeupBuffer() from PeiMpLib.c to MpLib.c. Cc: Michael Kinney Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan ---

[edk2] [Patch 6/6] UefiCpuPkg/MpInitLib: Don't allocate reset vector in Exit Boot Service

2016-08-24 Thread Jeff Fan
In Exit Boot Services callback function, we cannot use allocate memory services because it may change the memory map that has been gotten by OS. This fix is not to allocate reset vector buffer after SaveRestoreFlag is set to TRUE in MpInitExitBootServicesCallback(). Instead AllocateResetVector()

[edk2] [Patch 4/6] UefiCpuPkg/MpInitLib: Fix function header comments typo

2016-08-24 Thread Jeff Fan
Cc: Michael Kinney Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 2 +- UefiCpuPkg/Library/MpInitLib/Microcode.c | 2 +-

[edk2] [Patch 0/6] Fixed bugs in MpInitLib

2016-08-24 Thread Jeff Fan
Jeff Fan (6): UefiCpuPkg/MpInitLib: Move timeout delay to WakupAp() UefiCpuPkg/MpInitLib: Move allocating reserved memory for AP loop code UefiCpuPkg/MpInitLib: Rename EndOfPeiFlag to SaveRestoreFlag UefiCpuPkg/MpInitLib: Fix function header comments typo UefiCpuPkg/MpInitLib: Move two

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

2016-08-24 Thread Zeng, Star
[Snipped] I am not so clear about "the pristine "OVMF_VARS.fd" varstore template that falls right out of the OVMF build". Variable driver depends on PcdFlashNvStorageVariableBase(64) be set correctly to produce gEfiVariableArchProtocolGuid protocol. After PiSmmCpuDxeSmm adds

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

2016-08-24 Thread Laszlo Ersek
On 08/24/16 01:22, Zeng, Star wrote: > On 2016/8/24 11:27, Laszlo Ersek wrote: >> On 08/23/16 22:39, Zeng, Star wrote: >>> On 2016/8/23 23:33, Laszlo Ersek wrote: On 08/18/16 22:57, Zeng, Star wrote: > On 2016/8/19 10:45, Zeng, Star wrote: >> On 2016/8/19 10:26, Laszlo Ersek wrote:

Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

2016-08-24 Thread Santhapur Naveen
Hi Lubo, Can you please provide me any reference revision number to download and check the same? Thank you, Naveen -Original Message- From: Zhang, Lubo [mailto:lubo.zh...@intel.com] Sent: Wednesday, August 24, 2016 4:23 PM To: Santhapur Naveen Cc: edk2-devel@lists.01.org

Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

2016-08-24 Thread Zhang, Lubo
Hi Naveen I have checked the issue you mentioned. On my side, I updated the code to latest and do some test on NT32 and Denlow platform, both the first http boot and 2nd are successful. Until now , we have fixed few bugs which may lead the 2nd http boot fail. As for the patch you

[edk2] [EDK2] DxeCapsuleLib returns Status Issue

2016-08-24 Thread Ankit_Singh3
Dell - Internal Use - Confidential Hi EDK2 Developers, We are incorporating DxeCapsuleLib for FMP Capsule Update into our UEFI product, but we are hitting few issues as described below. In case of Capsule Update "SetImage" is randomly done for all the FMP Handles in case Image Type Id GUID and

Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

2016-08-24 Thread Zhang, Lubo
Thanks Naveen. I will check it first and any progress I will inform you. Best Regards Lubo -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Santhapur Naveen Sent: Wednesday, August 24, 2016 4:53 PM To: Zhang, Lubo Cc:

Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

2016-08-24 Thread Santhapur Naveen
Hi Lubo, Please find the following details that may help. NetworkPkg:Fix a bug the 2nd httpboot fail issue. Httpboot over Ipv4 or Ipv6 stack,for both Identity and chunked transfer mode,when the last data has been parsed by HttpLib, the HttpInstance->NextMsg pointer should point a

Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

2016-08-24 Thread Zhang, Lubo
Hi Naveen Could you list the patch name or Git SHA value which fixed the 2nd HttpBootfail issue. On my side, the SVN version 24729 is not exist. Thanks Lubo -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Santhapur Naveen Sent:

[edk2] [Patch] Nt32Pkg: Add Eric Dong as Nt32Pkg owner.

2016-08-24 Thread Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong Cc: Ruiyu Ni --- Maintainers.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Maintainers.txt b/Maintainers.txt index d0d5f5c..60c83bc 100644 --- a/Maintainers.txt

[edk2] [Patch] Nt32Pkg PlatformBootManagerLib: Enable BootManagerMenuApp.

2016-08-24 Thread Eric Dong
Enable BootManagerMenuApp application for Nt32 platform. Also enable F7 hotkey to select this boot option. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Eric Dong Cc: Ruiyu Ni --- .../PlatformBootManagerLib/PlatformBootManager.c

Re: [edk2] [Patch v5 48/48] UefiCpuPkg/PiSmmCpuDxeSmm: Add gEfiVariableArchProtocolGuid dependency

2016-08-24 Thread Zeng, Star
On 2016/8/24 13:22, Zeng, Star wrote: On 2016/8/24 11:27, Laszlo Ersek wrote: On 08/23/16 22:39, Zeng, Star wrote: On 2016/8/23 23:33, Laszlo Ersek wrote: On 08/18/16 22:57, Zeng, Star wrote: On 2016/8/19 10:45, Zeng, Star wrote: On 2016/8/19 10:26, Laszlo Ersek wrote: On 08/19/16 04:00,

Re: [edk2] 2nd HttpBoot fails even after upgrading to revision 24729

2016-08-24 Thread Santhapur Naveen
Hello, Revision 24729 of edk2 says 2nd HttpBoot fail issue has been fixed. So, I have taken the changes from the file NetworkPkg/HttpDxe/HttpImpl.c of the revsision 24729 and still the 2nd HttpBoot fails. Please let me know if I have missed any. P.S: The first http boot happens