Re: [edk2] [PATCH 40/45] Vlv2TbltDevicePkg/SystemBiosUpdateConfig: Add capsule config file.

Reviewed-by: David Wei Thanks, David Wei -Original Message- From: Yao, Jiewen Sent: Wednesday, September 21, 2016 2:45 PM To: edk2-devel@lists.01.org Cc: Wei, David ; Tian, Feng ; Zeng, Star ; Kinney, Michael D ; Gao, Liming ; Zhang, Chao B Subject:

Re: [edk2] [PATCH 39/45] Vlv2TbltDevicePkg/SystemBiosDescriptor: Add Descriptor for capsule update.

Reviewed-by: David Wei Thanks, David Wei -Original Message- From: Yao, Jiewen Sent: Wednesday, September 21, 2016 2:45 PM To: edk2-devel@lists.01.org Cc: Wei, David ; Tian, Feng ; Zeng, Star ; Kinney, Michael D ; Gao, Liming ; Zhang, Chao B Subject:

Re: [edk2] [PATCH 38/45] Vlv2TbltDevicePkg/PlatformFlashAccessLib: Add instance for capsule update.

Reviewed-by: David Wei Thanks, David Wei -Original Message- From: Yao, Jiewen Sent: Wednesday, September 21, 2016 2:45 PM To: edk2-devel@lists.01.org Cc: Wei, David ; Tian, Feng ; Zeng, Star ; Kinney, Michael D ; Gao, Liming ; Zhang, Chao B Subject:

[edk2] [PATCH 41/45] Vlv2TbltDevicePkg/FlashDeviceLib: Add DXE flash device lib.

Previous FlashDeviceLib only supports DxeRuntime and Smm. It cannot be linked with SystemBiosUpdateDxe driver. So we separate DxeRuntime related code into a standalone file, and create FlashDeviceLibDxe.inf. Cc: David Wei Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Ch

[edk2] [PATCH 45/45] Vlv2TbltDevicePkg/bat: add capsule generation in bat.

If OPENSSL_PATH is set, the build process generates capsule. Cc: David Wei Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- Vlv2TbltDevicePkg/bld_vlv.bat | 8 +++- 1 file

[edk2] [PATCH 43/45] Vlv2TbltDevicePkg/dsc/fdf: Add capsule/recovery support.

Add capsule and recovery support module in platform dsc and fdf. Cc: David Wei Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- Vlv2TbltDevicePkg/PlatformPkg.fdf | 132

[edk2] [PATCH 44/45] Vlv2TbltDevicePkg/dsc/fdf: add capsule generation DSC/FDF.

Add DSC/FDF to generate capsule image. It is separated from normal DSC/FDF, because the FDF file need use the result of final build. Cc: David Wei Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off

[edk2] [PATCH 42/45] Vlv2TbltDevicePkg/PlatformBootManager: Add capsule/recovery handling.

Add capsule and recovery boot path handling in platform BDS. Cc: David Wei Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatfo

[edk2] [PATCH 34/45] QuarkPlatformPkg/PlatformInit: Remove recovery PPI installation.

The QuarkPlatform will use MdeModulePkg/RecoveryModuleLoadPei for recovery. There is no need to produce recovery PPI in platform module. Cc: Michael D Kinney Cc: Kelly Steele Cc: Feng Tian Cc: Star Zeng Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Sig

[edk2] [PATCH 40/45] Vlv2TbltDevicePkg/SystemBiosUpdateConfig: Add capsule config file.

Add SystemBiosUpdateConfig as capsule configuration file. Cc: David Wei Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- Vlv2TbltDevicePkg/Feature/Capsule/SystemBiosUpdateCo

[edk2] [PATCH 37/45] QuarkPlatformPkg/dsc/fdf: add capsule generation DSC/FDF.

Add DSC/FDF to generate capsule image. It is separated from normal DSC/FDF, because the FDF file need use the result of final build. Cc: Michael D Kinney Cc: Kelly Steele Cc: Feng Tian Cc: Star Zeng Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-

[edk2] [PATCH 35/45] QuarkPlatformPkg/PlatformBootManager: Add capsule/recovery handling.

Add capsule and recovery boot path handling in platform BDS. Cc: Michael D Kinney Cc: Kelly Steele Cc: Feng Tian Cc: Star Zeng Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- QuarkPlatformPkg/Library/PlatformBootManagerLib

[edk2] [PATCH 36/45] QuarkPlatformPkg/dsc/fdf: Add capsule/recovery support.

Add capsule and recovery support module in platform dsc and fdf. Cc: Michael D Kinney Cc: Kelly Steele Cc: Feng Tian Cc: Star Zeng Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- QuarkPlatformPkg/Quark.dsc| 61

[edk2] [PATCH 33/45] QuarkPlatformPkg/SystemBiosUpdateConfig: Add capsule config file.

Add SystemBiosUpdateConfig as capsule configuration file. Cc: Michael D Kinney Cc: Kelly Steele Cc: Feng Tian Cc: Star Zeng Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- QuarkPlatformPkg/Feature/Capsule/SystemBiosUpdate

[edk2] [PATCH 39/45] Vlv2TbltDevicePkg/SystemBiosDescriptor: Add Descriptor for capsule update.

Add SystemBiosDescriptor for capsule update. The PEIM extracts SystemBiosDescriptor info from FFS and reports it via PCD. Cc: David Wei Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen

[edk2] [PATCH 38/45] Vlv2TbltDevicePkg/PlatformFlashAccessLib: Add instance for capsule update.

Add PlatformFlashAccessLib for capsule update. Cc: David Wei Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- Vlv2TbltDevicePkg/Feature/Capsule/Library/PlatformFlashAccessLi

[edk2] [PATCH 32/45] QuarkPlatformPkg/SystemBiosDescriptor: Add Descriptor for capsule update.

Add SystemBiosDescriptor for capsule update. The PEIM extracts SystemBiosDescriptor info from FFS and reports it via PCD. Cc: Michael D Kinney Cc: Kelly Steele Cc: Feng Tian Cc: Star Zeng Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jie

[edk2] [PATCH 30/45] UefiCpuPkg/UefiCpuPkg.dsc: Add MicrocodeCapsule related component.

Add Microcode capsule related component to check build. Cc: Jeff Fan Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- UefiCpuPkg/UefiCpuPkg.dsc | 3 +++ 1 file changed, 3 ins

[edk2] [PATCH 22/45] SecurityPkg/FmpAuthenticationRsa2048Sha256Lib: Add NULL class for FMP.

This is a NULL class for FmpAuthenticationLib. It provides Rsa2048Sha256 based FMP authentication. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- SecurityPkg/Library/FmpAut

[edk2] [PATCH 26/45] UefiCpuPkg/UefiCpuPkg.dec: Add Microcode capsule related definition.

1) Add Microcode capsule related GUID. gMicrocodeFmpImageTypeIdGuid 2) Add Microcode capsule related library. MicrocodeFlashAccessLib Cc: Jeff Fan Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Sign

[edk2] [PATCH 23/45] SecurityPkg/SecurityPkg.dsc: Add FmpAuthentication*Lib.

Add FmpAuthentication*Lib to check build. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- SecurityPkg/SecurityPkg.dsc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/S

[edk2] [PATCH 21/45] SecurityPkg/FmpAuthenticationPkcs7Lib: Add PKCS7 NULL class for FMP.

This is a NULL class for FmpAuthenticationLib. It provides PKCS7 based FMP authentication. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- SecurityPkg/Library/FmpAuthenticati

[edk2] [PATCH 24/45] UefiCpuPkg/Include: Add Microcode FMP definition.

It defined ImageTypeId for Microcode. Cc: Jeff Fan Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- UefiCpuPkg/Include/Guid/MicrocodeFmp.h | 21 1 file c

[edk2] [PATCH 28/45] UefiCpuPkg/MicrocodeFlashAccessLib: Add NULL MicrocodeFlashAccessLib.

Add NULL instance to pass build. Cc: Jeff Fan Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- UefiCpuPkg/Library/MicrocodeFlashAccessLibNull/MicrocodeFlashAccessLibNull.c

[edk2] [PATCH 29/45] UefiCpuPkg/MicrocodeCapsuleApp: Add MicrocodeCapsuleApp application.

This MicrocodeCapsuleApp can help generate Microcode FMP capsule. It can also dump Microcode capsule information. Cc: Jeff Fan Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao ---

[edk2] [PATCH 27/45] UefiCpuPkg/MicrocodeUpdate: Add MicrocodeUpdate component.

MicrocodeUpdate supports update Microcode region via UEFI FMP capsule. MicrocodeUpdate SetImage() will perform the Microcode version, ProcessorSignature/ProcessorFlag, and try to load microcode. If and only if the Microcode is loaded successfully, and new Microcode will be updated to system flash

[edk2] [PATCH 31/45] QuarkPlatformPkg/PlatformFlashAccessLib: Add instance for capsule update.

Add PlatformFlashAccessLib for capsule update. Cc: Michael D Kinney Cc: Kelly Steele Cc: Feng Tian Cc: Star Zeng Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- QuarkPlatformPkg/Feature/Capsule/Library/PlatformFlashAccess

[edk2] [PATCH 19/45] IntelFrameworkModulePkg/DxeCapsuleLib: Add ProcessCapsules() interface.

Add NULL ProcessCapsules() interface for DxeCapsuleLib. IntelFrameworkModulePkg is under maintenance phase. We stop adding new feature there. Just add NULL function to make it pass build. Cc: Jeff Fan Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-

[edk2] [PATCH 09/45] MdeModulePkg/FmpAuthenticationLib: Add FmpAuthenticationLib instance.

This library is used to authenticate a UEFI defined FMP Capsule. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- MdeModulePkg/Library/FmpAuthenitcationLib/FmpAuthenitcationLi

[edk2] [PATCH 20/45] SecurityPkg/SecurityPkg.dec: Add PcdPkcs7CertBuffer PCD.

This PCD is similar to PcdRsa2048Sha256PublicKeyBuffer. It provides trusted cert for PKCS7 verification. It can be used for Recovery and Capsule Update images. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.

[edk2] [PATCH 25/45] UefiCpuPkg/Include: Add MicrocodeFlashAccessLib header.

This library is used to abstract microcode flash region access. This library is consumed by a microcode capsule update module. Cc: Jeff Fan Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ji

[edk2] [PATCH 17/45] MdeModulePkg/CapsuleApp: Add CapsuleApp application.

This CapsuleApp can help perform capsule update in UEFI shell environment. It can also dump capsule information, capsule status variable, ESRT and FMP. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed

[edk2] [PATCH 18/45] MdeModulePkg/MdeModulePkg.dsc: Add capsule related component.

Add capsule related component to check build. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- MdeModulePkg/MdeModulePkg.dsc | 24 1 file changed, 24 inse

[edk2] [PATCH 12/45] MdeModulePkg/EdkiiSystemCapsuleLib: Add EdkiiSystemCapsuleLib instance.

This library is used to abstract the action for EDKII system FMP capsule, such as extracting a component from capsule, or authenticate the capsule. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off

[edk2] [PATCH 07/45] MdeModulePkg/MdeModulePkg.dec: Add capsule related definition.

1) Add capsule related GUID. EdkiiSystemFmpCapsule 2) Add capsule related library. EdkiiSystemCapsuleLib FmpAuthenticationLib IniParsingLib PlatformFlashAccessLib.c 3) Add capsule related status code PCD. PcdStatusCodeSubClassCapsule PcdCapsuleStatusCodeProcessCapsulesBegin

[edk2] [PATCH 14/45] MdeModulePkg/Esrt: Add ESRT_FW_TYPE_SYSTEMFIRMWARE check.

The previous ESRT driver unconditionally treat FMP to be ESRT_FW_TYPE_DEVICEFIRMWARE. EDKII System Capsule reuses FMP, but it is ESRT_FW_TYPE_SYSTEMFIRMWARE. Add check to ImageTypeId check to see if it is ESRT_FW_TYPE_SYSTEMFIRMWARE. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming

[edk2] [PATCH 04/45] MdeModulePkg/Include: Add IniParsingLib header.

This library is used to parse the INI configuration file. The INI configuration file is used in EDKII capsule image to describe the capsule information. The INI file format is: [SectionName] EntryName=EntryValue Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney

[edk2] [PATCH 11/45] MdeModulePkg/DxeCapsuleLibNull: Add ProcessCapsules() interface.

Add ProcessCapsules() interface for DxeCapsuleLibNull. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.c | 47 ++

[edk2] [PATCH 16/45] MdeModulePkg/RecoveryModuleLoadPei: Add RecoveryModuleLoadPei.

RecoveryModuleLoadPei supports recovery system BIOS via UEFI FMP capsule. RecoveryModuleLoadPei produces EFI_PEI_RECOVERY_MODULE_PPI. It is invoked by DxeIpl in recovery boot mode. LoadRecoveryCapsule() will scan all possible gEfiPeiDeviceRecoveryModulePpiGuid and get EDKII system FMP capsule the

[edk2] [PATCH 13/45] MdeModulePkg/PlatformFlashAccessLib: Add NULL PlatformFlashAccessLib.

Add NULL instance to pass build. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- MdeModulePkg/Library/PlatformFlashAccessLibNull/PlatformFlashAccessLibNull.c | 54

[edk2] [PATCH 01/45] MdeModulePkg/Include: Add EDKII system FMP capsule header.

Add EDKII system FMP capsule header file. This describes the EDKII system FMP capsule format. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- MdeModulePkg/Inclu

[edk2] [PATCH 15/45] MdeModulePkg/SystemBiosUpdate: Add SystemBiosUpdate component.

SystemBiosUpdate supports udpate system BIOS via UEFI FMP capsule. SystemBiosReportDxe.inf can be included in system BIOS. It is a lightweight FMP protocol implementation and it only reports FMP information, so that ESRT table can report the system firmware information. It does not support SetImag

[edk2] [PATCH 10/45] MdeModulePkg/DxeCapsuleLibFmp: Add DxeCapsuleLibFmp instance.

This instance handles Microsoft UX capsule, UEFI defined device FMP capsule, and EDKII system FMP capsule. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- MdeModulePkg/Librar

[edk2] [PATCH 08/45] MdeModulePkg/IniParsingLib: Add InitParsingLib instance.

This library is used to parse the INI configuration file. The INI configuration file is used in EDKII capsule image to describe the capsule information. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signe

[edk2] [PATCH 00/45] Add capsule update and recovery sample.

This series patch provides sample on how to do signed capsule update and recovery in EDKII. This series patch is also checked into g...@github.com:jyao1/edk2.git. The feature includes: 1) Define EDKII signed system BIOS capsule format. 2) Provide EDKII signed system BIOS update sample. 3) Provide

[edk2] [PATCH 05/45] MdeModulePkg/Include: Add PlatformFlashAccessLib header.

This library is used to abstract platform flash access. This library is consumed by a capsule update module. It may cover BIOS region and/or non-BIOS region. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0

[edk2] [PATCH 06/45] MdeModulePkg/CapsuleLib: Add ProcessCapsules() API.

ProcessCapsules() API can be used by platform BDS to process all capsules. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- MdeModulePkg/Include/Library/CapsuleLib.h | 45

[edk2] [PATCH 02/45] MdeModulePkg/Include: Add EdkiiSystemCapsuleLib definition.

This library is used to abstract the action for EDKII system FMP capsule, such as extracting a component from capsule, or authenticate the capsule. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off

[edk2] [PATCH 03/45] MdeModulePkg/Include: Add FmpAuthenticationLib header.

This library is used to authenticate a UEFI defined FMP Capsule. Cc: Feng Tian Cc: Star Zeng Cc: Michael D Kinney Cc: Liming Gao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- MdeModulePkg/Include/Library/FmpAuthenticationLib.h | 91

Re: [edk2] [EDK2][USB IF]Mismatch between EDK2 and a USB vendor

Hi, Katayama We never receive such feedback on inconsecutive usb interface number. I agree EDKII usb driver should be able to handle this. I am working on a fix, but I have no such device at hand. Could you help me verify it when the patch is ready? PS: what host controller are you using? EHC

Re: [edk2] [PATCH] [MdePkg ] New Debug Message Levels

Felix, Thanks for the quick update. Quick question on usage model. Do you expect to be able to mix an I/O subsystem bit with ERROR, WARN, INFO, or VERBOSE bits? Unfortunately, I do not think the current definition and implementation of the DebugLib instances support this type mixing with a res

Re: [edk2] [PATCH 6/6] SecuriryPkg/TPM2: Extract GetSupportedAndActivePcrs to Tpm2CommandLib

Serial reviewed by: Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: Zeng, Star Sent: Tuesday, September 20, 2016 6:52 PM To: edk2-devel@lists.01.org Cc: Yao, Jiewen; Zhang, Chao B; Zeng, Star Subject: [PATCH 6/6] SecuriryPkg/TPM2: Extract GetSupportedAndActivePcr

Re: [edk2] [Patch 2/3] MdeModulePkg HiiDatabaseDxe: Ignore new EFI_HII_IIBT_IMAGE_PNG type Image

Reviewed-by: Dandan Bi -Original Message- From: Gao, Liming Sent: Wednesday, September 21, 2016 10:39 AM To: edk2-devel@lists.01.org Cc: Dong, Eric ; Bi, Dandan Subject: [Patch 2/3] MdeModulePkg HiiDatabaseDxe: Ignore new EFI_HII_IIBT_IMAGE_PNG type Image HiiImage protocol implementat

Re: [edk2] [Patch 1/3] MdePkg UefiHii: Add IMAGE_TOKEN macro to access image resource in C and VFR

Reviewed-by: Dandan Bi -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Wednesday, September 21, 2016 10:39 AM To: edk2-devel@lists.01.org Cc: Bi, Dandan ; Dong, Eric Subject: [edk2] [Patch 1/3] MdePkg UefiHii: Add IMAGE_TOKEN ma

Re: [edk2] Protocol EFI_FORM_BROWSER_EXTENSION_PROTOCOL - included in UDK code but not part of the spec

Boaz: This protocol is edk2 implement protocol. We have no plan to propose it to UEFI spec. Its EFI_ prefix is history reason. To avoid the incompatible change, we don't change its definition. But for any new introduced protocol, we will insist on this rule without EFI_ prefix. Thanks Liming

Re: [edk2] [Patch 2/3] MdeModulePkg HiiDatabaseDxe: Ignore new EFI_HII_IIBT_IMAGE_PNG type Image

Reviewed-by: Eric Dong > -Original Message- > From: Gao, Liming > Sent: Wednesday, September 21, 2016 10:39 AM > To: edk2-devel@lists.01.org > Cc: Dong, Eric; Bi, Dandan > Subject: [Patch 2/3] MdeModulePkg HiiDatabaseDxe: Ignore new > EFI_HII_IIBT_IMAGE_PNG type Image > > HiiImage proto

Re: [edk2] [Patch 1/3] MdePkg UefiHii: Add IMAGE_TOKEN macro to access image resource in C and VFR

Reviewed-by: Eric Dong > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming > Gao > Sent: Wednesday, September 21, 2016 10:39 AM > To: edk2-devel@lists.01.org > Cc: Bi, Dandan; Dong, Eric > Subject: [edk2] [Patch 1/3] MdePkg UefiHii: Add IM

Re: [edk2] [Patch 0/4] Add support for running python tools from source on Windows

Reviewed the series of 4 patches. Reviewed-by: Yonghong Zhu Best Regards, Zhu Yonghong -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming Gao Sent: Tuesday, September 13, 2016 12:03 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch 0/4

[edk2] [Patch 0/3] BaseTools: Add build support to generate HII image package

HII image package is defined in UEFI spec. But, EDK2 BaseTools doesn't support its generation. To fill this gap, new image description file (*.idf) is introduced to describe HII image resource. *.idf file syntax has been proposed into edk2 community. This patch updates BaseTools base on it to ge

[edk2] [Patch 3/3] BaseTools: support generating image package from BMP/JPEG/PNG files

From: Yonghong Zhu BaseTools add support to generating image package from BMP/JPEG/PNG files. 1) New file type *.idf Image definition file to describe HII image resource. It is the ASCII text file, and includes one or more "#image IMAGE_ID [TRANSPARENT] ImageFileName". 2) New IMAGE_TOKEN macro is

[edk2] [Patch 2/3] MdeModulePkg HiiDatabaseDxe: Ignore new EFI_HII_IIBT_IMAGE_PNG type Image

HiiImage protocol implementation doesn't support EFI_HII_IIBT_IMAGE_PNG. Cc: Eric Dong Cc: Dandan Bi Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- MdeModulePkg/Universal/HiiDatabaseDxe/Image.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) d

[edk2] [Patch 1/3] MdePkg UefiHii: Add IMAGE_TOKEN macro to access image resource in C and VFR

Cc: Eric Dong Cc: Dandan Bi Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- MdePkg/Include/Uefi/UefiInternalFormRepresentation.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/MdePkg/Include/Uefi/UefiInternalFormRepresentation.h

Re: [edk2] [Patch] CryptoPkg: Clean up unreferenced symbol in Cryptest utility.

Reviewed-by: Ye Ting -Original Message- From: Long, Qin Sent: Wednesday, September 21, 2016 10:22 AM To: Ye, Ting ; edk2-devel@lists.01.org Subject: [Patch] CryptoPkg: Clean up unreferenced symbol in Cryptest utility. Remove "TSCounterSignature" from TSVerify.c, which is not being used

[edk2] [Patch] CryptoPkg: Clean up unreferenced symbol in Cryptest utility.

Remove "TSCounterSignature" from TSVerify.c, which is not being used by anyone. Cc: Ting Ye Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Qin Long --- CryptoPkg/Application/Cryptest/TSVerify.c | 137 -- 1 file changed, 137 deletions(-) diff

Re: [edk2] [PATCH v2 2/3] MdePkg/BaseMemoryLib*: add missing ASSERT()s

Ard: Thanks! Other two patches are good. Reviewed-by: Liming Gao Thanks Liming From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Tuesday, September 20, 2016 8:41 PM To: Wu, Hao A Cc: edk2-devel@lists.01.org; Gao, Liming ; vish...@qti.qualcomm.com;

Re: [edk2] [PATCH] [MdePkg ] New Debug Message Levels

Reviewed-by: Liming Gao > -Original Message- > From: Felix Poludov [mailto:fel...@ami.com] > Sent: Wednesday, September 21, 2016 3:29 AM > To: Kinney, Michael D ; Gao, Liming > ; edk2-devel@lists.01.org > Subject: RE: [PATCH] [MdePkg ] New Debug Message Levels > > Mike and Liming, > > T

[edk2] [EDK2][USB IF]Mismatch between EDK2 and a USB vendor

Hello, This is relating to my previous post "[edk2] Is this a right place to discuss EDK2's USB IF implementation?" We found a mismatch between EDK2 source code and our USB vendor's implementation. Could you give us your opinions? bInterfaceNumber , 9.6.5 Interface from Universal Serial Bus

Re: [edk2] [Patch 0/3] Fix Quark platform ASSERT() on GCC tip

Jeff, These changes look good to me and I have verified Galileo boots with these changes. Series Reviewed-by: Michael Kinney Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff > Fan > Sent: Tuesday, September 20, 2016 1:29 AM > To:

Re: [edk2] Help Required legacy booting from an EFI

On 09/20/2016 02:38 PM, Saqib Khan wrote: > > Booting using BBS is my option,i was already looking for this and I have > attempted to modify EFIBootManagerMenuApp to work with legacy boot used (). > > I have system with CSM support so essentially i will be doing all my work > on physical system n

Re: [edk2] [PATCH] [MdePkg ] New Debug Message Levels

Mike and Liming, Thanks for reviewing the patch. I implemented all the requested modifications: - EFI_D_ definitions are removed - DEBUG_CSM is removed - Validation expression in MdePkg.dec is updated - MdePkg.uni is updated Here is the updated patch Contributed-under: TianoCore Contribution

Re: [edk2] Help Required legacy booting from an EFI

CC'ing Ray On 09/20/16 20:38, Saqib Khan wrote: > > > On Mon, Sep 19, 2016 at 10:49 PM, Laszlo Ersek > wrote: > > On 09/19/16 17:00, Saqib Khan wrote: > > Hello all, this is my first post to this list and i am very new to edk2 > > development. > > >

Re: [edk2] Help Required legacy booting from an EFI

On Mon, Sep 19, 2016 at 10:49 PM, Laszlo Ersek wrote: > On 09/19/16 17:00, Saqib Khan wrote: > > Hello all, this is my first post to this list and i am very new to edk2 > > development. > > > > I started by building BootManagerMenuApp with following functionality > > > >- Boot from BootManage

Re: [edk2] [PATCH] [MdePkg ] New Debug Message Levels

Felix, We should only add the DEBUG_ defines for new bit values. We would like to retire the use of EFI_D_ defines and encourage use of DEBUG_ defines. The reason is that DEBUG() macros apply to all execution phases and module types. Also, what is the use case for DEBUG_CSM. I would image th

Re: [edk2] Issues with HTTPS Boot

Naveen, I cannot see attachments on this email. What TLS versions and ciphers does your web server support? Depending on when you built the UEFI image, your server may need to have TLS v1.0 enabled and support one of the non-SHA256 ciphers listed at the top of TlsLib.c.

Re: [edk2] [PATCH 0/6] Move/Extract generic duplicated code to Tpm2CommandLib

Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Tuesday, September 20, 2016 6:51 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Zhang, Chao B > ; Yao, Jiewen > Subject: [PATCH 0/6] Move/Extract generic duplicated code to > Tpm2CommandLib > > These p

Re: [edk2] SMM PciExpressLib Instance

Felix: This patch is good to me. Reviewed-by: Liming Gao Thanks Liming From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Felix Poludov Sent: Thursday, September 15, 2016 8:55 PM To: Kinney, Michael D ; edk2-devel@lists.01.org Subject: Re: [edk2] SMM PciExpressLib Instance

Re: [edk2] [PATCH] [MdePkg ] New Debug Message Levels

Felix: I have two comments. 1) Update @Expression 0x8002 | (gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel & 0x7F84AA00) == 0. 0x7F84AA00 should be updated to match the valid debug error level bit mask. 2) PCD help message in MdePkg.uni is also required to be updated. Thanks Liming -

Re: [edk2] [PATCH v2 2/3] MdePkg/BaseMemoryLib*: add missing ASSERT()s

On 20 September 2016 at 13:16, Ard Biesheuvel wrote: > On 20 September 2016 at 13:02, Wu, Hao A wrote: >>> -Original Message- >>> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard >>> Biesheuvel >>> Sent: Tuesday, September 20, 2016 4:38 PM >>> To: Wu, Hao A >>> C

Re: [edk2] [PATCH v2 2/3] MdePkg/BaseMemoryLib*: add missing ASSERT()s

On 20 September 2016 at 13:02, Wu, Hao A wrote: >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard >> Biesheuvel >> Sent: Tuesday, September 20, 2016 4:38 PM >> To: Wu, Hao A >> Cc: leif.lindh...@linaro.org; edk2-devel@lists.01.org; >> vish.

Re: [edk2] [PATCH v2 2/3] MdePkg/BaseMemoryLib*: add missing ASSERT()s

> -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard > Biesheuvel > Sent: Tuesday, September 20, 2016 4:38 PM > To: Wu, Hao A > Cc: leif.lindh...@linaro.org; edk2-devel@lists.01.org; > vish...@qti.qualcomm.com; Gao, Liming > Subject: Re: [edk2] [

[edk2] Issues with HTTPS Boot

Hello All, Since the HTTPS Boot came into picture, I was very enthusiastic to try it. I configured the server as-is explained in the white paper https://github.com/tianocore/tianocore.github.io/wiki/EDK%20II%20White%20papers But when I try to go for an HTTPS boot, it stops a

[edk2] UEFI BitlockerUnlock failed with DHCPv4 only case.

Hello All, I have been facing a problem i.e., Network Unlock is failing when tried with DHCP4 only by disabling TCP/IPv6. My server configuration is as below: 1.WDS Server details I.P: 10.10.10.11 Net Mask: 255.255.255.0 2.DHCP Server details IP: 10.10.10.2 Scope: 10.10.10.1

Re: [edk2] [PATCH 0/6] Move/Extract generic duplicated code to Tpm2CommandLib

There is typo in the title of patches, SecuriryPkg should be SecurityPkg and I have correct it at local, you may skip it when reviewing patches. Thanks, Star -Original Message- From: Zeng, Star Sent: Tuesday, September 20, 2016 6:51 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Zhang,

[edk2] [PATCH] SecurityPkg/TPM2: Sync PcrAllocations and PcrMask

From: Jiewen Yao Current TCG2 implementation will set Tpm2HashMask PCD value according to TPM2 PCR bank. However, there might be misconfiguration in BIOS build phase. The enhanced logic makes sure that the current PCR allocations, the TPM supported PCRs, and the PcdTpm2HashMask are all in agreeme

[edk2] [PATCH 6/6] SecuriryPkg/TPM2: Extract GetSupportedAndActivePcrs to Tpm2CommandLib

From: Jiewen Yao This patch extracts function Tpm2GetCapabilitySupportedAndActivePcrs() from drivers and also update Tcg2ExecutePhysicalPresence() to call Tpm2GetCapabilitySupportedAndActivePcrs() instead of Tcg2Protocol->GetCapability to query the TPM to determine which hashing algorithms are su

[edk2] [PATCH 5/6] SecuriryPkg/TPM2: Move CopyDigestListToBuffer() to Tpm2CommandLib

From: Jiewen Yao This patch just moves function CopyDigestListToBuffer() from drivers to library with HashAlgorithmMask parameter added to make the interface more applicable. The related function IsHashAlgSupportedInHashAlgorithmMask() is also moved from drivers to library as internal function.

[edk2] [PATCH 2/6] SecuriryPkg/TPM2: Move GetDigestFromDigestList() to Tpm2CommandLib

From: Jiewen Yao This patch just moves function Tpm2GetDigestFromDigestList() from drivers to library as GetDigestFromDigestList() and no functionality change. Cc: Chao B Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao Signed-off-by: Star Zeng --- Secu

[edk2] [PATCH 3/6] SecuriryPkg/TPM2: Update function header of GetDigestFromDigestList()

Update the return status description and use OUT identifier instead of IN for Digest parameter, no functionality change. Cc: Chao B Zhang Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- SecurityPkg/Include/Library/Tpm2CommandLib.h | 12 +

[edk2] [PATCH 4/6] SecuriryPkg/TPM2: Move GetDigestListSize() to Tpm2CommandLib

From: Jiewen Yao This patch just moves function GetDigestListSize() from drivers to library and no functionality change. Cc: Chao B Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao Signed-off-by: Star Zeng --- SecurityPkg/Include/Library/Tpm2CommandLib.

[edk2] [PATCH 1/6] SecuriryPkg/TPM2: Move Tpm2PcrAllocateBanks() to Tpm2CommandLib

From: Jiewen Yao This patch just moves function Tpm2CommandAllocPcr() from DxeTcg2PhysicalPresenceLib.c to Tpm2CommandLib as Tpm2PcrAllocateBanks() and no functionality change. Cc: Chao B Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao Signed-off-by: Sta

[edk2] [PATCH 0/6] Move/Extract generic duplicated code to Tpm2CommandLib

These patches move/extract Tpm2PcrAllocateBanks(), Tpm2GetCapabilitySupportedAndActivePcrs(), CopyDigestListToBuffer(), GetDigestListSize() and GetDigestFromDigestList() to Tpm2CommandLib. Cc: Chao B Zhang Cc: Jiewen Yao Jiewen Yao (5): SecuriryPkg/TPM2: Move Tpm2PcrAllocateBanks() to Tpm2Com

Re: [edk2] [PATCH v2 2/3] MdePkg/BaseMemoryLib*: add missing ASSERT()s

On 20 September 2016 at 03:00, Wu, Hao A wrote: > Hi Ard, > > The NULL checks for the input Guids in APIs CopyGuid(), CompareGuid() and > IsZeroGuid() are implicitly done within calls to BaseLib APIs > ReadUnaligned64() and WriteUnaligned64(). > > So I think the functions behavior matches with the

[edk2] [Patch 2/3] UefiCpuPkg/SecCore: Fix comment typo

Revert SecPlatformInformation2 and SecPlatformInformation in two comment blocks. And correct the words. Cc: Michael Kinney Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jeff Fan --- UefiCpuPkg/SecCore/SecBist.c | 12 ++-- 1 file changed, 6 inserti

[edk2] [Patch 3/3] UefiCpuPkg/SecCore: SecPlatformInformation(2) are optional PPIs

Currently, this is ASSERT() if neither SecPlatformInformation2 nor SecPlatformInformation PPIs are found. This is not correct. Per PI specification both of them are optional PPI. Platform may not install them. Cc: Michael Kinney Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1

[edk2] [Patch 1/3] QuarkPlatformPkg/PlatformSecLib: Fix stack pointer issue in Flat32.S

ESP should be set to top of eSRAM range that aligns with Flat32.asm. Because CPU BIST data will be located at top of STACK, this issue leads Platform Sec Lib cannot get the correct CPU BIST information. This fix is to address below issue: https://tianocore.acgmultimedia.com/show_bug.cgi?id=123

[edk2] [Patch 0/3] Fix Quark platform ASSERT() on GCC tip

Flat32.S should set ESP to top of eSRAM range that aligns with Flat32.asm. It cause ASSERT() reported at https://tianocore.acgmultimedia.com/show_bug.cgi?id=123 Jeff Fan (3): QuarkPlatformPkg/PlatformSecLib: Fix stack pointer issue in Flat32.S UefiCpuPkg/SecCore: Fix comment typo UefiCpuPkg

Re: [edk2] edk2 compile error

Hi All, Thank you. I installed nasm-2.12.02 and it workd. We will upgrade to RHEL-7 soon. Thanks Fan Chen -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Monday, September 19, 2016 7:00 PM To: Chen, Farrah ; 'edk2-de...@ml01.01.org' Cc: 'xen-de...@lists.xen.org