Re: [edk2] [PATCH 3/3] MdeModulePkg/TerminalDxe: Handle more keys with TtyTerm

2016-10-14 Thread Roy Franz (HPE)
On Fri, Oct 7, 2016 at 7:54 AM, Brian J. Johnson wrote: > The TtyTerm terminal driver is missing support for sequences produced > by the page up, page down, insert, home, and end keys in some terimnal > emulators. Add them. > > Tested under Ubuntu 16.04 using xterm 322-1ubuntu1, GNOME terminal >

Re: [edk2] [PATCH 0/3] MdeModulePkg/TerminalDxe: TtyTerm improvements

2016-10-14 Thread Laszlo Ersek
On 10/14/16 21:39, Brian J. Johnson wrote: > On 10/12/2016 03:17 AM, Ryan Harkin wrote: >> On 7 October 2016 at 16:59, Leif Lindholm >> wrote: >>> Roy can now be found at Roy Franz (cc:d). >>> >>> On Fri, Oct 07, 2016 at 05:56:26PM +0200, Laszlo Ersek wrote: Roy, Ryan, On 10/07/16

Re: [edk2] [PATCH 4/5] EmbeddedPkg/FdtPlatformDxe: Reference Shell protocols in MdePkg

2016-10-14 Thread Leif Lindholm
Reviewed-by: Leif Lindholm On Fri, Oct 14, 2016 at 05:44:30PM +0800, Ruiyu Ni wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni > Cc: Leif Lindholm > Cc: Ard Biesheuvel > --- > EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatform.h | 4 ++-- > 1 file changed

Re: [edk2] [PATCH 3/5] ArmPkg/LinuxLoader: Reference Shell protocols in MdePkg

2016-10-14 Thread Leif Lindholm
Much as I would like to kill off the LinuxLoader, I can't just yet, and like Tim I approve of the core change. Reviewed-by: Leif Lindholm On Fri, Oct 14, 2016 at 05:44:29PM +0800, Ruiyu Ni wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni > Cc: Leif Lind

Re: [edk2] [PATCH 0/3] MdeModulePkg/TerminalDxe: TtyTerm improvements

2016-10-14 Thread Brian J. Johnson
On 10/12/2016 03:17 AM, Ryan Harkin wrote: On 7 October 2016 at 16:59, Leif Lindholm wrote: Roy can now be found at Roy Franz (cc:d). On Fri, Oct 07, 2016 at 05:56:26PM +0200, Laszlo Ersek wrote: Roy, Ryan, On 10/07/16 16:53, Brian J. Johnson wrote: This patch series implements some improv

Re: [edk2] [PATCH 1/5] ShellPkg: Move SHELL_FREE_NON_NULL from ShellBase.h to ShellLib.h

2016-10-14 Thread Tim Lewis
Glad to see this is finally being done! -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni Sent: Friday, October 14, 2016 2:44 AM To: edk2-devel@lists.01.org Cc: Jaben Carsey ; Michael D Kinney ; Jiewen Yao Subject: [edk2] [PATCH 1/5] Shell

Re: [edk2] [PATCH 0/5] Move Shell protocol definitions to MdePkg

2016-10-14 Thread Tim Lewis
I prefer the renamed .h file, even though I have substantial investment in the current infrastructure. Why? Because engineers don't have time to remember "how does protocol X translate to header file Y" It should be a consistent rule. How many times have I needed to grep the header file name ju

Re: [edk2] [RFC V2] EDK2 Platform Proposal

2016-10-14 Thread Kinney, Michael D
Leif, That makes sense to me. I will update the Readme.md to cover The edk2-platforms/master branch. If a platform does not want to be maintained on master any longer, it could be moved to a stable-* branch against the most recent UDK20xx branch of edk2. Once a platform is no longer used or m

Re: [edk2] [PATCH 1/1] MdePkg/IoLib: Add support for big-endian MMIO

2016-10-14 Thread Laszlo Ersek
On 10/14/16 15:17, Bhupesh Sharma wrote: > Hi Laszlo, > >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Friday, October 14, 2016 5:37 PM >> >> On 10/14/16 11:33, Bhupesh Sharma wrote: >>> Various IPs on NXP/FSL SoCs having ARM64 cores have big-endian MMIO >>> interfaces. >>> >>> This imp

Re: [edk2] [PATCH 1/1] MdePkg/IoLib: Add support for big-endian MMIO

2016-10-14 Thread Bhupesh Sharma
Hi Laszlo, > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Friday, October 14, 2016 5:37 PM > > On 10/14/16 11:33, Bhupesh Sharma wrote: > > Various IPs on NXP/FSL SoCs having ARM64 cores have big-endian MMIO > > interfaces. > > > > This implies that a byte-swap operation is needed to rea

Re: [edk2] [PATCH 0/5] Move Shell protocol definitions to MdePkg

2016-10-14 Thread Yao, Jiewen
Or if you really think we should give a better name. My recommendation is: 1) We add content in MdePkg. 2) We can keep the old protocol file in ShellPkg, but let .h in shellPkg include the .h in MdePkg. Then we can avoid duplicated code and make it a compatible solution to avoid oth

Re: [edk2] [Patch] BaseTools: Update sign tool to make MonotonicCount *after* Payload

2016-10-14 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com Tested-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Friday, October 14, 2016 8:57 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Gao, Liming > > Subjec

Re: [edk2] [PATCH 0/5] Move Shell protocol definitions to MdePkg

2016-10-14 Thread Yao, Jiewen
Hi I think the requests is just to *move*. There is no request to *rename*. Can we just move to avoid other update? > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Friday, October 14, 2016 5:44 PM > To: edk2-devel@lists.01

Re: [edk2] [RFC V2] EDK2 Platform Proposal

2016-10-14 Thread Leif Lindholm
So, I don't actually disagree with what you're saying, but I think we already know that we are looking for different things out of this repository :) This is not a problem, but I do want us to be able to agree on a wording that works for both of our use-cases. I currently have no interest in the

[edk2] [Patch] BaseTools: Update sign tool to make MonotonicCount *after* Payload

2016-10-14 Thread Yonghong Zhu
The WIN_CERTIFICATE_UEFI_GUID AuthInfo defined in the UEFI spec mentioned that It is a signature across the image data and the Monotonic Count value. After clarification, we do the signature calculation, we put MonotonicCount after Payload. Cc: Liming Gao Cc: Jiewen Yao Contributed-under: TianoC

Re: [edk2] SmmCommunicationCommunicate question?

2016-10-14 Thread Laszlo Ersek
On 10/14/16 01:52, Ken Taylor wrote: > I think there are a couple of assumptions here that should be > reconsidered... > > First, it is not always the case that entry into SMM on one CPU will > always pull all CPUs into SMM. There are methods to deliver targeted > SMIs via the local APIC on some

Re: [edk2] [PATCH v2] MdeModulePkg/BootMaintenanceUi: Enhance the codes logic

2016-10-14 Thread Laszlo Ersek
On 10/14/16 08:43, Dandan Bi wrote: > This patch is mainly to: > 1. Enhance the error handling codes when set variable fail. > 2. Enhance the logic to fix some incorrect UI behaviors. My apologies, but both the subject line and the commit message are mostly impenetrable. This patch should be spli

Re: [edk2] [Patch] MdePkg BaseSynchronizationLib: Update InterlockedCompareExchange64.nasm

2016-10-14 Thread Laszlo Ersek
On 10/14/16 08:47, Liming Gao wrote: > Remove extra qword in nasm code to make it pass build. > This file is only built in INTEL ICC compiler. So, there is missing > build check for it. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Liming Gao > --- > .../BaseSynchr

Re: [edk2] [Patch] MdeModulePkg FileExplorerLib: Fix potential Integer Overflow.

2016-10-14 Thread Laszlo Ersek
On 10/14/16 08:49, Liming Gao wrote: > In function 'LibAppendFileName' of 'FileExplorer.c': > " > MaxLen = (Size1 + Size2 + sizeof (CHAR16))/ sizeof (CHAR16); > " > Overflow may happen here. MaxLen might become a very small number. > This patch adds integer overflow checker. > > Contributed-under:

Re: [edk2] [patch] NetworkPkg: Enhance the code in DNS driver.

2016-10-14 Thread Laszlo Ersek
On 10/14/16 08:54, Zhang Lubo wrote: > There may be an error happens when we use the > configure function to set or change the configuration > data for the DNS6 instance, So we will free the > DnsServerList without configured to NULL. If we reset > the instance with the parameter DnsConfigData to N

Re: [edk2] [PATCH 1/1] MdePkg/IoLib: Add support for big-endian MMIO

2016-10-14 Thread Laszlo Ersek
On 10/14/16 11:33, Bhupesh Sharma wrote: > Various IPs on NXP/FSL SoCs having ARM64 cores have big-endian > MMIO interfaces. > > This implies that a byte-swap operation is needed to read/write > such BE MMIO registers from the LE ARM64 cores. > > This patch adds the support for the same. > > Con

[edk2] [RESEND PATCH 1/1] ArmPlatformPkg/ArmTrustZone: Add support for specifying Subregions to be disabled

2016-10-14 Thread Bhupesh Sharma
ARM TZASC-380 IP provides a mechanism to split memory regions being protected via it into eight equal-sized sub-regions, with a bit setting allowing the corresponding subregion to be disabled. Several NXP/FSL SoCs support the TZASC-380 IP block and allow the DDR connected via the TZASC to be parti

Re: [edk2] [PATCH 1/1] ArmPlatformPkg/ArmTrustZone: Add support for specifying Subregions to be disabled

2016-10-14 Thread Bhupesh Sharma
This patch is missing a .h file. Please discard. I will RESEND the patch with the fix. Apologies for the inconvenience. Regards, Bhupesh > -Original Message- > From: Bhupesh Sharma [mailto:bhupesh.sha...@nxp.com] > Sent: Friday, October 14, 2016 4:22 PM > To: edk2-de...@ml01.01.org > Cc

[edk2] [PATCH 1/1] ArmPlatformPkg/ArmTrustZone: Add support for specifying Subregions to be disabled

2016-10-14 Thread Bhupesh Sharma
ARM TZASC-380 IP provides a mechanism to split memory regions being protected via it into eight equal-sized sub-regions, with a bit setting allowing the corresponding subregion to be disabled. Several NXP/FSL SoCs support the TZASC-380 IP block and allow the DDR connected via the TZASC to be parti

[edk2] [PATCH 2/5] MdePkg: Include Shell/ShellDynamicCommand/ShellParameters definitions

2016-10-14 Thread Ruiyu Ni
Copy Shell/ShellDynamicCommand/ShellParameters definitions from ShellPkg to MdePkg. Content of ShellBase.h is moved to Protocol/Shell.h. The following patches will update ShellPkg to reference all protocol definition to MdePkg. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by

[edk2] [PATCH 5/5] ShellPkg: Remove Shell/ShellDynamicCommand/ShellParameter definitions

2016-10-14 Thread Ruiyu Ni
Remove Shell/ShellDynamicCommand/ShellParameter definitions and update all sources to reference the ones in MdePkg. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey --- ShellPkg/Application/Shell/Shell.h |5 +- ShellPkg/Include

[edk2] [PATCH 0/5] Move Shell protocol definitions to MdePkg

2016-10-14 Thread Ruiyu Ni
The patches moves Shell spec defined protocol definitions to MdePkg and updates all references. Content of ShellBase.h is moved to Protocol/Shell.h and ShellBase.h is removed. Ruiyu Ni (5): ShellPkg: Move SHELL_FREE_NON_NULL from ShellBase.h to ShellLib.h MdePkg: Include Shell/ShellDynamicComm

[edk2] [PATCH 1/5] ShellPkg: Move SHELL_FREE_NON_NULL from ShellBase.h to ShellLib.h

2016-10-14 Thread Ruiyu Ni
The more proper place for macro SHELL_FREE_NON_NULL is ShellLib.h instead of ShellBase.h. Modify Compress.c to resolve build failure due to this change. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Jaben Carsey Cc: Jiewen Yao Cc: Michael D Kinney --- Sh

[edk2] [PATCH 3/5] ArmPkg/LinuxLoader: Reference Shell protocols in MdePkg

2016-10-14 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Leif Lindholm Cc: Ard Biesheuvel --- ArmPkg/Application/LinuxLoader/LinuxLoader.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ArmPkg/Application/LinuxLoader/LinuxLoader.h b/ArmPkg/Ap

[edk2] [PATCH 4/5] EmbeddedPkg/FdtPlatformDxe: Reference Shell protocols in MdePkg

2016-10-14 Thread Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Leif Lindholm Cc: Ard Biesheuvel --- EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatform.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatform.h b/E

[edk2] [PATCH 1/1] MdePkg/IoLib: Add support for big-endian MMIO

2016-10-14 Thread Bhupesh Sharma
Various IPs on NXP/FSL SoCs having ARM64 cores have big-endian MMIO interfaces. This implies that a byte-swap operation is needed to read/write such BE MMIO registers from the LE ARM64 cores. This patch adds the support for the same. Contributed-under: TianoCore Contribution Agreement 1.0 Signed

Re: [edk2] AsciiPrint behavior with \n linefeed characters.

2016-10-14 Thread Gao, Liming
Tim: PrintLib only says \n in format string to be converted. It keeps other string as-is. So, this is the expected behavior. Thanks Liming > -Original Message- > From: Tim Lewis [mailto:tim.le...@insyde.com] > Sent: Friday, October 14, 2016 10:05 AM > To: Gao, Liming ; edk2-devel-01 d

Re: [edk2] [Patch] NetworkPkg: Record user configured TargetIP/Port in iBFT

2016-10-14 Thread Zhang, Lubo
Reviewed-by: Zhang Lubo -Original Message- From: Ye, Ting Sent: Thursday, September 29, 2016 1:59 PM To: edk2-devel@lists.01.org Cc: Subramanian; Sriram ; Fu, Siyuan ; Zhang, Lubo Subject: [Patch] NetworkPkg: Record user configured TargetIP/Port in iBFT Current ISCSI driver records re

[edk2] [Patch] MdePkg ACPI51: Update GIC version per ACPI 5.1 Errata B

2016-10-14 Thread Liming Gao
Fix issue: https://bugzilla.tianocore.org/show_bug.cgi?id=95 Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming Gao --- MdePkg/Include/IndustryStandard/Acpi51.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/MdePkg/Include/I

[edk2] [patch] NetworkPkg: Add dns support for pxe boot based on IPv6.

2016-10-14 Thread Zhang Lubo
The BootFileURL option (59) in dhcpv6 is used to deliver the next server address with bootfile name, as an example "tftp://[FEDC:BA98:7654:3210:FEDC:BA98:7654:3210]/BOOTFILE_NAME; mode=octet", it can also be “tftp://domain_name/BOOTFILE_NAME; mode=octet”, this patch is to support this case. Contri

Re: [edk2] [RFC V2] EDK2 Platform Proposal

2016-10-14 Thread Kinney, Michael D
Leif, I could see edk2-platforms/master being the platform branch that contains the set of platforms that are synced with edk2/master and are required to be tested when changes are made to edk2/master. Or at least guaranteed to be tested when a stable release of edk2/master is made. Similar to w

Re: [edk2] [Patch] MdeModulePkg: Support classless IP for DHCPv4 TransmitReceive()

2016-10-14 Thread Santhapur Naveen
Hello Jiaxin, We've run into one more problem with PXE boot. The PXE boot is not happening when the server tries to assign an IP address whose last octet is zero. The below is my configuration: [Server Configuration] Ipv4 address : 192.168.0.1/16 Netmask: 255.255.0.0 DHCPv4 Scope: Ran

Re: [edk2] [RFC V2] EDK2 Platform Proposal

2016-10-14 Thread Kinney, Michael D
Leif and Andrew, I have added the content of this proposal to a new Readme.md file in the edk2-platforms/about branch and removed the old README file. https://github.com/tianocore/edk2-platforms/tree/about I have also added a template at the bottom of the process description for a Readme.md th

Re: [edk2] [[patch]] UefiCpuPkg/Cpuid: Remove wrong while-loop check after for-loop

2016-10-14 Thread Gao, Liming
Reviewed-by: Liming Gao > -Original Message- > From: Fan, Jeff > Sent: Friday, October 14, 2016 3:04 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Kinney, Michael D > ; Tian, Feng > Subject: [[patch]] UefiCpuPkg/Cpuid: Remove wrong while-loop check after > for-loop > > while-loop

[edk2] [Patch] MdeModulePkg FileExplorerLib: Fix potential Integer Overflow.

2016-10-14 Thread Liming Gao
In function 'LibAppendFileName' of 'FileExplorer.c': " MaxLen = (Size1 + Size2 + sizeof (CHAR16))/ sizeof (CHAR16); " Overflow may happen here. MaxLen might become a very small number. This patch adds integer overflow checker. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

[edk2] [[patch]] UefiCpuPkg/Cpuid: Remove wrong while-loop check after for-loop

2016-10-14 Thread Jeff Fan
while-loop check should not co-exist with for-loop. This should be typo when we check-in the original code. We should keep one loop only. This issue caused CLANG38 build failure reported by https://tianocore.acgmultimedia.com/show_bug.cgi?id=148 Contributed-under: TianoCore Contribution Agreement

Re: [edk2] AsciiPrint behavior with \n linefeed characters.

2016-10-14 Thread Joaquin Cono Bolillo
In theory, and in “Standard C”-implementations, the fwrite()—related functions does the conversations in the “internal” FILE* -- buffer (in userland). The translation is done if the so called “stream”, that is • file on disk • terminal • printer • NULL • something else, that is handled by the fo