On 2016-10-26 23:45:48, Wei, David wrote:
> From 5d74ba9b6be85a86cb470b302fe25349d05caa04 Mon Sep 17 00:00:00 2001
> From: david wei
> Date: Thu, 27 Oct 2016 14:42:07 +0800
> Subject: [PATCH] Change maintainer of VLV2 packages.
>
Can you use git send-email to send patches?
For the subject, how a
>From 5d74ba9b6be85a86cb470b302fe25349d05caa04 Mon Sep 17 00:00:00 2001
From: david wei
Date: Thu, 27 Oct 2016 14:42:07 +0800
Subject: [PATCH] Change maintainer of VLV2 packages.
Contributed-under: TianoCore Contribution Agreement 1.0
Cc: Liming Gao
Cc: Justen, Jordan L
Signed-off-by: David Wei
Current code not validate the input buffer before touch.
it may touch the buffer outside the validate scope. This
patch validate the input size big enough to touch the
first node.
Cc: Ruiyu NI
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong
---
.
Current code not validate the input buffer before touch.
it may touch the buffer outside the validate scope. This
patch validate the input size big enough to touch the
first node.
Cc: Ruiyu NI
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong
---
.
Former patch still has some bugs, so rollback it and
enhance the original code.
Cc: Ruiyu NI
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong
---
.../UefiDevicePathLib/DevicePathUtilities.c| 22 ++
1 file changed, 6 ins
Former patch still has some bugs, so rollback it and
enhance the original code.
Cc: Ruiyu NI
Cc: Jiewen Yao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Eric Dong
---
.../UefiDevicePathLib.c| 22 ++
1 file changed, 6 ins
Current code may return error status and touch unsafe
buffer, this patch series fix these issues.
Eric Dong (4):
MdePkg DevicePathLib: Rollback former change.
MdePkg DevicePathLib: Validate before touch input buffer.
MdePkg UefiDevicePathLib: Rollback former change.
MdePkg UefiDevicePathLi
On 2016-10-26 12:04:17, Laszlo Ersek wrote:
> I'm sure most of us have wished at some point that ARRAY_SIZE()
> had existed in a central header file, like it does in many other
> open source projects.
Indeed!
> This series implements that.
>
> Patches 01-04 round up the modules that #define ARRA
I agree with Andrew to only add the missing Ppi/Protocol/Guid used in Library
INF file.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Lin,
> Derek (HPS UEFI Dev)
> Sent: Thursday, October 27, 2016 1:50 PM
> To: af...@apple.com
> Cc: edk2-de
Andrew,
The ModuleGuidDict was not for performance, it's because Arch IA32 X64 have
same library name/FILE_GUID pair, for not duplicate it.
You are right the patch add library FILE_GUID but they are not end up in the
ROM, I'm ok remove it or not.
Feel free to update the patch.
Thanks,
Derek
-
> On Oct 26, 2016, at 9:09 PM, Lin, Derek (HPS UEFI Dev)
> wrote:
>
> Hi Andrew,
>
> We also see this issue recently. And we have a fix. I've send email patch
> minutes ago.
>
Derek,
Thanks for sharing the fix.
I noticed it introduced a build failure for a badly formed library INF file.
Hi Ard,
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Monday, October 17, 2016 7:46 PM
>
> On 17 October 2016 at 14:25, Leif Lindholm
> wrote:
> > On Mon, Oct 17, 2016 at 10:18:01AM +, Bhupesh Sharma wrote:
> >> Hi Ard, Leif,
> >>
> >> Any comments on this patch ?
> >
> >
Hi Leif,
Thanks for the review.
Please see my replies in-line.
> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> Sent: Monday, October 17, 2016 6:55 PM
>
> On Mon, Oct 17, 2016 at 10:18:01AM +, Bhupesh Sharma wrote:
> > Hi Ard, Leif,
> >
> > Any comments on this patch ?
>
> You did
Mike,
You are right, the VS2015x64 IA32 build would fail.
With your fix, the code could pass build.
If there is no objection, I will help to push this fix tomorrow after adding
EDKII commit log with your Sign-off and my Review-by.
Thanks
Feng
-Original Message-
From: Kinney, Michael D
On Wed, Oct 26, 2016 at 09:04:17PM +0200, Laszlo Ersek wrote:
> I'm sure most of us have wished at some point that ARRAY_SIZE()
> had existed in a central header file, like it does in many other
> open source projects. This series implements that.
>
> Patches 01-04 round up the modules that #defin
Hi Andrew,
We also see this issue recently. And we have a fix. I've send email patch
minutes ago.
Thanks,
Derek
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Andrew
Fish
Sent: Thursday, October 27, 2016 9:08 AM
To: edk2-devel
Subject: [edk2] [BaseTools] Library GUIDs
The original Guid.xref lost some Guid which only defined in Library. When the
library is used by a driver, its Guids were not listed in Guid.xref. Now they
will.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Derek Lin
---
BaseTools/Source/Python/GenFds/GenFds.py | 9 ++
Reviewed-by: Liming Gao
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Michael Kinney
> Sent: Thursday, October 27, 2016 5:46 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [edk2] [Patch] MdePkg/Include: Add enumeration size
Reviewed-by: Liming Gao
> -Original Message-
> From: Kinney, Michael D
> Sent: Thursday, October 27, 2016 5:18 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [Patch] MdePkg/PciSegmentLib: Optimize
> PCI_SEGMENT_LIB_ADDRESS()
>
> The PCI_SEGMENT_LIB_ADDRESS() macro puts th
On Wed, Oct 26, 2016 at 09:04:26PM +0200, Laszlo Ersek wrote:
> Rely on the central macro definition from "MdePkg/Include/Base.h" instead.
>
Reviewed-by: Gary Lin
> Cc: Gary Lin
> Cc: Jordan Justen
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Laszlo Ersek
> ---
>
On Wed, Oct 26, 2016 at 09:04:21PM +0200, Laszlo Ersek wrote:
> In one of the next patches, we'll introduce ARRAY_SIZE in
> "MdePkg/Include/Base.h". In order to proceed in small steps, make the
> module-local definition of ARRAY_SIZE conditional. This way the
> introduction of the macro under MdePk
Based on Laszlo Ersek work to add ASSERT_RETURN_ERORR():
https://lists.01.org/pipermail/edk2-devel/2016-October/003132.html
Laszlo also discovered libraries of type BASE that include
UefiBaseType.h that should not include that file:
https://lists.01.org/pipermail/edk2-devel/2016-October/0033
Reviewed-by: Jeff Fan
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Thursday, October 27, 2016 3:05 AM
To: edk2-devel-01
Cc: Fan, Jeff
Subject: [PATCH 16/47] IntelFrameworkModulePkg/BdsDxe: rebase to ARRAY_SIZE()
Cc: Jeff Fan
Contributed-under: TianoCore Contri
Tian Feng,
Unfortunately, this patch that was pushed to edk2/master today
breaks on IA32 VS2015x86 builds with a signed/unsigned mismatch
on 3 lines. I think the right fix might be:
diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConOut.c
b/MdeModulePkg/Universal/Console/Termina
Reviewed-by: Jeff Fan
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Thursday, October 27, 2016 3:05 AM
To: edk2-devel-01
Cc: Fan, Jeff
Subject: [PATCH 15/47] IntelFrameworkModulePkg/LegacyBootManagerLib: rebase to
ARRAY_SIZE()
Cc: Jeff Fan
Contributed-under: T
Guo,
I think it is better to add "EFIAPI" to force the calling convention.
Thanks
Maurice
-Original Message-
From: Dong, Guo
Sent: Wednesday, October 26, 2016 5:35 PM
To: edk2-devel@lists.01.org
Cc: Ma, Maurice; Agyeman, Prince; Dong, Guo
Subject: [edk2] [PATCH] CorebootModulePkgPkg: E
Reviewed-by: Maurice Ma
-Original Message-
From: Dong, Guo
Sent: Wednesday, October 26, 2016 5:45 PM
To: edk2-devel@lists.01.org
Cc: Ma, Maurice; Agyeman, Prince; Dong, Guo
Subject: [edk2] [PATCH] CorebootPayloadPkg: Add "Down" key to Boot Manager Menu
Also add Down key to Boot Manager
Reviewed-by: Maurice Ma
-Original Message-
From: Dong, Guo
Sent: Wednesday, October 26, 2016 5:51 PM
To: edk2-devel@lists.01.org
Cc: Ma, Maurice; Agyeman, Prince; Dong, Guo
Subject: [edk2] [PATCH] CorebootPayloadPkg: Make EFI shell the last boot option.
To let it boot to OS automaticall
Hi Laszlo,
I investigated the QuarkSocPkg ones.
The extra #include of BaseType.h should be removed from:
QuarkSocPkg/QuarkNorthCluster/Library/QNCSmmLib/QNCSmmLib.c
However, it should not be removed from the other one:
QuarkSocPkg/QuarkNorthCluster/Library/ResetSystemLib/ResetSystemLib.c
The Re
Reviewed-By: Wu Jiaxin
Best Regards!
Jiaxin
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, October 27, 2016 3:05 AM
> To: edk2-devel-01
> Cc: Fu, Siyuan ; Wu, Jiaxin
> Subject: [PATCH 34/47] NetworkPkg/TcpDxe: rebase to ARRAY_SIZE()
>
> Cc: Siy
Reviewed-by: Star Zeng to MdeModulePkg changes.
Thanks,
Star
-Original Message-
From: Tian, Feng
Sent: Thursday, October 27, 2016 9:17 AM
To: Laszlo Ersek ; edk2-devel-01
Cc: Ard Biesheuvel ; Cecil Sheng
; Zhang, Chao B ; Bi, Dandan
; Daryl McDaniel ; Wei, David
; Dong, Eric ; Gary L
Reviewed-By: Wu Jiaxin
Best Regards!
Jiaxin
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, October 27, 2016 3:04 AM
> To: edk2-devel-01
> Cc: Wu, Jiaxin ; Fu, Siyuan
> Subject: [PATCH 07/47] NetworkPkg/IpsecConfig: remove module-local
> ARRAY_SIZ
Reviewed-By: Wu Jiaxin
Best Regards!
Jiaxin
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, October 27, 2016 3:04 AM
> To: edk2-devel-01
> Cc: Wu, Jiaxin ; Fu, Siyuan
> Subject: [PATCH 02/47] NetworkPkg/IpsecConfig: guard the definition of
> ARRAY
With that change:
Reviewed-by: Michael Kinney
Mike
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, October 26, 2016 3:26 PM
> To: Kinney, Michael D ; edk2-devel-01 de...@ml01.01.org>
> Cc: Ni, Ruiyu ; Tim He ; Tian, Feng
> ; Dong, Eric ; Cecil Sh
Reviewed-by: Michael Kinney
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, October 26, 2016 12:05 PM
> To: edk2-devel-01
> Cc: Tian, Feng ; Kinney, Michael D
> ;
> Zeng, Star
> Subject: [PATCH 22/47] MdeModulePkg/Core/PiSmmCore: rebase to ARRAY_
Jiewen,
Thanks. That makes sense.
Let's make sure the array is handled correctly in this platform specific
solution and the new tool feature.
Mike
From: Yao, Jiewen
Sent: Wednesday, October 26, 2016 6:48 PM
To: Kinney, Michael D ; edk2-devel@lists.01.org
Cc: Tian, Feng ; Gao, Liming ; Zeng,
Reviewed-by: Fu Siyuan siyuan...@intel.com
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, October 27, 2016 3:05 AM
> To: edk2-devel-01
> Cc: Fu, Siyuan ; Wu, Jiaxin
> Subject: [PATCH 34/47] NetworkPkg/TcpDxe: rebase to ARRAY_SIZE()
>
> Cc: Si
Reviewed-by: Fu Siyuan siyuan...@intel.com
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, October 27, 2016 3:05 AM
> To: edk2-devel-01
> Cc: Wu, Jiaxin ; Fu, Siyuan
> Subject: [PATCH 33/47] NetworkPkg/IScsiDxe: rebase to ARRAY_SIZE()
>
> Cc:
Reviewed-by: Fu Siyuan siyuan...@intel.com
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, October 27, 2016 3:04 AM
> To: edk2-devel-01
> Cc: Wu, Jiaxin ; Fu, Siyuan
> Subject: [PATCH 07/47] NetworkPkg/IpsecConfig: remove module-local
> ARRAY_S
Reviewed-by: Fu Siyuan siyuan...@intel.com
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, October 27, 2016 3:04 AM
> To: edk2-devel-01
> Cc: Wu, Jiaxin ; Fu, Siyuan
> Subject: [PATCH 02/47] NetworkPkg/IpsecConfig: guard the definition of
> ARRAY
Reviewed-by: Ruiyu Ni
Regards,
Ray
>-Original Message-
>From: Laszlo Ersek [mailto:ler...@redhat.com]
>Sent: Thursday, October 27, 2016 3:05 AM
>To: edk2-devel-01
>Cc: Ni, Ruiyu
>Subject: [PATCH 14/47] FatPkg/EnhancedFatDxe: rebase to ARRAY_SIZE()
>
>Cc: Ruiyu Ni
>Contributed-under: T
Reviewed-by: Ruiyu Ni
Regards,
Ray
>-Original Message-
>From: Laszlo Ersek [mailto:ler...@redhat.com]
>Sent: Thursday, October 27, 2016 3:05 AM
>To: edk2-devel-01
>Cc: Tian, Feng ; Ni, Ruiyu ; Zeng,
>Star
>Subject: [PATCH 27/47] MdeModulePkg/Logo: rebase to ARRAY_SIZE()
>
>Cc: Feng Ti
Reviewed-by: Ruiyu Ni
Regards,
Ray
>-Original Message-
>From: Laszlo Ersek [mailto:ler...@redhat.com]
>Sent: Thursday, October 27, 2016 3:05 AM
>To: edk2-devel-01
>Cc: Tian, Feng ; Ni, Ruiyu ; Zeng,
>Star
>Subject: [PATCH 18/47] MdeModulePkg/PciBusDxe: rebase to ARRAY_SIZE()
>
>Cc: Fe
Reviewed-by: Ruiyu Ni
Regards,
Ray
>-Original Message-
>From: Laszlo Ersek [mailto:ler...@redhat.com]
>Sent: Thursday, October 27, 2016 3:05 AM
>To: edk2-devel-01
>Cc: Tian, Feng ; Ni, Ruiyu ; Zeng,
>Star
>Subject: [PATCH 28/47] MdeModulePkg/BdsDxe: rebase to ARRAY_SIZE()
>
>Cc: Feng
Reviewed-by: Ruiyu Ni
Regards,
Ray
>-Original Message-
>From: Laszlo Ersek [mailto:ler...@redhat.com]
>Sent: Thursday, October 27, 2016 3:05 AM
>To: edk2-devel-01
>Cc: Tian, Feng ; Ni, Ruiyu ; Zeng,
>Star
>Subject: [PATCH 28/47] MdeModulePkg/BdsDxe: rebase to ARRAY_SIZE()
>
>Cc: Feng
Reviewed-by: Ruiyu Ni
Regards,
Ray
>-Original Message-
>From: Laszlo Ersek [mailto:ler...@redhat.com]
>Sent: Thursday, October 27, 2016 3:05 AM
>To: edk2-devel-01
>Cc: Tian, Feng ; Ni, Ruiyu ; Zeng,
>Star
>Subject: [PATCH 25/47] MdeModulePkg/UefiBootManagerLib: rebase to ARRAY_SIZE()
Reviewed-by: Ruiyu Ni
Regards,
Ray
>-Original Message-
>From: Laszlo Ersek [mailto:ler...@redhat.com]
>Sent: Thursday, October 27, 2016 3:05 AM
>To: edk2-devel-01
>Cc: Tian, Feng ; Ni, Ruiyu ; Zeng,
>Star
>Subject: [PATCH 19/47] MdeModulePkg/PciHostBridgeDxe: rebase to ARRAY_SIZE()
>
Reviewed-by: Ruiyu Ni
Regards,
Ray
>-Original Message-
>From: Laszlo Ersek [mailto:ler...@redhat.com]
>Sent: Thursday, October 27, 2016 3:05 AM
>To: edk2-devel-01
>Cc: Ni, Ruiyu
>Subject: [PATCH 35/47] Nt32Pkg/WinNtSerialIoDxe: rebase to ARRAY_SIZE()
>
>Cc: Ruiyu Ni
>Contributed-under
Yes, Mike. You are right.
We do have plan to make it generic. As we discussed before, we will enhance the
tool to detect such info and set a PCD at build time. Then we can include that
in the UiApp driver to report such error directly.
The tool is not ready yet. So current platform solution is
Reviewed-by: Ruiyu Ni
>-Original Message-
>From: Laszlo Ersek [mailto:ler...@redhat.com]
>Sent: Thursday, October 27, 2016 3:05 AM
>To: edk2-devel-01
>Cc: Carsey, Jaben ; Ni, Ruiyu
>Subject: [PATCH 42/47] ShellPkg/UefiShellLevel2CommandsLib: rebase to
>ARRAY_SIZE()
>
>Cc: Jaben Carsey
Reviewed-by: Ruiyu Ni
>-Original Message-
>From: Laszlo Ersek [mailto:ler...@redhat.com]
>Sent: Thursday, October 27, 2016 3:05 AM
>To: edk2-devel-01
>Cc: Ni, Ruiyu
>Subject: [PATCH 36/47] OptionRomPkg/AtapiPassThruDxe: rebase to ARRAY_SIZE()
>
>Cc: Ruiyu Ni
>Contributed-under: TianoC
Reviewed-by: Ruiyu Ni
>-Original Message-
>From: Laszlo Ersek [mailto:ler...@redhat.com]
>Sent: Thursday, October 27, 2016 3:05 AM
>To: edk2-devel-01
>Cc: Carsey, Jaben ; Ni, Ruiyu
>Subject: [PATCH 41/47] ShellPkg/UefiDpLib: rebase to ARRAY_SIZE()
>
>Cc: Jaben Carsey
>Cc: Ruiyu Ni
>C
Reviewed-by: Ruiyu Ni
>-Original Message-
>From: Kinney, Michael D
>Sent: Thursday, October 27, 2016 6:31 AM
>To: edk2-devel@lists.01.org
>Cc: Ni, Ruiyu
>Subject: [Patch] PcAtChipsetPkg/HpetTimerDxe: Fix race condition in
>SetTimerPeriod()
>
>https://bugzilla.tianocore.org/show_bug.cgi
Hi Mike
I think that is misunderstanding.
Chao did test before and the UX capsule from Windows does contain a BMP file.
He told me that I should use BMP file.
I will let Chao to clarify more.
I also include Sean Brogan to double check the Windows side.
Thank you
Yao Jiewen
From: Kinney, Michae
Agree. I will move the 2 PCD to SignedCapsulePkg.
From: Kinney, Michael D
Sent: Thursday, October 27, 2016 9:28 AM
To: Yao, Jiewen ; edk2-devel@lists.01.org; Kinney,
Michael D
Cc: Tian, Feng ; Gao, Liming ; Zeng,
Star ; Zhang, Chao B
Subject: RE: [edk2] [PATCH V4 1/8] QuarkPlatformPkg/dec: Add
Reviewed-by: Chao Zhang
Thanks & Best regards
Chao Zhang
-Original Message-
From: Gary Lin [mailto:g...@suse.com]
Sent: Wednesday, October 19, 2016 3:02 PM
To: edk2-devel@lists.01.org
Cc: Zhang, Chao B
Subject: [PATCH 29/33] SecurityPkg: Fix typos in comments
- intialized -> initia
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Fu Siyuan
Cc: Ye Ting
Cc: Zhang Lubo
Cc: Wu Jiaxin
---
NetworkPkg/IScsiDxe/IScsiConfig.c | 16
NetworkPkg/TcpDxe/TcpMain.c| 6 +-
NetworkPkg/UefiPxeBcDxe/PxeBcImpl.c| 30 ++
The classful addressing (IP class A/B/C) has been deprecated according to
RFC4632. This patch updates the NetLib NetGetIpClass() and NetIp4IsUnicast()
accordingly.
NetGetIpClass()
The function is kept for compatibility, while the caller of this function
could only check the returned value against
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Fu Siyuan
Cc: Ye Ting
Cc: Zhang Lubo
Cc: Wu Jiaxin
---
MdeModulePkg/Include/Library/IpIoLib.h | 4 ++-
MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.c | 9 ++-
MdeModulePkg/Universal/Network/ArpDxe/ArpI
The classful addressing (IP class A/B/C) has been deprecated according to
RFC4632. This patch updates the NetLib and network drivers for the unicast
check in classless network.
Fu Siyuan (3):
MdeModulePkg: Update NetLib interface to support classless addressing.
MdeModulePkg: Update IP4 stack
Good question again.
That is because the platform PEI phase does not report all FV information to
DXE.
I did use this way in my early version. I give up later, because I realize if
so we need update all platforms to let it report all FV information. It is a
burden.
Using PCD is a standalone so
Jiewen,
Why are these 2 PCDs added to a platform specific DEC file?
The same feedback applies to the Vlv2 platform.
Since we want platform agnostic detection for the use of
test keys, these PCDs should be added to SignedCapsulePkg.
I think the best place to do the check for use of test keys
an
Jiewen,
They why do we need the PCD?
We should be able to find this section in current FLASH image and in new FLASH
image. Right?
Mike
From: Yao, Jiewen
Sent: Wednesday, October 26, 2016 6:15 PM
To: Kinney, Michael D ; edk2-devel@lists.01.org
Cc: Tian, Feng ; Gao, Liming ; Zeng,
Star ; Zhan
Reviewed-by: Liming Gao
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Thursday, October 27, 2016 3:04 AM
To: edk2-devel-01
Cc: Gao, Liming
Subject: [PATCH 12/47] EdkCompatibilityPkg/FrameworkHiiOnUefiHiiThunk: rebase
to ARRAY_SIZE()
Cc: Liming Gao
Contribute
Reviewed-by: Liming Gao
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Thursday, October 27, 2016 3:05 AM
To: edk2-devel-01
Cc: Gao, Liming
Subject: [PATCH 13/47] EdkCompatibilityPkg/Sample/Tools: rebase to ARRAY_SIZE()
Cc: Liming Gao
Contributed-under: TianoC
MdeModulePkg
reviewed-by: Feng Tian
Thanks
Feng
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Thursday, October 27, 2016 3:04 AM
To: edk2-devel-01
Cc: Ard Biesheuvel ; Cecil Sheng
; Zhang, Chao B ; Bi, Dandan
; Daryl McDaniel ; Wei, David
; Dong, Eric ; Tia
Mike
That is a good question.
We create a standalone FFS SECTION to hold the descriptor purposely.
The reason is that: the SystemFirmwareUpdate need to know the version of the
*new image*.
SystemFirmwareUpdate can know the version and lowest supported version of the
current image by using PCD.
Agree and updated.
From: Kinney, Michael D
Sent: Thursday, October 27, 2016 8:41 AM
To: Yao, Jiewen ; edk2-devel@lists.01.org; Kinney,
Michael D
Cc: Tian, Feng ; Gao, Liming ; Zeng,
Star ; Zhang, Chao B
Subject: RE: [edk2] [PATCH V4 7/8] QuarkPlatformPkg/dsc/fdf: Add
capsule/recovery support.
I noticed if a GUID (PPI & Protocol) was only used via a library it does not
end up in the Guid.xref file.
It looks to me like this code is only extracting the GUIDs from the Drivers INF
file and the GUIDs defined in dependent libraries are skipped?
https://github.com/tianocore/edk2/blob/ma
Sorry for missing this patch.
Reviewed-by: Feng Tian
I will help push it in.
Thanks
Feng
-Original Message-
From: Brian J. Johnson [mailto:bjohn...@sgi.com]
Sent: Wednesday, October 26, 2016 11:00 PM
To: Tian, Feng ; Zeng, Star
Cc: Roy Franz ; Ryan Harkin ; Laszlo
Ersek ; edk2-devel
To let it boot to OS automatically, make built in shell
as the last boot option.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Guo Dong
Reviewed-by: Maurice Ma
---
.../Library/PlatformBootManagerLib/PlatformBootManager.c | 10 +-
1 file changed, 5 insertio
Also add Down key to Boot Manager Menu since some serial
terminals don't support F2 key.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Guo Dong
Reviewed-by: Maurice Ma
---
.../Library/PlatformBootManagerLib/PlatformBootManager.c| 13 +++--
1 file changed, 11
Jiewen,
A couple comments inline below.
Mike
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiewen
> Yao
> Sent: Saturday, October 22, 2016 7:32 PM
> To: edk2-devel@lists.01.org
> Cc: Tian, Feng ; Gao, Liming ;
> Zeng, Star
> ; Kinney, Mic
CbPlatformSupportLib might use FindCbTag() API to parse
platform specific information.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Guo Dong
Reviewed-by: Maurice Ma
---
CorebootModulePkg/Include/Library/CbParseLib.h | 19 ++-
1 file changed, 18 insertio
Jiewen,
Why is .aslc file used in this PEIM. It is not an ACPI table.
You are generating a C structure that is used to set the value of
a PCD. The C structure could be a global variable in the PEIM
that is initialized the same way the .aslc file does or you
could initialize the fields in the PE
Jiewen,
Why is .aslc file used in this PEIM. It is not an ACPI table.
You are generating a C structure that is used to set the value of
a PCD. The C structure could be a global variable in the PEIM
that is initialized the same way the .aslc file does or you
could initialize the fields in the PE
Jiewen,
I have looked Microsoft UX capsule in the Microsoft
Windows UEFI Firmware Update Platform Specification, and
that specification only defines support for an ImageType value
of 0, which is bitmap format based on ACPI 5.0 BGRT. There
are no defined ImageType values for BMP.
I recommend yo
Reviewed-by: Maurice Ma
-Original Message-
From: Dong, Guo
Sent: Tuesday, October 18, 2016 12:11 PM
To: edk2-devel@lists.01.org
Cc: Ma, Maurice; Agyeman, Prince; Dong, Guo
Subject: [edk2] [PATCH] CorebootModulePkg: Fix memmap issue
Some reserved memory (e.g. CSE reserved memory) might b
Jiewen,
I have looked Microsoft UX capsule in the Microsoft
Windows UEFI Firmware Update Platform Specification, and
that specification only define support for an ImageType value
of 0, which is bitmap format based on ACPI 5.0 BGRT. There
are no defined ImageType values for BMP. We need to remove
Jiewen,
See feedback for QuarkPlatformPkg/PlatformBootManager.
The same feedback applies.
Mike
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiewen
> Yao
> Sent: Saturday, October 22, 2016 7:33 PM
> To: edk2-devel@lists.01.org
> Cc: Tian,
Jiewen,
Can the code that checks for the use of a test key be moved into a common BDS
lib or module?
Maybe in MdeModulePkg\Universal\BdsDxe\BdsEntry.c right before the call to
PlatformBootManagerAfterConsole()? The logic in BdsEntry.c can do the check
and set the
PcdTestKeyUsed PCD and can go
https://bugzilla.tianocore.org/show_bug.cgi?id=182
The function TimerDriverSetTimerPeriod() disables the HPET timer
while the HPET timer HW is reprogrammed with a new timer period.
However, the MMIO write to disable the HPET timer HW can be
delayed and an HPET timer interrupt may be processed in t
On 10/27/16 00:13, Kinney, Michael D wrote:
> Hi Laszlo,
>
> One comment inline below.
>
> Mike
>
>> -Original Message-
>> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
>> Laszlo Ersek
>> Sent: Wednesday, October 26, 2016 12:04 PM
>> To: edk2-devel-01
>> Cc: Ni
Hi Laszlo,
One comment inline below.
Mike
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
> Ersek
> Sent: Wednesday, October 26, 2016 12:04 PM
> To: edk2-devel-01
> Cc: Ni, Ruiyu ; Tim He ; Tian, Feng
> ; Kinney, Michael D ; Dong,
>
For 05, 39, 41, 42
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, October 26, 2016 12:04 PM
> To: edk2-devel-01
> Cc: Ard Biesheuvel ; Cecil Sheng
> ; Zhang, Chao B ; Bi,
> Dandan ; Daryl McDaniel li...@mc2research.org>
https://bugzilla.tianocore.org/show_bug.cgi?id=181
Add size check for 8-bit, 16-bit, and 32-bit enums
to make sure they follow the UEFI Specification 2.3.1
Data Types.
Element of a standard ANSI C enum type declaration.
Type INT32.or UINT32. ANSI C does not define the
size of sign of an enum s
The current CorebootPayloadPkg will use the legacy 8254 timer
driver as the default. However, on some platforms legacy timer
might not exist anymore. This patch adds HPET timer driver as
a build option.
Cc: Prince Agyeman
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Maur
The PCI_SEGMENT_LIB_ADDRESS() macro puts the Segment number
into bits 32..47 of the logical address that is returned.
The portable method to put Segment in this bit range is to
use LShitU64(). For 64-bit CPUs, this is optimized well
by the compiler. For 32-bit CPUs, a call to LSHiftU64()
is inclu
Hi, Guo,
Please fix the typos "specif" in commit message.
Other than this, it looks good to me.
Reviewed-by: Maurice Ma
-Original Message-
From: Dong, Guo
Sent: Monday, October 17, 2016 3:33 PM
To: edk2-devel@lists.01.org
Cc: Ma, Maurice; Agyeman, Prince; Dong, Guo
Subject: [edk2] [
This patch looks good to me.
Reviewed-by: Maurice Ma
-Original Message-
From: Dong, Guo
Sent: Monday, October 17, 2016 3:39 PM
To: edk2-devel@lists.01.org
Cc: Ma, Maurice; Agyeman, Prince; Dong, Guo
Subject: [edk2] [PATCH] CorebootPayloadPkg: Notify EndOfDxe and install
ReadyToLock p
Cc: Jaben Carsey
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
ShellPkg/Library/UefiDpLib/DpTrace.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/ShellPkg/Library/UefiDpLib/DpTrace.c
b/ShellPkg/Library/Uefi
Cc: David Wei
Cc: Tim He
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
Vlv2TbltDevicePkg/Application/FirmwareUpdate/FirmwareUpdate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Vlv2TbltDevicePkg/Application/FirmwareUpdate/Firmwar
M: David Wei
M: Tim He
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
Vlv2TbltDevicePkg/PlatformInitPei/FlashMap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Vlv2TbltDevicePkg/PlatformInitPei/FlashMap.c
b/Vlv2TbltDevicePkg/Platf
Cc: Jaben Carsey
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
ShellPkg/Library/UefiShellLevel2CommandsLib/TimeDate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/TimeDate.c
Cc: Jordan Justen
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c
b/Ov
Cc: David Wei
Cc: Tim He
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscOemType0x94Function.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscOemType0x94Function.
Cc: Daryl McDaniel
Cc: Jaben Carsey
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
PerformancePkg/Dp_App/Dp.c | 2 +-
PerformancePkg/Dp_App/DpTrace.c | 10 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/PerformancePkg/Dp_
Cc: Chao Zhang
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
SecurityPkg/Library/AuthVariableLib/AuthVariableLib.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/SecurityPkg/Library/AuthVariableLib/AuthVariableLib.
Cc: David Wei
Cc: Tim He
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
Vlv2TbltDevicePkg/PlatformPei/BootMode.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Vlv2TbltDevicePkg/PlatformPei/BootMode.c
b/Vlv2TbltDevicePkg/Platf
Cc: David Wei
Cc: Tim He
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek
---
Vlv2TbltDevicePkg/PlatformSetupDxe/SetupInfoRecords.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Vlv2TbltDevicePkg/PlatformSetupDxe/SetupInfoRecords.c
b/Vlv
1 - 100 of 168 matches
Mail list logo
