[edk2] [patch] MdeModulePkg/UsbMass: Revert changes of removing retry logic

2016-11-06 Thread Feng Tian
This patch is used to revert changes done in commit 17f3e942 bc527fbd75068d2d5752b6af54917487 - "MdeModulePkg/UsbMass: Not retry if usb bot transfer execution fail" It's because Usb Floppy will report DEVICE_ERROR for the first several cmds when it need spin up. so retry logic makes sense. Cc: St

Re: [edk2] Unit tests and the EDK2

2016-11-06 Thread Matt Lazarowitz
I decided to give embUnit a try since it offers basic functionality without the C standard libraries. I have my work available on github at https://github.com/mattlazarowitz/UnitTestNoStdLibPkg The embUnitSamples folder may give you an idea of what I am trying. I create a new folder in the package

Re: [edk2] [PATCH 0/4] Defer 3rd party images loading to after EndOfDxe

2016-11-06 Thread Ni, Ruiyu
Thanks/Ray > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Saturday, November 5, 2016 12:48 AM > To: Ni, Ruiyu ; Gao, Liming ; > edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH 0/4] Defer 3rd party images loading to after > EndOfDxe > > On 11/04/16 07:

Re: [edk2] [PATCH v2 1/2] MdeModulePkg: Do not free memory during ExitBootServices ().

2016-11-06 Thread Tian, Feng
Marvin, The commit log is a little confusing. Please update the commit title to clarify it's only for Iscsi. And I will leave this RB to network owner. Thanks Feng -Original Message- From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] Sent: Friday, November 4, 2016 7:10 AM To: edk

Re: [edk2] [PATCH] UefiCpuPkg/MpInitLib: Do not wakeup AP if only one processor supported

2016-11-06 Thread Fan, Jeff
Laszlo, Yes. MP PPI and Protocol still be installed even there is only one processor supported or found? Jeff -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Saturday, November 05, 2016 12:40 AM To: Fan, Jeff; edk2-de...@ml0

Re: [edk2] Unit tests and the EDK2

2016-11-06 Thread Kinney, Michael D
Marvin, UEFI environment. Emulated environments are great for some types of testing. OVMF is also interesting for something that is a bit closer to real HW without requiring the real hardware. And types of testing always requires a real HW target. Mike > -Original Message- > From: e

Re: [edk2] Unit tests and the EDK2

2016-11-06 Thread Blibbet
> I am evaluating a number of options and hope to put together > a complete proposal as an RFC for consideration in the next > few weeks. For your evaluation, please also check out the U-Boot and coreboot projects, they both have some built-in tests. Thanks, Lee Fisher _

Re: [edk2] Unit tests and the EDK2

2016-11-06 Thread Marvin H?user
Hey Mike, Is the framework you plan to RFC a framework within the UEFI environment (UEFI Shell) or within the OS? Using the OS implementations of UEFI (Nt32 & Emulator) to run Unit Tests without the need for a separate UEFI device or a reboot sounds pretty compelling to me, to be honest. Thank

Re: [edk2] Unit tests and the EDK2

2016-11-06 Thread Kinney, Michael D
Hi, A test framework for EDK2 is one of my highest priorities to complete before the end of the year. I am evaluating a number of options and hope to put together a complete proposal as an RFC for consideration in the next few weeks. Thanks, Mike > -Original Message- > From: edk2-de

Re: [edk2] Unit tests and the EDK2

2016-11-06 Thread Blibbet
On 11/06/2016 01:57 AM, Matt Lazarowitz wrote: > I would like to find out if anyone has experience with an off the shelf > unit test framework in the EDK2.[...] If you haven't looked at it, two months ago Microsoft open-sourced some EDK2-centric unit tests. https://firmwaresecurity.com/2016/09/23

[edk2] Unit tests and the EDK2

2016-11-06 Thread Matt Lazarowitz
I would like to find out if anyone has experience with an off the shelf unit test framework in the EDK2. I'm currently experimenting with embUnit and have some of the project's sample code running without using the StdLib package. My eventual goal is to see if this can be used as an automated unit