Paolo,
I added patch #3 in v2 to do InterlockedDecrement (&mNumberToFinish) in the
safe code.
This is very good comment to eliminate this gap.
Thanks!
Jeff
-Original Message-
From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini
Sent: Thursday, November 10, 20
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=205
Cc: Jiewen Yao
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng
---
MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/M
We will put APs into hlt-loop in safe code. But we decrease mNumberToFinish
before APs enter into the safe code. Paolo pointed out this gap.
This patch is to move mNumberToFinish decreasing to the safe code. It could
make sure BSP could wait for all APs are running in safe code.
https://bugzilla.
On S3 path, we will wake up APs to restore CPU context in PiSmmCpuDxeSmm
driver. In case, one NMI or SMI happens, APs may exit from hlt state and
execute the instruction after HLT instruction.
But APs are not running on safe code, it leads OVMF S3 boot unstable.
https://bugzilla.tianocore.org/sho
On S3 path, we may transfer to long mode (if DXE is long mode) to restore CPU
contexts with CR3 = SmmS3Cr3 (in SMM). AP will execute hlt-loop after CPU
contexts restoration. Once one NMI or SMI happens, APs may exit from hlt state
and execute the instruction after HLT instruction. If APs are runnin
On S3 path, we will wake up APs to restore CPU context in PiSmmCpuDxeSmm
driver. However, we place AP in hlt-loop under 1MB space borrowed after CPU
restoring CPU contexts.
In case, one NMI or SMI happens, APs may exit from hlt state and execute the
instruction after HLT instruction. But the code u
v2:
* Separate out the return status fix.
* Replace IP4_MASK_MAX with IP4_MASK_MAX.
* Remove the ON_EXIT label.
This patch is used to add the wrong/invalid subnet check.
Cc: Santhapur Naveen
Cc: Laszlo Ersek
Cc: Ye Ting
Cc: Fu Siyuan
Contributed-under: TianoCore Contribution Agreement 1.0
Sig
Cc: Santhapur Naveen
Cc: Laszlo Ersek
Cc: Ye Ting
Cc: Fu Siyuan
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiaxin Wu
Jiaxin Wu (2):
MdeModulePkg/Ip4Dxe: Add wrong/invalid subnet check
MdeModulePkg/Ip4Dxe: Correct the return status
.../Universal/Network/Ip4Dxe
This patch made the following change:
* DataItem->Status should be updated to the status code.
* Data should not be freed if EFI_NOT_READY returned.
Cc: Santhapur Naveen
Cc: Laszlo Ersek
Cc: Ye Ting
Cc: Fu Siyuan
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiaxin Wu
For field name in structure, its first character should be upper case.
Cc: Michael Kinney
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao
---
MdePkg/Include/Base.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/MdePkg/Include/Base.h b
Thanks Laszlo, your suggestions make sense.
Best Regards!
Jiaxin
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, November 10, 2016 5:19 PM
> To: Wu, Jiaxin ; edk2-de...@ml01.01.org
> Cc: Santhapur Naveen ; Ye, Ting
> ; Fu, Siyuan
> Subject: Re: [Pat
Reviewed-by: Qin Long
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Dandan Bi
> Sent: Thursday, November 10, 2016 5:09 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH v2] CryptoPkg/BaseCryptLib:
Mike:
Thanks for your clarification. This way works for me.
Thanks
Liming
From: Kinney, Michael D
Sent: Friday, November 11, 2016 12:46 AM
To: Gao, Liming ; edk2-devel@lists.01.org; Kinney,
Michael D
Subject: RE: [edk2] [Patch] BaseTools/Scripts: Add BinToPcd utility
Liming,
There are severa
On 11/10/16 13:08, Laszlo Ersek wrote:
> On 11/10/16 12:17, Yao, Jiewen wrote:
>> Hi Laszlo
>>
>> Thanks to test for us.
>>
>>
>>
>> Are you saying Jeff’s patch introduces a new issue?
>>
>> Or is this a previous issue but just not fixed by Jeff’s patch?
>
> With your v2 series applied, Jeff's p
Liming,
There are several ways that BinPcd can produce output files.
* Use -o, --output flag (e.g. -o test.pcd)
* Use output redirection > (e.g. > test.pcd)
* Use output redirection with append >> (e.g. >> test.pcd)
Here is an example using append with current patch:
BinToPcd.py -i test1.bin
> And, in my recent KVM / QEMU usage instructions for Jiewen:
>
> https://www.mail-archive.com/edk2-devel@lists.01.org/msg19446.html
>
> I provided the following settings:
>
> > # Settings for Ia32 only:
> > [...]
> > QEMU_COMMAND="qemu-system-i386 -cpu coreduo,-nx"
> >
> > # Settings for Ia32
On 11/10/16 15:48, Yao, Jiewen wrote:
> Laszlo, your analysis will save me one day to install the Linux QEMU. J
Perfect; I can't wait till you guys adopt QEMU/KVM as a test platform! :)
Cheers
Laszlo
___
edk2-devel mailing list
edk2-devel@lists.01.org
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Ni, Ruiyu
> Sent: Wednesday, November 09, 2016 10:59 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben
> Subject: [PATCH] ShellPkg/ShellCommandLib: Add missing EFIAPI for public
> library APIs
> Importance: High
>
> DumpHex() and
Yes. Wiki is good enough.
For second one, I understand its complexity. Append is optional option. Users
will decide to use it or not. I don't expect to add every file for every PCD.
From: Kinney, Michael D
Sent: Friday, November 11, 2016 12:11 AM
To: Gao, Liming ; edk2-devel@lists.01.org; Kinney
On 11/10/16 15:53, Paolo Bonzini wrote:
>
>
> On 10/11/2016 15:48, Yao, Jiewen wrote:
>> I cannot reproduce it before, because all my real hardware supports XD.
>> My Windows QEMU also supports XD (to my surprise.)
>
> QEMU can be configured to support XD or not. Possibly Laszlo was using
> som
Right. To customize CreatePopup(), new library instance and platform dsc are
both updated. Not to customize Createpopup(), there is nothing to do.
From: Felix Poludov [mailto:fel...@ami.com]
Sent: Friday, November 11, 2016 12:11 AM
To: Kinney, Michael D ; Gao, Liming
; Yao, Jiewen ;
edk2-devel@
Yes, but if I understand Liming's proposal correctly, there will be no
dependency between UefiLib and UiLib (UefiLib will not use UiLib).
It means that just adding a constructor to UiLib will be insufficient.
The DSC file will still have to be updated to link either UiLib or a NULL lib
proposed b
Liming,
This utility would not used as part of a build.
I put it in BaseTools/Scripts because it is intended to be a helper
tool for developers. I have been writing the Wiki on the Capsule
Based System Firmware Update and there are development steps in that
Wiki that will be simpler if this ut
Felix,
The CONSTRUCTOR for the UiLib could do the registration.
Mike
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Felix
> Poludov
> Sent: Thursday, November 10, 2016 7:44 AM
> To: Gao, Liming ; Yao, Jiewen ;
> edk2-
> de...@lists.01.org
>
Yes. Quick way is to search CreatePopUp in build output map file. If the driver
map includes this function, this driver will require to link NULL library
instance. That means RegisterCreatePopUpHandler() and CreatePopUp() are both
required in map file. You can develop one script to detect every
On 11/9/2016 5:37 PM, Wu, Hao A wrote:
This issue was introduced by commit 2ff3293. And it has been fixed via
commit 49d8f53.
Could you help to update the repository and see whether this issue still
exists? Thanks in advance.
Thanks - after rebuilding BaseTools and regenerating the files in C
Liming,
With your proposal if a projects uses RegisterCreatePopUpHandler(), DSC file
has to be updated to link popup handler NULL library
with all the modules that consume CreatePopup().
Since projects tend to evolve (new modules added, existing code changes), this
sounds like a constant mainten
Felix:
I think two major concerns are here.
1) UefiLib depends on UiLib
2) UiLib class is defined in MdePkg.
To resolve it, I have another idea.
1) Introduce new API RegisterCreatePopUpHandler() in UefiLib. Its input
parameter is the handler function that is same to UiCre
On 10/11/2016 15:48, Yao, Jiewen wrote:
> I cannot reproduce it before, because all my real hardware supports XD.
> My Windows QEMU also supports XD (to my surprise.)
QEMU can be configured to support XD or not. Possibly Laszlo was using
some different default, or testing both cases.
Paolo
___
Nice shot
After I reviewed SMI entry code again, I know the root-cause.
I made a huge mistake there.
We always save CpuIndex on the top of stack.
However, during SMI entry, below code *conditionally* push EDX.
; enable NXE if supported
DB 0b0h; mov al, imm8
Mike:
I have two comments.
1) Could you also provide the patch to use this utility in edk2 platform, such
as quark platform?
2) Suggest to support append mode as one option. If so, we can use this utility
to dump more one PCD values into one file.
Thanks
Liming
-Original Message-
Fr
Hi Jiewen,
Updating "all the code that uses the old API to use the new API" is not always
possible.
We can certainly update all the EDKII packages; however, it is trickier with
the non-open source packages.
For example, the Reference Code we are getting from a chipset vendor is using
CreatePopU
On 11/10/16 13:26, Paolo Bonzini wrote:
>
>
> On 10/11/2016 11:41, Laszlo Ersek wrote:
>> Here's an excerpt from the KVM trace:
>>
>>> CPU-23509 [002] 8406.908787: kvm_enter_smm:vcpu 1: entering SMM,
>>> smbase 0x3
>>> CPU-23509 [002] 8406.908836: kvm_enter_smm:vcpu 1: le
Hi Brandon Huber,
Thanks for reporting this, I will investigate it and fix it.
Best Regards,
Zhu Yonghong
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Huber,
Brandon
Sent: Wednesday, November 09, 2016 11:25 PM
To: edk2-devel@lists.01.org
Subj
On 10/11/2016 11:41, Yao, Jiewen wrote:
> I also did not quite understand below log.
>
> * CPU #0: pc=0xc1844555 (halted) thread_id=7835
> CPU #1: pc=0xc1844555 (halted) thread_id=7836
> CPU #2: pc=0xc1844555 (halted) thread_id=7837
> CPU #3: pc=0x7ffd17ca t
On 10/11/2016 11:41, Laszlo Ersek wrote:
> Here's an excerpt from the KVM trace:
>
>> CPU-23509 [002] 8406.908787: kvm_enter_smm:vcpu 1: entering SMM,
>> smbase 0x3
>> CPU-23509 [002] 8406.908836: kvm_enter_smm:vcpu 1: leaving SMM,
>> smbase 0x7ffb3000
>> CPU-23510 [00
On 11/10/16 12:17, Yao, Jiewen wrote:
> Hi Laszlo
>
> Thanks to test for us.
>
>
>
> Are you saying Jeff’s patch introduces a new issue?
>
> Or is this a previous issue but just not fixed by Jeff’s patch?
With your v2 series applied, Jeff's patches replace the crash /
emulation failure sympt
On 11/10/16 11:41, Yao, Jiewen wrote:
> Thanks to report case 3 issue on bugzillar.
>
> Let's focus on Case 8.
> It seems another random failure issue.
>
> I did more test.
>
> 1) I tested some other our internal real platform for UEFI32 OS boot. I
> cannot reproduce the ASSERT.
>
> 2)
Hi Laszlo
Thanks to test for us.
Are you saying Jeff's patch introduces a new issue?
Or is this a previous issue but just not fixed by Jeff's patch?
Thank you
Yao Jiewen
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Thursday, November 10, 2016 6:41 PM
To: Fan, Jeff
Cc: edk2-de...@ml01.01
On 11/10/16 07:07, Jeff Fan wrote:
> On S3 path, we will wake up APs to restore CPU context in PiSmmCpuDxeSmm
> driver. In case, one NMI or SMI happens, APs may exit from hlt state and
> execute the instruction after HLT instruction.
>
> But APs are not running on safe code, it leads OVMF S3 boot
Thanks to report case 3 issue on bugzillar.
Let's focus on Case 8.
It seems another random failure issue.
I did more test.
1) I tested some other our internal real platform for UEFI32 OS boot. I
cannot reproduce the ASSERT.
2) I wrote a small test app to call ExitBootServices and sen
On 10/11/2016 07:07, Jeff Fan wrote:
> On S3 path, we will wake up APs to restore CPU context in PiSmmCpuDxeSmm
> driver. In case, one NMI or SMI happens, APs may exit from hlt state and
> execute the instruction after HLT instruction.
>
> But APs are not running on safe code, it leads OVMF S3 b
On 11/10/16 10:00, Fan, Jeff wrote:
> I agree with your proposal. Great suggestion. I will create v2 later.
Thank you.
Since you're going to send a v2: while applying this patch for testing,
git-am warned me that there were 7 new lines with trailing whitespace.
Can you please trim those?
Thanks
I have a few comments:
On 11/10/16 09:45, Jiaxin Wu wrote:
> This patch is used to add the wrong/invalid subnet check.
> Meanwhile, correct the the return status.
(1) I propose to split this patch into three patches, with the following
subjects:
MdeModulePkg/Ip4Dxe: Catch invalid subnet early in
V2: Correct the unaligned parameter name in BaseCryptLib.h.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
CryptoPkg/Include/Library/BaseCryptLib.h | 4 ++--
CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacSha256.c | 2 +-
CryptoPkg/Library
I agree with your proposal. Great suggestion. I will create v2 later.
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Thursday, November 10, 2016 4:51 PM
To: Fan, Jeff; edk2-de...@ml01.01.org
Cc: Kinney, Michael D; Paolo Bonzin
On 11/10/16 07:07, Jeff Fan wrote:
> On S3 path, we will wake up APs to restore CPU context in PiSmmCpuDxeSmm
> driver. In case, one NMI or SMI happens, APs may exit from hlt state and
> execute the instruction after HLT instruction.
>
> But APs are not running on safe code, it leads OVMF S3 boot
Before I test this, I have one question / suggestion:
On 11/10/16 07:07, Jeff Fan wrote:
> On S3 path, we will wake up APs to restore CPU context in PiSmmCpuDxeSmm
> driver. However, we place AP in hlt-loop under 1MB space borrowed after CPU
> restoring CPU contexts.
> In case, one NMI or SMI happ
This patch is used to add the wrong/invalid subnet check.
Meanwhile, correct the the return status.
Cc: Santhapur Naveen
Cc: Laszlo Ersek
Cc: Ye Ting
Cc: Fu Siyuan
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiaxin Wu
---
MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Co
Yes! I will correct them and send a V2 patch.
Thanks,
Dandan
-Original Message-
From: Long, Qin
Sent: Thursday, November 10, 2016 4:25 PM
To: Bi, Dandan ; edk2-devel@lists.01.org
Subject: RE: [patch] CryptoPkg/BaseCryptLib: Make comments consistent with the
function
Dandan,
Could you
Reviewed-by: Liming Gao
> -Original Message-
> From: Song, BinX
> Sent: Thursday, November 10, 2016 4:20 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming
> Subject: [PATCH V2] MdeModulePkg/BootLogoLib: Remove invalid if
> judgments
>
> FreePool (Blt) function will be called in while l
Dandan,
Could you help to correct the comments in BaseCryptLib.h, which also used the
unaligned parameter name?
Best Regards & Thanks,
LONG, Qin
> -Original Message-
> From: Bi, Dandan
> Sent: Thursday, November 10, 2016 3:40 PM
> To: edk2-devel@lists.01.org
> Cc: Long, Qin
> Subject:
FreePool (Blt) function will be called in while loop, cannot be removed.
Cc: Liming Gao
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Bell Song
---
MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 4
1 file changed, 4 deletions(-)
diff --git a/MdeModulePkg/Library
53 matches
Mail list logo
