Added NULL Library constructor DxeSmbiosDataHobLib which adds SMBIOS
records from gIntelSmbiosDataHobGuid HOB to SMBIOS table using
SMBIOS protocol.
Cc: Jiewen Yao
Cc: Star Zeng
Cc: Michael Kinney
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Giri P Mudusuru
---
.../D
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Monday, November 14, 2016 2:37 PM
To: edk2-devel@lists.01.org
Subject: [edk2] [Patch 0/2] BaseTools tools_def.txt: Update GCC
Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: Kinney, Michael D
Sent: Monday, November 14, 2016 11:49 AM
To: edk2-devel@lists.01.org
Cc: Zhu, Yonghong ; Gao, Liming
Subject: [Patch v2] BaseTools/Scripts: Add BinToPcd utility
Add a utility that convert
Sounds good.
Reviewed-by: Ye Ting
Thanks,
Ting
-Original Message-
From: Wu, Jiaxin
Sent: Monday, November 14, 2016 3:01 PM
To: Ye, Ting ; edk2-devel@lists.01.org
Cc: Santhapur Naveen ; Laszlo Ersek
; Fu, Siyuan
Subject: RE: [PATCH v2 1/2] MdeModulePkg/Ip4Dxe: Add wrong/invalid subne
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Mudusuru, Giri P
> Sent: Monday, November 14, 2016 2:33 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Zeng, Star
> Subject: [edk2][PATCH V2] IntelSiliconPkg: Add PCD for Graphics VBT FFS
> GUID
>
> Added PCD PcdIntelGr
Hi Ting,
Thanks for catch. Item 2 should be: * Replace IP4_MASK_MAX with IP4_MASK_NUM.
Item 3 is part of patch 2/2.
I will correct it when I commit the patch.
Thanks
Jiaxin.
> -Original Message-
> From: Ye, Ting
> Sent: Monday, November 14, 2016 2:52 PM
> To: Wu, Jiaxin ; edk2-devel@li
Hi Jiaxin,
It looks the check-in log is incorrect.
-- Any typo in item 2?
-- Is item 3 part of patch 2/2?
Please double check, thanks.
Best Regards,
Ting
-Original Message-
From: Wu, Jiaxin
Sent: Friday, November 11, 2016 1:19 PM
To: edk2-devel@lists.01.org
Cc: Santhapur Naveen ; L
Update GCC ASLPP_FLAGS to align to VS ASLPP_FLAGS so that the same ASL file
can support GCC and VS tool chains both.
Liming Gao (2):
BaseTools tools_def.txt: Remove -P option in GCC ASLPP_FLAGS
BaseTools tools_def.txt: Include AutoGen.h in GCC ASLPP_FLAGS
BaseTools/Conf/tools_def.template |
https://bugzilla.tianocore.org/show_bug.cgi?id=227
Refer to VS ASLPP_FLAGS, force include AutoGen.h so that ASL code
can use FixedPcdGetXX to get FixedPcd value.
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao
---
BaseTools/Conf/tools_def.templ
https://bugzilla.tianocore.org/show_bug.cgi?id=227
After -P option is removed, the generated preprocessed ASL file will have
line markers. The extra information can be removed by Trim script. ASL code
can refer to the definition in C source file. This has been supported in
VS and XCODE tool chains
Added PCD PcdIntelGraphicsVbtFileGuid to store raw format
Graphics Video BIOS Table (VBT) in FFS.
Cc: Jiewen Yao
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Giri P Mudusuru
---
IntelSiliconPkg/IntelSiliconPkg.dec | 12
1 file changed, 12 in
Lin:
We don't plan to clean up all existing codes with EDKII DEBUG_ macros. We
expect DEBUG_ macro will be applied with other change together. So, I propose
to add this check in PatchCheck.py script. You only need to update your changed
lines.
Thanks
Liming
> -Original Message-
> Fr
Mike:
There is one minor issue in help message. -m is not only used with --type
VPD.
-m MAXSIZE, --max-size MAXSIZE
Maximum size of the PCD. Only used with --type VPD.
Other are good to me. Reviewed-by: Liming Gao
Thanks
Liming
> -Original Message-
> From:
The ACPI code may reserve the first entry for a certain table
(might be FACS) to help with OS compatible issues.
We need to skip the NULL table entry in RSDT/XSDT.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ruiyu Ni
Cc: Sean Brogan
---
PcAtChipsetPkg/PcatRealTimeCloc
I don't catch what you mean. We have had 10ms delay for port reset. Which line
of UsbHub.c do you think there is problem?
Quote from USB2.0 spec:
"Hubs must be able to accept all hub requests and devices must be able to
accept a SetAddress() request (refer to
Section 11.24.2 and Section 9.4 res
On Mon, Nov 14, 2016 at 03:12:16AM +, Zhang, Chao B wrote:
> Hi Gary:
> I see some warnings while running PatchChecy.py with this patch.
> Please help to update the patch, run PatchCheck.py(BaseTools/Scripts) &
> re-send the patch.
>
Hi Chao,
PatchCheck.py showed this:
The commit messag
HI,
i am running linuxloader (ArmPkg/Application/LinuxLoader) application in
armQemu ( QEMU_EFI.fd on qemu-system-aarch64)
but linuxloader is failing while initializing
shellLibs(ShellLibConstructor).
i included Shell lib(ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf)
in armVirtQemu.dsc
Add a utility that converts a binary file into a VOID* PCD value
or a full DSC file VOID* PCD statement with support for all the
DSC supported PCD sections.
usage: BinToPcd [-h] [--version] -i INPUTFILE [-o OUTPUTFILE] [-p PCDNAME]
[-t {VPD,HII}] [-m MAXSIZE] [-f OFFSET] [-n VARIAB
Liming,
Thanks for catching this case. I will send a V2 patch
Mike
From: Gao, Liming
Sent: Sunday, November 13, 2016 6:58 PM
To: Gao, Liming ; Kinney, Michael D
; edk2-devel@lists.01.org
Subject: RE: [edk2] [Patch] BaseTools/Scripts: Add BinToPcd utility
Mike:
Per DSC spec, MaxSize supports
Some CPU information (InitialApicId/ApicId/Health) are duplicated in CPU_AP_DATA
and CPU_INFO_IN_HOB.
This update is to remove the ones from CPU_AP_DATA and update MpInitLib to
consume the ones from CPU_INFO_IN_HOB.
Cc: Feng Tian
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Ag
If BSP found APs timeout happened when AP executing AP task, BSP will reset APs
by WakeUpAP(). However, if ApLoopMode is ApMwaitLoop or ApRunLoop, WakeUpAp()
will try to write semaphore in memory to wake up AP. It cannot wake up APs
actually if APs still executing AP task.
This fix is to set ApIni
Currently, MpInitLib will program AP stack in dynamic address. Each processor
will calculate its stack address by adding stack size based on the last stack
address. That means AP may have the different stack address everytime it is
wakeup by INIT-SIPI-SIPI.
When all APs have wakeup to execute AP t
When BSP switched, we need to update some AP information. For example,
ApStartupSignalBuffer and ApTopOfStack.
Cc: Feng Tian
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan
---
UefiCpuPkg/Library/MpInitLib/MpLib.c | 3 +++
UefiCpuPkg/Library
Cr3Location offset value should be 0x34 not 0x3C.
Cc: Feng Tian
Cc: Hao Wu
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan
---
UefiCpuPkg/Library/MpInitLib/Ia32/MpEqu.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/U
Currently, MpInitLib will program AP stack in dynamic address. Each processor
will calculate its stack address by adding stack size based on the last stack
address. That means AP may have the different stack address everytime it is
wakeup by INIT-SIPI-SIPI.
When all APs have wakeup to execute AP t
Cc: Feng Tian
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jeff Fan
---
UefiCpuPkg/Library/MpInitLib/Ia32/MpEqu.inc | 2 ++
UefiCpuPkg/Library/MpInitLib/MpLib.c| 2 ++
UefiCpuPkg/Library/MpInitLib/MpLib.h| 2 ++
UefiCpuPkg/Library/M
I didn't mean to have extra delays. Am asking whether EDKII have to be updated
for 10ms reset recovery time regardless of port status to align with spec?
>From: Tian, Feng [mailto:feng.t...@intel.com]
>Sent: Sunday, November 13, 2016 7:46 PM
>To: Anbazhagan, Baraneedharan ; edk2-devel@lists.01.
Jiewen & Mike,
I just supplemented a patch to update PeiHobLib according to your suggestion.
Thanks,
Star
From: Yao, Jiewen
Sent: Monday, November 14, 2016 9:43 AM
To: Kinney, Michael D ; Zeng, Star
; edk2-devel@lists.01.org
Cc: Gao, Liming ; Zeng, Star
Subject: RE: [PATCH] MdeModulePkg DxeCore
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=205
Cc: Jiewen Yao
Cc: Liming Gao
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng
---
MdePkg/Library/PeiHobLib/HobLib.c | 66 ++-
1 file changed, 65 in
Hi Gary:
I see some warnings while running PatchChecy.py with this patch.
Please help to update the patch, run PatchCheck.py(BaseTools/Scripts) & re-send
the patch.
Thanks & Best regards
Chao Zhang
-Original Message-
From: Gary Lin [mailto:g...@suse.com]
Sent: Wednesday, October
Mike:
Per DSC spec, MaxSize supports all type PCDs. Here is one example in NT32Pkg
DSC file. Could you help update BinToPcd utility to remove MaxSize limitation
for VPD only?
[PcdsDynamicDefault.common.DEFAULT]
gEfiNt32PkgTokenSpaceGuid.PcdWinNtSerialPort|L"COM1!COM2"|VOID*|20
gEfiNt32PkgTo
Yes I just saw that difference in Spec.
I agree to remove the sfo support for -s and -l.
But I do not think we need to define new SFO table.
I think the V1 patch's implementation can satisfy caller's information needs.
For -s, displaying the variable content in SFO is to tell caller that the
exac
In V2, add comments on why uses __ prefix in enum type name.
For field name in structure, its first character should be upper case.
Cc: Michael Kinney
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao
---
MdePkg/Include/Base.h | 11 ---
1 file changed, 8
Comments below.
Thanks/Ray
> -Original Message-
> From: Shah, Tapan [mailto:tapands...@hpe.com]
> Sent: Saturday, November 12, 2016 1:21 AM
> To: Ni, Ruiyu ; edk2-devel@lists.01.org
> Cc: Chen, Chen A ; Carsey, Jaben
>
> Subject: RE: [PATCH] ShellPkg/dmpstore: Support "-sfo"
>
> Two com
The patch adds the "-sfo" support to "dmpstore" command.
When -l or -d is specified, -sfo is not supported.
When the variable specified by name and GUID cannot be found,
an error message is displayed; Otherwise, the SFO is displayed.
E.g.: "dmpstore -guid GuidThatDoesntExist -sfo" produces output
Hi, Baranee
Linux wait 10 + 40 ms (TRSTRCY = 10 ms, plus extra 40 ms). Do you mean EDKII
should be same with linux to wait more time?
Thanks
Feng
From: Anbazhagan, Baraneedharan [mailto:anbazha...@hp.com]
Sent: Sunday, November 13, 2016 11:53 AM
To: edk2-devel@lists.01.org; Tian, Feng
Subject:
Ah, yes. Definitely.
I think it is a good idea to catch such issue as early as possible.
Thank you
Yao Jiewen
From: Kinney, Michael D
Sent: Monday, November 14, 2016 9:41 AM
To: Yao, Jiewen ; Zeng, Star ;
edk2-devel@lists.01.org; Kinney, Michael D
Cc: Yao, Jiewen ; Gao, Liming ;
Zeng, Star
S
Yes. I think it is good to check in because it did fix an existing issue.
I suggest we describe the remaining issue honestly in our checkin log.
Thank you
Yao Jiewen
From: Fan, Jeff
Sent: Sunday, November 13, 2016 8:52 PM
To: Laszlo Ersek
Cc: edk2-de...@ml01.01.org; Yao, Jiewen ; Paolo Bonzini
Jiewen,
Do you think it would be a good idea to add a similar DEBUG()
message in the HobLib when an FV HOBs are created? There are
other ways FV HOBs can be created, so I think the DEBUG() message
in this patch is very important, but getting a message when
the an FV HOB is created will make fixi
Reviewed-by: Feng Tian
Thanks
Feng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jeff Fan
Sent: Friday, November 11, 2016 7:58 PM
To: edk2-de...@ml01.01.org
Subject: [edk2] [PATCH 0/2] Place APs to suitable state on Legacy OS boot
Currently, D
Reviewed-by: jiewen@intel.com
>
>
> -Original Message-
> From: Zeng, Star
> Sent: Friday, November 11, 2016 1:59 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Yao, Jiewen ;
> Gao, Liming
> Subject: [PATCH] MdeModulePkg DxeCore: Show error message on
> unaligned FvImage issue
>
Laszlo,
Thanks your testing. It seems that there is still some unknown issue existing.
I suggest to push this serial of patches firstly, because they have big
progress to solve the AP crashed issue in
https://bugzilla.tianocore.org/show_bug.cgi?id=216.
I could submit another bug to handle "AP
42 matches
Mail list logo