[edk2] [PATCH] SecurityPkg DxeTcg2PPLib: Lock Tcg2PhysicalPresenceFlags variable on S4

The code updates Tcg2PhysicalPresenceLibProcessRequest() to also lock Tcg2PhysicalPresenceFlags variable on S4. Cc: Jiewen Yao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- .../DxeTcg2PhysicalPresenceLib.c | 34 +++

Re: [edk2] [PATCH V2 0/4] Tcg2Dxe: Filter inactive digest in event2 log from PEI HOB

Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Star Zeng > Sent: Friday, November 18, 2016 1:58 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star > Subject: [edk2] [PATCH V2 0/4] Tcg2Dxe: Filter inactive di

[edk2] [Patch] MdeModulePkg/DxeNetLib: Allow the IPv4/prefix case when AsciiStrToIp4

This patch is used to allow the IPv4 with prefix case. Cc: Fu Siyuan Cc: Ye Ting Cc: Zhang Lubo Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiaxin Wu --- MdeModulePkg/Library/DxeNetLib/DxeNetLib.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff

Re: [edk2] [PATCH v3 1/5] MdeModulePkg: introduce non-discoverable device protocol

On 18 November 2016 at 06:13, Ni, Ruiyu wrote: > > > Regards, > Ray > >>-Original Message- >>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard >>Biesheuvel >>Sent: Friday, November 18, 2016 12:59 PM >>To: Ni, Ruiyu >>Cc: Kinney, Michael D ; edk2-devel@lists.01.or

Re: [edk2] [PATCH V2 0/4] Tcg2Dxe: Filter inactive digest in event2 log from PEI HOB

Serial Reviewed-by : Chao Zhang Thanks & Best regards Chao Zhang -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng Sent: Friday, November 18, 2016 1:58 PM To: edk2-devel@lists.01.org Cc: Zeng, Star Subject: [edk2] [PATCH V2 0/4] Tcg2

[edk2] [PATCH] MdeModulePkg/PiSmmCore: Cache CommunicationBuffer info before using it

gSmmCorePrivate->CommunicationBuffer and gSmmCorePrivate->BufferSize locate at runtime memory region. That means they could be modified by non-SMM code during runtime. We should cache them into SMM local variables before we verify them. After verification, we should use the cached ones directly in

Re: [edk2] [PATCH v3 1/5] MdeModulePkg: introduce non-discoverable device protocol

On 18 November 2016 at 05:24, Tian, Feng wrote: > Ard, > > I have another question. > > Is it the only way to specify device type in below enum? Looks like it will > be changed often. Is it possible to make use of DevicePath node? Of course, I > have no good idea to handle AMBA controller... >

Re: [edk2] [PATCH v3 1/5] MdeModulePkg: introduce non-discoverable device protocol

Regards, Ray >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard >Biesheuvel >Sent: Friday, November 18, 2016 12:59 PM >To: Ni, Ruiyu >Cc: Kinney, Michael D ; edk2-devel@lists.01.org; >Gao, Liming ; >af...@apple.com; Leif Lindholm >Subject:

[edk2] [PATCH V2 4/4] SecurityPkg Tcg2Dxe: Filter inactive digest in event2 log from PEI HOB

Cc: Jiewen Yao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 98 +-- 1 file changed, 94 insertions(+), 4 deletions(-) diff --git a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c b/

[edk2] [PATCH V2 0/4] Tcg2Dxe: Filter inactive digest in event2 log from PEI HOB

V2: Add PATCH 2/4 and 3/4. Add GetHashMaskFromAlgo() into Tpm2CommandLib. Update desc for param Buffer of GetDigestListSize(). Check if required digests in event2 log are reported and show error if not. PATCH 4/4 will consume GetHashMaskFromAlgo() that's why PATCH 2/4 added. Star Zeng (4): S

[edk2] [PATCH V2 3/4] SecurityPkg TPM2: Update desc for param Buffer of GetDigestListSize()

To make the description more clear, update the description for parameter Buffer of GetDigestListSize() to "Buffer to hold copied TPML_DIGEST_VALUES compact binary.". Cc: Jiewen Yao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- SecurityPkg/I

[edk2] [PATCH V2 1/4] SecurityPkg TPM2: Make IsHashAlgSupportedInHashAlgorithmMask external

Current IsHashAlgSupportedInHashAlgorithmMask is only an internal function, this patch makes it external for coming consumer. Cc: Jiewen Yao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng Reviewed-by: Jiewen Yao --- SecurityPkg/Include/Library/

[edk2] [PATCH V2 2/4] SecurityPkg TPM2: Add GetHashMaskFromAlgo() into Tpm2CommandLib

Add GetHashMaskFromAlgo() into Tpm2CommandLib for coming consumer. Cc: Jiewen Yao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- SecurityPkg/Include/Library/Tpm2CommandLib.h | 13 ++ SecurityPkg/Library/Tpm2CommandLib/Tpm2Help.c | 3

Re: [edk2] [PATCH] SecurityPkg Tcg2Pei: Add comments into LogHashEvent()

Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Friday, November 18, 2016 1:43 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen ; > Zhang, Chao B > Subject: [PATCH] SecurityPkg Tcg2Pei: Add comments into LogHashEvent() > > Add comments int

[edk2] [PATCH] SecurityPkg Tcg2Pei: Add comments into LogHashEvent()

Add comments into LogHashEvent() to describe the usage of GetDigestListSize (DigestList). Cc: Jiewen Yao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 4 1 file changed, 4 insertions(+) diff --git a

Re: [edk2] [PATCH v3 1/5] MdeModulePkg: introduce non-discoverable device protocol

Ard, I have another question. Is it the only way to specify device type in below enum? Looks like it will be changed often. Is it possible to make use of DevicePath node? Of course, I have no good idea to handle AMBA controller... +// +// Data Types +// +typedef enum { + NonDiscoverableDevice

[edk2] [PATCH v2] MdePkg IndustryStandard: Add DDR3, DDR4 and LPDDR definition per SPD spec

https://bugzilla.tianocore.org/show_bug.cgi?id=201 In V2, separate DDR3, DDR4 and LPDDR definition into the different files; use the different SPD prefix as structure definitions for each SPD type. Cc: Giri P Mudusuru Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Liming

Re: [edk2] [PATCH] BaseTools: Skip module AutoGen by comparing timestamp.

Thanks for your contribution. I will review it and do some verification. May give comment later. Best Regards, Zhu Yonghong -Original Message- From: Derek Lin [mailto:derek.l...@hpe.com] Sent: Friday, November 18, 2016 10:30 AM To: edk2-devel@lists.01.org Cc: derek.l...@hpe.com; Zhu, Yo

Re: [edk2] EDK2 master build failure

In Misc.py, it import string class. But, in the same directory, there is source file String.py. Seemly, python interpreter wrongly imports String.py and cause this issue. This issue may happen on the case insensitive file system. We meet with such issue before. We set up virtual machine on wind

Re: [edk2] [PATCH v3 1/5] MdeModulePkg: introduce non-discoverable device protocol

On 18 November 2016 at 02:11, Ni, Ruiyu wrote: > > > Regards, > Ray > >>-Original Message- >>From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >>Sent: Thursday, November 17, 2016 6:43 PM >>To: Ni, Ruiyu >>Cc: Kinney, Michael D ; edk2-devel@lists.01.org; >>Gao, Liming ; >>af...@appl

Re: [edk2] [Patch] OvmfPkg AcpiTables: Use PcdDebugIoPort to describe QEMU debug console

Lin: Please run . edksetup.sh --reconfig to reset your local configure files. Thanks Liming > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Gary Lin > Sent: Friday, November 18, 2016 11:43 AM > To: Gao, Liming ; Laszlo Ersek > Cc: edk2-d

Re: [edk2] [Patch] OvmfPkg AcpiTables: Use PcdDebugIoPort to describe QEMU debug console

On Wed, Nov 16, 2016 at 10:10:07AM +0800, Liming Gao wrote: > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Liming Gao Hi Liming and Laszlo, I failed to compile OVMF after applying this patch: "iasl" -p/home/gary/git/edk2/Build/OvmfX64/DEBUG_GCC5

Re: [edk2] [PATCH] PcAtChipsetPkg/PcRtc: Handle NULL table entry in RSDT/XSDT

I agree to use FADT in commit log. I got the reason why "Table = 0;" needs. With that commit log updated, Reviewed-by: Star Zeng Thanks, Star -Original Message- From: Ni, Ruiyu Sent: Friday, November 18, 2016 9:59 AM To: Zeng, Star ; edk2-devel@lists.01.org Cc: sean.bro...@microsoft.com

[edk2] [PATCH] BaseTools: Skip module AutoGen by comparing timestamp.

[Introduction] The BaseTool Build.py AutoGen parse INF meta-file and generate AutoGen.c/AutoGen.h/makefile. When we only change .c .h code, the AutoGen might be not necessary, but Build.py spend a lot of time on it. There's a -u flag to skip all module's AutoGen. In my environment, it save 35%~50%

Re: [edk2] [PATCH] SecurityPkg Tcg2Dxe: Get correct digest list size

Yes, that is correct. I misunderstand the patch. Reviewed-by: jiewen@intel.com At same time, I would recommend we update PEI with comment on why we can use GetDigestListSize (DigestList) in PEI, but not use GetDigestListSize in DXE, because people may compare th

Re: [edk2] [PATCH v3 1/5] MdeModulePkg: introduce non-discoverable device protocol

Regards, Ray >-Original Message- >From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >Sent: Thursday, November 17, 2016 6:43 PM >To: Ni, Ruiyu >Cc: Kinney, Michael D ; edk2-devel@lists.01.org; >Gao, Liming ; >af...@apple.com; Leif Lindholm >Subject: Re: [edk2] [PATCH v3 1/5] MdeM

Re: [edk2] [PATCH] PcAtChipsetPkg/PcRtc: Handle NULL table entry in RSDT/XSDT

Regards, Ray >-Original Message- >From: Zeng, Star >Sent: Thursday, November 17, 2016 6:55 PM >To: Ni, Ruiyu ; edk2-devel@lists.01.org >Cc: sean.bro...@microsoft.com; Zeng, Star >Subject: RE: [edk2] [PATCH] PcAtChipsetPkg/PcRtc: Handle NULL table entry in >RSDT/XSDT > >Hi Ray, > >Add t

Re: [edk2] [PATCH 2/2] SecurityPkg Tcg2Dxe: Filter inactive digest in event2 log from PEI HOB

That's good idea. I like both. :) From: Zeng, Star Sent: Friday, November 18, 2016 9:31 AM To: Yao, Jiewen ; edk2-devel@lists.01.org Cc: Zhang, Chao B ; Zeng, Star Subject: Re: [edk2] [PATCH 2/2] SecurityPkg Tcg2Dxe: Filter inactive digest in event2 log from PEI HOB On 2016/11/17 20:19, Yao, Ji

Re: [edk2] [PATCH 2/2] SecurityPkg Tcg2Dxe: Filter inactive digest in event2 log from PEI HOB

On 2016/11/17 20:19, Yao, Jiewen wrote: Hi Star 1) I am a little confused on below description. + @param[in,out] Buffer Buffer to hold TPML_DIGEST_VALUES. I think the buffer is the *TPML_DIGEST_VALUES compact binary buffer*, instead of *TPML_DIGEST_VALUES*, right? I suggest we desc

Re: [edk2] [Patch v2 0/3] MdePkg/BaseSynchronizationLib: Add volatile

Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Michael Kinney Sent: Friday, November 18, 2016 3:35 AM To: edk2-devel@lists.01.org Subject: [edk2] [Patch v2 0/3] MdePkg/BaseSynchronizationLib: Add volatile Updates for V2

Re: [edk2] [PATCH] SecurityPkg Tcg2Dxe: Get correct digest list size

On 2016/11/17 20:32, Yao, Jiewen wrote: Hi star I am sorry that I am confused on this patch. 1) Below update is not related to the GIT message. I think there is nothing wrong with previous code. May I know if you observe something? The following GetDigestListBinSize (DigestBuffer) needs *Dige

Re: [edk2] [Patch v2 0/2] Fix ACPI S3 resume failure with GCC 5.4

Reviewed-by: Jeff Fan Thanks! -Original Message- From: Kinney, Michael D Sent: Friday, November 18, 2016 5:19 AM To: edk2-devel@lists.01.org Cc: Gao, Liming; Laszlo Ersek; Andrew Fish; Fan, Jeff Subject: [Patch v2 0/2] Fix ACPI S3 resume failure with GCC 5.4 Add volatile qualifier to m

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpu: Check XdSupport before set NX.

Reviewed-by: Jeff Fan -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, November 17, 2016 11:58 PM To: Yao, Jiewen; edk2-de...@ml01.01.org Cc: Kinney, Michael D; Fan, Jeff Subject: Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpu: Check XdSupport before set NX. On 1

Re: [edk2] [Patch v2 0/2] Fix ACPI S3 resume failure with GCC 5.4

On 11/17/16 22:19, Michael Kinney wrote: > Add volatile qualifier to mNumberToFinish to prevent GCC 5.4 > compiler from optimizing away required logic in ACPI S3 resume. > > Update TransferApToSafeState() use UINTN params to reduce the > number of type casts required in these calls and change > th

[edk2] [Patch v2 0/2] Fix ACPI S3 resume failure with GCC 5.4

Add volatile qualifier to mNumberToFinish to prevent GCC 5.4 compiler from optimizing away required logic in ACPI S3 resume. Update TransferApToSafeState() use UINTN params to reduce the number of type casts required in these calls and change the NumberToFinish parameter from UINT32* to UINTN Numb

[edk2] [Patch v2 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: TransferApToSafeState() use UINTN params

Update TransferApToSafeState() use UINTN params to reduce the number of type casts required in these calls. Also change the NumberToFinish parameter from UINT32* to UINTN NumberToFinishAddress to resolve issues with conversion from a volatile pointer to a non-volatile pointer. The assembly code t

[edk2] [Patch v2 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Add volatile to mNumberToFinish

Add volatile qualifier to mNumberToFinish to prevent GCC 5.4 compiler from optimizing away required logic in ACPI S3 resume. Cc: Liming Gao Cc: Laszlo Ersek Cc: Andrew Fish Cc: Jeff Fan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney --- UefiCpuPkg/PiSmm

Re: [edk2] [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add volatile to mNumberToFinish

Laszlo, I redid some tests using the following as you suggested, and it works. TransferApToSafeState ((UINTN)mApHltLoopCode, TopOfStack, (UINTN)&mNumberToFinish); So I will use this style in V2. Mike > -Original Message- > From: Kinney, Michael D > Sent: Thursday, November 17, 2016

[edk2] EDK2 master build failure

Hi EDK2 experts, I have just rebased my code on the latest EDK2 master branch and now when I am trying to compile the same I am getting the following errors (for my ARMv8 build): # ./build.sh RELEASE clean; ./build.sh RELEASE .. Welcome to LS1043A UEFI Bui

Re: [edk2] [Patch v2 0/3] MdePkg/BaseSynchronizationLib: Add volatile

On 11/17/16 20:34, Michael Kinney wrote: > Updates for V2 > == > * Split out patch that corrects function names in comment blocks > * Change InterlockedCompareExchangePointer() parameter from volatile VOID** > to VOID * volatile *. > * Remove unnessary typecast in calls to Interlocked

Re: [edk2] [PATCH 2/2] IntelFsp2Pkg: Use FspSiliconInitDone2 API for the Notify Phase Use FspSiliconInitDone2 API (with error status handling) for the Notify Phase

Correcting the edk2 mailing list. > -Original Message- > From: Mudusuru, Giri P > Sent: Thursday, November 17, 2016 11:33 AM > To: Thomaiyar, Richard Marian ; ed2- > de...@lists.01.org > Cc: Ma, Maurice ; Yao, Jiewen > > Subject: RE: [PATCH 2/2] IntelFsp2Pkg: Use FspSiliconInitDone2 API f

[edk2] [Patch v2 1/3] MdePkg/Include: Add volatile to SynchronizationLib parameters

The SpinLock functions in the SynchronicationLib use volatile parameters to keep compiler from optimizing these functions too much. The volatile keyword is missing from the Interlocked*() functions in this same library class. Update the library class to consistently use volatile on all functions

[edk2] [Patch v2 0/3] MdePkg/BaseSynchronizationLib: Add volatile

Updates for V2 == * Split out patch that corrects function names in comment blocks * Change InterlockedCompareExchangePointer() parameter from volatile VOID** to VOID * volatile *. * Remove unnessary typecast in calls to InterlockedCompareExchangePointer() * Fix missing copyright upda

[edk2] [Patch v2 3/3] MdePkg/BaseSynchronizationLib: Fix function names in function headers

Some of the function names in function header comment blocks in assembly files do not match the symbol name in the assembly sources. Update function header comment blocks to match symbol name. Cc: Liming Gao Cc: Laszlo Ersek Cc: Andrew Fish Cc: Jeff Fan Contributed-under: TianoCore Contributio

[edk2] [Patch v2 2/3] MdePkg/BaseSynchronizationLib: Add volatile Interlocked*() APIs

The SpinLock functions in the SynchronicationLib use volatile parameters to keep compiler from optimizing these functions too much. The volatile keyword is missing from the Interlocked*() functions in this same library instance. Update the library instance to consistently use volatile on all func

Re: [edk2] [PATCH] IntelFsp2Pkg: Use FspSiliconInitDone2 API

Reviewed-by: Giri P Mudusuru > -Original Message- > From: Thomaiyar, Richard Marian > Sent: Wednesday, November 16, 2016 1:47 AM > To: edk2-devel@lists.01.org > Cc: Ma, Maurice ; Yao, Jiewen > ; Mudusuru, Giri P ; > Thomaiyar, Richard Marian > Subject: [PATCH] IntelFsp2Pkg: Use FspSilic

Re: [edk2] [Patch 2/2] MdePkg/BaseSynchronizationLib: Add volatile Interlocked*() APIs

Laszlo, I agree. I will do a different patch to fix the function names in comments. Mike > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, November 17, 2016 8:02 AM > To: Kinney, Michael D ; edk2-de...@ml01.01.org > Cc: Gao, Liming ; Andrew Fish ; Fa

Re: [edk2] [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add volatile to mNumberToFinish

Laszlo, Yes. I can split. I will send V2 with your feedback. For the following line, the cast to (VOID *) before cast to (UINTN) was required to pass VS build. Since mNumberToFinish is a volatile pointer, it needs to be cast to a non-volatile pointer before the pointer can be converted to an u

Re: [edk2] [PATCH] IntelSiliconPkg/IntelSiliconPkg.dec: drop bogus semicolon from GUID def

On 11/17/16 15:27, Mudusuru, Giri P wrote: > Thank you for fixing it. > Reviewed-by: Giri P Mudusuru Thanks! I was eager and already committed it with Jiewen's R-b. Cheers! Laszlo >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Thursday, November 17, 2016

Re: [edk2] OVMF: cross-filesystem copy broken? ("The source and destination are the same")

On 11/17/16 16:24, Bruce Cran wrote: > On 11/17/2016 2:35 AM, Laszlo Ersek wrote: > >> There's a patch on the list for said BZ: >> [edk2] [PATCH v2] API PathRemoveLastItem not handle root paths properly >> >> so if the BZ is indeed what you're encountering, then the patch should >> fix it for you.

Re: [edk2] [Patch 2/2] MdePkg/BaseSynchronizationLib: Add volatile Interlocked*() APIs

On 11/17/16 16:55, Kinney, Michael D wrote: > Laszlo, > > Thanks for the feedback. I will update and send V2. > > I did not change the names of any functions. The comment > blocks had names that did not match the name of the function, > so I was only fixing the comment. Ah! Thank you. That's

Re: [edk2] [PATCH V2] Add 4K PE alignment to enable SMM page level protection.

On 11/17/16 14:40, Jiewen Yao wrote: > Tested boot with below configuration: > IA32 > IA32X64 > X64 > > Tested boot with XD enabled/disabled. > > Requested-by: Laszlo Ersek > Cc: Jordan Justen > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jiewen

Re: [edk2] [PATCH] UefiCpuPkg/PiSmmCpu: Check XdSupport before set NX.

On 11/17/16 14:33, Jiewen Yao wrote: > When XD is not supported, the BIT63 is reserved. > We should not set BIT63 in the page table. > > Test OVMF IA32/IA32X64 with XD enabled/disabled. > > Analyzed-by: Laszlo Ersek > Cc: Laszlo Ersek > Cc: Jeff Fan > Cc: Michael D Kinney > Cc: Laszlo Ersek

Re: [edk2] [Patch 2/2] MdePkg/BaseSynchronizationLib: Add volatile Interlocked*() APIs

Laszlo, Thanks for the feedback. I will update and send V2. I did not change the names of any functions. The comment blocks had names that did not match the name of the function, so I was only fixing the comment. Mike > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.c

Re: [edk2] OVMF: cross-filesystem copy broken? ("The source and destination are the same")

On 11/17/2016 2:35 AM, Laszlo Ersek wrote: There's a patch on the list for said BZ: [edk2] [PATCH v2] API PathRemoveLastItem not handle root paths properly so if the BZ is indeed what you're encountering, then the patch should fix it for you. Can you please test it and report back in that threa

Re: [edk2] [PATCH] IntelSiliconPkg/IntelSiliconPkg.dec: drop bogus semicolon from GUID def

Thank you for fixing it. Reviewed-by: Giri P Mudusuru > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, November 17, 2016 2:37 AM > To: edk2-devel-01 > Cc: Mudusuru, Giri P ; Yao, Jiewen > > Subject: [PATCH] IntelSiliconPkg/IntelSiliconPkg.dec: drop

Re: [edk2] [PATCH] IntelSiliconPkg/IntelSiliconPkg.dec: drop bogus semicolon from GUID def

On 11/17/16 13:04, Yao, Jiewen wrote: > Reviewed-by: jiewen@intel.com Thanks! Commit 2048ab4b3ec9. Laszlo > >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Laszlo Ersek >> Sent: Thursday, November 17, 2016 6:37 PM >> To: edk2-devel-

Re: [edk2] [PATCH] OvmfPkg/dsc: enable SMM page level protection.

Both patches are submitted. I will discuss with Jeff tomorrow to see how we can improve the debug message. -- "Stack Overflow" for "XD page fault" is definitely a misreport. :( Thank you Yao Jiewen From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yao, Jiewen Sent: Thursday

[edk2] [PATCH V2] Add 4K PE alignment to enable SMM page level protection.

Tested boot with below configuration: IA32 IA32X64 X64 Tested boot with XD enabled/disabled. Requested-by: Laszlo Ersek Cc: Jordan Justen Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- OvmfPkg/OvmfPkgIa32.dsc| 5 + OvmfPkg/OvmfP

[edk2] [PATCH] UefiCpuPkg/PiSmmCpu: Check XdSupport before set NX.

When XD is not supported, the BIT63 is reserved. We should not set BIT63 in the page table. Test OVMF IA32/IA32X64 with XD enabled/disabled. Analyzed-by: Laszlo Ersek Cc: Laszlo Ersek Cc: Jeff Fan Cc: Michael D Kinney Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 S

Re: [edk2] [PATCH] OvmfPkg/dsc: enable SMM page level protection.

Yes, Laszlo. You are right. Thanks to catch this. I will 1) Submit a new patch to fix XD issue. 2) Submit V2 patch for OVMF. From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, November 17, 2016 8:18 PM To: Yao, Jiewen ; edk2-de...@ml01.01.org Cc: Justen, Jordan L Subject: Re: [edk2] [

Re: [edk2] [PATCH] SecurityPkg Tcg2Dxe: Get correct digest list size

Hi star I am sorry that I am confused on this patch. 1) Below update is not related to the GIT message. I think there is nothing wrong with previous code. May I know if you observe something? > -DigestBuffer = CopyDigestListToBuffer (DigestBuffer, DigestList, > mTcgDxeData.BsCap.ActivePc

Re: [edk2] [PATCH 1/2] SecurityPkg TPM2: Make IsHashAlgSupportedInHashAlgorithmMask external

Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Thursday, November 17, 2016 5:29 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen ; > Zhang, Chao B > Subject: [PATCH 1/2] SecurityPkg TPM2: Make > IsHashAlgSupportedInHashAlgorithmMask extern

Re: [edk2] [PATCH 2/2] SecurityPkg Tcg2Dxe: Filter inactive digest in event2 log from PEI HOB

Hi Star 1) I am a little confused on below description. + @param[in,out] Buffer Buffer to hold TPML_DIGEST_VALUES. I think the buffer is the *TPML_DIGEST_VALUES compact binary buffer*, instead of *TPML_DIGEST_VALUES*, right? I suggest we describe it clearly. 2) I think the FILTER is

Re: [edk2] [PATCH] OvmfPkg/dsc: enable SMM page level protection.

On 11/17/16 09:21, Jiewen Yao wrote: > Add 4K PE alignment to enable SMM page level protection. > > Tested boot with below configuration: > IA32 > IA32X64 > X64 > > Requested-by: Laszlo Ersek > Cc: Jordan Justen > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.0 > Sig

Re: [edk2] [PATCH V2] SecurityPkg TPM2: Assign real copied count in CopyDigestListToBuffer()

Reviewed-by: jiewen@intel.com > -Original Message- > From: Zeng, Star > Sent: Thursday, November 17, 2016 4:06 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Yao, Jiewen ; > Zhang, Chao B > Subject: [PATCH V2] SecurityPkg TPM2: Assign real copied count in > CopyDigestListToBuffer

Re: [edk2] [PATCH] IntelSiliconPkg/IntelSiliconPkg.dec: drop bogus semicolon from GUID def

Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Thursday, November 17, 2016 6:37 PM > To: edk2-devel-01 > Cc: Yao, Jiewen > Subject: [edk2] [PATCH] IntelSiliconPkg/IntelSiliconPkg.dec:

Re: [edk2] [PATCH V3 0/6] Enable SMM page level protection.

Oops, my bad. Thank you for check in that for me. Thank you Yao Jiewen From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: Thursday, November 17, 2016 5:55 PM To: Yao, Jiewen ; Kinney, Michael D ; Fan, Jeff ; edk2-devel@lists.01.org Cc: Paolo Bonzini ; Tian, Feng ; Zeng, Star Subject: Re: [e

Re: [edk2] [PATCH] PcAtChipsetPkg/PcRtc: Handle NULL table entry in RSDT/XSDT

Hi Ray, Add two minor comments inline. Thanks, Star > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Monday, November 14, 2016 1:26 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH] PcAtChipsetPkg/PcRtc: Handle NULL

Re: [edk2] [PATCH v3 1/5] MdeModulePkg: introduce non-discoverable device protocol

> On 17 Nov 2016, at 08:52, Ni, Ruiyu wrote: > > > > Thanks/Ray > >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Ard Biesheuvel >> Sent: Thursday, November 17, 2016 2:07 PM >> To: Ni, Ruiyu >> Cc: Kinney, Michael D ; edk2- >> de...@

[edk2] [PATCH] IntelSiliconPkg/IntelSiliconPkg.dec: drop bogus semicolon from GUID def

The DEC spec doesn't allow the trailing semicolon: 2.6 [Guids] Usage GuidCName = {C Format Guid Value} # Comment Cc: Giri P Mudusuru Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek --- IntelSiliconPkg/IntelSiliconPkg.dec | 2 +- 1 file c

Re: [edk2] [Patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add volatile to mNumberToFinish

On 11/17/16 06:34, Michael Kinney wrote: > Add volatile qualifier to mNumberToFinish to prevent compiler > optimization. Also update TransferApToSafeState() to pass in > UINTN values and treat the mNumberToFinish as an address value > that is passed to the assembly code. Is it possible to split t

Re: [edk2] [PATCH 4/4] UefiCpuPkg/MpInitLib: support 64-bit AP stack addresses

On 11/17/16 02:18, Fan, Jeff wrote: > Laszlo, > > We have two solutions to fix stack > 4G issue. > 1. Allocate AP stack buffer and all CPU MP data buffer under < 4G at the > beginning. > 2. Support AP stack buffer and all CPU MP data buffer > 4G as showed in your > patch. > > For 1), it seems n

Re: [edk2] [PATCH V3 0/6] Enable SMM page level protection.

Jiewen, On 11/17/16 02:36, Yao, Jiewen wrote: > You are right. That is good suggestion to mention it. I will add. > > Thank you > Yao Jiewen You forgot to commit patch #1 from the series, and the build is now broken. ... I have now committed patch #1 for you, with the following commit message m

Re: [edk2] OVMF: cross-filesystem copy broken? ("The source and destination are the same")

On 11/17/16 04:11, Bruce Cran wrote: > I don't know if this is a known issue, but it appears that > cross-filesystem copies no longer work. I'm running OVMF X64 built from > git commit a0426207c133bdf40c42561f26c20c4b3114d8f9. I've tried copying > between filesystems in various ways - with the cur

[edk2] [PATCH 0/2] Tcg2Dxe: Filter inactive digest in event2 log from PEI HOB

Star Zeng (2): SecurityPkg TPM2: Make IsHashAlgSupportedInHashAlgorithmMask external SecurityPkg Tcg2Dxe: Filter inactive digest in event2 log from PEI HOB SecurityPkg/Include/Library/Tpm2CommandLib.h | 16 ++ SecurityPkg/Library/Tpm2CommandLib/Tpm2Help.c | 1 + SecurityPkg/Tcg/Tcg2Dxe/

[edk2] [PATCH 1/2] SecurityPkg TPM2: Make IsHashAlgSupportedInHashAlgorithmMask external

Current IsHashAlgSupportedInHashAlgorithmMask is only an internal function, this patch makes it external for coming consumer. Cc: Jiewen Yao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- SecurityPkg/Include/Library/Tpm2CommandLib.h | 16 ++

[edk2] [PATCH 2/2] SecurityPkg Tcg2Dxe: Filter inactive digest in event2 log from PEI HOB

Cc: Jiewen Yao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 80 +-- 1 file changed, 76 insertions(+), 4 deletions(-) diff --git a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c b/

[edk2] [PATCH] SecurityPkg Tcg2Dxe: Get correct digest list size

Current code uses GetDigestListSize(DigestList) to get digest list size, that is incorrect. The code should get digest list size of digests copied into event2 log, those digests are compacted, so GetDigestListBinSize() should be used. Cc: Jiewen Yao Cc: Chao Zhang Contributed-under: TianoCore Co

Re: [edk2] [Patch 2/2] MdePkg/BaseSynchronizationLib: Add volatile Interlocked*() APIs

On 11/17/16 05:53, Michael Kinney wrote: > The SpinLock functions in the SynchronicationLib use volatile > parameters to keep compiler from optimizing these functions > too much. The volatile keyword is missing from the Interlocked*() > functions in this same library instance. Update the library

Re: [edk2] [Patch 1/2] MdePkg/Include: Add volatile to SynchronizationLib parameters

On 11/17/16 05:53, Michael Kinney wrote: > The SpinLock functions in the SynchronicationLib use volatile > parameters to keep compiler from optimizing these functions > too much. The volatile keyword is missing from the Interlocked*() > functions in this same library class. Update the library cla

Re: [edk2] [PATCH] IntelSiliconPkg: Add DxeSmbiosDataHobLib

Reviewed-by: jiewen@intel.com > -Original Message- > From: Mudusuru, Giri P > Sent: Monday, November 14, 2016 3:27 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Zeng, Star ; > Kinney, Michael D > Subject: [edk2][PATCH] IntelSiliconPkg: Add DxeSmbiosDataHobLib > > Added NULL Li

Re: [edk2] [Patch 2/2] SecurityPkg OpalPasswordDxe: Clean PSID buffer.

Reviewed-by: jiewen@intel.com > -Original Message- > From: Dong, Eric > Sent: Wednesday, November 16, 2016 2:16 PM > To: edk2-devel@lists.01.org > Cc: Tian, Feng ; Yao, Jiewen > Subject: [Patch 2/2] SecurityPkg OpalPasswordDxe: Clean PSID buffer. > > Change callback handler type to a

Re: [edk2] [Patch 1/2] SecurityPkg OpalPasswordDxe: Clean password buffer.

Reviewed-by: jiewen@intel.com > -Original Message- > From: Dong, Eric > Sent: Wednesday, November 16, 2016 2:15 PM > To: edk2-devel@lists.01.org > Cc: Tian, Feng ; Yao, Jiewen > Subject: [Patch 1/2] SecurityPkg OpalPasswordDxe: Clean password buffer. > > Cc: Feng Tian > Cc: Jiewen Y

[edk2] [PATCH] OvmfPkg/dsc: enable SMM page level protection.

Add 4K PE alignment to enable SMM page level protection. Tested boot with below configuration: IA32 IA32X64 X64 Requested-by: Laszlo Ersek Cc: Jordan Justen Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- OvmfPkg/OvmfPkgIa32.dsc| 4 +

Re: [edk2] [PATCH] SecurityPkg TPM2: Assign real copied count in CopyDigestListToBuffer()

Chao, Great comments, just sent out V2 patch, please help review it. Thanks, Star -Original Message- From: Zhang, Chao B Sent: Thursday, November 17, 2016 11:19 AM To: Zeng, Star ; edk2-devel@lists.01.org Cc: Yao, Jiewen Subject: RE: [PATCH] SecurityPkg TPM2: Assign real copied count in

[edk2] [PATCH V2] SecurityPkg TPM2: Assign real copied count in CopyDigestListToBuffer()

In CopyDigestListToBuffer() of Tpm2CommandLib, the count in returned Buffer should be real copied DigestList count. Cc: Jiewen Yao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- SecurityPkg/Library/Tpm2CommandLib/Tpm2Help.c | 7 ++- 1 fi