Re: [edk2] [PATCH] SecurityPkg Tcg2Dxe: ASSERT to ensure 'VarData' is not NULL

2016-11-20 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Wu, Hao A > Sent: Monday, November 21, 2016 3:53 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Yao, Jiewen ; > Zhang, Chao B > Subject: [PATCH] SecurityPkg Tcg2Dxe: ASSERT to ensure 'VarData' is not > NULL > > The logic

Re: [edk2] [PATCH] SecurityPkg TcgStorageCoreLib: ASSERT to ensure 'ByteSeq' is not NULL

2016-11-20 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Hao Wu > Sent: Monday, November 21, 2016 3:52 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Tian, Feng ; > Dong, Eric > Subject: [edk2] [PATCH] SecurityPk

Re: [edk2] [PATCH v2] MdeModulePkg CapsuleApp: ASSERT to ensure 'CapsuleIndex' is not NULL

2016-11-20 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: Wu, Hao A > Sent: Monday, November 21, 2016 3:50 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Yao, Jiewen > Subject: [PATCH v2] MdeModulePkg CapsuleApp: ASSERT to ensure > 'CapsuleIndex' is not NULL > > Function GetVari

[edk2] [PATCH] SecurityPkg Tcg2Dxe: ASSERT to ensure 'VarData' is not NULL

2016-11-20 Thread Hao Wu
The logic in functions ReadAndMeasureVariable() and MeasureVariable() within Tcg2Dxe ensure that 'VarData' will not be NULL before calling TcgDxeHashLogExtendEvent() at line 1716. This commit adds ASSERT as warnings for the case that will not happen. Cc: Jiewen Yao Cc: Chao Zhang Contributed-un

[edk2] [PATCH] SecurityPkg TcgStorageCoreLib: ASSERT to ensure 'ByteSeq' is not NULL

2016-11-20 Thread Hao Wu
Add ASSERT to make sure 'ByteSeq' is not NULL before comsumed by CopyMem(). Cc: Eric Dong Cc: Feng Tian Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a

[edk2] [PATCH v2] MdeModulePkg CapsuleApp: ASSERT to ensure 'CapsuleIndex' is not NULL

2016-11-20 Thread Hao Wu
Function GetVariable2() ensures its third (output) parameter will not be NULL when the return status is EFI_SUCCESS. This commit adds ASSERT as warnings for the case that will not happen. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- MdeModule

Re: [edk2] [PATCH] BaseTools: Skip module AutoGen by comparing timestamp.

2016-11-20 Thread Lin, Derek (HPS UEFI Dev)
Hi Yonghong, Thanks for review. I just sent a patch v2 to fix them. Thanks, Derek -Original Message- From: Zhu, Yonghong [mailto:yonghong@intel.com] Sent: Saturday, November 19, 2016 9:43 PM To: Lin, Derek (HPS UEFI Dev) ; 'edk2-devel@lists.01.org' Cc: Gao, Liming ; Zhu, Yonghong

[edk2] [PATCH v2] BaseTools: Skip module AutoGen by comparing timestamp.

2016-11-20 Thread Derek Lin
[Introduction] The BaseTool Build.py AutoGen parse INF meta-file and generate AutoGen.c/AutoGen.h/makefile. When we only change .c .h code, the AutoGen might be not necessary, but Build.py spend a lot of time on it. There's a -u flag to skip all module's AutoGen. In my environment, it save 35%~50%

Re: [edk2] [Patch 00/10] Enable BlockSid related PP actions.

2016-11-20 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Eric Dong > Sent: Wednesday, November 16, 2016 2:01 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [Patch 00/10] Enable BlockSid related PP actions. > > TC

Re: [edk2] [PATCH v2] MdeModulePkg/DxeCapsuleLibFmp: Use AllocatePool for CapsuleResultVariable

2016-11-20 Thread Yao, Jiewen
Reviewed-by: jiewen@intel.com > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Dandan Bi > Sent: Monday, November 21, 2016 9:49 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > Subject: [edk2] [PATCH v2] MdeModulePkg/DxeCapsuleLibFmp:

[edk2] [PATCH v2] MdeModulePkg/DxeCapsuleLibFmp: Use AllocatePool for CapsuleResultVariable

2016-11-20 Thread Dandan Bi
V2: Add check for the result of AllocatePool function. Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Library/DxeCapsuleLibFmp/DxeCapsuleReportLib.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git

Re: [edk2] [patch] MdeModulePkg/DxeCapsuleLibFmp: Use AllocatePool for CapsuleResultVariable

2016-11-20 Thread Bi, Dandan
Yes, that's right! I will update it. Thanks! Thanks, Dandan -Original Message- From: Yao, Jiewen Sent: Monday, November 21, 2016 9:29 AM To: Bi, Dandan ; edk2-devel@lists.01.org Cc: Yao, Jiewen Subject: RE: [edk2] [patch] MdeModulePkg/DxeCapsuleLibFmp: Use AllocatePool for CapsuleResul

Re: [edk2] [patch] MdeModulePkg/DxeCapsuleLibFmp: Use AllocatePool for CapsuleResultVariable

2016-11-20 Thread Yao, Jiewen
Thanks. I think we should check allocation result to see if it is NULL. + CapsuleResultVariable = AllocatePool (CapsuleResultVariableSize); + CapsuleResultVariableHeader = (VOID *)CapsuleResultVariable; Thank you Yao Jiewen > -Original Message- > From: edk2-devel [mailto:edk2-devel-bo

[edk2] [patch] MdeModulePkg/DxeCapsuleLibFmp: Use AllocatePool for CapsuleResultVariable

2016-11-20 Thread Dandan Bi
Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Library/DxeCapsuleLibFmp/DxeCapsuleReportLib.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleRepor

[edk2] [PATCH] ArmPkg/ArmMmuLib: support page tables in cacheable memory only

2016-11-20 Thread Ard Biesheuvel
Translation table walks are always cache coherent on ARMv8-A, so cache maintenance on page tables is never needed. Since there is a risk of loss of coherency when using mismatched attributes, and given that memory is mapped cacheable except for extraordinary cases (such as non-coherent DMA), restri