Reviewed-by: Ye Ting
-Original Message-
From: Wu, Jiaxin
Sent: Wednesday, December 14, 2016 4:05 PM
To: edk2-devel@lists.01.org
Cc: Long, Qin ; Ni, Ruiyu ; Ye, Ting
; Fu, Siyuan ; Zhang, Lubo
; Thomas Palmer ; Yao, Jiewen
; Wu, Jiaxin
Subject: [PATCH v2 10/10] Nt32Pkg: Enable HTTPS
Reviewed-by: Ye Ting
-Original Message-
From: Wu, Jiaxin
Sent: Wednesday, December 14, 2016 3:34 PM
To: edk2-devel@lists.01.org
Cc: Long, Qin ; Ni, Ruiyu ; Ye, Ting
; Fu, Siyuan ; Zhang, Lubo
; Thomas Palmer ; Wu, Jiaxin
Subject: [Patch 09/10] Nt32Pkg/Nt32Pkg.dsc: Remove the flag fo
Reviewed-by: Ye Ting
-Original Message-
From: Wu, Jiaxin
Sent: Wednesday, December 14, 2016 3:34 PM
To: edk2-devel@lists.01.org
Cc: Ye, Ting ; Fu, Siyuan ; Zhang, Lubo
; Long, Qin ; Thomas Palmer
; Wu, Jiaxin
Subject: [Patch 08/10] NetworkPkg/NetworkPkg.dsc: Enable TlsDxe and
TlsAut
Hi Jiaxin,
Some comments included below.
1. In TlsConfigCertificate, HttpInstance->TlsConfigData.CACert is not used and
local variable "CACert" is not freed after calling TlsConfiguration->SetData.
2. In TlsConfigureSession, several gotos are useless. Suggest to replace with
return status direc
According to UEFI spec, capsule report variable should include
a null terminator for capsule name and capsule target, if they are
not present.
Jiewen Yao (2):
MdeModulePkg/CapsuleLib: Add NULL capsule name in record.
MdeModulePkg/CapsuleApp: Dump capsule name in record.
MdeModulePkg/Applicat
According to UEFI spec, capsule report variable should include
a null terminator for capsule name and capsule target, if they are
not present.
The reserved field is zeroed.
Cc: Feng Tian
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiewen Yao
---
MdeMod
According to UEFI spec, capsule report variable should include
a null terminator for capsule name and capsule target, if they are
not present.
Cc: Feng Tian
Cc: Star Zeng
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiewen Yao
---
MdeModulePkg/Application/CapsuleApp/C
Reviewed-by: Qin Long
> -Original Message-
> From: Yao, Jiewen
> Sent: Thursday, December 22, 2016 1:00 PM
> To: edk2-devel@lists.01.org
> Cc: Zhang, Chao B; Long, Qin
> Subject: [PATCH 2/2] SignedCapsulePkg/SystemCapsuleLib: Add ASSERT
> check for PCD
>
> Add ASSERT check for PCD to av
Reviewed-by: Qin Long
> -Original Message-
> From: Yao, Jiewen
> Sent: Thursday, December 22, 2016 1:00 PM
> To: edk2-devel@lists.01.org
> Cc: Zhang, Chao B; Long, Qin
> Subject: [PATCH 1/2] SecurityPkg/FmpAuthLib: Add PublicKeyDataLength
> check
>
> Add PublicKeyDataLength check to be
Add more check for PublicKeyDataLength to avoid user mistake
or platform mis-configuration.
Jiewen Yao (2):
SecurityPkg/FmpAuthLib: Add PublicKeyDataLength check
SignedCapsulePkg/SystemCapsuleLib: Add ASSERT check for PCD
SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticati
Add PublicKeyDataLength check to be multiple SHA256_DIGEST_SIZE
to avoid caller make mistake, or platform mis-configuration.
Cc: Chao Zhang
Cc: Qin Long
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiewen Yao
---
SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/
Add ASSERT check for PCD to avoid platform mis-configuration.
Cc: Chao Zhang
Cc: Qin Long
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jiewen Yao
---
SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.c | 2 ++
1 file changed, 2 insertions(+)
diff -
Reviewed-by: Liming Gao
> -Original Message-
> From: Wu, Hao A
> Sent: Thursday, December 22, 2016 9:32 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Gao, Liming ;
> Zhu, Yonghong
> Subject: [PATCH] BaseTools/Pccts: Resolve GCC sting format mismatch build
> warning
>
> Cc: Liming G
Reviewed-by: Liming Gao
> -Original Message-
> From: Wu, Hao A
> Sent: Friday, December 16, 2016 11:38 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Yao, Jiewen ;
> Gao, Liming ; Kinney, Michael D
>
> Subject: [PATCH v2 1/6] MdePkg/BaseLib: Refine (Ascii)StrnLenS functions
> logic
>
Thanks Ting. The standardization is in the plan. Before finished, I will keep
the existing APIs.
As the return value of GuidToString, you are right, it should be "Size" instead
of "Size-1". I will correct it before commit the patch.
Thanks,
Jiaxin
> -Original Message-
> From: Ye, Ting
I agree. Adding new StringToGuid and GuidToString to common library seems a
good idea if we don't have existing APIs.
In GuidToString, the comment indicates that SPrint will NULL terminate the
string, so use Size -1 to skip the NULL. However, I see UnicodeSPrint in MdePkg
returns the number o
Thanks a lot, Andrew and Jaben.
I will check these and get back...
Thanks again. :)
Regards,
Keshava
On ಗುರು, ಡಿಸೆಂ 22, 2016 12:43 ಪೂರ್ವಾಹ್ನ Andrew Fish wrote:
> On Dec 20, 2016, at 11:32 PM, GN Keshava wrote:
>
> Hi,
>
> I'm developing a shell application. A call to LocateHandle for
> gEfiSh
> On Dec 21, 2016, at 5:18 PM, Gao, Liming wrote:
>
> Andrew:
> You mean newform.bin has section header. It is just a leaf section. You
> expect to directly add it into GUIDED section without specify section header
> again. Right?
>
Liming,
Yes.
The issue is Leaf section header in the FD
Cc: Liming Gao
Cc: Yonghong Zhu
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu
---
BaseTools/Source/C/VfrCompile/Pccts/support/set/set.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source/C/VfrCompile/Pccts/support/set/set.c
b/Ba
Andrew:
You mean newform.bin has section header. It is just a leaf section. You
expect to directly add it into GUIDED section without specify section header
again. Right?
Thanks
Liming
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Andrew
Fis
> On Dec 20, 2016, at 11:32 PM, GN Keshava wrote:
>
> Hi,
>
> I'm developing a shell application. A call to LocateHandle for
> gEfiShellProtocolGuid is failing with Status 0x0E.
>
> Below is my code. Please let me know what I'm doing wrong.
>
Assuming this is your entire code fragment you ar
> On Dec 20, 2016, at 11:32 PM, GN Keshava wrote:
>
> Hi,
>
> I'm developing a shell application. A call to LocateHandle for
> gEfiShellProtocolGuid is failing with Status 0x0E.
>
> Below is my code. Please let me know what I'm doing wrong.
>
> Status = gBS->LocateHandle(ByProtocol, &gEfiShel
Hi Keshava,
few questions:
Is there a reason that you are not using ShellLib to facilitate your app
functionality? That library makes lots of things a lot easier.
Why do you use LocateHandle and not LocateProtocol?
Are you sure about that return code? Usually most-sig-bit is set for error
ret
> On Dec 21, 2016, at 6:27 AM, Gao, Liming wrote:
>
> Andrew:
> Encapsulation section data is the section stream, not raw format. Then, Leaf
> section can be extracted from encapsulation section.
>
Liming,
I happen to have the section stream in binary form checked into the source
tree. The
> -Original Message-
> From: Ni, Ruiyu
> Sent: Wednesday, December 21, 2016 12:55 AM
> To: edk2-devel@lists.01.org
> Cc: Chen, Chen A ; Carsey, Jaben
>
> Subject: [PATCH 2/2] ShellPkg/cd: Fix "cd" to support "fs0:dir" (no slash
> after
> ':')
> Importance: High
>
> When "fs0:dir"(drive
Andrew:
Encapsulation section data is the section stream, not raw format. Then, Leaf
section can be extracted from encapsulation section.
Thanks
Liming
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Andrew
Fish
Sent: Wednesday, December 21, 20
Since ARM VExpress FVP platform will support some PCIe devices
(e.g, SMMU Test Engine) behind the PCIe Root Complex and SMMUv3 which
can generate PCI ITS-MSI/memory transaction to the core. Moreover, the
IORT based SMMU patch has been merged into the linux kernel, in order
to ease the testing/ver
We add this token in order to support the GICv3 ITS feature on
ARM VExpress FVP platform (related patch will be based on OpenPlatformPkg
git repository)
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dennis Chen
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Cc: Lorenzo Pieralisi
When "fs0:dir"(drive letter without slash) is used as destination
of "cd", "cd" tries to change to "dir" in root directory of "fs0:".
It's incorrect. The correct behavior is to change to "dir" in
current directory of "fs0:"
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Rui
When "fs0:dir"(drive letter without slash) is used as destination
of "cd", "cd" tries to change to "dir" in root directory of "fs0:".
It's incorrect. The correct behavior is to change to "dir" in
current directory of "fs0:"
Ruiyu Ni (2):
MdePkg/BaseLib: Fix PathCleanUpDirectories to correctly ha
The old code incorrectly cleans path like "fs0:\abc\.\.." to
"fs0:\abc", instead of "fs0:\"
The patch fixes this bug.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chen A Chen
Signed-off-by: Ruiyu Ni
Cc: Jaben Carsey
---
MdePkg/Library/BaseLib/FilePaths.c | 60 +++
31 matches
Mail list logo
