Re: [edk2] [patch] ShellPkg: Add check logic for the gateway validity.

Reviewed-by: Wu Jiaxin > -Original Message- > From: Zhang, Lubo > Sent: Friday, January 6, 2017 5:16 PM > To: edk2-devel@lists.01.org > Cc: Santhapur Naveen ; Ye, Ting > ; Fu, Siyuan ; Wu, Jiaxin > > Subject: [patch] ShellPkg: Add check logic for the gateway validity. > > if we set a s

Re: [edk2] [patch] ShellPkg: Add check logic for the gateway validity.

Reviewed-by: Fu Siyuan -Original Message- From: Zhang, Lubo Sent: 2017年1月6日 17:16 To: edk2-devel@lists.01.org Cc: Santhapur Naveen ; Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin Subject: [patch] ShellPkg: Add check logic for the gateway validity. if we set a static IP using command 'ifconfig -s

Re: [edk2] [patch] ShellPkg: Add check logic for the gateway validity.

Reviewed-by: Ye Ting -Original Message- From: Zhang, Lubo Sent: Friday, January 06, 2017 5:16 PM To: edk2-devel@lists.01.org Cc: Santhapur Naveen ; Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin Subject: [patch] ShellPkg: Add check logic for the gateway validity. if we set a static IP using comm

Re: [edk2] [PATCH] MdeModulePkg/DxeCore:Clear RT attribute on SetCapabilities.

Reviewed-by: Star Zeng -Original Message- From: Yao, Jiewen Sent: Monday, January 9, 2017 2:35 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Tian, Feng Subject: [PATCH] MdeModulePkg/DxeCore:Clear RT attribute on SetCapabilities. When gDS->SetMemorySpaceCapabilities() is called, curre

[edk2] [PATCH] MdeModulePkg/DxeCore:Clear RT attribute on SetCapabilities.

When gDS->SetMemorySpaceCapabilities() is called, current DXE core will sync all GCD attributes to memory map attributes, including RUNTIME attributes. It is wrong, because RUNTIME attributes should be set for runtime memory only. This fix clears the RUNTIME attributes before convert to UEFI memor

Re: [edk2] [Patch] ShellPkg/Shell: Add double quotes to args with white space

Mike, According to the wording below copied from Shell spec, quotes are removed before saving To Argv. "Argv Points to an Argc-element array of points to null-terminated strings containing the command-line parameters. The first entry in the array is always the full file path of the executable. Any

Re: [edk2] [PATCH] SecurityPkg Tcg2ConfigDxe: Refine debug message and comments

Reviewed-by : Chao Zhang -Original Message- From: Zeng, Star Sent: Monday, January 9, 2017 1:40 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Zhang, Chao B Subject: [PATCH] SecurityPkg Tcg2ConfigDxe: Refine debug message and comments Cc: Chao Zhang Contributed-under: TianoCore Contr

[edk2] [PATCH] SecurityPkg Tcg2ConfigDxe: Refine debug message and comments

Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c | 6 +++--- SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/SecurityPkg/Tcg/Tcg

[edk2] [Patch] OvmgPkg/PlatformBootManagerLib: Add Debug Agent console

The Debug Agent in the SourceLevelDebugPkg can multiplex both source level debug messages and console messages on the same UART. WHen this is done, the Debug Agent owns the UART device and an additional device handle with a Serial I/O Protocol is produced with a VenHw device path node. In order f

Re: [edk2] [Patch] MdeModulePkg/DxeCore: Fix ASSERT() from GCD DEBUG() messages

Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Michael Kinney >Sent: Monday, January 09, 2017 1:00 PM >To: edk2-devel@lists.01.org >Cc: Tian, Feng ; Zeng, Star >Subject: [edk2] [Patch] MdeModulePkg/DxeCore: Fix ASSERT(

Re: [edk2] [Patch] MdePkg/Include: Add include file to FileHandleLib.h

Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Michael Kinney >Sent: Monday, January 09, 2017 12:48 PM >To: edk2-devel@lists.01.org >Subject: [edk2] [Patch] MdePkg/Include: Add include file to FileHandleLib.h > >FileHan

Re: [edk2] [Patch] MdeModulePkg/DxeCore: Fix ASSERT() from GCD DEBUG() messages

Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Zeng, Star Sent: Monday, January 9, 2017 1:06 PM To: Kinney, Michael D ; edk2-devel@lists.01.org Cc: Tian, Feng Subject: RE: [Patch] MdeModulePkg/DxeCore: Fix ASSERT() from GCD DEBUG() messages Reviewed-by: Star Zeng -

Re: [edk2] [Patch] MdeModulePkg/DxeCore: Fix ASSERT() from GCD DEBUG() messages

Reviewed-by: Star Zeng -Original Message- From: Kinney, Michael D Sent: Monday, January 9, 2017 1:00 PM To: edk2-devel@lists.01.org Cc: Tian, Feng ; Zeng, Star Subject: [Patch] MdeModulePkg/DxeCore: Fix ASSERT() from GCD DEBUG() messages If a BaseAddress of NULL is passed into DXE Core

[edk2] [Patch] MdeModulePkg/DxeCore: Fix ASSERT() from GCD DEBUG() messages

If a BaseAddress of NULL is passed into DXE Core services CoreAllocateIoSpace() or CoreAllocateMemorySpace(), and DEBUG() messages are enabled, then a NULL pointer reference is made. The parameter check for BaseAddress is performed in the function CoreAllocateSpace() after the DEBUG() messages. A

[edk2] [Patch] MdePkg/Include: Add include file to FileHandleLib.h

FileHandleLib.h uses the data type EFI_FILE_INFO, so this library class should include . Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Michael Kinney --- MdePkg/Include/Library/FileHandleLib.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --gi

Re: [edk2] [PATCH v3 0/4] BaseIoFifoLib

Leo: IoLib Library class is designed from the functionality, not code implementation. So, many IO operations are included in this library class. If developers want to use IO API, they only need to check IoLib library class. After add new APIs, we need to update all IoLib library instances to i

Re: [edk2] [PATCH] SecurityPkg Tcg2ConfigDxe: Typecast to (CHAR8*) as para of AsciiStrSize

Reviewed-by: Dandan Bi Thanks, Dandan -Original Message- From: Zeng, Star Sent: Monday, January 9, 2017 10:06 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Bi, Dandan ; Yao, Jiewen ; Zhang, Chao B Subject: [PATCH] SecurityPkg Tcg2ConfigDxe: Typecast to (CHAR8*) as para of AsciiStrS

Re: [edk2] [PATCH] SecurityPkg Tcg2ConfigDxe: Typecast to (CHAR8*) as para of AsciiStrSize

Reviewed-by: Chao Zhang -Original Message- From: Zeng, Star Sent: Monday, January 9, 2017 10:06 AM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Bi, Dandan ; Yao, Jiewen ; Zhang, Chao B Subject: [PATCH] SecurityPkg Tcg2ConfigDxe: Typecast to (CHAR8*) as para of AsciiStrSize Cc: Dandan

Re: [edk2] [PATCH] MdePkg/UefiFileHandleLib: Refine the check for valid Ascii character

Reviewed-by: Liming Gao >-Original Message- >From: Wu, Hao A >Sent: Friday, January 06, 2017 4:50 PM >To: edk2-devel@lists.01.org >Cc: Wu, Hao A ; Gao, Liming ; >Kinney, Michael D >Subject: [PATCH] MdePkg/UefiFileHandleLib: Refine the check for valid Ascii >character > >The commit will c

[edk2] [PATCH] MdeModulePkg/BootMaintenanceManagerUiLib: Support NT32 terminals

The patch enhances Boot Maintenance Manager to recognize the terminal consoles in NT32 platform. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Dandan Bi Cc: Liming Gao --- .../BootMaintenanceManagerUiLib/ConsoleOption.c| 213 ++--- 1 fi

Re: [edk2] [PATCH v4 7/9] Vlv2TbltDevicePkg: Modify .DSC files that include UefiCpuPkg/CpuIo2Dxe

Reviewed-by: zwei4 Thanks, David Wei -Original Message- From: Leo Duran [mailto:leo.du...@amd.com] Sent: Saturday, January 07, 2017 12:25 AM To: edk2-devel@lists.01.org Cc: brijesh.si...@amd.com; ler...@redhat.com; Justen, Jordan L ; Fan, Jeff ; Kinne

[edk2] [PATCH] SecurityPkg Tcg2ConfigDxe: Typecast to (CHAR8*) as para of AsciiStrSize

Cc: Dandan Bi Cc: Jiewen Yao Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDriver.c | 4 ++-- SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff

Re: [edk2] [PATCH 4/4] MdePkg/BaseLib: Add safe string functions [U|A]StrnTo[A|U]StrS

Reviewed-by: jiewen@intel.com > -Original Message- > From: Wu, Hao A > Sent: Wednesday, January 4, 2017 7:23 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Yao, Jiewen ; > Gao, Liming ; Kinney, Michael D > > Subject: [PATCH 4/4] MdePkg/BaseLib: Add safe string functions > [U|A]Str

Re: [edk2] [PATCH 3/4] MdePkg/BaseLib: Enhance the return value for string to uint functions

Reviewed-by: jiewen@intel.com > -Original Message- > From: Wu, Hao A > Sent: Wednesday, January 4, 2017 7:23 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Yao, Jiewen ; Wu, > Jiaxin ; Gao, Liming ; Kinney, > Michael D > Subject: [PATCH 3/4] MdePkg/BaseLib: Enhance the return valu

Re: [edk2] [PATCH 2/4] MdePkg/BaseLib: Add safe string functions that convert str to value

Reviewed-by: jiewen@intel.com > -Original Message- > From: Wu, Hao A > Sent: Wednesday, January 4, 2017 7:23 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Yao, Jiewen ; > Gao, Liming ; Kinney, Michael D > > Subject: [PATCH 2/4] MdePkg/BaseLib: Add safe string functions that conve

Re: [edk2] [PATCH 4/9] Ufs: fix to set UTRLBA and UTRLBAU register

Haojian, Please refer to below pic. For example, we set UTRL as 0x1, and we found 5th slot is free, then we should doorbell the 5th bit of UTRLDBR. Your change will set UTRL as 0x100050,(assume each TRD uses 0x10bytes for easy understanding), then you have to set doorbell to 0. Besides th

Re: [edk2] [PATCH 4/9] Ufs: fix to set UTRLBA and UTRLBAU register

Hi Feng, I don’t understand why doorbell location should be updated too. If we don’t update UTRLBA & UTRLBAU for sending each UPIU packet, we have to extend the size of UTRD packet. Then we could avoid to create a new command buffer. Best Regards Haojian From: Tian, Feng