Linson,
Reviewed-by: Star Zeng
I can help push this patch at tomorrow morning (PRC time) if no other comments
received.
Thanks,
Star
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Linson
Augustine
Sent: Thursday, January 12, 2017 3:00 PM
To:
Added decoding of the new SMBIOS Type 43 record.
Addressed review comments.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Augustine Linson P
---
ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c |
72 +++-
ShellPkg/Library/Uefi
Star,
Thanks for the clarification. I will send the patch shortly.
Regards,
Linson
-Original Message-
From: Zeng, Star [mailto:star.z...@intel.com]
Sent: Thursday, January 12, 2017 11:39 AM
To: Augustine, Linson P ; edk2-devel@lists.01.org
Cc: Carsey, Jaben ; Ni, Ruiyu ;
Zeng, Star
Linson,
" no comments to it" I said meant I have no comments to it, I just put a mark
at there as my following comments "How about use "Display TPM Device (Type 43)
Characteristics" to align with the comment above?" will refer it.
Sorry for confusing.
Please update patch.
Thanks,
Star
-Orig
Hi Star,
This is regarding the following comments.
>//
> + // TPM Device (Type 43)
The comment here is using "TPM Device (Type 43)", no comments to it. :)
> + //
All the comments in the function are using the heading of corresponding table
in SMBIOS spec. And for Type 43 it is " TPM De
Leo,
1. What does "Bm" stand for in "BmDmaLib"?
2. Include/Library/BmDmaLib.h says
" DMA abstraction library APIs. Based on PCI IO protocol DMA abstractions."
I think that means the BmDmaLib library class knows the PCI IO concept.
If so, why not directly use the EFI_PCI_ROT_BRIDGE_IO_PR
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Wu, Hao A
> Sent: Friday, January 6, 2017 4:56 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Zhang, Chao B ;
> Yao, Jiewen
> Subject: [PATCH] SignedCapsulePkg/CapsuleLib: Refine to compare with same
> type
>
> Cc: Chao Z
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Wu, Hao A
> Sent: Friday, January 6, 2017 4:56 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Zhang, Chao B ;
> Yao, Jiewen
> Subject: [PATCH] SecurityPkg/FmpAuthenticationLib: Refine to compare with
> same type
>
> Cc: C
Reviewed-by:jiewen@intel.com
> -Original Message-
> From: Wu, Hao A
> Sent: Friday, January 6, 2017 4:55 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Zhang, Chao B ;
> Yao, Jiewen
> Subject: [PATCH] SecurityPkg/TcgDxe: Refine to compare 2 values with the same
> type
>
> Cc: Cha
Leo:
Current IO driver does support EfiCpuIoWidthFifoUint#, although CpuIo and
PeiCpuIo driver doesn't support the optimized FifoIo operation. So, I think
rework IoLib instance has no risk.
Thanks
Liming
>-Original Message-
>From: Duran, Leo [mailto:leo.du...@amd.com]
>Sent: Thursday,
Reviewed-by: Zhang Lubo
> -Original Message-
> From: hegdenag [mailto:nagaraj-p.he...@hpe.com]
> Sent: Thursday, January 12, 2017 11:40 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Jiaxin ; Carsey, Jaben ;
> Ni, Ruiyu ; Zhang, Lubo ; sriram-
> s...@hpe.com
> Subject: [PATCH v1 1/1] ShellPkg
When we issue 'ifconfig6 -s auto' system hangs with
an ASSERT in StrLen. in IfConfig6SetInterfaceInfo, for 'auto' case
we added checks to rule out the invalid inputs like 'host', 'gw'
and 'dns'. To parse through this, we do a VarArg = VarArg->Next but
we dont check new VarArg before calling StrCmp
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: Zhang, Chao B
> Sent: Thursday, January 12, 2017 10:44 AM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen ; Zeng, Star ;
> Zhang, Chao B
> Subject: [PATCH] SecuritPkg: Tcg2Smm: Add PlatformClass to TPM2 Table
>
> Add Platform
That's good question.
The "reset system service implementation" is expected to detect capsule
variable and convert the reset type from warm reset to a type which can
maintain the system memory.
It could be warm reset, if the warm reset can keep the memory content.
Or it could be S3 reset, if th
Reviewed-by: Ruiyu Ni
Thanks/Ray
> -Original Message-
> From: Wu, Hao A
> Sent: Thursday, January 12, 2017 10:45 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Ni, Ruiyu
> Subject: [PATCH] MdeModulePkg/TerminalDxe: Refine
> SetTerminalDevicePath
>
> Pass '&Node.Header' instead of '
HI All,
I want to update capsule image with CapsuleApp. The capsule image is built
and can be update by CapsuleApp. From current edk2 master code ,it seems the
reset mode should be S3 mode first (I understand this since we need to keep
capsule information in memory),but CapsuleApp will only
Reviewed-by: Star Zeng
-Original Message-
From: Zhang, Chao B
Sent: Thursday, January 12, 2017 10:44 AM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen ; Zeng, Star ;
Zhang, Chao B
Subject: [PATCH] SecuritPkg: Tcg2Smm: Add PlatformClass to TPM2 Table
Add PlatformClass info into TPM2 ACPI
Pass '&Node.Header' instead of '&Node' as the 1st parameter to function
SetDevicePathNodeLength().
Cc: Ruiyu Ni
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu
---
MdeModulePkg/Universal/Console/TerminalDxe/Terminal.c | 2 +-
1 file changed, 1 insertion(+), 1 delet
Add PlatformClass info into TPM2 ACPI table, it is only valid with table
Rev 4 and later.
Cc: Star Zeng
Cc: Yao Jiewen
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chao Zhang
---
SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c | 10 ++
SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.inf
Ummh...
> -Original Message-
> From: Gao, Liming [mailto:liming@intel.com]
> Sent: Wednesday, January 11, 2017 7:39 PM
> To: Duran, Leo ; edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Justen, Jordan L
> ; Singh, Brijesh ; Fan,
> Jeff ; ler...@redhat.com
> Subject: RE: [edk2] [PATCH
Leo:
I suggest you rework IoLib instances PeiIoLib, DxeIoLibCpuIo, DxeIoLibCpuIo2
library instance first. Then, later you only need to change CpuIo PEIM and
driver, don't need to change library instances again.
Thanks
Liming
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun.
Jeff,
Please see inline below.
Leo
> -Original Message-
> From: Fan, Jeff [mailto:jeff@intel.com]
> Sent: Wednesday, January 11, 2017 7:33 PM
> To: Duran, Leo ; edk2-devel@lists.01.org
> Cc: Singh, Brijesh ; Justen, Jordan L
> ; Gao, Liming ; Kinney,
> Michael D ; ler...@redhat.com
> S
How about this instead:
1) I submit a "v2" to take care of the code-style issue, while making all
instances of IoLib fully functional & complaint with the complete IoLib API.
2) At a later time (soon, I promise), I submit a patch for CpuIo2Dxe to
properly support FiFo types and also rework the I
Linson,
The patch has been pushed at 713e4b007cb791829397522ad8f366dd1e08bee6, thanks
for the contribution.
Star
-Original Message-
From: Augustine, Linson P [mailto:linson.august...@hpe.com]
Sent: Wednesday, January 11, 2017 5:36 PM
To: Zeng, Star ; edk2-devel@lists.01.org
Cc: Carsey,
Leo,
+VOID
+EFIAPI
+IoWriteFifo8 (
+ IN UINTN Port,
+ IN UINTN Count,
+ OUT VOID *Buffer
+ );
Buffer should be "IN" instead of "OUT". I understand you just copied original
code from UefiCpuPkg.
It's better you could
Leo:
CpuIo2Dxe supports FifoIo operation, because original logic includes FifoIo
implementation. CpuIoCheckParameter() checks the parameter, doesn't performance
operation. And, 64bit IO operation is not supported. You add three APIs for 8,
16 and 32 Io operation. So, there is no lose functiona
Liming, et al,
Bottom line, in my estimation:
Supporting EfiCpuIoWidthFifoUint# via the CPU I/O protocol would require
significant rework of the CpuIo2Dxe driver.
(Which frankly is a bit beyond of the scope of my proposed patch set)
So, if you are in agreement, I'm prepared to submit a "v2" to c
On 01/11/17 18:32, Stephen Polkowski wrote:
> Hi all,
>
> I'm having a new problem with the 2.1 shell. I've noticed that
> shell scripts will fail and exit if you test an undefined shell
> variable. This wasn't a problem on the 2.0 shell. For example:
>
> if %undefinedvar% == "xyz" then
>
Search before July 2015: https://sourceforge.net/p/edk2/mailman/edk2-devel/
thanks,
Laurie
laurie.jarlst...@intel.com
Intel SSG/STO/EBP
(503) 712-9395
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
Richardson, Brian
Sent: Wednesday, January
The list archives are available here -
https://lists.01.org/mailman/listinfo/edk2-devel
Thanks ... br
---
Brian Richardson, Senior Technical Marketing Engineer, Intel Software
brian.richard...@intel.com -- @intel_Brian (Twitter & WeChat)
https://software.intel.com/en-us/meet-the-developers/evang
Aravind,
I am trying to reproduce this issue and so far everything works for me.
I pulled the sources this morning (df3f02df1bde40c2a0d486d3ca6bd529c3654049)
I did the following build command (I am using VS2015x86 by default)
build -a IA32 -n 5 -t VS2015x86 -p QuarkPlatformPkg\Quark.dsc
On 01/11/17 11:59, Wu, Hao A wrote:
>> -Original Message-
>> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
>> Sent: Wednesday, January 11, 2017 3:55 PM
>> To: Ni, Ruiyu; Laszlo Ersek
>> Cc: Wu, Hao A; edk2-devel@lists.01.org
>> Subject: Re: [edk2] [PATCH] MdeModulePkg/NonDiscovera
Hi all,
I'm having a new problem with the 2.1 shell. I've noticed that shell
scripts will fail and exit if you test an undefined shell variable.
This wasn't a problem on the 2.0 shell. For example:
if %undefinedvar% == "xyz" then
Anyhow, I wanted to search the mailing lists first to see
Liming,
However, here are some issues with trying to use Fifo types via the I/O
protocol:
1) CpuIo2Dxe.c - CpuIoCheckParameter(): Count is forced to 1 for Fifo types:
//
// For FIFO type, the target address won't increase during the access,
// so treat Count as 1
//
if (Width >= EfiCpuI
On 11 January 2017 at 11:45, Ryan Harkin wrote:
> On 10 January 2017 at 22:36, Leif Lindholm wrote:
>> On Mon, Jan 09, 2017 at 03:20:51PM -0600, Daniil Egranov wrote:
>>> From: Daniil Egranov
>>>
>>> The patch reads a valid MAC address form the Juno IOFPGA registers
>>> and pushes it into onboar
On 10 January 2017 at 22:36, Leif Lindholm wrote:
> On Mon, Jan 09, 2017 at 03:20:51PM -0600, Daniil Egranov wrote:
>> From: Daniil Egranov
>>
>> The patch reads a valid MAC address form the Juno IOFPGA registers
>> and pushes it into onboard Marvell Yukon NIC.
>>
>> Contributed-under: TianoCore
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Wednesday, January 11, 2017 3:55 PM
> To: Ni, Ruiyu; Laszlo Ersek
> Cc: Wu, Hao A; edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH] MdeModulePkg/NonDiscoverable: Compare
> SIZE_4GB with address type
Chris,
Since no other comments received, do you need me to help push the SMBIOS
related patches?
Thanks,
Star
On 2017/1/11 9:36, Zeng, Star wrote:
Reviewed-by: Star Zeng
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Chris
Phillips
Sent:
Linson,
Add minor comments inline. :)
On 2017/1/11 16:57, Linson Augustine wrote:
Added decoding of the new SMBIOS Type 43 record.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Augustine Linson P
---
ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
Star,
I agree with this. Please help me to push this patch.
Regards,
Linson.
-Original Message-
From: Zeng, Star [mailto:star.z...@intel.com]
Sent: Wednesday, January 11, 2017 2:53 PM
To: Augustine, Linson P ; edk2-devel@lists.01.org
Cc: jaben.car...@intel.com; ruiyu...@intel.com; mic
Linson,
Add minor comments inline.
On 2017/1/11 17:10, Linson Augustine wrote:
Added definitions for the new SMBIOS Type 43 record.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Augustine Linson P
---
MdePkg/Include/IndustryStandard/SmBios.h | 19 ++-
Is there a way to make the FV defined in the FD section be only big enough to
contain the data? The remaining area could be 0xFF (erase value). If the FV is
read only there is no point reading the extra data from the FLASH device if all
the bytes are 0xFF.
For example if we make an FV to be co
Added definitions for the new SMBIOS Type 43 record.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Augustine Linson P
---
MdePkg/Include/IndustryStandard/SmBios.h | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/MdePkg/Include/Indus
Added decoding of the new SMBIOS Type 43 record.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Augustine Linson P
---
ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c |
72 +++-
ShellPkg/Library/UefiShellDebug1CommandsLib/Smbi
Hi Jiewen:
I will give another patch for the PCD configuration. Thanks for your comment.
-Original Message-
From: Yao, Jiewen
Sent: Wednesday, January 11, 2017 4:18 PM
To: Zhang, Chao B ; edk2-devel@lists.01.org
Cc: Zhang, Chao B ; Zeng, Star
Subject: RE: [edk2] [PATCH 2/2] SecurityPk
Hi
I think we should add assign PlatformClass to PcdGet8 (PcdTpmPlatformClass), if
version is 4, to follow TCG spec.
You may want to submit another patch to resolve.
Reviewed-by: jiewen@intel.com
Thank you
Yao Jiewen
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun.
Hi
Can we add more comment:
> + //BIT0~15: PlatformClass // this field is only valid for version 4
> and above.
With the comment update, reviewed-by: jiewen@intel.com
Thank you
Yao Jiewen
> -Original Message-
> From: Zhang, Chao B
> Sent: Wednesday, January 11, 2017 4:13 PM
>
Address incompatible change introduced in patch
8f07a374b1d0497b6676491de8cbe2f08f4f7e9f
Cc: Star Zeng
Cc: Yao Jiewen
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chao Zhang
---
SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions
Fix incompatible change. Some modules are still referencing old definition.
Cc: Star Zeng
Cc: Yao Jiewen
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Chao Zhang
---
MdePkg/Include/IndustryStandard/Tpm2Acpi.h | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-
v2:
*1. Add IScsiDnsIsConfigured function in IScsiSupported to check
attempt using DNS protocol or not.2. Fix wrongs typos in IScsiDns.c
and .uni file.3. define a macro for the length of target URL.4.
update the Copyright to 2017.
Add DNS support for target URL directly configuration in UI.
Besi
50 matches
Mail list logo
