Re: [edk2] [PATCH] OvmfPkg: Enable HTTPS for Ovmf

2017-01-15 Thread Gary Lin
On Mon, Jan 16, 2017 at 06:15:08AM +, Wu, Jiaxin wrote: > More: TLS feature should not be limit to HTTP(S) feature. > Is there any other planned usage for TLS? > !if $(HTTP_BOOT_ENABLE) == TRUE >!if $(TLS_ENABLE) == TRUE > ... >!endif > !endif > I checked my patch again and fou

Re: [edk2] [PATCH] OvmfPkg: Enable HTTPS for Ovmf

2017-01-15 Thread Gary Lin
On Mon, Jan 16, 2017 at 05:44:49AM +, Wu, Jiaxin wrote: > Hi Gary, > > Before we enable the HTTPS/TLS for OVMF, We need remove the > 'SECURE_BOOT_ENABLE' flag control for the CryptoPkg librarie. Not only the > secure boot feature requires the CryptoPkg libraries (e.g, OpensslLib, > BaseCryp

[edk2] [PATCH] NetworkPkg/TlsAuthConfigDxe: Declare EFIAPI for the ChooseFile handler

2017-01-15 Thread Gary Lin
The ChooseFile handler, UpdateCAFromFile, has to be EFIAPI or gcc would use the wrong ABI and cause the crash of the firmware. This commit also removes the unnecessary type casting in ChooseFile. Cc: Siyuan Fu Cc: Jiaxin Wu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: G

Re: [edk2] [PATCH] OvmfPkg: Enable HTTPS for Ovmf

2017-01-15 Thread Wu, Jiaxin
More: TLS feature should not be limit to HTTP(S) feature. !if $(HTTP_BOOT_ENABLE) == TRUE !if $(TLS_ENABLE) == TRUE ... !endif !endif Best Regard! Jiaxin > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wu, > Jiaxin > Sent: Monday,

[edk2] [patch 3/3] MdeModulePkg/FileExplorer: Enable functionality of creating new file/folder

2017-01-15 Thread Dandan Bi
https://bugzilla.tianocore.org/show_bug.cgi?id=324 Enhance the FileExplorerlib so that user can create a new file/folder through the UI page. Cc: Eric Dong Cc: Liming Gao Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Library/FileExplo

[edk2] [patch 1/3] MdeModulePkg/FileExplorer: Remove the codes of searching load file protocol

2017-01-15 Thread Dandan Bi
https://bugzilla.tianocore.org/show_bug.cgi?id=323 FileExplorer no need to search load file protocol to show files. Now remove the codes. Cc: Eric Dong Cc: Liming Gao Cc: Jiewen Yao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- .../Library/FileExplorerL

[edk2] [patch 2/3] MdeModulePkg/FileExplorer: Update QuesrionId when Updating FileExplore form

2017-01-15 Thread Dandan Bi
https://bugzilla.tianocore.org/show_bug.cgi?id=342 When user select and enter a directory, File Explorer will update the form based on the new folders and files in the directory. But when creating question opcodes, the question id is same with previous one and this will cause browser to show the h

Re: [edk2] [PATCH] OvmfPkg: Enable HTTPS for Ovmf

2017-01-15 Thread Wu, Jiaxin
Hi Gary, Before we enable the HTTPS/TLS for OVMF, We need remove the 'SECURE_BOOT_ENABLE' flag control for the CryptoPkg librarie. Not only the secure boot feature requires the CryptoPkg libraries (e.g, OpensslLib, BaseCryptLib), but also ISCSI, IpSec and HTTPS/TLS features. If we not remove t

[edk2] [Patch] OvmfPkg: Remove the flag control for the CryptoPkg libraries

2017-01-15 Thread Jiaxin Wu
This patch is to remove the 'SECURE_BOOT_ENABLE' flag control for the CryptoPkg librarie. Not only the secure boot feature requires the CryptoPkg libraries (e.g, OpensslLib, BaseCryptLib), but also ISCSI, IpSec and HTTPS/TLS features. Those modules can be always included since no build performance

[edk2] [PATCH] OvmfPkg: Enable HTTPS for Ovmf

2017-01-15 Thread Gary Lin
This commit introduces a new build option to OvmfPkg: TLS_ENABLE. When setting the option, the TLS drivers will be included to support HTTPS. NOTE: HTTP_BOOT_ENABLE is needed to enable HTTPS support since it's pointless to enable TLS alone. Cc: Laszlo Ersek Cc: Jordan Justen Cc: Jiaxin Wu

[edk2] [patch] ShellPkg/HandleParsingLib: Fix coding style issue

2017-01-15 Thread Dandan Bi
Cc: Jaben Carsey Cc: Ruiyu Ni Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- ShellPkg/Include/Library/HandleParsingLib.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ShellPkg/Include/Library/HandleParsingLib.h b/ShellPkg/Include/

Re: [edk2] [PATCH v3 09/10] IntelFrameworkPkg/DxeIoLibCpuIo: Add new Fifo routines in IoLib class

2017-01-15 Thread Fan, Jeff
Reviewed-by: Jeff Fan -Original Message- From: Leo Duran [mailto:leo.du...@amd.com] Sent: Saturday, January 14, 2017 4:10 AM To: edk2-devel@lists.01.org Cc: Gao, Liming; Kinney, Michael D; Fan, Jeff; Justen, Jordan L; ler...@redhat.com; brijesh.si...@amd.com; Leo Duran Subject: [PATCH v

Re: [edk2] [PATCH v3 04/10] IntelFrameworkModulePkg: Modify CpuIoDxe to support new IoLib library

2017-01-15 Thread Fan, Jeff
Reviewed-by: Jeff Fan -Original Message- From: Leo Duran [mailto:leo.du...@amd.com] Sent: Saturday, January 14, 2017 4:10 AM To: edk2-devel@lists.01.org Cc: Gao, Liming; Kinney, Michael D; Fan, Jeff; Justen, Jordan L; ler...@redhat.com; brijesh.si...@amd.com; Leo Duran Subject: [PATCH v

Re: [edk2] [PATCH v3 03/10] UefiCpuPkg: Modify CpuIoPei to support new IoLib library

2017-01-15 Thread Fan, Jeff
Reviewed-by: Jeff Fan -Original Message- From: Leo Duran [mailto:leo.du...@amd.com] Sent: Saturday, January 14, 2017 4:10 AM To: edk2-devel@lists.01.org Cc: Gao, Liming; Kinney, Michael D; Fan, Jeff; Justen, Jordan L; ler...@redhat.com; brijesh.si...@amd.com; Leo Duran Subject: [PATCH v

Re: [edk2] [PATCH v3 02/10] UefiCpuPkg: Modify CpuIo2Dxe to use new IoLib library

2017-01-15 Thread Fan, Jeff
Reviewed-by: Jeff Fan -Original Message- From: Leo Duran [mailto:leo.du...@amd.com] Sent: Saturday, January 14, 2017 4:10 AM To: edk2-devel@lists.01.org Cc: Gao, Liming; Kinney, Michael D; Fan, Jeff; Justen, Jordan L; ler...@redhat.com; brijesh.si...@amd.com; Leo Duran Subject: [PATCH v

Re: [edk2] [PATCH v3 00/10] IoLib class library

2017-01-15 Thread Duran, Leo
Thanks Jordan. Please see my reply below. Leo > -Original Message- > From: Jordan Justen [mailto:jordan.l.jus...@intel.com] > Sent: Saturday, January 14, 2017 4:19 PM > To: Duran, Leo ; edk2-devel@lists.01.org > Cc: Singh, Brijesh ; liming@intel.com; Duran, > Leo ; michael.d.kin...@int