[edk2] [PATCH V2 1/6] CryptoPkg:SmmCryptLib: Add real Pkcs5Pbkdf2.c.

2017-02-07 Thread Jiewen Yao
Cc: Qin Long Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf b/CryptoPkg/Library/BaseCryptL

[edk2] [PATCH V2 6/6] SecurityPkg/dsc: add Password authentication module.

2017-02-07 Thread Jiewen Yao
Cc: Qin Long Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- SecurityPkg/SecurityPkg.dsc | 7 +++ 1 file changed, 7 insertions(+) diff --git a/SecurityPkg/SecurityPkg.dsc b/SecurityPkg/SecurityPkg.dsc index dee9241..d337a26 100644 --- a/

[edk2] [PATCH V2 4/6] SecurityPkg/PlatformPasswordLibNull: Add PlatformPasswordLib instance.

2017-02-07 Thread Jiewen Yao
This lib instance is to return if the password is cleared based upon PCD. Cc: Qin Long Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- SecurityPkg/Library/PlatformPasswordLibNull/PlatformPasswordLibNull.c | 84 Securi

[edk2] [PATCH V2 0/6] Add password support

2017-02-07 Thread Jiewen Yao
V2 1) Add SmmCommunicationBufferProtocol dependency. 2) Cleanup header file and copyright to 2017. 3) Add missing UserAuthenticationSmm.uni. 4) Rename KeyLib.h/c to KeyService.h/c to avoid confusing. V1 This series patch adds password support in EDKII. This password based user

[edk2] [PATCH V2 5/6] SecurityPkg/Password: Add Password based UserAuthentication modules.

2017-02-07 Thread Jiewen Yao
This password based user authentication is to verify user when a user wants to enter BIOS setup page. The DXE driver registers report status code listener. When it gets (EFI_SOFTWARE_DXE_BS_DRIVER | EFI_SW_PC_USER_SETUP) progress code, it will let the user input password. If and only if the user i

[edk2] [PATCH V2 2/6] SecurityPkg/dec: Add PcdPasswordCleared.

2017-02-07 Thread Jiewen Yao
This PCD is to indicate if the password is cleared. Cc: Qin Long Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- SecurityPkg/SecurityPkg.dec | 6 ++ SecurityPkg/SecurityPkg.uni | 10 ++ 2 files changed, 16 insertions(+) diff --

[edk2] [PATCH V2 3/6] SecurityPkg/include: Add PlatformPasswordLib lib class.

2017-02-07 Thread Jiewen Yao
This lib is to indicate if the password is cleared. Cc: Qin Long Cc: Chao Zhang Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiewen Yao --- SecurityPkg/Include/Library/PlatformPasswordLib.h | 54 SecurityPkg/SecurityPkg.dec |

Re: [edk2] [PATCH] ArmPkg: Bug #361 fix Watchdog PCDs

2017-02-07 Thread Ard Biesheuvel
On 6 February 2017 at 19:05, wrote: > From: Alexei > > "ARM Generic Watchdog base addresses must be declared as UINT64 values" > https://bugzilla.tianocore.org/show_bug.cgi?id=361 > > PcdGenericWatchdogControlBase & PcdGenericWatchdogRefreshBase > are declared as UINT32 values in ArmPkg.dec, but

Re: [edk2] [PATCH] SignedCapsulePkg/EdkiiSystemCapsuleLib: Fix logic error.

2017-02-07 Thread wang xiaofeng
Hi Jiewen, The fix is OK for me. Reviewed-by Wang,Cloud At 2017-02-07 14:33:45, "Jiewen Yao" wrote: >This patch fixes https://bugzilla.tianocore.org/show_bug.cgi?id=367 > >Cc: Wang Cloud >Contributed-under: TianoCore Contribution Agreement 1.0 >Signed-off-by: Jiewen Yao >--- > SignedCap

Re: [edk2] [PATCH v3 2/2] OvmfPkg/SmmControl2Dxe: select broadcast SMI if available

2017-02-07 Thread Jordan Justen
On 2017-01-31 03:02:21, Laszlo Ersek wrote: > When writing to IO port 0xB2 (ICH9_APM_CNT), QEMU by default injects an > SMI only on the VCPU that is writing the port. I'm still annoyed that qemu didn't follow chipset hardware in handling the b2 port. I know this is long passed any possibility of d

Re: [edk2] [PATCH 0/2] MdeModulePkg/AcpiTableDxe: improve FADT.{DSDT, X_DSDT} mutual exclusion

2017-02-07 Thread Zeng, Star
Laszlo, I will give feedback tomorrow (PRC time) to this series, sorry for late. Also Cc Jiewen. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Thursday, February 2, 2017 1:57 AM To: edk2-devel-01 Cc: Tian, Feng

Re: [edk2] [PATCH v3 2/2] OvmfPkg/SmmControl2Dxe: select broadcast SMI if available

2017-02-07 Thread Laszlo Ersek
On 02/07/17 10:56, Jordan Justen wrote: > On 2017-01-31 03:02:21, Laszlo Ersek wrote: >> When writing to IO port 0xB2 (ICH9_APM_CNT), QEMU by default injects an >> SMI only on the VCPU that is writing the port. > > I'm still annoyed that qemu didn't follow chipset hardware in handling > the b2 por

[edk2] [Patch] BaseTools: Fix the bug to parse the short varname in map file

2017-02-07 Thread Yonghong Zhu
current in the map file, there have two ways for var to save its offset, if the varname is short, then the offset will in the same line with varname, otherwise, it saved in the next line. Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Yonghong Zhu --- Base

[edk2] Testing SMM with QEMU, KVM and libvirt

2017-02-07 Thread Laszlo Ersek
Hi, I've added the following article to the TianoCore wiki: https://github.com/tianocore/tianocore.github.io/wiki/Testing-SMM-with-QEMU,-KVM-and-libvirt It should help both Windows and Linux desktop users build a KVM test machine / environment that closely resembles mine. Such an environment is

Re: [edk2] [PATCH v3 5/6] OvmfPkg/IncompatiblePci: Do not use deprecated macros

2017-02-07 Thread Laszlo Ersek
On 02/07/17 04:33, Ruiyu Ni wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni > Cc: Laszlo Ersek > --- > .../IncompatiblePciDeviceSupport.c | 13 > +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git

Re: [edk2] [PATCH v3 6/6] MdePkg/Pci22.h: Deprecate out-of-Spec IncompatiblePciDevice macros

2017-02-07 Thread Laszlo Ersek
On 02/07/17 04:33, Ruiyu Ni wrote: > DEVICE_ID_NOCARE is defined as 0x but Spec says (UINT64) -1 > should be used to match any VendorId/DeviceId/RevisionId/ > SubsystemVendorId/SubsystemDeviceId. > > PCI_BAR_OLD_ALIGN/PCI_BAR_EVEN_ALIGN/PCI_BAR_SQUAD_ALIGN/ > PCI_BAR_DQUAD_ALIGN are defined bu

[edk2] [PATCH] Fix some typos of "according"

2017-02-07 Thread Rebecca Cran
Cc: Feng Tian Cc: Star Zeng Cc: Siyuan Fu Cc: Jiaxin Wu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Rebecca Cran --- EdkCompatibilityPkg/Sample/Tools/Source/UefiStrGather/StrGather.c | 2 +- MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c

[edk2] [PATCH] MdeModulePkg: Add dynamic PCD

2017-02-07 Thread Leo Duran
The new PcdPteMemoryEncryptionAddressOrMask dynamic PCD holds the address mask for page table entries when memory encryption is enabled on AMD processors supporting the Secure Encrypted Virtualization (SEV) feature. This mask should be applied when creating 1:1 virtual to physical mapping tables.

[edk2] [PATCH] MdeModulePkg: Add dynamic PCD PcdPteMemoryEncryptionAddressOrMask

2017-02-07 Thread Leo Duran
From: Brijesh Singh This dynamic PCD holds the address mask for page table entries when memory encryption is enabled on AMD processors supporting the Secure Encrypted Virtualization (SEV) feature. Cc: Feng Tian Cc: Star Zeng Cc: Laszlo Ersek Contributed-under: TianoCore Contribution Agreement

Re: [edk2] [Patch] BaseTools: Fix the bug to parse the short varname in map file

2017-02-07 Thread Gao, Liming
Reviewed-by: Liming Gao -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yonghong Zhu Sent: Tuesday, February 7, 2017 8:31 PM To: edk2-devel@lists.01.org Cc: Gao, Liming Subject: [edk2] [Patch] BaseTools: Fix the bug to parse the short varname in

Re: [edk2] [PATCH v3 6/6] MdePkg/Pci22.h: Deprecate out-of-Spec IncompatiblePciDevice macros

2017-02-07 Thread Ni, Ruiyu
These macros comply with the spec so I had no reason to deprecate them. But I did want to avoid using them in drivers. Maybe I could just deprecate the two macros PCI_ACPI_UNUSED and PCI_BAR_NOCHANGE. What do you think? Regards, Ray From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On B

Re: [edk2] [PATCH] Fix some typos of "according"

2017-02-07 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan -Original Message- From: Rebecca Cran [mailto:rebe...@bluestop.org] Sent: 2017年2月8日 3:41 To: edk2-devel@lists.01.org Cc: Rebecca Cran ; Tian, Feng ; Zeng, Star ; Fu, Siyuan ; Wu, Jiaxin ; Gao, Liming Subject: [PATCH] Fix some typos of "according" Cc: Feng Tian

Re: [edk2] [PATCH v3 6/6] MdePkg/Pci22.h: Deprecate out-of-Spec IncompatiblePciDevice macros

2017-02-07 Thread Laszlo Ersek
On 02/08/17 01:58, Ni, Ruiyu wrote: > These macros comply with the spec so I had no reason to deprecate them. > > But I did want to avoid using them in drivers. > > Maybe I could just deprecate the two macros PCI_ACPI_UNUSED and > PCI_BAR_NOCHANGE. > > What do you think? I'm fine either way: -

Re: [edk2] [PATCH] Fix some typos of "according"

2017-02-07 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Rebecca Cran [mailto:rebe...@bluestop.org] Sent: Wednesday, February 8, 2017 3:41 AM To: edk2-devel@lists.01.org Cc: Rebecca Cran ; Tian, Feng ; Zeng, Star ; Fu, Siyuan ; Wu, Jiaxin ; Gao, Liming Subject: [PATCH] Fix some typos of "accor

Re: [edk2] [PATCH] Fix some typos of "according"

2017-02-07 Thread Tian, Feng
MdeModulePkg reviewed-by: Feng Tian Thanks Feng -Original Message- From: Zeng, Star Sent: Wednesday, February 8, 2017 9:45 AM To: Rebecca Cran ; edk2-devel@lists.01.org Cc: Tian, Feng ; Fu, Siyuan ; Wu, Jiaxin ; Gao, Liming ; Zeng, Star Subject: RE: [PATCH] Fix some typos of "accordi

[edk2] [Patch][edk2-platforms/devel-MinnowBoard3] Change BIOS version to 0061

2017-02-07 Thread Guo, Mang
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Guo Mang --- Platform/BroxtonPlatformPkg/BiosId.env | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Platform/BroxtonPlatformPkg/BiosId.env b/Platform/BroxtonPlatformPkg/BiosId.env index e7eda3d..bed873

Re: [edk2] [Patch][edk2-platforms/devel-MinnowBoard3] Change BIOS version to 0061

2017-02-07 Thread Lu, ShifeiX A
Reviewed-by: lushifex Thanks, Shifei -Original Message- From: Guo, Mang Sent: Wednesday, February 08, 2017 10:11 AM To: edk2-devel@lists.01.org Cc: Wei, David; Lu, ShifeiX A Subject: [Patch][edk2-platforms/devel-MinnowBoard3] Change BIOS version to 0061 Contributed-under: TianoCore Con

Re: [edk2] [PATCH] MdeModulePkg: Add dynamic PCD PcdPteMemoryEncryptionAddressOrMask

2017-02-07 Thread Zeng, Star
Does Create4GPageTablesIa32Pae() also need to be updated? Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Leo Duran Sent: Wednesday, February 8, 2017 3:54 AM To: edk2-de...@ml01.01.org Cc: Laszlo Ersek ; Tian, Feng ; Brijesh Singh ; Z

[edk2] [Patch] MdeModulePkg/DxeHttpLib: Correct the return status for the HTTP Port/ContentLength

2017-02-07 Thread Jiaxin Wu
Replace AsciiStrDecimalToUintn with AsciiStrDecimalToUintnS to return the correct status for the HTTP Port/ContentLength. Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c | 8 +++- 1

[edk2] [Patch] NetworkPkg/NetworkPkg.uni: Define the prompt and help information for PcdAllowHttpConnections

2017-02-07 Thread Jiaxin Wu
Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- NetworkPkg/NetworkPkg.uni | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/NetworkPkg/NetworkPkg.uni b/NetworkPkg/NetworkPkg.uni index 6eecd88..d0e9b36 100644

Re: [edk2] [PATCH] Fix some typos of "according"

2017-02-07 Thread Wu, Jiaxin
Reviewed-by: Wu Jiaxin > -Original Message- > From: Rebecca Cran [mailto:rebe...@bluestop.org] > Sent: Wednesday, February 8, 2017 3:41 AM > To: edk2-devel@lists.01.org > Cc: Rebecca Cran ; Tian, Feng ; > Zeng, Star ; Fu, Siyuan ; Wu, > Jiaxin ; Gao, Liming > Subject: [PATCH] Fix some t

Re: [edk2] [Patch] NetworkPkg/NetworkPkg.uni: Define the prompt and help information for PcdAllowHttpConnections

2017-02-07 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan -Original Message- From: Wu, Jiaxin Sent: 2017年2月8日 12:59 To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin Subject: [Patch] NetworkPkg/NetworkPkg.uni: Define the prompt and help information for PcdAllowHttpConnections Cc: Ye Ting Cc: Fu Siyu

Re: [edk2] [Patch] MdeModulePkg/DxeHttpLib: Correct the return status for the HTTP Port/ContentLength

2017-02-07 Thread Fu, Siyuan
Reviewed-by: Fu Siyuan -Original Message- From: Wu, Jiaxin Sent: 2017年2月8日 12:58 To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin Subject: [Patch] MdeModulePkg/DxeHttpLib: Correct the return status for the HTTP Port/ContentLength Replace AsciiStrDecimalToUintn with

[edk2] [Patch][edk2-platforms] Vlv2DeviceRefCodePkg: Fixed thermal issue.

2017-02-07 Thread lushifex
Fixed System auto shutdown when it reached minus 20 degree. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: lushifex --- Vlv2DeviceRefCodePkg/AcpiTablesPCAT/THERMAL.ASL | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Vlv2DeviceRefCodePkg/AcpiTa

Re: [edk2] [PATCH] Fix some typos of "according"

2017-02-07 Thread Gao, Liming
Reviewed-by: Liming Gao To meet with edk2 patch policy, I will separate this patch per package, then push it. >-Original Message- >From: Rebecca Cran [mailto:rebe...@bluestop.org] >Sent: Wednesday, February 08, 2017 3:41 AM >To: edk2-devel@lists.01.org >Cc: Rebecca Cran ; Tian, Feng ;

Re: [edk2] [PATCH] Fix some typos of "according"

2017-02-07 Thread B Cran
Thanks! Sent from my iPhone > On Feb 7, 2017, at 10:07 PM, Gao, Liming wrote: > > Reviewed-by: Liming Gao > > To meet with edk2 patch policy, I will separate this patch per package, then > push it. > >> -Original Message- >> From: Rebecca Cran [mailto:rebe...@bluestop.org] >> Sent:

Re: [edk2] [Patch][edk2-platforms] Vlv2DeviceRefCodePkg: Fixed thermal issue.

2017-02-07 Thread Wei, David
Reviewed-by: David Wei Thanks, David Wei -Original Message- From: Lu, ShifeiX A Sent: Wednesday, February 08, 2017 1:08 PM To: edk2-devel@lists.01.org Cc: Wei, David Subject: [Patch][edk2-platforms] Vlv2DeviceRefCodePkg: Fixed thermal issue. Fixed Sy

[edk2] [patch] OvmfPkg/QemuBootOrderLib: Fix NOOPT build failure

2017-02-07 Thread Dandan Bi
Cc: Jordan Justen Cc: Laszlo Ersek Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Dandan Bi --- OvmfPkg/Library/QemuBootOrderLib/ExtraRootBusMap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OvmfPkg/Library/QemuBootOrderLib/ExtraRo

Re: [edk2] [patch] OvmfPkg/QemuBootOrderLib: Fix NOOPT build failure

2017-02-07 Thread Jordan Justen
On 2017-02-07 21:55:52, Dandan Bi wrote: > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi > --- > OvmfPkg/Library/QemuBootOrderLib/ExtraRootBusMap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(

Re: [edk2] [Patch] NetworkPkg/NetworkPkg.uni: Define the prompt and help information for PcdAllowHttpConnections

2017-02-07 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: Wu, Jiaxin Sent: Wednesday, February 08, 2017 12:59 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin Subject: [Patch] NetworkPkg/NetworkPkg.uni: Define the prompt and help information for PcdAllowHttpConnections Cc:

Re: [edk2] [Patch] MdeModulePkg/DxeHttpLib: Correct the return status for the HTTP Port/ContentLength

2017-02-07 Thread Ye, Ting
Reviewed-by: Ye Ting -Original Message- From: Wu, Jiaxin Sent: Wednesday, February 08, 2017 12:58 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Fu, Siyuan ; Wu, Jiaxin Subject: [Patch] MdeModulePkg/DxeHttpLib: Correct the return status for the HTTP Port/ContentLength Replace AsciiSt

Re: [edk2] [patch] OvmfPkg/QemuBootOrderLib: Fix NOOPT build failure

2017-02-07 Thread Bi, Dandan
Hi Jordan, Yes, it fails on IA32. As far as I know, it impacts VS2012/2013/2015. I will create a new patch and add the impacted toolchain and arch info to the commit message. Thanks, Dandan -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jorda

Re: [edk2] [PATCH v2 1/6] MdeModulePkg/PciSioSerialDxe: Use MAX_UINT8 instead of PCI_BAR_ALL

2017-02-07 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Ni, Ruiyu Sent: Monday, February 6, 2017 2:01 PM To: edk2-devel@lists.01.org Cc: Tian, Feng Subject: [PATCH v2 1/6] MdeModulePkg/PciSioSerialDxe: Use MAX_UINT8 instead of PCI_BAR_ALL When BarIndex equals to 0xFF, default val