[edk2] [PATCH] BaseTools/GenVtf & VolInfo: Fix build fail for 'snprintf' not defined

Function snprintf() is not supported in Visual Studio 2013 or older version. The commit replaces the use of snprintf() with sprintf() to avoid build failure for VS compilers. Cc: Yonghong Zhu Cc: Liming Gao Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Hao Wu --- BaseT

Re: [edk2] [PATCH 2/2] ShellPkg/comp: Add "-n "/"-s " support

On 27 February 2017 at 16:36, Carsey, Jaben wrote: > Reviewed-by: Jaben Carsey > This patch breaks the build on GCC: : In function 'ShellCommandRunComp':

[edk2] [Patch] NetworkPkg/TlsAuthConfigDxe: Use StrToGuid in BaseLib

Cc: Ye Ting Cc: Fu Siyuan Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin --- NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c | 157 ++-- 1 file changed, 10 insertions(+), 147 deletions(-) diff --git a/NetworkPkg/TlsAuthConfigDxe/TlsAuthConf

Re: [edk2] [PATCH v2] CryptoPkg/OpensslLib: Upgrade OpenSSL version to 1.0.2k

Reviewed-by: Ye Ting -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Qin Long Sent: Monday, February 27, 2017 3:21 PM To: edk2-devel@lists.01.org Cc: Ye, Ting ; Wu, Jiaxin ; ler...@redhat.com Subject: [edk2] [PATCH v2] CryptoPkg/OpensslLib: Upgr

Re: [edk2] [PATCH v2] CryptoPkg/OpensslLib: Upgrade OpenSSL version to 1.0.2k

Reviewed-by: Wu Jiaxin PASS the HTTPS/TLS functionality test over NT32 platform with TLS_ENABLE flag. Thanks, Jiaxin > -Original Message- > From: Long, Qin > Sent: Monday, February 27, 2017 3:21 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Wu, Jiaxin ; > ler...@redhat.com > Subje

Re: [edk2] [PATCH v4 0/7] MdeModulePkg/DxeCore: increased memory protection

All series reviewed-by: jiewen@intel.com X86 platform regression tested-by: jiewen@intel.com Thank you Yao Jiewen > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Monday, February 27, 2017 10:38 PM > To: edk2-devel@lists.01.org; af...@apple.c

Re: [edk2] [PATCH v4 2/7] MdeModulePkg/PeiCore: allocate BootServicesCode memory for PE/COFF images

Reviewed-by: Liming Gao >-Original Message- >From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >Sent: Monday, February 27, 2017 10:38 PM >To: edk2-devel@lists.01.org; af...@apple.com; leif.lindh...@linaro.org; >Kinney, Michael D ; Gao, Liming >; Yao, Jiewen >Cc: ler...@redhat.com;

Re: [edk2] [PATCH v2 04/11] MdePkg/BaseLib: Add StrToGuid/StrHexToBytes/StrToIpv[4/6]Address

Patch 4, 5, 11 Reviewed-by: Fu Siyuan -Original Message- From: Ni, Ruiyu Sent: 2017年2月27日 15:23 To: edk2-devel@lists.01.org Cc: Gao, Liming ; Yao, Jiewen ; Fu, Siyuan Subject: [PATCH v2 04/11] MdePkg/BaseLib: Add StrToGuid/StrHexToBytes/StrToIpv[4/6]Address The patch adds 4 APIs to

Re: [edk2] [PATCH v2 00/11] Add StrToGuid/HexToBytes/Ipv4/Ipv6 in BaseLib

The change in MdePkg are good to me. Reviewed-by: Liming Gao >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >Ruiyu Ni >Sent: Monday, February 27, 2017 3:22 PM >To: edk2-devel@lists.01.org >Subject: [edk2] [PATCH v2 00/11] Add StrToGuid/HexToBy

Re: [edk2] [PATCH] ShellPkg/bcfg: Add Shell Spec 2.2 modification functionality

Reviewed-by: Ruiyu Ni Thanks/Ray > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Monday, February 27, 2017 3:50 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Chen, Chen A > ; chen881220 > Subject: [edk2] [PATCH] S

Re: [edk2] [PATCH V2] NetworkPkg: Add check logic for some variable in iSCSI driver.

Hi Lubo, In IScsiConfigProcessDefault, we'd better replace the ASSERT for AttemptConfigOrder/AttemptConfigData with "if error" condition. Others is good to me. Reviewed-by: Wu Jiaxin Thanks, Jiaxin > -Original Message- > From: Zhang, Lubo > Sent: Monday, February 27, 2017 5:10 PM >

Re: [edk2] [patch] NetworkPkg: Define the prompt and help information for new PCD.

Reviewed-by: Wu Jiaxin > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Zhang Lubo > Sent: Monday, February 27, 2017 5:10 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting ; Fu, Siyuan ; Wu, > Jiaxin > Subject: [edk2] [patch] NetworkPkg: Defi

Re: [edk2] [PATCH v4 1/6] MdeModulePkg: Add PCD PcdPteMemoryEncryptionAddressOrMask

Reviewed-by: Star Zeng to MdeModulePkg changes. Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Duran, Leo Sent: Monday, February 27, 2017 10:13 PM To: Zeng, Star ; edk2-de...@ml01.01.org Cc: Singh, Brijesh ; Tian, Feng ; Laszlo Ers

Re: [edk2] [platforms/devel-MinnowBoard3] Reformat ReadMe.MD with markdown (github) and simplify instructions

On 2/26/2017 11:11 PM, Guo, Mang wrote: Thanks Rebecca. I tried to apply your patch but failed with the below errors, could you update and send the patch again? .git/rebase-apply/patch:16: trailing whitespace. # INDEX Those are because some lines in the old ReadMe.MD file had trailing whit

Re: [edk2] ISCSI says "Session Doesn't Exist"

Hello Ting, I've configured iSCSI target in Windows Server 2012. And the procedure is similar as in https://blogs.technet.microsoft.com/filecab/2012/05/21/introduction-of-iscsi-target-in-windows-server-2012/ Please let me know if I had to make any changes to my iSCSI server. Thank you, Naveen _

Re: [edk2] [PATCH] ArmPkg: remove unused PcdArmUncachedMemoryMask PCD

On 27 February 2017 at 16:25, Laszlo Ersek wrote: > On 02/27/17 17:18, Ard Biesheuvel wrote: >> On 27 February 2017 at 15:44, Leif Lindholm wrote: >>> On Fri, Feb 24, 2017 at 06:40:25PM +, Ard Biesheuvel wrote: This removes the PCD PcdArmUncachedMemoryMask from ArmPkg, along with an

Re: [edk2] [PATCH v3 10/12] ShellPkg: Refine casting expression result to bigger size

Reviewed-by: Jaben Carsey > -Original Message- > From: Wu, Hao A > Sent: Friday, February 24, 2017 9:13 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Carsey, Jaben > ; Ni, Ruiyu > Subject: [PATCH v3 10/12] ShellPkg: Refine casting expression result to bigger > size > Importance: Hig

Re: [edk2] [PATCH v3 6/6] ShellPkg: Refine type cast for pointer subtraction

Reviewed-by: Jaben Carsey > -Original Message- > From: Wu, Hao A > Sent: Friday, February 24, 2017 8:05 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Carsey, Jaben > ; Ni, Ruiyu > Subject: [PATCH v3 6/6] ShellPkg: Refine type cast for pointer subtraction > Importance: High > > For

Re: [edk2] [PATCH 1/2] ShellPkg/comp: Rename variable names to proper ones

Reviewed-by: Jaben Carsey > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Tuesday, February 21, 2017 11:46 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Chen, Chen A > > Subject: [edk2] [PATCH 1/2] ShellPkg/comp: R

Re: [edk2] [PATCH 2/2] ShellPkg/comp: Add "-n "/"-s " support

Reviewed-by: Jaben Carsey > -Original Message- > From: Ni, Ruiyu > Sent: Tuesday, February 21, 2017 11:47 PM > To: edk2-devel@lists.01.org > Cc: Chen, Chen A ; Carsey, Jaben > > Subject: [PATCH 2/2] ShellPkg/comp: Add "-n "/"-s " > support > Importance: High > > From: Chen A Chen > >

Re: [edk2] [PATCH] ArmPkg: remove unused PcdArmUncachedMemoryMask PCD

On 02/27/17 17:18, Ard Biesheuvel wrote: > On 27 February 2017 at 15:44, Leif Lindholm wrote: >> On Fri, Feb 24, 2017 at 06:40:25PM +, Ard Biesheuvel wrote: >>> This removes the PCD PcdArmUncachedMemoryMask from ArmPkg, along with >>> any remaining references to it in various platform .DSC fil

Re: [edk2] [PATCH] ArmPkg: remove unused PcdArmUncachedMemoryMask PCD

On 27 February 2017 at 15:44, Leif Lindholm wrote: > On Fri, Feb 24, 2017 at 06:40:25PM +, Ard Biesheuvel wrote: >> This removes the PCD PcdArmUncachedMemoryMask from ArmPkg, along with >> any remaining references to it in various platform .DSC files. It is >> no longer used now that we remove

Re: [edk2] [PATCH v2] ArmVirtPkg: clear PcdPerformanceLibraryPropertyMask PCD

On 02/27/17 16:09, Ard Biesheuvel wrote: > The only observeable effect of having PcdPerformanceLibraryPropertyMask > set to 1 is that a EfiReservedMemory region of 4 pages is allocated right > below the 4 GB mark. This region is out of bounds for the OS, which means > it is not even allowed to map

Re: [edk2] [PATCH] ArmPkg: remove unused PcdArmUncachedMemoryMask PCD

On Fri, Feb 24, 2017 at 06:40:25PM +, Ard Biesheuvel wrote: > This removes the PCD PcdArmUncachedMemoryMask from ArmPkg, along with > any remaining references to it in various platform .DSC files. It is > no longer used now that we removed the virtual uncached pages protocol > and the associate

Re: [edk2] [PATCH v4 1/7] ArmPkg/CpuDxe: ignore attribute changes during SyncCacheConfig()

On 27 February 2017 at 15:32, Leif Lindholm wrote: > On Mon, Feb 27, 2017 at 02:38:05PM +, Ard Biesheuvel wrote: >> To prevent the initial MMU->GCD memory space map synchronization from >> stripping permissions attributes [which we cannot use in the GCD memory >> space map, unfortunately], imp

Re: [edk2] [PATCH v4 1/7] ArmPkg/CpuDxe: ignore attribute changes during SyncCacheConfig()

On Mon, Feb 27, 2017 at 03:39:54PM +, Ard Biesheuvel wrote: > On 27 February 2017 at 15:38, Leif Lindholm wrote: > > On Mon, Feb 27, 2017 at 03:33:56PM +, Ard Biesheuvel wrote: > >> On 27 February 2017 at 15:32, Leif Lindholm > >> wrote: > >> > On Mon, Feb 27, 2017 at 02:38:05PM +, A

Re: [edk2] [PATCH v4 1/7] ArmPkg/CpuDxe: ignore attribute changes during SyncCacheConfig()

On 27 February 2017 at 15:38, Leif Lindholm wrote: > On Mon, Feb 27, 2017 at 03:33:56PM +, Ard Biesheuvel wrote: >> On 27 February 2017 at 15:32, Leif Lindholm wrote: >> > On Mon, Feb 27, 2017 at 02:38:05PM +, Ard Biesheuvel wrote: >> >> To prevent the initial MMU->GCD memory space map sy

Re: [edk2] [PATCH v2] CryptoPkg/OpensslLib: Upgrade OpenSSL version to 1.0.2k

Laszlo, Thanks for validations. And, I knew CRLF issue is really annoying here. Just keep this in 1.0.2xx series for consistency, and we will remove the patch totally in next 1.1.0xx. :-) Best Regards & Thanks, LONG, Qin > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun.

Re: [edk2] [PATCH v4 1/7] ArmPkg/CpuDxe: ignore attribute changes during SyncCacheConfig()

On Mon, Feb 27, 2017 at 03:33:56PM +, Ard Biesheuvel wrote: > On 27 February 2017 at 15:32, Leif Lindholm wrote: > > On Mon, Feb 27, 2017 at 02:38:05PM +, Ard Biesheuvel wrote: > >> To prevent the initial MMU->GCD memory space map synchronization from > >> stripping permissions attributes

Re: [edk2] [PATCH v4 1/7] ArmPkg/CpuDxe: ignore attribute changes during SyncCacheConfig()

On Mon, Feb 27, 2017 at 02:38:05PM +, Ard Biesheuvel wrote: > To prevent the initial MMU->GCD memory space map synchronization from > stripping permissions attributes [which we cannot use in the GCD memory > space map, unfortunately], implement the same approach as x86, and ignore > SetMemoryAt

[edk2] [PATCH v2] ArmVirtPkg: clear PcdPerformanceLibraryPropertyMask PCD

The only observeable effect of having PcdPerformanceLibraryPropertyMask set to 1 is that a EfiReservedMemory region of 4 pages is allocated right below the 4 GB mark. This region is out of bounds for the OS, which means it is not even allowed to map it, to avoid speculative loads from it. On Linux

[edk2] [PATCH v4 4/7] MdeModulePkg/DxeCore: use separate lock for pool allocations

In preparation of adding memory permission attribute management to the pool allocator, split off the locking of the pool metadata into a separate lock. This is an improvement in itself, given that pool allocation can only interfere with the page allocation bookkeeping if pool pages are allocated or

[edk2] [PATCH v4 3/7] MdeModulePkg/EbcDxe: use EfiBootServicesCode memory for thunks

The EBC driver emits thunks for native to EBC calls, which are short instructions sequences that bridge the gap between the native execution environment and the EBC virtual machine. Since these thunks are allocated using MemoryAllocationLib::AllocatePool(), they are emitted into EfiBootServicesDat

[edk2] [PATCH v4 5/7] MdeModulePkg: define PCD for DXE memory protection policy

Define a new fixed/patchable PCD that sets the DXE memory protection policy: its primary use is to define which memory types should have their executable permissions removed. Combined with the image protection policy, this can be used to implement a strict W^X policy, i.e.. a policy where no region

[edk2] [PATCH v4 0/7] MdeModulePkg/DxeCore: increased memory protection

Hello all, First of all, thanks for the reviews and regression testing. However, I did not add the tested-by tags nor some of the R-b's, given the changes in this v4. This series implements a memory protection policy that removes all executable permissions from writable memory regions, which grea

[edk2] [PATCH v4 6/7] MdeModulePkg/DxeCore: implement memory protection policy

This implements a DXE memory protection policy that ensure that regions that don't require executable permissions are mapped with the non-exec attribute set. First of all, it iterates over all entries in the UEFI memory map, and removes executable permissions according to the configured DXE memory

[edk2] [PATCH v4 7/7] ArmVirtPkg/ArmVirt.dsc.inc: enable NX memory protection for all platforms

This sets the recently introduced PCD PcdDxeNxMemoryProtectionPolicy to a value that protects all memory regions except code regions against inadvertent execution. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Biesheuvel --- ArmVirtPkg/ArmVirt.dsc.inc | 6 ++ 1 f

[edk2] [PATCH v4 1/7] ArmPkg/CpuDxe: ignore attribute changes during SyncCacheConfig()

To prevent the initial MMU->GCD memory space map synchronization from stripping permissions attributes [which we cannot use in the GCD memory space map, unfortunately], implement the same approach as x86, and ignore SetMemoryAttributes() calls during the time SyncCacheConfig() is in progress. This

[edk2] [PATCH v4 2/7] MdeModulePkg/PeiCore: allocate BootServicesCode memory for PE/COFF images

Ensure that any memory allocated for PE/COFF images is identifiable as a boot services code region, so that we know it requires its executable permissions to be preserved when we tighten mapping permissions later on. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ard Bieshe

Re: [edk2] [PATCH v4 6/6] UefiCpuPkg/PiSmmCpuDxeSmm: Add support for PCD PcdPteMemoryEncryptionAddressOrMask

Excellent, thanks. Leo > -Original Message- > From: Fan, Jeff [mailto:jeff@intel.com] > Sent: Monday, February 27, 2017 1:51 AM > To: Duran, Leo ; edk2-de...@ml01.01.org > Cc: Tian, Feng ; Zeng, Star ; > Laszlo Ersek ; Singh, Brijesh > Subject: RE: [PATCH v4 6/6] UefiCpuPkg/PiSmmCpuDx

Re: [edk2] [PATCH v4 1/6] MdeModulePkg: Add PCD PcdPteMemoryEncryptionAddressOrMask

Please see below. > -Original Message- > From: Zeng, Star [mailto:star.z...@intel.com] > Sent: Sunday, February 26, 2017 8:20 PM > To: Duran, Leo ; edk2-de...@ml01.01.org > Cc: Tian, Feng ; Laszlo Ersek ; > Singh, Brijesh ; Zeng, Star > Subject: RE: [PATCH v4 1/6] MdeModulePkg: Add PCD >

Re: [edk2] [PATCH v3 0/6] RFC: increased memory protection

On 02/26/17 19:29, Ard Biesheuvel wrote: > Hello all, > > This is a proof of concept implementation that removes all executable > permissions from writable memory regions, which greatly enhances security. > It is based on Jiewen's recent work, which is a step in the right direction, > but still le

Re: [edk2] [PATCH v2] CryptoPkg/OpensslLib: Upgrade OpenSSL version to 1.0.2k

On 02/27/17 08:20, Qin Long wrote: > v2: > Re-generate the patch after the new OpensslLibCrypto instance. > > OpenSSL 1.0.2k was released with several severity fixes at > 26-Jan-2017 (https://www.openssl.org/news/secadv/20170126.txt). > This patch is to upgrade the supported OpenSSL version in > C

Re: [edk2] [PATCH v3 6/6] MdeModulePkg/DxeCore: implement memory protection policy

On 27 February 2017 at 09:56, Laszlo Ersek wrote: > On 02/26/17 19:30, Ard Biesheuvel wrote: >> This implements a DXE memory protection policy that ensure that regions >> that don't require executable permissions are mapped with the non-exec >> attribute set. >> >> First of all, it iterates over a

Re: [edk2] [PATCH v3 6/6] MdeModulePkg/DxeCore: implement memory protection policy

On 02/26/17 19:30, Ard Biesheuvel wrote: > This implements a DXE memory protection policy that ensure that regions > that don't require executable permissions are mapped with the non-exec > attribute set. > > First of all, it iterates over all entries in the UEFI memory map, and > removes executab

Re: [edk2] [PATCH v2 4/5] Nt32Pkg: exclude libssl functionality from OpensslLib if TLS_ENABLE=FALSE

On 02/27/17 01:52, Wu, Jiaxin wrote: > Reviewed-by: Wu Jiaxin Thank you both, patch committed as 9fba024ed8f7. Cheers Laszlo > > > Thanks, > Jiaxin > >> -Original Message- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Laszlo Ersek >> Sent: Friday, Febru

[edk2] [PATCH V2] NetworkPkg: Add check logic for some variable in iSCSI driver.

v2: need to check the global variable mPrivate before using it in the Convert AttemptConfigData To IfrNvData by Keyword function. Add check logic for some attempt variable to enhance code in iSCSI. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo Cc: Ye Ting Cc:

[edk2] [patch] NetworkPkg: Define the prompt and help information for new PCD.

Define the prompt and help information for PcdMaxIScsiAttemptNumber. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Zhang Lubo Cc: Ye Ting Cc: Fu Siyuan Cc: Wu Jiaxin --- NetworkPkg/NetworkPkg.uni | 3 +++ 1 file changed, 3 insertions(+) diff --git a/NetworkPkg/Networ

Re: [edk2] [PATCH v2 0/5] RFC: increased memory protection

On 02/26/17 16:09, Ard Biesheuvel wrote: > On 25 February 2017 at 04:04, Yao, Jiewen wrote: >> Thank you Ard. I like this patch - simple and obvious. >> > > Thank you > >> I put all my comment together for your consideration. >> >> 1) Patch V2 1/5 -- reviewed-by: jiewen@intel.com >> 2) Patch

Re: [edk2] [PATCH v3 4/6] MdeModulePkg/DxeCore: use separate lock for pool allocations

If it is really needed, I am fine to either this patch or another patch to add it. :) Thanks, Star -Original Message- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard Biesheuvel Sent: Monday, February 27, 2017 4:16 PM To: Zeng, Star Cc: Tian, Feng ; edk2-devel@

Re: [edk2] [PATCH v3 4/6] MdeModulePkg/DxeCore: use separate lock for pool allocations

On 27 February 2017 at 01:56, Zeng, Star wrote: > Minor comment: CoreFreePoolPagesI() has no need to have PoolType parameter, > how about to remove it? > I need it after patch 6. But perhaps it is better to only add it there, not here. > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org

Re: [edk2] [PATCH v3 4/6] MdeModulePkg/DxeCore: use separate lock for pool allocations

On 27 February 2017 at 06:50, Zeng, Star wrote: > CoreAllocatePoolPages() could not be updated simply by adding > CoreAcquireMemoryLock() and CoreReleaseMemoryLock(), it is also used by > AllocateMemoryMapEntry() with the lock locked. > Indeed. But I am wondering now if that means some code pa

Re: [edk2] [PATCH v3 2/6] MdeModulePkg/PeiCore: allocate BootServicesCode memory for PE/COFF images

On 27 February 2017 at 06:43, Gao, Liming wrote: > Ard: > In line 128, there is another AllocatePages() to allocate memory to store > the code. To be consistent, could you help also update it? > OK >>-Original Message- >>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Be