Re: [edk2] overriding variables from cmdline used in fdf broken?

2017-03-12 Thread Zhu, Yonghong
Got you. Thanks for the info. Best Regards, Zhu Yonghong -Original Message- From: Michael Zimmermann [mailto:sigmaepsilo...@gmail.com] Sent: Monday, March 13, 2017 2:29 PM To: Gao, Liming Cc: edk2-devel@lists.01.org ; Zhu, Yonghong Subject: Re: [edk2] overriding variables from cmdline

Re: [edk2] overriding variables from cmdline used in fdf broken?

2017-03-12 Thread Michael Zimmermann
I just tested it again and apparently everything is working just fine now. So either, I've done something wrong in past or you guys have already fixed it. Sorry for not testing before bumping this old thread. Thanks Michael On Mon, Mar 13, 2017 at 3:13 AM, Gao, Liming wrote: > Michael: > I ag

Re: [edk2] [patch] MdeModulePkg/SdMmc: Add break to avoid dead loop when polling OCR Reg

2017-03-12 Thread Wu, Hao A
> -Original Message- > From: Tian, Feng > Sent: Monday, March 13, 2017 11:24 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A > Subject: [patch] MdeModulePkg/SdMmc: Add break to avoid dead loop when > polling OCR Reg > > At worst case, OCR register may always not set BIT31. It will cause >

[edk2] [patch] MdeModulePkg/SdMmc: Add break to avoid dead loop when polling OCR Reg

2017-03-12 Thread Feng Tian
At worst case, OCR register may always not set BIT31. It will cause original code enter to dead loop. Adding a break for such case. Cc: Hao Wu Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Feng Tian --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c | 9 - MdeM

Re: [edk2] [PATCH 0/3] Add Context in SmiHandlerProfileUnregister.

2017-03-12 Thread Tian, Feng
Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Fan, Jeff Sent: Monday, March 13, 2017 10:06 AM To: Yao, Jiewen ; edk2-devel@lists.01.org Cc: Tian, Feng ; Zeng, Star ; Bret Barkelew Subject: RE: [PATCH 0/3] Add Context in SmiHandlerProfileUnregister. Reviewed-by: Jeff Fan

Re: [edk2] [PATCH v2 2/2] MdeModulePkg/AcpiTableDxe: improve FADT.{DSDT, X_DSDT} mutual exclusion

2017-03-12 Thread Fan, Jeff
Laszlo, We found one Windows Server 2012 R2 blue screen issue with ACPI 6.1 FADT table. We did the following configuration test with DSDT under 4GB. .DSDT .X_DSDT Window Server 2012 R2 -- --- setclear Fai

Re: [edk2] [PATCH 0/3] Refine the comment for AsciiValueToStringS

2017-03-12 Thread Gao, Liming
Reviewed-by: Liming Gao >-Original Message- >From: Wu, Hao A >Sent: Tuesday, March 07, 2017 4:16 PM >To: edk2-devel@lists.01.org >Cc: Wu, Hao A ; Yao, Jiewen ; >Gao, Liming ; Kinney, Michael D > >Subject: [PATCH 0/3] Refine the comment for AsciiValueToStringS > >The series will refine the

Re: [edk2] Do edk2 support PcdGetEx64 in library

2017-03-12 Thread Gao, Liming
Xiaofeng: Thanks for your reporting. This is a tool issue. Please submit one bug in bugzillar. We will fix it. Thanks Liming >-Original Message- >From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >wang xiaofeng >Sent: Thursday, March 09, 2017 10:46 AM >To: edk2-dev

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Generate boot description for NVME

2017-03-12 Thread Wang, Sunny (HPS SW)
Never mind. I overlooked something. Thanks for clarifying this. Looks good to me. Reviewed-by: Sunny Wang -Original Message- From: Ni, Ruiyu [mailto:ruiyu...@intel.com] Sent: Monday, March 13, 2017 10:24 AM To: Wang, Sunny (HPS SW) ; edk2-devel@lists.01.org Cc: Tian, Feng ; Haskell, Da

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Generate boot description for NVME

2017-03-12 Thread Tian, Feng
There is no such library class/instance. It should be HPE-specific stuff. Reviewed-by: Feng Tian Thanks Feng -Original Message- From: Ni, Ruiyu Sent: Monday, March 13, 2017 10:24 AM To: Wang, Sunny (HPS SW) ; edk2-devel@lists.01.org Cc: Tian, Feng ; Haskell, Darrell Subject: RE: [edk2

Re: [edk2] [PATCH] MdeModulePkg/UefiBootManagerLib: Generate boot description for NVME

2017-03-12 Thread Ni, Ruiyu
I didn't find this library in EDKII. When I firstly saw your comments, I was a little bit unwilling to change UefiBootManagerLib to depend on UefiNvmExpressLib. Because it would require all platforms to include UefiNvmExpressLib in DSC. But since now I find no such library, I feel much better😊 Tha

Re: [edk2] overriding variables from cmdline used in fdf broken?

2017-03-12 Thread Gao, Liming
Michael: I agree this is a bug. Could you enter it into bugzillar? Thanks Liming > -Original Message- > From: Michael Zimmermann [mailto:sigmaepsilo...@gmail.com] > Sent: Sunday, March 12, 2017 12:44 AM > To: edk2-devel@lists.01.org > Cc: Zhu, Yonghong ; Gao, Liming > Subject: Re: [edk

Re: [edk2] [PATCH 0/3] Add Context in SmiHandlerProfileUnregister.

2017-03-12 Thread Fan, Jeff
Reviewed-by: Jeff Fan -Original Message- From: Yao, Jiewen Sent: Friday, March 10, 2017 3:35 PM To: edk2-devel@lists.01.org Cc: Fan, Jeff; Tian, Feng; Zeng, Star; Bret Barkelew Subject: [PATCH 0/3] Add Context in SmiHandlerProfileUnregister. This issue is reported by bret.barke...@micro

Re: [edk2] [PATCH V4 1/3] UefiCpuPkg/CpuDxe: Add memory attribute setting.

2017-03-12 Thread Fan, Jeff
Anthony, It's very interesting. Some INTEL IA-32 architectural MSR (like 0x1A0, IA32_MISC_ENABLE) is not supported by AMD processors. For this case, I think reading 0x1A0 is not necessary. Reading CPUID.8001H:EDK[20] is enough to check if XD feature is supported or not. I will create the