Reviewed-by: Yonghong Zhu
Best Regards,
Zhu Yonghong
-Original Message-
From: Chen, Hesheng
Sent: Friday, March 10, 2017 8:25 AM
To: edk2-devel@lists.01.org
Cc: Zhu, Yonghong
Subject: [patch] BaseTools/UPT: Fix an issue in subst command
UPT used to use "B:" as the temp directory wh
Hi Liming,
It seems no need to change the comments in the implementation codes.
The comments in the implementation codes are correct.
Thanks,
Dandan
-Original Message-
From: Gao, Liming
Sent: Tuesday, March 14, 2017 12:23 PM
To: Bi, Dandan ; edk2-devel@lists.01.org
Cc: Ni, Ruiyu ; Dong,
Hi Naveen
I mean that the patch will fix reconnect -r command but not reset command
for next boot iSCSI connection.
Thanks
Lubo
> -Original Message-
> From: Santhapur Naveen [mailto:nave...@amiindia.co.in]
> Sent: Tuesday, March 14, 2017 1:01 PM
> To: Zhang, Lubo
> Cc: Ye, Ting ;
Hi Lubo,
Many thanks for your update.
You mean to say that this issue is because of the TCP Service and this can be
fixed with the path you are yet to send. Am I right?
Warm Regards,
Naveen
From: Zhang, Lubo [lubo.zh...@intel.com]
Sent: Tuesday, March 14
Dandan:
Is this change required in HiiDataBase? HiiDataBase implements HiiImageEx
protocol.
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Dandan
> Bi
> Sent: Tuesday, March 14, 2017 9:39 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ;
Laszlo,
I agree that there are some inconsistencies in the edk2 C source files.
For this specific example, I prefer what Jordan recommended:
> > Status = QemuFwCfgS3WriteBytes (
> > mRequestedFeaturesItem,
> > sizeof ScratchBuffer->Features
> > );
When m
Thanks for your comments, will send another patch to update this.
Best regards
Lubo
-Original Message-
From: Wu, Jiaxin
Sent: Monday, March 13, 2017 3:44 PM
To: Zhang, Lubo ; edk2-devel@lists.01.org
Cc: Ye, Ting ; Fu, Siyuan
Subject: RE: [edk2] [patch] NetworkPkg: Fix driver binding is
Hi Naveen
For this issue you mentioned, I have found the root cause. After we
established the iSCSI connection between initiator and target server, if we use
the following command immediately
Reset command (system power off, will not perform driver binding stop, from my
debug log) : we c
Cc: Ruiyu Ni
Cc: Jaben Carsey
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommand
Cc: Liming Gao
Cc: Ruiyu Ni
Cc: Eric Dong
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi
---
MdePkg/Include/Protocol/HiiImageEx.h | 80 +++-
1 file changed, 43 insertions(+), 37 deletions(-)
diff --git a/MdePkg/Include/Protocol
On 2017-03-13 15:12:08, Laszlo Ersek wrote:
>
> "CCS_2_1_Draft.pdf" seems to be the most recent version; in it, I find:
>
> (1)
>
> 5.2.2.4 Subsequent lines of multi-line function calls should line up
> one or two tab-stops from the beginning of the function name
>
> Use either
On 03/13/17 22:32, Jordan Justen wrote:
> On 2017-03-10 11:36:36, Laszlo Ersek wrote:
>> On 03/10/17 11:14, Jordan Justen wrote:
>>> On 2017-02-22 17:48:13, Laszlo Ersek wrote:
+ //
+ ScratchBuffer->Features = mSmiFeatures;
+ Status = QemuFwCfgS3WriteBytes (mRequestedFeaturesItem,
On 2017-03-10 11:36:36, Laszlo Ersek wrote:
> On 03/10/17 11:14, Jordan Justen wrote:
> > On 2017-02-22 17:48:13, Laszlo Ersek wrote:
> >> + //
> >> + ScratchBuffer->Features = mSmiFeatures;
> >> + Status = QemuFwCfgS3WriteBytes (mRequestedFeaturesItem,
> >
> > I noticed a fair amount of functi
On 03/13/17 21:39, Laszlo Ersek wrote:
> On 03/13/17 15:59, Ard Biesheuvel wrote:
>> On 13 March 2017 at 14:53, Laszlo Ersek wrote:
>>> On 03/13/17 11:23, Ard Biesheuvel wrote:
On 11 March 2017 at 10:26, Leif Lindholm wrote:
> On Sat, Mar 11, 2017 at 08:38:19AM +0100, Laszlo Ersek wrote:
On 13 March 2017 at 20:39, Laszlo Ersek wrote:
> On 03/13/17 15:59, Ard Biesheuvel wrote:
>> On 13 March 2017 at 14:53, Laszlo Ersek wrote:
>>> On 03/13/17 11:23, Ard Biesheuvel wrote:
On 11 March 2017 at 10:26, Leif Lindholm wrote:
> On Sat, Mar 11, 2017 at 08:38:19AM +0100, Laszlo Ers
On 03/13/17 15:59, Ard Biesheuvel wrote:
> On 13 March 2017 at 14:53, Laszlo Ersek wrote:
>> On 03/13/17 11:23, Ard Biesheuvel wrote:
>>> On 11 March 2017 at 10:26, Leif Lindholm wrote:
On Sat, Mar 11, 2017 at 08:38:19AM +0100, Laszlo Ersek wrote:
>>> "MdeModulePkg/Universal/Acpi/S3SaveS
On 13 March 2017 at 14:53, Laszlo Ersek wrote:
> On 03/13/17 11:23, Ard Biesheuvel wrote:
>> On 11 March 2017 at 10:26, Leif Lindholm wrote:
>>> On Sat, Mar 11, 2017 at 08:38:19AM +0100, Laszlo Ersek wrote:
>> "MdeModulePkg/Universal/Acpi/S3SaveStateDxe/AcpiS3ContextSave.c". I
>> think th
On 03/11/17 15:23, Lans Zhang wrote:
> The modified pattern can match up both the openssl source directory
> and tarball.
>
> Cc: Ye Ting
> Cc: Wu Jiaxin
> Cc: Laszlo Ersek
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Lans Zhang
> ---
> CryptoPkg/.gitignore | 2 +
On 03/13/17 11:23, Ard Biesheuvel wrote:
> On 11 March 2017 at 10:26, Leif Lindholm wrote:
>> On Sat, Mar 11, 2017 at 08:38:19AM +0100, Laszlo Ersek wrote:
> "MdeModulePkg/Universal/Acpi/S3SaveStateDxe/AcpiS3ContextSave.c". I
> think the above check should be reworked to look for the FADT
On 03/13/17 04:07, Fan, Jeff wrote:
> Laszlo,
>
> We found one Windows Server 2012 R2 blue screen issue with ACPI 6.1 FADT
> table.
>
> We did the following configuration test with DSDT under 4GB.
> .DSDT .X_DSDT Window Server 2012 R2
> -- ---
On 11 March 2017 at 10:26, Leif Lindholm wrote:
> On Sat, Mar 11, 2017 at 08:38:19AM +0100, Laszlo Ersek wrote:
>> >> "MdeModulePkg/Universal/Acpi/S3SaveStateDxe/AcpiS3ContextSave.c". I
>> >> think the above check should be reworked to look for the FADT
>> >> (EFI_ACPI_2_0_FIXED_ACPI_DESCRIPTION_T
On 13 March 2017 at 09:55, Michael Zimmermann wrote:
> I had to include because I was getting
> this error:
> EmbeddedPkg/Library/PrePiLib/PrePiLib.c: In function ‘AllocateCodePages’:
> EmbeddedPkg/Library/PrePiLib/PrePiLib.c:59:3: error: implicit
> declaration of function ‘FreePages’
> [-Werror=
I had to include because I was getting
this error:
EmbeddedPkg/Library/PrePiLib/PrePiLib.c: In function ‘AllocateCodePages’:
EmbeddedPkg/Library/PrePiLib/PrePiLib.c:59:3: error: implicit
declaration of function ‘FreePages’
[-Werror=implicit-function-declaration]
FreePages (Alloc, Pages);
Other th
The recently introduced memory protection features inadvertently broke
the boot on all PrePi platforms, because the changes to explicitly use
EfiBootServicesCode for loading the DxeCore PE/COFF image need to be
applied in a different way for PrePi. So add a simple helper function
that sets the type
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: lushifex
---
Vlv2TbltDevicePkg/BiosIdD.env| 4 ++--
Vlv2TbltDevicePkg/BiosIdR.env| 4 ++--
Vlv2TbltDevicePkg/BiosIdx64D.env | 4 ++--
Vlv2TbltDevicePkg/BiosIdx64R.env | 4 ++--
4 files changed, 8 insertions(+), 8 delet
> You are using PrePi, right?
yes. Isn't that supported yet? afaik ArmVirtXen uses PrePi too.
On Mon, Mar 13, 2017 at 9:50 AM, Ard Biesheuvel
wrote:
> On 13 March 2017 at 09:43, Michael Zimmermann
> wrote:
>> I fail to get this working on my target. I've enabled the following
>> Pcd's like in A
On 13 March 2017 at 09:43, Michael Zimmermann wrote:
> I fail to get this working on my target. I've enabled the following
> Pcd's like in ArmVirt:
> gEfiMdeModulePkgTokenSpaceGuid.PcdImageProtectionPolicy|0x3
> gEfiMdeModulePkgTokenSpaceGuid.PcdDxeNxMemoryProtectionPolicy|0xC0007FD1
> gEf
I fail to get this working on my target. I've enabled the following
Pcd's like in ArmVirt:
gEfiMdeModulePkgTokenSpaceGuid.PcdImageProtectionPolicy|0x3
gEfiMdeModulePkgTokenSpaceGuid.PcdDxeNxMemoryProtectionPolicy|0xC0007FD1
gEfiMdeModulePkgTokenSpaceGuid.PcdSetNxForStack|TRUE
but apparentl
My comments as below:
1. SockDestroyChild: The sock should be locked to access first, then we can
update it (close/uninstall).
2. SockDestroyChild: Debug info should be "SockDestroyChild:" instead of
"SockDestroy:"
3. One concern in SockCreateChild:
Since the " CloseProtocol/Uninst
Reviewed-by: Wu Jiaxin
> -Original Message-
> From: Zhang, Lubo
> Sent: Thursday, March 9, 2017 4:18 PM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting ; Fu, Siyuan ; Wu,
> Jiaxin
> Subject: [patch] NetworkPkg: Fix potential bug if the iSCSI use dns protocol.
>
> Since we use the Attempt
30 matches
Mail list logo
